- This was done with `brew typecheck --update --suggest-typed` which
(as of the previous commit) uses Spoom, yet another gem. I thought I'd
see how well it works. There are no Sorbet errors after these changes!
Also, use `--no-same-permissions` instead of `-o` (which does nothing
without `-p` being passed and run as `root`) for the more explicit
description of the behaviour we want.
Instead of only looking at the extension when invoked as part of
Homebrew's formulae' download strategies instead prioritise the
extension if it actually exists. When it does not, fall back to the
magic detection logic which is likely to be more reliable.
Fixes https://github.com/Homebrew/brew/issues/5895
update gnu_tar.rb
removed tab
update unpacking_strategy/tar.rb
to resolve conversations
But OFFENCE found, W: 31: 36: Unused method argument - basename (brew style)
Now I start to using rubocop inside Sublime_text3 where I see all right linting messages.
Rollback install.rb changes.
Conversation resolved, extra_args: "--owner=0", "--group=0" and "--no-same-owner" in extend/os/linux/gnu_tar.rb.
Conversation: file extend/os/linux/gnu_tar.rb moved to extend/os/linux/unpack_strategy/tar.rb. Module UnpackStrategy is parent for the GnuTar module.
Conversation: new file extent/unpack_strategy/tar.rb to require logic, unpack_strategy/tar.rb newline bef. require-line, require-line changed.
Deletion of files added in PR. -o addition is only one needed argument in unpack_strategy/tar.rb.
Adjust the rules based on the current codebase. Remove various enable,
disables and default values that are unnecessary. Add more comments
explaining why. Make minor changes needed to enable a few more rules.
Use 124 max line length everywhere. Also, reduce tap max line length to
189 as Homebrew/homebrew-core has that as a maximum now. In future
Homebrew/homebrew-core will also be reduced to 124 maximum line length.
