122 Commits

Author SHA1 Message Date
Markus Reiter
b9f3589ab7 Test casks are already tested covered brew style. 2020-09-01 19:26:46 +02:00
Markus Reiter
b4d14c193f Use Homebrew::Style for brew cask style. 2020-09-01 18:34:26 +02:00
Bo Anderson
e3372e2a14 Lazily require some heavy files 2020-08-20 02:05:17 +01:00
Mike McQuaid
3a91c37e66
Fix RuboCop checks. 2020-08-19 17:12:32 +01:00
William Ma
3918e13070 cask --cache: Deprecate command 2020-08-18 10:37:29 -04:00
Sean Molenaar
5d38cd7296
cask/list: fix artifact list 2020-08-14 23:12:17 +02:00
William Ma
2f68aad417 home: Deprecate brew cask home 2020-08-14 11:02:30 -04:00
Markus Reiter
3b2a9c3b55
Merge pull request #8335 from waldyrious/show-cask-descs-in-info-command
Show cask description in `brew cask info` command
2020-08-14 00:52:27 +02:00
Waldir Pimenta
53932185e6 Show cask description as None if not present 2020-08-13 22:21:10 +01:00
Waldir Pimenta
619af6a723 Show cask description in brew cask info command 2020-08-13 22:21:10 +01:00
Waldir Pimenta
efbfb90c42 Use cask with name for basic info command test
Also add non-dummy URL in the test fixture, to match the name, version, etc.
2020-08-13 22:21:10 +01:00
Markus Reiter
b48bc316e0 Use CLI::Parser for cask commands. 2020-08-13 05:15:15 +02:00
Waldir Pimenta
ffed8fdbb3 Add a desc stanza to the cask DSL 2020-08-08 23:02:23 +01:00
Seeker
3a2dc79153 cask/create: update template to match new style 2020-08-06 09:39:07 -07:00
Markus Reiter
5cf7ffd93e Make Cask::Auditor return a Hash with warnings and errors. 2020-07-28 09:50:15 +02:00
Mike McQuaid
25db60ebbb
Unify (mostly) Homebrew code style
Make the Homebrew/cask and Homebrew/homebrew-core style more closely
match the rest of Homebrew.

To accomplish this:
- Run `brew cask style` to ensure we don't break style there when
  making changes or upgrading RuboCop in Homebrew/brew.
- Fix the HomepageMatchesUrl cop to better handle weird input.
- Remove the now unneeded `.rubocop_shared.yml`
- Fix the cask fixtures with `brew cask style --fix`.
- Share more style between Homebrew/brew, casks and formulae.
2020-07-27 12:57:40 +01:00
Sean Molenaar
832073a3c7
cask: add list --json 2020-07-10 21:05:12 +02:00
Mike McQuaid
2ee93a2476
Revert "remove flaky cask upgrade test"
This reverts commit 626f9406b1987932382814bc7d7cae3b41b771f4.
2020-06-29 09:50:43 +01:00
Mike McQuaid
a9877088ea
Revert "test/cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 8a0e6a1603ce823eb66cc183a692f722668d9c67.
2020-06-29 09:50:36 +01:00
Mike McQuaid
cc0ea9aec3
Revert "cask/cmd/upgrade_spec: remove flaky test."
This reverts commit 75c74e4674d3f6a85c4afce79a6096bcc5cca9fc.
2020-06-29 09:50:29 +01:00
Mike McQuaid
af2c57dbeb
Revert "cask/cmd/upgrade_spec: remove more flaky tests."
This reverts commit fb0fa419abc750bf33695a396244b9cffbea1554.
2020-06-29 09:50:18 +01:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Sean Molenaar
3567892802
Add notibility checks for casks 2020-05-26 14:21:25 +02:00
Tharun
aeede8374f fixed review changes 2020-05-19 21:41:02 +05:30
Tharun
84f2edc884 replaced json and used dictionary 2020-05-19 19:35:30 +05:30
Tharun
6a50f31feb fixed proper parsing of mock data for analytics 2020-05-19 17:25:16 +05:30
Tharun
9e26a451e3 Updated mocking analytics call 2020-05-19 14:58:55 +05:30
Tharun
6e543f7289 Updated test with stubing cask analytics call 2020-05-18 20:46:43 +05:30
Tharun
4aba04556e Updated tests 2020-05-17 02:55:07 +05:30
Frank Lam
dabbfe3e3e
Fix linter offenses 2020-04-26 21:31:21 +08:00
Frank Lam
f2fa2c5d30
Add JSON support to brew cask outdated
* brew outdated already has JSON support, now users and tools can get
similar results with brew cask outdated --json
2020-04-26 21:13:19 +08:00
Mike McQuaid
fb0fa419ab
cask/cmd/upgrade_spec: remove more flaky tests. 2020-04-20 16:45:44 +01:00
Mike McQuaid
75c74e4674
cask/cmd/upgrade_spec: remove flaky test. 2020-04-20 09:25:16 +01:00
Mike McQuaid
8a0e6a1603
test/cask/cmd/upgrade_spec: remove flaky test.
This is the second flaky test removed in this file. Tempting to just
remove the whole file if there's more.
2020-04-18 14:37:10 +01:00
Dario Vladovic
d12784533b
Update options spec 2020-04-06 15:24:15 +02:00
Dawid Dziurla
626f9406b1
remove flaky cask upgrade test 2020-03-23 19:27:48 +01:00
Mike McQuaid
c1b00297e0
cask/cmd/style_spec: add rubocop test.
This verifies the cask configuration hasn't been broken.
2019-12-01 15:04:32 +00:00
Mike McQuaid
6670ae6202
global: require rubygems for activesupport. 2019-11-06 10:36:40 +00:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
  Layout/InconsistentIndentation once the auto-fixer had got rid of the
  "redundant begin"s.
2019-10-13 16:04:27 +01:00
Markus Reiter
b6b9cd248c Refactor brew cask style. 2019-10-04 23:43:48 +02:00
Alec Clarke
45806f6a97 Include test casks in the cask style check.
Currently the tests casks found in "/Homebrew/test/support/fixtures/cask/Casks" and "/Homebrew/test/support/fixtures/third-party/Casks" aren't included in the paths checked when running "brew cask style".

This change includes these test cask paths in the checked paths, and also includes the auto style fixes made by running `brew cask style --fix`.
2019-09-23 08:50:24 -04:00
Jonathan Chang
7ddc185b35 Fix various typos 2019-08-19 16:12:34 +10:00
Doug Hogan
55fcd01bed cask/cmd/upgrade: add --dry-run option. 2019-07-26 23:20:56 -07:00
Mike McQuaid
3dc82bc8bf
Commit 'brew style --fix' results. 2019-07-23 17:09:57 +01:00
Cheng XU
ba517e07e2
fix brew style error
Spec path should end with cask/cmd/cache*_spec.rb.
describe Cask::Cmd::Cache, :cask do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2019-05-23 15:50:55 +08:00
Cheng XU
8ad48f56e8
add test for brew cask --cache 2019-05-23 15:28:00 +08:00
Isabell (Issy) Long
7a367980b6
Add a blank line between brew cask info output for multiple casks
- `brew info` adds a blank line between info output for multiple
  formulae. This replicates that display for `brew cask info`, as
  requested in Issue 6126.
2019-05-13 19:45:08 +01:00
Julian Mayer
a061a8d9f7 add optional checking whether appcast contains the version stanza to "brew cask audit" 2019-05-07 17:06:54 +02:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00