Gautham Goli
781da49df8
audit: Add tests for audit rules ported from line_problems method to rubocops
2017-08-06 02:28:58 +05:30
Gautham Goli
66ffdb5b06
Refactor legacy_patches_cop to merge external patch audit rules in a single cop and add tests
2017-08-05 21:51:24 +05:30
Mike McQuaid
f4983ab16b
Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
...
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Gautham Goli
c575f34d5f
audit: Port audit_urls strict rules to rubocop, add tests and autocorrect
2017-07-30 12:59:37 +05:30
Gautham Goli
e1cb0b43d7
audit: Port dependency rules from line_problems to rubocop and add tests
2017-07-29 16:36:32 +05:30
Gautham Goli
2639b6c556
audit: Update Urls Cop with more rules of audit_urls and corresponding tests
2017-07-25 19:06:36 +05:30
Gautham Goli
b7ddd271e1
audit: Port audit_urls partially to rubocop and add corresponding tests
2017-07-21 20:50:28 +05:30
Gautham Goli
a8f1b02be9
audit: Port audit_options rules for new formulae to rubocop and add test
2017-07-15 17:35:10 +05:30
Gautham Goli
f3923f23ef
audit: Port audit_options strict rules to rubocop and add tests
2017-07-14 21:43:16 +05:30
Gautham Goli
222af82401
Read rubocop offenses as const from corresponding class in tests
2017-07-13 12:43:08 +05:30
Gautham Goli
b8adc1a8aa
audit: Port audit_options non-strict rules to rubocop and add tests
2017-07-13 12:41:43 +05:30
Gautham Goli
4ed34f91c2
audit: Port audit_conflicts method to rubocop and add tests
2017-07-07 20:46:57 +05:30
ilovezfs
7013f9dee3
formula_desc_cop: allow formula name in desc
...
except at the very beginning, as the audit originally intended.
See https://github.com/Homebrew/legacy-homebrew/pull/45493 .
2017-06-29 08:14:58 -07:00
Mike McQuaid
f4cdd7a051
Merge pull request #2790 from GauthamGoli/audit_legacy_patches_rubocop
...
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-25 08:54:59 +01:00
Gautham Goli
2e82754776
audit: Port audit_legacy_patches method to rubocop and add tests
2017-06-24 17:06:26 +05:30
Gautham Goli
0e1c88e7ae
Refactor Checksum cop to add autocorrect method
2017-06-16 19:45:16 +05:30
Gautham Goli
77da75e7d6
Simplify Checksum cop by auditing all checksums
2017-06-16 19:45:16 +05:30
Gautham Goli
4d7a983415
audit: Port audit_checksum method to rubocop and add tests
2017-06-16 19:45:16 +05:30
Mike McQuaid
113a7a81d0
Revert "audit: Port audit_checksum method to rubocop and add tests"
2017-06-09 11:16:11 +03:00
Gautham Goli
d09d5ecc55
audit: Port audit_checksum method to rubocop and add tests
2017-06-08 21:53:46 +05:30
Mike McQuaid
c572081f8b
formula_desc_cop: tweak some rules.
...
Allow some specific lowercase words and provide an autocorrect for some
of these rules.
2017-06-08 15:13:10 +03:00
Markus Reiter
2d6ae61314
Re-revert "Fix operator spacing."
2017-06-02 19:22:05 +02:00
Gautham Goli
cf848a14d2
audit: Port audit_caveats method to rubocop and add tests
2017-05-31 22:59:48 +05:30
Gautham Goli
51f2338dd5
audit: Port audit_text method to rubocop and add tests
2017-05-30 15:28:05 +05:30
Isabell Long
279a4df6c3
Match the "formula name in description" on word boundaries
...
- The regexp for the "check if formula name is used in formula's
description" cop matches every instance of the formula name if it
exists, whether it's in a word or not.
- For example, the formula `mon` has the description "Monitor
hosts/services/whatever and alert about problems". This makes
`brew audit --strict` complain because it matches "Monitor",
which isn't the formula name! The formula `pass` has the description
"Password manager". Again, the strict audit matches "Password",
which isn't an issue.
- Instead, this change matches on a word boundary, so it will match
`mon:`, or `mon `, but not "Monitor", or, for example, "harmony".
- I've changed the tests to account for this change.
2017-05-29 00:26:47 +01:00
Mike McQuaid
ea8be174f6
Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop
...
audit: Port audit_homepage method to rubocop and add tests
2017-05-15 10:02:47 +01:00
Mike McQuaid
9889b42ec4
Merge pull request #2628 from GauthamGoli/formula_desc_cop_fix
...
audit: Detect multiline and interpolated strings in formula desc cop
2017-05-15 10:01:38 +01:00
Gautham Goli
91efcb045e
Port audit_homepage method to rubocop and add tests
2017-05-14 22:05:46 +05:30
Gautham Goli
80572939b4
Update string_content method to support multiline strings, add test for same
2017-05-13 18:48:40 +05:30
Gautham Goli
d04f295de3
Add autocorrect method for ComponentsOrder rubocop and tests
2017-05-13 03:09:55 +05:30
Gautham Goli
fed668b330
Add --only-cops,--except-cops options for brew style and simplify cop names
2017-05-03 14:49:23 +05:30
Gautham Goli
c3330c289d
Add --only-cops,--except-cops options for brew audit
...
Also refactor audit cops into two "departments"
- FormulaAudit
- FormulaAuditStrict
2017-05-02 23:26:12 +05:30
Gautham Goli
413a7e5dae
Port audit_components method to rubocops and add corresponding tests
2017-04-22 21:53:16 +05:30
Gautham Goli
a693ca332e
Wrap rubocop specific code into methods inside FormulaCop
2017-03-26 15:26:41 +05:30
Gautham Goli
4e57f4279a
Add RSpec tests for bottle_block and formula_desc cops
2017-03-26 15:26:41 +05:30
