10578 Commits

Author SHA1 Message Date
Markus Reiter
da2ad32a8d Don’t use should syntax in rspec. 2016-08-27 11:56:52 +02:00
Markus Reiter
c1621f7f54 Also report Cask coverage. 2016-08-27 10:17:20 +02:00
Tim D. Smith
f4fb655aaa Replaced ; with && under Update Bug in README.md. (#815)
* Replaced ; with && under Update Bug in README.md.

* Updated issue template's brew update fix.
2016-08-26 16:43:25 -07:00
Mike McQuaid
5a45e4c7dc Merge pull request #822 from vladshablinsky/fix-link
Brew-Test-Bot-For-Core-Contributors: fix broken link
2016-08-26 19:57:41 +01:00
Ball
238d38bfbb Updated issue template's brew update fix. 2016-08-26 11:30:25 -07:00
Vlad Shablinsky
6d54a25047 Brew-Test-Bot-For-Core-Contributors: fix broken link 2016-08-26 20:19:39 +03:00
Mike McQuaid
aa165e1707 Merge pull request #819 from reitermarkus/fix-tty
Fix missing `magenta` in Tty.
2016-08-26 14:15:37 +01:00
Markus Reiter
db88ca1e18 Fix missing magenta in Tty. 2016-08-26 14:14:18 +02:00
Mike McQuaid
48ac15180c Merge pull request #818 from reitermarkus/refactor-cask
Remove `exist?` check for `brew-cask-tests.rb`.
2016-08-26 12:57:11 +01:00
Markus Reiter
a11f536280 Remove exist? check for brew-cask-tests.rb. 2016-08-26 11:46:32 +02:00
Mike McQuaid
9c09f05730 Merge pull request #794 from AnastasiaSulyagina/tty
cask tty removed
2016-08-26 10:05:35 +01:00
Mike McQuaid
373159dedd Merge pull request #817 from zmwangx/restrict-tmpdir-change
Restrict TMPDIR etc. changes to install, post_install and test
2016-08-26 09:54:26 +01:00
Zhiming Wang
e82347b233
Restrict TMPDIR etc. changes to install, post_install and test
See discussion in Homebrew/brew#800.
2016-08-26 12:39:27 +08:00
Dominyk Tiller
00bb1f2767 Merge pull request #816 from DomT4/httpsbot
various: update CI links.
2016-08-26 03:29:04 +01:00
Dominyk Tiller
f37d7a5637
test_integration_cmds: use https://bot.brew.sh 2016-08-26 01:43:25 +01:00
Dominyk Tiller
435d70163f
New-Maintainer-Checklist: update links 2016-08-26 01:42:13 +01:00
Dominyk Tiller
1b320a3158
Brew-Test-Bot: update links 2016-08-26 01:40:10 +01:00
Dominyk Tiller
0111523e58
Brew-Test-Bot-For-Core-Contributors: update links 2016-08-26 01:35:54 +01:00
Ball
33a8c993dd Replaced ; with && under Update Bug in README.md. 2016-08-25 16:53:24 -07:00
Mike McQuaid
c39f0baa21 Merge pull request #808 from MikeMcQuaid/homebrew-root-complain
brew.sh: complain when running Homebrew as root.
2016-08-25 19:19:48 +01:00
Mike McQuaid
27b0ca4b47 brew.sh: complain when running Homebrew as root.
As discussed: announce that we are deprecating running Homebrew as the
root user as it's insecure and requires disabling the sandbox.

Fixes #796.
2016-08-25 18:32:32 +01:00
Mike McQuaid
bf872672a8 Merge pull request #809 from MikeMcQuaid/doctor-local-tweak
diagnostic: tweak /usr/local messaging.
2016-08-25 15:44:41 +01:00
Mike McQuaid
2691cf1b8b diagnostic: tweak /usr/local messaging.
Highlight that the main reason for preferring /usr/local is because of
bottles. There's been some confusion around this e.g.
https://github.com/Homebrew/homebrew-core/issues/3968
2016-08-25 15:29:43 +01:00
ilovezfs
9d77652549 audit: detect partial component order compliance
depends_on "foo"
conflicts_with "bar"
depends_on "baz"

should still detect that "bar" and "baz" are in the wrong order even
though "foo" and "bar" happen to be in the right order.
2016-08-25 07:01:46 -07:00
Mike McQuaid
46a3003a2f update.sh: reset pre-stash, die if stash fails.
A `git reset --hard` without stashing first risks nuking in-progress
work. A `git reset --mixed` should allow stashing to occur more often
on e.g. merge conflicts.

Fixes #766.
2016-08-25 11:45:59 +01:00
Mike McQuaid
408ac6088f scm/git: make --homebrew=print-path absolute.
This ensures that the output is always a fully-resolved path.
2016-08-25 11:12:22 +01:00
Mike McQuaid
ea069936bf Revert "update: make GIT_EXECUTABLE an absolute path."
This reverts commit b6afa228f4974f4af1e8938911e35150aa2991c8 from #778.
2016-08-25 11:12:22 +01:00
Mike McQuaid
df21e57179 Merge pull request #800 from zmwangx/set-TMPDIR-TEMP-TMP-to-HOMEBREW_TEMP
config: set TMPDIR, TEMP and TMP to HOMEBREW_TEMP
2016-08-25 10:37:07 +01:00
Mike McQuaid
6e535e1f7c Merge pull request #804 from MikeMcQuaid/brewfile-unset
Improve HOMEBREW_BREW_FILE unset failure case.
2016-08-25 08:46:05 +01:00
Markus Reiter
72846fac47 Merge pull request #803 from reitermarkus/heredoc-style
Unify heredoc style.
2016-08-24 20:23:50 +02:00
Josh Hagins
4f6a46f4b1 Merge pull request #791 from reitermarkus/per-cask-cleanup
Allow per-cask `cleanup`.
2016-08-24 11:11:19 -04:00
Mike McQuaid
e7984b34d5 Improve HOMEBREW_BREW_FILE unset failure case.
Print a better exception message and handle this in more cases rather
than producing confusing errors when it’s unset.
2016-08-24 14:48:53 +01:00
Mike McQuaid
8d79cf1eb6 Merge pull request #779 from MikeMcQuaid/bin-brew-local-homebrew
bin/brew: improve $HOMEBREW_REPOSITORY/bin/brew handling.
2016-08-24 14:42:27 +01:00
Mike McQuaid
66f26259ac Merge pull request #780 from MikeMcQuaid/usr-local-cellar
brew.sh: don't require /usr/local/Cellar creation.
2016-08-24 14:41:52 +01:00
Mike McQuaid
acfb1b1979 Merge pull request #783 from MikeMcQuaid/update-link-manpages
update-report: also link `brew*.1` manpages.
2016-08-24 14:41:35 +01:00
Markus Reiter
50fee14358 Unify heredoc style. 2016-08-24 13:52:46 +02:00
Markus Reiter
fa19447a2d Merge pull request #793 from reitermarkus/refactoring-pathname
Merge Cask’s `Pathname` extension with Homebrew’s.
2016-08-24 12:32:17 +02:00
Markus Reiter
ff7d3f226a Merge pull request #795 from Homebrew/plist-readme
Add vendored `plist` to ReadMe.
2016-08-24 12:21:16 +02:00
Mike McQuaid
ec75fbcb65 cmd/man: deprecate --link option. 2016-08-24 11:07:06 +01:00
Mike McQuaid
3df7daa5bf update-report: also link brew*.1 manpages.
Otherwise if your `HOMEBREW_PREFIX` and `HOMEBREW_REPOSITORY` are not
equal then your tap manpages will be linked but your `brew*` ones will
not.
2016-08-24 11:06:58 +01:00
Mike McQuaid
03352805c6 tap: use utils link_path_manpages. 2016-08-24 11:06:58 +01:00
Mike McQuaid
8cc027a3cd utils: add link_path_manpages method. 2016-08-24 11:06:58 +01:00
Mike McQuaid
d0ff64666a bin/brew: improve /usr/local/bin/brew handling.
If `/usr/local` is the prefix but not the repository (so bottles can be
used) then running `/usr/local/bin/brew` works great but
`$HOMEBREW_REPOSITORY/bin/brew` assumes the prefix is
`$HOMEBREW_REPOSITORY`. This is a pain when doing work on the Homebrew
repository and having e.g. `bin` in your `$PATH`. Improve this
behaviour so `bin/brew` knows how to handle this situation.
2016-08-24 10:56:28 +01:00
Mike McQuaid
2f9bf5f047 bin/brew: split up brew file symlink check.
This will enable this code to be reused in a future commit and makes it
more obvious what’s being done.
2016-08-24 10:56:28 +01:00
Mike McQuaid
db4ce3d6b7 bin/brew: refactor HOMEBREW_PREFIX="/" logic.
The previous approach of trying to do it on one line was confusing.
2016-08-24 10:56:28 +01:00
Mike McQuaid
eabc8a2561 brew.sh: don't require /usr/local/Cellar creation.
If you're using e.g. a `/usr/local/homebrew` prefix then don't require
the `/usr/local/Cellar` to be manually created to avoid e.g.
`/usr/local/homebrew/Cellar` being used. Let's do all we can to let
people use this `Cellar` location as it means they can put their
repository wherever they like and still use all our bottles.
2016-08-24 10:04:30 +01:00
Markus Reiter
fef96f0ba8 Move part of parser_test to system_command_result_spec. 2016-08-24 08:54:19 +02:00
Misty De Meo
e93771ae07 no_weak_imports: call ENV.append, not .add 2016-08-24 16:20:13 +10:00
Zhiming Wang
9f072a92d5
config: set TMPDIR, TEMP and TMP to HOMEBREW_TEMP
TMPDIR, TEMP and TMP (when set) are not whitelisted for writing in
sandbox.rb, which could result in sandbox violations when programs
attempt to write to these locations.

Setting TMPDIR, TEMP and TMP to HOMEBREW_TEMP (which defaults to /tmp
when not set) works around the aforementioned problem and also improves
uniformity in the locations of tempfiles created during Homebrew
operations.

Caveat: Non-matching HOMEBREW_TEMP and TMPDIR could lead to undesirable
side effects in certain cases, e.g., emacsclient not being able to find
an existing server (whose socket lives in $TMPDIR/emacs$UID/) when
launched through brew edit.
2016-08-24 12:59:57 +08:00
Markus Reiter
85635a1e19 Merge Cask’s Pathname extension with Homebrew’s. 2016-08-24 00:43:32 +02:00