admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
19,665 Commits 15 Branches 471 Tags
Commit Graph

15650 Commits

Author SHA1 Message Date
Mike McQuaid
bc3a4c1897
diagnostic: tweak frozen string handling. 2019-04-23 23:05:28 -07:00
Mike McQuaid
6325db9e37
utils: fix frozen string usage in odeprecated. 
Fixes https://github.com/Homebrew/brew/issues/6053
 2019-04-23 22:32:11 -07:00
follower
2064b30fce
Fix check_for_unsupported_macos() on outdated releases 
Recent commit 36dbad3922 to default to frozen string literals (via `frozen_string_literal`) broke `check_for_unsupported_macos()` on outdated releases--due to attempted modification of a frozen string literal.

This breaks `install` and `doctor`.

It's like the change wasn't tested on an unsupported outdated release or something... :D

Adding a `+` prefix is apparently one way around this issue according to https://stackoverflow.com/questions/37799296/what-does-the-comment-frozen-string-literal-true-do#37799399. The change worked for me.
 2019-04-24 15:02:13 +12:00
Mike McQuaid
47c886117b
compat: add missing frozen string literals. 
These weren't added yet due to CI being run at different times to
merges.
 2019-04-23 09:42:36 -07:00
Mike McQuaid
6b2dbbc96f
Merge pull request #6042 from MikeMcQuaid/boring_homebrew_display 
config: don't show HOMEBREW_DISPLAY.
 2019-04-22 13:07:20 -07:00
Mike McQuaid
0d54978ba8
Merge pull request #6036 from MikeMcQuaid/enable-frozen-string-literal 
Use FrozenStringLiteralComment instead of flag.
 2019-04-22 13:07:08 -07:00
Mike McQuaid
b89589ea29
Merge pull request #6045 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-expectations-3.8.3 
Bump rspec-expectations from 3.8.2 to 3.8.3 in /Library/Homebrew
 2019-04-22 13:06:46 -07:00
Mike McQuaid
21e07b1ad4
Merge pull request #6046 from Homebrew/dependabot/bundler/Library/Homebrew/unf_ext-0.0.7.6 
Bump unf_ext from 0.0.7.5 to 0.0.7.6 in /Library/Homebrew
 2019-04-22 13:06:33 -07:00
dependabot[bot]
d23f324acb
[Security] Bump nokogiri from 1.10.2 to 1.10.3 in /Library/Homebrew 
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.2 to 1.10.3. **This update includes security fixes.**
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.10.2...v1.10.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-04-22 18:18:00 +00:00
dependabot[bot]
39d62762eb
Bump unf_ext from 0.0.7.5 to 0.0.7.6 in /Library/Homebrew 
Bumps [unf_ext](https://github.com/knu/ruby-unf_ext) from 0.0.7.5 to 0.0.7.6.
- [Release notes](https://github.com/knu/ruby-unf_ext/releases)
- [Changelog](https://github.com/knu/ruby-unf_ext/blob/master/CHANGELOG.md)
- [Commits](https://github.com/knu/ruby-unf_ext/compare/v0.0.7.5...v0.0.7.6)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-04-22 06:36:22 +00:00
dependabot[bot]
3ffc01175f
Bump rspec-expectations from 3.8.2 to 3.8.3 in /Library/Homebrew 
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.8.2 to 3.8.3.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.8.2...v3.8.3)

Signed-off-by: dependabot[bot] <support@dependabot.com>
 2019-04-22 06:35:49 +00:00
Markus Reiter
ce15622584 Add *_to_slashes methods to compat. 2019-04-20 23:58:48 +02:00
Mike McQuaid
58e57f2d49
config: don't show HOMEBREW_DISPLAY. 
This is set by XQuartz and not needed information for us.
 2019-04-20 16:22:10 +09:00
Mike McQuaid
fc6bd2ea1c
Fixup more frozen string handling. 2019-04-20 14:07:29 +09:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
f76b083b91
Use FrozenStringLiteralComment instead of flag. 
Unfortunately we cannot use `--frozen-string-literal` with Ruby 2.3 due
to https://bugs.ruby-lang.org/issues/12031 and our usage of ERB.
 2019-04-20 13:25:33 +09:00
Mike McQuaid
e68fc530c0
Merge pull request #6040 from claui/endorse-adoptopenjdk 
Endorse AdoptOpenJDK instead of Oracle OpenJDK
 2019-04-20 13:14:26 +09:00
Claudia
f155ede7fb
Endorse AdoptOpenJDK instead of Oracle OpenJDK 
This commit changes the message that appears when Homebrew detects
that a Java requirement is unmet.

The new message will say:

```
Install AdoptOpenJDK with Homebrew Cask:
  brew cask install adoptopenjdk
```

And for Java 8:

```
Install AdoptOpenJDK 8 with Homebrew Cask:
  brew cask install homebrew/cask-versions/adoptopenjdk8
```
 2019-04-19 18:00:31 +02:00
Mike McQuaid
d1ea6f38d3
Fix mutable constants violations. 2019-04-19 21:46:20 +09:00
Mike McQuaid
420e63ebcd
Freeze more mutable constants. 
This rule adjustment is experimental in RuboCop as it may double-freeze
objects but this isn't an error (and freezing too much is better than
too little).
 2019-04-19 18:08:05 +09:00
Mike McQuaid
d42f562d45
Merge pull request #6038 from GauthamGoli/extract-args-fix 
extract: Replace ARGV.named with args.remaining
 2019-04-19 17:40:55 +09:00
Gautham Goli
8374c3713a extract: Replace ARGV.named with args.remaining 2019-04-19 13:13:43 +05:30
Mike McQuaid
4b369962d3
test: kill all subprocesses on timeout. 
Fixes #5885.
 2019-04-19 14:42:26 +09:00
Mike McQuaid
8f5be03cb8
Merge pull request #6029 from MikeMcQuaid/frozen-string-literal 
Enable/fix optional Ruby frozen string literal usage
 2019-04-19 13:25:43 +09:00
Mike McQuaid
8fdd278cd3
Merge pull request #6031 from iMichka/sudo3 
brew: remove sudo call only in docker context
 2019-04-19 10:32:22 +09:00
Mike McQuaid
86f43f79ee
Enable/fix optional Ruby frozen string literal usage 
Combined with https://github.com/Homebrew/homebrew-test-bot/pull/247
this will test Homebrew's use of frozen strings in CI. After this we
will then enable it for Homebrew developers and eventually all Homebrew
users.
 2019-04-19 10:30:41 +09:00
Mike McQuaid
7ab5fef7f2
brew.rb: remove unless ||. 2019-04-19 10:12:03 +09:00
Michka Popoff
49aad7ddb3 brew: remove sudo call only in docker context 
Follow up from #6018
 2019-04-18 17:16:05 +02:00
Mike McQuaid
892d0ac5fe
style: don’t run shellcheck on specified ruby file. 2019-04-18 21:42:42 +09:00
Mike McQuaid
9e7b98d3e2
Don't check system Ruby is new enough when unnecessary. 
We know this is the case in macOS >=10.13.3 so save a Ruby process call.
 2019-04-18 21:42:28 +09:00
Mike McQuaid
ef2e297d3b
Disable RubyGems by default. 
This speeds up all Ruby invocations where we don't need RubyGems by
around 10%. Where we do need RubyGems: include it manually.
 2019-04-18 17:45:03 +09:00
Mike McQuaid
640234caa1
Merge pull request #6030 from MikeMcQuaid/ruby-no-threads 
Remove usage of Thread.new
 2019-04-18 16:03:18 +09:00
Mike McQuaid
7fbfb02625
Remove usage of Thread.new 
I benchmarked these both locally and neither use of `Thread.new`
provides any measurable speedup (and in the `readall` case appears to
slow things down) on my 8 core machine.
 2019-04-18 14:46:40 +09:00
Mike McQuaid
1aaffda62f
Merge pull request #6027 from vitorgalvao/remove_to_slashes 
hbc: remove all *_to_slashes
 2019-04-18 11:59:10 +09:00
Mike McQuaid
4ad8d7608e
Merge pull request #6021 from MikeMcQuaid/argv-cleanup 
Update ARGV and CLI parsing
 2019-04-17 21:51:27 +01:00
Michka Popoff
f35f17ccf4
Merge pull request #6018 from iMichka/sudo2 
brew: remove sudo call
 2019-04-17 20:50:06 +02:00
Vítor Galvão
0ee226769a hbc: remove all *_to_slashes 2019-04-17 16:31:35 +01:00
Mike McQuaid
ae63381bd9
cli/parser: use cli/args and tweak freeze behaviour. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e9806b6b55
cli/args: add class to handle arguments. 2019-04-17 22:16:58 +09:00
Mike McQuaid
34a8ab74af
global: provide unpatched ARGV. 2019-04-17 22:16:58 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
Mike McQuaid
18630c7032
extend/ARGV: remove unused methods. 2019-04-17 21:08:26 +09:00
Mike McQuaid
0b272ad26e
cleanup: don’t cleanup periodic clean file. 
Cleaning up this file means that cleanup will run again prematurely.
 2019-04-17 21:06:47 +09:00
Mike McQuaid
4d6de005d8
Merge pull request #6025 from MikeMcQuaid/release-notes-stderr 
release-notes: use stderr for header output.
 2019-04-17 13:04:39 +01:00
Mike McQuaid
f6337c543a
Merge pull request #6023 from MikeMcQuaid/config-no-default-logs 
system_config: don’t output default HOMEBREW_LOGS.
 2019-04-17 13:04:29 +01:00
Mike McQuaid
8229e592d7
cask/cmd/info_spec: needs network connection. 
Tag it accordingly.
 2019-04-17 17:34:33 +09:00
Mike McQuaid
b03558e296
system_config: don’t output default HOMEBREW_LOGS. 
This cuts down a bit on noise. While we’re here, optimise the checks too.
 2019-04-17 17:02:33 +09:00
Mike McQuaid
888c384801
release-notes: use stderr for header output. 
This makes the use of `brew release-notes | pbcopy` a bit easier.
 2019-04-17 17:00:24 +09:00
Michka Popoff
1c016ecee7 brew: remove sudo call 
except for "brew services" command
 2019-04-16 20:35:41 +02:00
Mike McQuaid
356f72dcc6
Merge pull request #6012 from amyspark/hotpatch-fix-atomic_write 
atomic_write: repair permissions after writing
 2019-04-14 10:02:15 +01:00