admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
15,146 Commits 15 Branches 471 Tags
Commit Graph

13469 Commits

Author SHA1 Message Date
Mike McQuaid
76f48d338e keg: skip opt versioned aliases for devel/head. 
These versioned aliases don’t correspond to the correct version if not
Installed from stable.

Fixes #2596.
 2017-05-09 15:10:57 +01:00
Mike McQuaid
b14f1572b7 audit: more checks for versioned aliases. 
Check that a required versioned alias has a valid name (rather than
assuming it’s fine based on it’s existence alone) and check for
the presence of invalid version aliases.

This should handle the case where someone bumps a formula but forgets
to rename the alias that’s mentioned in #2596.
 2017-05-09 15:10:29 +01:00
Mike McQuaid
0fb1fb51be rubocop: don't always care about module length. 
We don't care about this in external taps as this is more about code
architecture than code style.
 2017-05-09 12:58:49 +01:00
Markus Reiter
5828eefd01 Remove to_s from some Pathnames. 2017-05-08 13:37:28 +02:00
Mike McQuaid
f1d4c4be78 Merge pull request #2607 from MikeMcQuaid/travis-ci-tweaks-2 
Travis CI tweaks.
 2017-05-08 09:51:06 +01:00
Mike McQuaid
9853a78397 Travis CI tweaks. 
Attempt to improve Travis CI. This time without any vendoring gems
nonsense.
 2017-05-08 08:38:25 +01:00
Mike McQuaid
e4ecf6d6bc Merge pull request #2591 from retokromer/patch-1 
fix date-based versioning
 2017-05-07 21:13:52 +01:00
Mike McQuaid
57db2e539e Revert "Merge pull request #2597 from MikeMcQuaid/vendor-gems" 
This reverts commit 3e4547f52e7ebec633f8bfefc8a396d944edf908, reversing
changes made to 6edf9382bcc1240ad6f97c8b752cfe56cef9965d.
 2017-05-07 17:28:39 +01:00
Mike McQuaid
e1bbab6ca6 Revert "Merge pull request #2603 from MikeMcQuaid/tweak-gem-vendoring" 
This reverts commit 2372872974d1049c2beafe7dedb7f8f882502058, reversing
changes made to 3e4547f52e7ebec633f8bfefc8a396d944edf908.
 2017-05-07 17:28:37 +01:00
Mike McQuaid
a76392dd5f Revert "Merge pull request #2602 from MikeMcQuaid/travis-ci-tweaks" 
This reverts commit 8d948e4b0b55912c592d34cb5ea83c649b1f9d5e, reversing
changes made to 2372872974d1049c2beafe7dedb7f8f882502058.
 2017-05-07 17:28:34 +01:00
Mike McQuaid
5cdb0d0a6d Travis CI tweaks 
Tweak our Travis CI configuration and the one we suggest for taps to
be faster and use caching.
 2017-05-07 16:00:04 +01:00
Mike McQuaid
33f83be10e Tweak Gem vendoring. 
If people have `HOMEBREW_RUBY_PATH` set then things explode in a rather
confusing fashion. Instead, run `bundle` for them with the arguments
that they'd want.

Also, move `macho` requires into the module itself; it's a pain having
to do everything for Bundler before requiring `pathname` which is a core
Ruby class.
 2017-05-07 15:33:54 +01:00
Mike McQuaid
ee253e465b Vendor all Homebrew's gems. 
Homebrew's actually ended up using a fair few gems. While we want to
avoid Bundler at runtime (and this PR still does that, in fact uses
Bundler even less at runtime than it did before) writing our own version
to use at build-time seems redundant.
 2017-05-07 13:52:57 +01:00
Tim D. Smith
22d3a67b73 Relocate virtualenv orig-prefix.txt 
Virtualenvs remember the path to the stdlib in a file named
orig_prefix.txt. This file wasn't being relocated because Homebrew skips
files that look like they're intended for human consumption by matching
against the list of metafile extensions. This led to the bug described
in https://github.com/Homebrew/homebrew-core/issues/12869. This fixes
relocation by creating an exception for orig-prefix.txt.
 2017-05-06 15:56:55 -07:00
Markus Reiter
6b5171de30 Remove unused e from rescue Interrupt. 2017-05-05 20:50:11 +02:00
pseudoku
77728abbfc Remove unused command_args 
Extra command_args in gain_permissions_remove caused silent failure and path never gets deleted.
 2017-05-04 00:17:56 -07:00
Mike McQuaid
6a15cea0b4 style: fix audit --online 
This passed a symbol to `:except_cops` which caused a 💥.
 2017-05-03 12:58:08 +01:00
Mike McQuaid
56413f6f6d Merge pull request #2582 from MikeMcQuaid/style-fix-rubocop-require 
style: don't require rubocop until installed.
 2017-05-03 12:40:45 +01:00
Mike McQuaid
790a113371 brew.sh: >v1.2.0 now. 2017-05-03 12:10:25 +01:00
Mike McQuaid
1c43070e69 style: don't require rubocop until installed. 
This avoids an error when RuboCop installed installed yet.

CC @GauthamGoli FYI.
 2017-05-03 12:09:18 +01:00
Mike McQuaid
a25cd9d8ba Merge pull request #2580 from reitermarkus/gem-path 
Remove `existing` from PATH when adding `Gem.bindir`.
 2017-05-03 11:37:18 +01:00
Mike McQuaid
555505ec54 Merge pull request #2531 from GauthamGoli/audit_cops_options_refactor 
audit: Allow skipping/selective running of cops and cops refactor
 2017-05-03 11:28:25 +01:00
Mike McQuaid
ffa45521f4 Merge pull request #2406 from sjackman/install-bottle-url 
Install a bottle from an URL
 2017-05-03 11:25:12 +01:00
Mike McQuaid
e1ef37953f Merge pull request #2577 from DomT4/keg_only_style_tweaks 
caveats: tweak keg_only style
 2017-05-03 11:19:33 +01:00
Gautham Goli
fed668b330 Add --only-cops,--except-cops options for brew style and simplify cop names 2017-05-03 14:49:23 +05:30
Mike McQuaid
935a3fd4fc Merge pull request #2579 from MikeMcQuaid/install-etc-var-postinstall 
Install etc/var files on postinstall.
 2017-05-03 09:35:28 +01:00
Markus Reiter
24b190cc14 Remove existing from PATH when adding Gem.bindir. 2017-05-03 10:18:07 +02:00
Mike McQuaid
f951a22bea Install etc/var files on postinstall. 
Also, don't delete them after that. This means that `brew postinstall`
becomes a way to easily reinstall configuration files for any formula
without needing any changes to any bottles or requiring a reinstall.
 2017-05-03 09:00:17 +01:00
Mike McQuaid
5b19563937 utils: create GEM_HOME when installing Gems. 
It may not exist before Gem installation which means that the resulting
installed gem will not be found in the PATH.
 2017-05-03 08:26:30 +01:00
Markus Reiter
77b9ef84ee Merge pull request #2560 from reitermarkus/PATH-refactoring 
Refactor PATH generation.
 2017-05-03 01:00:03 +02:00
Dominyk Tiller
bf491e5102
audit_spec: add keg_only_style tests 2017-05-02 20:08:30 +01:00
Dominyk Tiller
9aeb8f0f0b
audit: match start of string, not line 2017-05-02 19:30:41 +01:00
Dominyk Tiller
80483c0206
audit: whitelist 'Firefox' in keg_only_style 2017-05-02 19:05:56 +01:00
Dominyk Tiller
c081b3d975
caveats: chomp keg_only reason 2017-05-02 19:03:03 +01:00
Gautham Goli
c3330c289d Add --only-cops,--except-cops options for brew audit 
Also refactor audit cops into two "departments"
 - FormulaAudit
 - FormulaAuditStrict
 2017-05-02 23:26:12 +05:30
Gautham Goli
a4568a8697 Let cops run without --strict flag 2017-05-02 23:14:44 +05:30
Reto Kromer
cb5316fc17 move before GitHub tarballs 2017-05-01 22:42:57 +02:00
Dominyk Tiller
25ffa301b8
formula_support: keg_only style harmonisation 2017-05-01 19:22:40 +01:00
Dominyk Tiller
85053b1476
audit: add audit_keg_only_style 2017-05-01 19:22:34 +01:00
Shaun Jackman
ffe1ee1636 Install a bottle from an URL 2017-05-01 10:58:26 -07:00
Dominyk Tiller
285b0bc941
caveats: tweak keg_only wording 
Current:
```
This formula is keg-only, which means it was not symlinked into /usr/local.

Qt has CMake issues when linked
```

After:
```
This formula is keg-only, which means it was not symlinked into /usr/local,
because Qt has CMake issues when linked.
```
 2017-05-01 16:56:16 +01:00
Daniel Martín
a98991a10f Revert "Fix IO#select blocking." 2017-05-01 15:45:32 +02:00
Markus Reiter
1be5eeec26 Add test and comment for PATH#existing. 2017-04-30 21:23:12 +02:00
Markus Reiter
1c7238e59b Add tests for PATH#select and PATH#reject. 2017-04-30 21:18:06 +02:00
Markus Reiter
005f165dcb Simplify PATH#parse. 2017-04-30 21:11:49 +02:00
Markus Reiter
24f48ae7d9 Use PATH#select. 2017-04-30 21:11:28 +02:00
Markus Reiter
4d5d6a65e3 Rename PATH#validate to PATH#existing. 2017-04-30 21:11:28 +02:00
Markus Reiter
22f624b373 Make PATH enumerable. 2017-04-30 21:11:28 +02:00
Markus Reiter
e70f2ec332 Make sure duplicates are remove from PATH. 2017-04-30 21:11:28 +02:00
Markus Reiter
0bb9b4918e Remove PATH#inspect. 2017-04-30 21:11:28 +02:00