13469 Commits

Author SHA1 Message Date
Mike McQuaid
6a31e02ab2 Merge pull request #3005 from MikeMcQuaid/cleanup-aliases
keg: cleanup aliases correctly.
2017-08-07 09:50:56 +01:00
Gautham Goli
a92e1eda27 audit: Port rules from line_problems to rubocop part 4(WIP) 2017-08-07 14:08:22 +05:30
Gautham Goli
d9c81901c3 audit: Add tests for rubocop methods in line_cop.rb 2017-08-06 18:36:09 +05:30
Gautham Goli
b8f811cca6 audit: Port rules from line_problems to rubocop part 3 2017-08-06 18:36:09 +05:30
Gautham Goli
3edae73cd9 audit: Add tests for audit rules ported from line_problems method to rubocops 2017-08-06 18:36:09 +05:30
Gautham Goli
b5da76e28d audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 18:36:09 +05:30
Gautham Goli
bc2bcef1ba audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 18:36:09 +05:30
Markus Reiter
ffc47388bd Fix Pkg#uninstall not calling MacOS.undeletable? for all files. 2017-08-06 13:19:30 +02:00
Mike McQuaid
c2cbfc1526 Merge pull request #3010 from rwhogg/remove-homebrew-x11-reference
formula: Remove reference to homebrew/x11
2017-08-06 09:55:56 +01:00
Gautham Goli
781da49df8 audit: Add tests for audit rules ported from line_problems method to rubocops 2017-08-06 02:28:58 +05:30
Gautham Goli
7614d2cc8b audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Markus Reiter
bd25c2e219 Fix parsing extension from URL. 2017-08-05 22:05:04 +02:00
Bob W. Hogg
06ecad2950 formula: Remove reference to homebrew/x11
That tap is now defunct.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-05 12:54:39 -07:00
Markus Reiter
7a17a166ec Merge pull request #3006 from reitermarkus/unfocus
Delete `:focus`.
2017-08-05 21:05:08 +02:00
Mike McQuaid
e862bcbc32 keg: cleanup aliases correctly.
This was missed when I was focused on cleaning up versioned aliases.

Fixes #2992.
2017-08-05 18:03:04 +01:00
Mike McQuaid
eaea27c960 formula_installer: restore build_bottle defaults. 2017-08-05 17:51:47 +01:00
Gautham Goli
66ffdb5b06 Refactor legacy_patches_cop to merge external patch audit rules in a single cop and add tests 2017-08-05 21:51:24 +05:30
Gautham Goli
43cec10000 audit: Port patches audit code to a rubocop 2017-08-05 21:51:24 +05:30
Markus Reiter
f5af3fe0cd Delete :focus. 2017-08-05 18:09:09 +02:00
Markus Reiter
c26c9204fa Merge pull request #2965 from reitermarkus/cask-tap
Detect `Tap` in `CaskLoader`.
2017-08-05 16:54:26 +02:00
Markus Reiter
f89e09b785 Add spec for conflicts_with cask. 2017-08-05 16:21:14 +02:00
Markus Reiter
67327c75b5 Implement conflicts_with :cask. 2017-08-05 16:19:50 +02:00
Mike McQuaid
ae0b7cb824 Merge pull request #2991 from javian/additionalphpignores
audit: add additional php header ignore patterns
2017-08-05 15:16:05 +01:00
Markus Reiter
42cfb6d238 Merge pull request #2999 from mistydemeo/tap_each_enum
Tap.each: return an enumerable when no block given
2017-08-04 16:14:06 +02:00
Markus Reiter
12d4226bfc Remove _checkurl. 2017-08-04 15:39:32 +02:00
Misty De Meo
1c3ece12b9 Tap.each: return an enumerable when no block given 2017-08-03 17:23:16 -07:00
Andrew Yates
365c55573b Moving /usr/lib/pkg-config to be first
Ensuring old functionality still happens and /usr/lib/pkg-config is the first location found in macOS.
2017-08-03 17:22:18 +01:00
ilovezfs
ee6b0e7c9b formula_cellar_checks: check_non_libraries only for new formulae
This check is overly opinionated and leads to audit failures no one
cares to fix, so let's only run it for new formulae.
2017-08-03 05:21:36 -07:00
Andrew Yates
19cfcc34ef Adding in "/usr/lib/pkg-config"
Moving "/usr/lib/pkg-config" into the pkg-path path
2017-08-03 10:46:12 +01:00
Andrew Yates
980db9d3fb Remove errant pkg-config libdir
We found an issue in Linuxbrew/homebrew-core#3366 where the addition of "/usr/lib/pkg-config" causes compilation issues if system pkg-config files are in that directory on Linux. Removing the line from here and adding it into the mac superenv.
2017-08-03 10:44:56 +01:00
Jan Viljanen
85da376233 audit: add additional php header ignore patterns 2017-08-03 06:13:15 +02:00
JCount
68878d73ef formula_desc_cop: add 'x86' to VALID_LOWERCASE_WORDS 2017-08-01 11:36:44 -04:00
Mike McQuaid
f4983ab16b Merge pull request #2975 from GauthamGoli/audit_urls_rubocop_strict
audit: Port audit_urls strict rules to rubocop, add tests, autocorrect
2017-08-01 11:39:01 +01:00
Mike McQuaid
43d68b6dda Merge pull request #2980 from GauthamGoli/audit_style_check_bug_fix
audit: fix bug where `brew audit foo` runs every style check.
2017-08-01 11:36:18 +01:00
Mike McQuaid
c3c3575b70 Merge pull request #2964 from GauthamGoli/audit_line_rubocop_part_1
audit: Port dependency rules from line_problems to rubocop and add tests
2017-08-01 11:29:26 +01:00
Bob W. Hogg
732e0aa689 formula: Remove reference to Homebrew/Homebrew
That repo is now defunct. Reference homebrew-core instead.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-07-31 19:24:33 -07:00
Markus Reiter
05e9086355 Merge pull request #2978 from reitermarkus/simplify-dsl
Simplify `assert_only_one_stanza_allowed`.
2017-07-31 16:44:12 +02:00
Mike McQuaid
af463a0535 formula_installer: never build dependency bottles.
This also helpfully avoids always building all dependencies from source
when passing `--build-bottle` or forcing all bottles when passing
`--force-bottle`.
2017-07-31 10:36:10 +01:00
Mike McQuaid
044f4d947b Tweak preserve link status on reinstall/upgrade.
Treat a `brew install` command as normal i.e. link by default unless
keg-only and only specify whether a keg should be linked when upgrading
or reinstalling. Also, adjust the naming accordingly so it's more
obvious that this is the case.
2017-07-30 21:44:43 +01:00
Mike McQuaid
9d55446cd0 formula_installer: fix typo. 2017-07-30 20:04:41 +01:00
Mike McQuaid
e1fd69de42 Merge pull request #2961 from MikeMcQuaid/preserve-link-on-upgrade-reinstall
Preserve link status on reinstall/upgrade.
2017-07-30 18:42:06 +01:00
Mike McQuaid
e755505c70 Merge pull request #2969 from MikeMcQuaid/default-formula-bottles
formula_installer: use default_formula for bottles
2017-07-30 18:41:10 +01:00
Markus Reiter
0d1162d821 Make zap recognize --force. 2017-07-30 18:51:05 +02:00
Markus Reiter
8779784d70 Fix trash script. 2017-07-30 18:44:53 +02:00
Gautham Goli
5e8e705b50 audit: fix bug where brew audit foo runs every style check. 2017-07-30 22:03:43 +05:30
Markus Reiter
8d7ab78a75 Simplify assert_only_one_stanza_allowed. 2017-07-30 18:06:59 +02:00
Mike McQuaid
a83baba8b5 formula_installer: use default_formula for bottles
This was the original, intended functionality before this was broken
in fe117bf79b244c42b7e4049d353c3c003eae4880.

Fixes https://github.com/Homebrew/homebrew-core/issues/13680.
2017-07-30 16:56:24 +01:00
Mike McQuaid
896f41f7ed Merge pull request #2899 from MikeMcQuaid/enable-deprecations
Enable more deprecations.
2017-07-30 16:32:34 +01:00
Mike McQuaid
7ec0505200 Preserve link status on reinstall/upgrade.
This means if a user has manually `brew unlink` or `brew link --force`d
something then that status will be preserved after they `brew upgrade`
or `brew reinstall` that formula.

This generally should make things that are keg-only by default easier
to swallow.
2017-07-30 16:20:32 +01:00