admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
15,146 Commits 15 Branches 471 Tags
Commit Graph

13469 Commits

Author SHA1 Message Date
Markus Reiter
71b6e239d7 Set RuboCop maximum to current maximum. 2017-10-10 17:00:04 +02:00
Dominyk Tiller
0865ab0d1b audit: nudge to use predicate for 'executable?' as well 2017-10-10 15:45:41 +01:00
Viktor Szakats
811f5fd145 pull: fix bintray verification failing due to redirection 2017-10-10 13:35:49 +00:00
Dominyk Tiller
a0f4861934
audit: broaden refute_predicate nudge 2017-10-09 16:46:01 +01:00
Mike McQuaid
56458f03fc Merge pull request #3277 from sjackman/audit-notable 
audit: Silence not notable on non-Homebrew taps
 2017-10-08 13:41:15 -07:00
Shaun Jackman
53dd0e3f28 audit: Silence not notable on non-Homebrew taps 
Silence "GitHub repository not notable" on non-Homebrew taps.
 2017-10-08 10:35:53 -07:00
Markus Reiter
175ca909ee Clean up code style and remove .rubocop_todo.yml. 2017-10-08 16:10:37 +02:00
Markus Reiter
91ab116ace Merge pull request #3289 from reitermarkus/cask-loader 
Fix regexes in `CaskLoader`.
 2017-10-08 16:07:09 +02:00
Markus Reiter
efbc1b0cb4 Add specs for CaskLoader. 2017-10-08 15:48:54 +02:00
Markus Reiter
cbd9715e5b Fix regexes in CaskLoader. 2017-10-08 15:21:04 +02:00
Markus Reiter
69e2be832c Fix comment location. 2017-10-08 14:14:24 +02:00
Dominyk Tiller
2a25825a12
audit: tweak assert/refute_predicate audit 
Addresses some of the issues I raised in https://github.com/Homebrew/homebrew-core/pull/19127#issue-263566817.
Would still like to work out a way to check `File.exist?`-style language
inside the `test do` block exclusively but for now it's better to be
too conservative on the audit than to be overly-zealous and flag too
much.
 2017-10-08 06:54:49 +01:00
Markus Reiter
bae08d5188 Don’t track files in test and vendor. 2017-10-08 01:47:12 +02:00
Markus Reiter
9795195726 Fix RuboCop tests. 2017-10-07 23:30:47 +02:00
Markus Reiter
5cbf8bdaa7 Merge pull request #3283 from reitermarkus/cask-loader 
Add helper method for Cask fixture paths and refactor CaskLoader.
 2017-10-07 18:30:32 +02:00
Markus Reiter
97333df4cb Add helper method for Cask fixture paths and refactor CaskLoader. 2017-10-07 16:11:25 +02:00
Markus Reiter
62315e93f8 Merge pull request #3280 from commitay/cask-internal-audit 
InternalAuditModifiedCask: audit renamed Casks
 2017-10-07 15:55:02 +02:00
commitay
4fde8f56ce add pkg / binary comment 2017-10-07 23:10:59 +10:00
commitay
a7cf6c1ff0 Cask AbstractArtifact: fix install order 2017-10-07 22:06:39 +10:00
commitay
d5cc68fba3 InternalAuditModifiedCask: audit renamed Casks 2017-10-07 12:53:07 +10:00
Markus Reiter
8f43d6b9f7 Merge pull request #3267 from reitermarkus/refactoring 
Refactor DSL and Artifact classes.
 2017-10-07 00:32:42 +02:00
Mike McQuaid
708c4e0ebd Merge pull request #3273 from MikeMcQuaid/mdfind-reject-backups 
os/mac: ignore apps found in Time Machine backups.
 2017-10-06 15:20:51 +01:00
ilovezfs
10491e1c30 Merge pull request #3274 from MikeMcQuaid/official-taps-remove-apache 
official_taps: remove apache.
 2017-10-05 21:00:48 -07:00
Mike McQuaid
3c0162a5ba Merge pull request #3269 from DomT4/assert_predicate 
audit: prefer assert/refute_predicate over File.exist?
 2017-10-06 04:34:56 +01:00
Mike McQuaid
dd2083d03d Merge pull request #3262 from kabel/version-detect-php 
Add version detection support for php URL
 2017-10-06 04:34:12 +01:00
Mike McQuaid
1c0f12307b official_taps: remove apache. 
It's now deprecated.
 2017-10-05 20:33:22 -07:00
Mike McQuaid
4f8af059df os/mac: ignore apps found in Time Machine backups. 
These can introduce confusion on e.g. outdated Xcode versions when they
are the only (or first) versions that are found.
 2017-10-05 21:47:26 +01:00
Dominyk Tiller
4e957165d1
audit: prefer assert/refute_predicate over File.exist? 2017-10-05 02:52:21 +01:00
Markus Reiter
e9c587d751 Refactor tests. 2017-10-04 18:52:34 +02:00
Markus Reiter
02362259a5 Don’t reorder “basic” artifacts. 2017-10-04 18:47:55 +02:00
Markus Reiter
51a0de6368 Directly save artifacts in DSL. 2017-10-04 18:47:55 +02:00
Markus Reiter
2c7ef064e4 Refactor DSL and Artifacts. 2017-10-04 18:47:55 +02:00
Mike McQuaid
113e5da55e Merge pull request #3263 from MikeMcQuaid/formulary-unreadable-bottle-formula 
formulary: handle unreadable bottle formula.
 2017-10-04 11:38:36 +01:00
Markus Reiter
0fbcbc7864 Merge pull request #3259 from reitermarkus/underscore_supporting_uri 
Remove `UnderscoreSupportingURI`.
 2017-10-04 11:40:38 +02:00
Markus Reiter
67afb6ea68 Merge pull request #3260 from reitermarkus/cask-cli-specs 
Refactor `cask/cli` specs.
 2017-10-04 11:40:03 +02:00
Mike McQuaid
83e2049636 formulary: handle unreadable bottle formula. 
This occurs for any formulae that use relative `require` to files that
are inside of e.g. a tap to use abstract formulae.
 2017-10-04 10:14:06 +01:00
Kevin Abel
4f55565677 Add test for php version in URL middle 2017-10-03 23:39:14 -05:00
Kevin Abel
9d36096d68 Add version detection support for php URL 
Pulls a semver from anywhere in the URL (not just stem).
 2017-10-03 23:29:33 -05:00
Markus Reiter
7ee86cfe77 Merge pull request #3256 from claui/pkg-unshadow-options 
Unshadow `allow_untrusted` option for pkg artifact
 2017-10-03 18:25:59 +02:00
Markus Reiter
643b2a168c Refactor cask/cli specs. 2017-10-03 10:56:40 +02:00
Markus Reiter
ec0d8fa7ba Merge pull request #3220 from yzguy/yzguy/cask_available_languages_to_info 
add available languages to cask info command
 2017-10-03 08:31:56 +02:00
Markus Reiter
a92b6318eb Remove UnderscoreSupportingURI. 2017-10-03 08:29:20 +02:00
Adam Smith
270bf0506a stylistic changes for cask info tests 2017-10-02 11:34:50 -07:00
Markus Reiter
e322663836 Merge pull request #3255 from reitermarkus/summarize 
Add missing `summarize` method.
 2017-10-02 14:21:45 +02:00
Markus Reiter
23da0aa7fb Merge pull request #3247 from reitermarkus/fix-trash 
Fix `brew tests` leaving last file in trash.
 2017-10-02 14:02:24 +02:00
Claudia
fbd526ffe6 Unshadow allow_untrusted option for pkg artifact 
The pkg stanza has an option called `allow_untrusted`, which is
supposed to cause `/usr/sbin/installer` to be called with the
`-allowUntrusted` switch.

PR #3141 seems to have renamed the `pkg_install_opts` field to
`options`. At the same time, it introduces an `options` parameter for
the `run_installer` method, which shadows the `options` getter
method, causing the `allow_untrusted` option to be silently ignored.

The issue affects just the `pkg` stanza because `Hbc::Artifact::Pkg`
is the only artifact class that has an `options` method.

This commit removes the shadowing by renaming the field to
`stanza_options`; in one case, it uses `_options` for a parameter
name (instead of the more canonical `_`) for the sake of clarity.
 2017-10-02 13:34:57 +02:00
Shaun Jackman
03ae6aae3b text_files: Skip the formula in .brew/formula.rb 2017-10-01 18:27:05 -07:00
Markus Reiter
da66e06068 Add missing summarize method. 2017-10-01 23:33:52 +02:00
Markus Reiter
e86c79fbc0 Merge pull request #3248 from reitermarkus/audit-warning 
Add audit warning if previous Cask version cannot be read.
 2017-10-01 22:27:53 +02:00
Markus Reiter
3bb89f5440 Only run trash test when collecting coverage. 2017-10-01 22:26:04 +02:00