12522 Commits

Author SHA1 Message Date
Tim D. Smith
22d3a67b73 Relocate virtualenv orig-prefix.txt
Virtualenvs remember the path to the stdlib in a file named
orig_prefix.txt. This file wasn't being relocated because Homebrew skips
files that look like they're intended for human consumption by matching
against the list of metafile extensions. This led to the bug described
in https://github.com/Homebrew/homebrew-core/issues/12869. This fixes
relocation by creating an exception for orig-prefix.txt.
2017-05-06 15:56:55 -07:00
Markus Reiter
6b5171de30 Remove unused e from rescue Interrupt. 2017-05-05 20:50:11 +02:00
pseudoku
77728abbfc Remove unused command_args
Extra command_args in gain_permissions_remove caused silent failure and path never gets deleted.
2017-05-04 00:17:56 -07:00
Mike McQuaid
6a15cea0b4 style: fix audit --online
This passed a symbol to `:except_cops` which caused a 💥.
2017-05-03 12:58:08 +01:00
Mike McQuaid
56413f6f6d Merge pull request #2582 from MikeMcQuaid/style-fix-rubocop-require
style: don't require rubocop until installed.
2017-05-03 12:40:45 +01:00
Mike McQuaid
790a113371 brew.sh: >v1.2.0 now. 2017-05-03 12:10:25 +01:00
Mike McQuaid
1c43070e69 style: don't require rubocop until installed.
This avoids an error when RuboCop installed installed yet.

CC @GauthamGoli FYI.
2017-05-03 12:09:18 +01:00
Mike McQuaid
a25cd9d8ba Merge pull request #2580 from reitermarkus/gem-path
Remove `existing` from PATH when adding `Gem.bindir`.
2017-05-03 11:37:18 +01:00
Mike McQuaid
555505ec54 Merge pull request #2531 from GauthamGoli/audit_cops_options_refactor
audit: Allow skipping/selective running of cops and cops refactor
2017-05-03 11:28:25 +01:00
Mike McQuaid
ffa45521f4 Merge pull request #2406 from sjackman/install-bottle-url
Install a bottle from an URL
2017-05-03 11:25:12 +01:00
Mike McQuaid
e1ef37953f Merge pull request #2577 from DomT4/keg_only_style_tweaks
caveats: tweak keg_only style
2017-05-03 11:19:33 +01:00
Gautham Goli
fed668b330 Add --only-cops,--except-cops options for brew style and simplify cop names 2017-05-03 14:49:23 +05:30
Mike McQuaid
935a3fd4fc Merge pull request #2579 from MikeMcQuaid/install-etc-var-postinstall
Install etc/var files on postinstall.
2017-05-03 09:35:28 +01:00
Markus Reiter
24b190cc14 Remove existing from PATH when adding Gem.bindir. 2017-05-03 10:18:07 +02:00
Mike McQuaid
f951a22bea Install etc/var files on postinstall.
Also, don't delete them after that. This means that `brew postinstall`
becomes a way to easily reinstall configuration files for any formula
without needing any changes to any bottles or requiring a reinstall.
2017-05-03 09:00:17 +01:00
Mike McQuaid
5b19563937 utils: create GEM_HOME when installing Gems.
It may not exist before Gem installation which means that the resulting
installed gem will not be found in the PATH.
2017-05-03 08:26:30 +01:00
Markus Reiter
77b9ef84ee Merge pull request #2560 from reitermarkus/PATH-refactoring
Refactor PATH generation.
2017-05-03 01:00:03 +02:00
Dominyk Tiller
bf491e5102
audit_spec: add keg_only_style tests 2017-05-02 20:08:30 +01:00
Dominyk Tiller
9aeb8f0f0b
audit: match start of string, not line 2017-05-02 19:30:41 +01:00
Dominyk Tiller
80483c0206
audit: whitelist 'Firefox' in keg_only_style 2017-05-02 19:05:56 +01:00
Dominyk Tiller
c081b3d975
caveats: chomp keg_only reason 2017-05-02 19:03:03 +01:00
Gautham Goli
c3330c289d Add --only-cops,--except-cops options for brew audit
Also refactor audit cops into two "departments"
 - FormulaAudit
 - FormulaAuditStrict
2017-05-02 23:26:12 +05:30
Gautham Goli
a4568a8697 Let cops run without --strict flag 2017-05-02 23:14:44 +05:30
Reto Kromer
cb5316fc17 move before GitHub tarballs 2017-05-01 22:42:57 +02:00
Dominyk Tiller
25ffa301b8
formula_support: keg_only style harmonisation 2017-05-01 19:22:40 +01:00
Dominyk Tiller
85053b1476
audit: add audit_keg_only_style 2017-05-01 19:22:34 +01:00
Shaun Jackman
ffe1ee1636 Install a bottle from an URL 2017-05-01 10:58:26 -07:00
Dominyk Tiller
285b0bc941
caveats: tweak keg_only wording
Current:
```
This formula is keg-only, which means it was not symlinked into /usr/local.

Qt has CMake issues when linked
```

After:
```
This formula is keg-only, which means it was not symlinked into /usr/local,
because Qt has CMake issues when linked.
```
2017-05-01 16:56:16 +01:00
Daniel Martín
a98991a10f Revert "Fix IO#select blocking." 2017-05-01 15:45:32 +02:00
Markus Reiter
1be5eeec26 Add test and comment for PATH#existing. 2017-04-30 21:23:12 +02:00
Markus Reiter
1c7238e59b Add tests for PATH#select and PATH#reject. 2017-04-30 21:18:06 +02:00
Markus Reiter
005f165dcb Simplify PATH#parse. 2017-04-30 21:11:49 +02:00
Markus Reiter
24f48ae7d9 Use PATH#select. 2017-04-30 21:11:28 +02:00
Markus Reiter
4d5d6a65e3 Rename PATH#validate to PATH#existing. 2017-04-30 21:11:28 +02:00
Markus Reiter
22f624b373 Make PATH enumerable. 2017-04-30 21:11:28 +02:00
Markus Reiter
e70f2ec332 Make sure duplicates are remove from PATH. 2017-04-30 21:11:28 +02:00
Markus Reiter
0bb9b4918e Remove PATH#inspect. 2017-04-30 21:11:28 +02:00
Markus Reiter
d552ff316d Make PATH#validate return nil if empty. 2017-04-30 21:11:28 +02:00
Markus Reiter
cb1ac3f998 Don’t implement PATH#eql?. 2017-04-30 21:11:27 +02:00
Markus Reiter
f8ad9d7efd Use PATH where possible. 2017-04-30 21:11:27 +02:00
Markus Reiter
314483f75c Remove Array#to_path_s. 2017-04-30 21:11:27 +02:00
Markus Reiter
a16746906d Add PATH class. 2017-04-30 21:11:27 +02:00
Markus Reiter
e221d0481a Use to_path_s in install_gem_setup_path!. 2017-04-30 21:11:27 +02:00
Markus Reiter
3e4fe279b0 Use to_path_s for determine_pkg_config_libdir. 2017-04-30 21:11:27 +02:00
Mike McQuaid
0c9047a2b8 Merge pull request #2562 from DomT4/you_shall_not_pass_go_get
audit: formally ban go get usage
2017-04-30 13:32:22 +01:00
Zhiming Wang
7a75de7cb1
pull: fix status code check in check_bintray_mirror
The status code of the last redirect should be 2xx to be deemed successful.
2017-04-29 19:30:19 -04:00
Markus Reiter
989a19b676 Update plist to 3.3.0. 2017-04-28 20:51:07 +02:00
Dominyk Tiller
ed1ae19aee
audit_spec: test go get ban 2017-04-28 18:13:38 +01:00
Dominyk Tiller
2ad43cb1fd
audit: formally ban go get usage
There's been an informal ban for a while but let's
be punchier because this crops up still.
2017-04-28 17:38:01 +01:00
Mike McQuaid
1c9cfb2419 audit: tweak dependency option audit.
Make sure that `if build.with?` isn't caught.
2017-04-27 16:30:05 +01:00