Mike McQuaid
c6a5bbac7d
Merge pull request #3411 from issyl0/whitelist_etc_and_fix_autocorrect
...
formula_desc_cop: Whitelist "etc." and fix the full stop autocorrect
2017-11-19 14:39:09 +00:00
Dan Wendorf
151c2861ac
Custom commands can show help
...
We attempted to find the help message for commands before loading custom
commands in the path.
2017-11-18 17:04:54 -08:00
ilovezfs
15a2ef525f
ENV: don't set MACOSX_DEPLOYMENT_TARGET
...
CMake tries to use Xcode if MACOSX_DEPLOYMENT_TARGET is set but that can
lead to build failures when SDKROOT isn't set. The CMake behavior at
minimum manifests as -isysroot spontaneously being set to the Xcode SDK,
which brew sometimes can't successfully fully unwind with its ENV hacks.
2017-11-18 11:31:08 -08:00
Mike McQuaid
28f4d68b31
bottle: use HOMEBREW_GIT_* vars.
...
This allows them to be passed through from `brew test-bot`.
2017-11-18 11:22:46 +00:00
Mike McQuaid
2e1331cbc8
Tweak SDK variables for new Xcode/CLT setup.
2017-11-17 21:35:49 +00:00
Mike McQuaid
cd0db51343
diagnostic: check if Xcode needs CLT installed.
...
Require the CLT on all but the latest version of macOS to avoid the
continuous workarounds for SDK weirdness.
2017-11-17 21:35:49 +00:00
Mike McQuaid
889fc81906
Merge pull request #3449 from MikeMcQuaid/diagostic-fix-paths
...
diagnostic: fix paths usage.
2017-11-17 19:50:04 +00:00
Mike McQuaid
a582be054c
official_taps: migrate nginx.
2017-11-17 19:47:58 +00:00
Mike McQuaid
9ebf338804
diagnostic: fix paths usage.
...
- Don't allow taking an argument. This doesn't work and never has as it
caches the result regardless of the argument.
- Don't rely on the PATH to check for external commands.
2017-11-17 17:41:58 +00:00
Shaun Jackman
6da95d882d
vendor-install: Observe HOMEBREW_STDERR
...
Suppress stderr unless HOMEBREW_STDERR is set.
2017-11-16 11:08:50 -08:00
L. E. Segovia
8ee6ac2613
Implement @reitermarkus's comments
...
- Split move into a move_back (and clarify when it is used)
- Remove unused flags
- Raise error if installed Caskfile not found
- Error out if an upgrade fails
- Remove some defensive programming checks
2017-11-16 10:40:32 -03:00
L. E. Segovia
36fe355159
Add tests for upgrade recovery
2017-11-13 08:46:08 -03:00
Mike McQuaid
5241d07474
environment filtering: pass through TRAVIS vars.
...
We use these internally so let's map them to `HOMEBREW_` variables.
2017-11-13 10:01:54 +00:00
L. E. Segovia
8cc1aea5f0
Implement @reitermarkus's upgrade flow
2017-11-11 17:21:13 -03:00
Martin Schimandl
17e001bd30
Remove (soon to be) obsolete check
...
Fix small typo
2017-11-10 20:16:38 +01:00
Martin Schimandl
fea5350d52
Add line break to string
2017-11-10 20:16:38 +01:00
Martin Schimandl
4e4405e6d7
split string to stay below 80 characters per line
2017-11-10 20:16:38 +01:00
Martin Schimandl
2b261ad4a7
Refactor code to reduce characters per line
2017-11-10 20:16:38 +01:00
Martin Schimandl
5eab54f892
Reduce verbosity of artifacts hash
2017-11-10 20:16:38 +01:00
Martin Schimandl
52343142a7
Remove unused variables. Refactor code
2017-11-10 20:16:38 +01:00
Martin Schimandl
d03720320a
adapt internal_stanza command to work with SortedSet of Artifacts
2017-11-10 20:16:38 +01:00
Martin Schimandl
587c5b07b3
Fix handling of artifact set
2017-11-10 20:16:38 +01:00
Martin Schimandl
255e991cc3
Remove obsolete code to fix tests.
2017-11-10 20:16:38 +01:00
Martin Schimandl
db2c86204b
internal_stanza.rb: Remove obsolete code. Improve detection of missing stanzas
...
internal_stanza_spec.rb: change do ... end blocks to { } blocks
2017-11-10 20:16:38 +01:00
Martin Schimandl
7f70080c94
Add another test to increase coverage.
2017-11-10 20:16:38 +01:00
Martin Schimandl
dfe4e7641a
combine errors to a single if-statement. fix spec test
2017-11-10 20:16:38 +01:00
Martin Schimandl
99b7636008
Fix 'brew style' issues
2017-11-10 20:16:38 +01:00
Martin Schimandl
ff2239509d
Change behaviour of 'cask _stanza' command. Add tests for 'cask _stanza' command
2017-11-10 20:16:38 +01:00
Martin Schimandl
be68f3d7b4
Fix 'brew style' offenses
2017-11-10 20:16:38 +01:00
Martin Schimandl
b7a51eab6b
improve 'brew cask _stanza' by checking for known stanzas
2017-11-10 20:16:38 +01:00
Mike McQuaid
441c212f2d
Merge pull request #3416 from zmwangx/bump-formula-pr-fix-message
...
bump-formula-pr: --message: add newlines before and after hr
2017-11-10 17:53:10 +00:00
Mike McQuaid
ee4172159b
Merge pull request #3377 from maxim-belkin/extend-pathname
...
pathname: new methods and improvements
2017-11-10 17:49:27 +00:00
Markus Reiter
5318907d93
Merge pull request #3432 from reitermarkus/delegate-class
...
Refactor `DependsOn` with `DelegateClass`.
2017-11-10 18:29:28 +01:00
L. E. Segovia
72e673afae
Fix reinstall/uninstall tests
2017-11-10 11:33:44 -03:00
Mike McQuaid
4d4722c97c
Remove more uses of EOS.undent.
2017-11-10 14:22:39 +00:00
Mike McQuaid
219f9691ef
Merge pull request #3292 from claui/add-audit-test-cases
...
Add tests for `FormulaAuditor#audit_deps`
2017-11-10 13:34:56 +00:00
L. E. Segovia
522a229dbb
Fix upgrade tests and some upgrade? leftovers
2017-11-08 08:33:33 -03:00
Maxim Belkin
de0b93f912
pathname: improvements, cleanups, and new methods
...
- atomic_write: close file before renaming to prevent error:
'Device or resource busy'
- ensure_writable: preserve executable bit
- new elf? and dynamic? methods
2017-11-07 14:18:25 -06:00
Mike McQuaid
ccf933f31c
Merge pull request #3435 from MikeMcQuaid/auto-update-checked
...
Use HOMEBREW_AUTO_UPDATE_CHECKED variable.
2017-11-07 08:26:19 +00:00
Mike McQuaid
3ad4dcafd7
Merge pull request #3427 from MikeMcQuaid/bump-formula-pr-env-filtering-github
...
bump-formula-pr: use GitHub vars under env filter.
2017-11-07 08:12:53 +00:00
Mike McQuaid
b96ded7ca4
Merge pull request #3430 from commitay/hash-order
...
brew list 'filtered_list': pass explicit sort to handle APFS
2017-11-07 08:03:48 +00:00
Mike McQuaid
5f301755c0
Use HOMEBREW_AUTO_UPDATE_CHECKED variable.
...
Rather than reusing `HOMEBREW_NO_AUTO_UPDATE` to indicate that we've
already made a check. This allows `HOMEBREW_NO_AUTO_UPDATE` to be
displayed properly by `brew config`.
2017-11-07 08:01:51 +00:00
Mike McQuaid
127bdfdc71
bump-formula-pr: use HOMEBREW_BROWSER.
2017-11-07 07:54:34 +00:00
Mike McQuaid
9358f678a3
Clear/mask passwords as well as tokens.
2017-11-07 07:54:34 +00:00
Mike McQuaid
3f8f2c6726
bump-formula-pr: use GitHub vars under env filter.
...
Ensure that the various variables are passed through and reset
correctly. If we end up doing this in a bunch of places we may add some
helpers to simplify this.
2017-11-07 07:54:34 +00:00
Mike McQuaid
2ad1799308
os/mac/diagnostic: fix XQuartz message.
...
Fixes #3434 .
2017-11-07 07:39:10 +00:00
ilovezfs
4cc72cf3be
Merge pull request #3409 from DomT4/xcode
...
Xcode 9.1 Updates.
2017-11-06 23:22:50 -08:00
commitay
ac799d9f2d
brew list --pinned: pass explicit sort to handle APFS
2017-11-07 12:35:40 +10:00
L. E. Segovia
94d266e2d6
Rework uninstallation step
...
Now the artifacts get re-staged, and upon an uninstall/finalize_upgrade
they are deleted by purge_versioned_files instead
2017-11-06 21:27:02 -03:00
L. E. Segovia
84c128411f
Fix style issues
2017-11-06 18:33:29 -03:00