33639 Commits

Author SHA1 Message Date
Michael Cho
834c2b1094
rubocops: xcodebuild needs an Xcode dependency 2024-09-17 20:41:31 -04:00
BrewTestBot
a64aea60d9
brew vendor-gems: commit updates. 2024-09-17 18:49:39 +00:00
dependabot[bot]
32f771ee86
build(deps-dev): bump rubocop-performance in /Library/Homebrew
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.22.0 to 1.22.1.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.22.0...v1.22.1)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-17 18:44:07 +00:00
Michael Cho
133e46e484
dev-cmd/unbottled: fix total unbottled count 2024-09-17 12:47:39 -04:00
Mike McQuaid
335d370ec0
Merge pull request #18326 from notfirefox/update-shellenv
cmd/shellenv: set `XDG_DATA_DIRS` on Linux
2024-09-17 13:51:21 +01:00
notfirefox
12982a2d97 cmd/shellenv: set XDG_DATA_DIRS on Linux
Some programs like `vapigen` might not work correctly, when `XDG_DATA_DIRS`
does not include `$HOMEBREW_PREFIX/share`. Instead of requiring the user
to manually adjust the shell environment, we can set `XDG_DATA_DIRS` as
part of `cmd/shellenv`, so that it is sufficient to run `brew shellenv`
on any particular system.

Fixes #18317
2024-09-17 13:54:53 +02:00
Mike McQuaid
6c39a5883f
Merge pull request #18345 from daeho-ro/add-search-characters
search: allow @ and + characters
2024-09-17 08:48:28 +01:00
Ruoyu Zhong
28a1dbd2ab
Merge pull request #18342 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.22.0
build(deps-dev): bump rubocop-performance from 1.21.1 to 1.22.0 in /Library/Homebrew
2024-09-17 12:14:11 +08:00
Carlo Cabrera
04a2c994e5
Merge pull request #18333 from Homebrew/ld-so-diagnostics-typeerror 2024-09-17 12:09:09 +08:00
Carlo Cabrera
1656d08629
os/linux/ld: drop retry logic
This is a hack, so let's see if we can get away with skipping it for
now.
2024-09-17 11:51:27 +08:00
Daeho Ro
47e70ab3ea allow @ and + characters for search 2024-09-17 12:43:28 +09:00
Bo Anderson
70b8b41b37
resource: further fix manifest retry handling 2024-09-16 21:05:39 +01:00
BrewTestBot
05c0f473f0
brew vendor-gems: commit updates. 2024-09-16 19:43:34 +00:00
dependabot[bot]
7ec083ebd6
build(deps-dev): bump rubocop-performance in /Library/Homebrew
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.21.1 to 1.22.0.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.21.1...v1.22.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-16 18:30:51 +00:00
Carlo Cabrera
70ab4932d3
Add link to issue with context 2024-09-17 01:03:34 +08:00
Mike McQuaid
08e5122036
Merge pull request #18340 from Homebrew/revert-18329-limit-annotations
Revert "Limit usage of GitHub Actions Annotations"
2024-09-16 17:49:45 +01:00
Mike McQuaid
547677c810
Merge pull request #18341 from Homebrew/add-warning-silence-suggestions
cli/named_args: update `package_conflicts_message`
2024-09-16 17:40:07 +01:00
Mike McQuaid
8f5c74592e
Merge pull request #18328 from notfirefox/fix-rubocop-cache
style: resolve symblic links in `HOMEBREW_CACHE`
2024-09-16 17:23:51 +01:00
Carlo Cabrera
2101411c0a
cli/named_args: update package_conflicts_message
Let's also show users the right way to silence this message.

Follow-up to #18330.
2024-09-17 00:23:15 +08:00
Mike McQuaid
8fd78bffce
Merge pull request #18330 from Homebrew/package-conflicts-message-quiet
cli/named_args: silence `package_conflicts_message` with `--quiet`
2024-09-16 17:00:04 +01:00
Mike McQuaid
1c390093f8
Revert "Limit usage of GitHub Actions Annotations" 2024-09-16 16:52:03 +01:00
Bo Anderson
337ac07980
dev-cmd/generate-cask-api: fix handling of + characters 2024-09-16 16:25:19 +01:00
Bo Anderson
a434e516cd
formula_installer: fix fetch call 2024-09-16 15:03:58 +01:00
Carlo Cabrera
bb20b3c720
os/linux/ld: harden brewed_ld_so_diagnostics against TypeError
I think this is a bug in Ruby, but I've no idea how to track it down. I
can reproduce it intermittently in a codespace when `brew install`ing a
large number of formulae.

To work around this:
- cache the return value of `brewed_ld_so_diagnostics` so that we can
  limit the number of calls to `IO.popen`
- retry once when we see a `TypeError`

Closes #17828.
2024-09-16 20:26:35 +08:00
notfirefox
bb4208ebf1 style: resolve symblic links in HOMEBREW_CACHE
On Linux HOMEBREW_CACHE may be set to `$HOME/.cache/Homebrew`. Some
systems, like Fedora Silverblue, have `/home` set up to be a symbolic
link to `/var/home`. While Homebrew generally seems to work fine on
Fedora Silverblue, rubocop causes the `brew style` command to emit
a lot of warnings because of the symbolic link[1]. This can be resolved
by looking up the real path of HOMEBREW_CACHE before passing it to rubocop.

[1] https://github.com/rubocop/rubocop/issues/6228

Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-09-16 09:50:48 +02:00
Carlo Cabrera
076c4e01f2
Merge pull request #18334 from Homebrew/NoSuchKegFromTapError 2024-09-16 12:59:35 +08:00
Bo Anderson
eb93d844d8
Fix NoSuchKegFromTapError handling 2024-09-16 05:46:14 +01:00
Bo Anderson
2985b16369
Merge pull request #18331 from Homebrew/debug-symbols-prefix
shims/super/cc: don't strip prefixes with `--debug-symbols`
2024-09-16 05:07:46 +01:00
Bo Anderson
505d184a16
Merge pull request #18332 from Homebrew/manifest-error-fix
software_spec: fix invalid manifest handling
2024-09-16 01:31:39 +01:00
Bo Anderson
45c88cc508
software_spec: fix invalid manifest handling 2024-09-16 00:39:53 +01:00
Bo Anderson
0820c19417
shims/super/cc: don't strip prefixes with --debug-symbols 2024-09-15 19:07:12 +01:00
Carlo Cabrera
150e14f83d
cli/named_args: silence package_conflicts_message with --quiet
Based on feedback from Homebrew/discussions#5602.

While users can already silence this by passing `--formula` or `--cask`
as required, I am inclined to agree that `--quiet` should probably
silence messages that are relatively low priority (of which I think this
is one).
2024-09-15 18:51:06 +08:00
Carlo Cabrera
c6e2cd9037
Limit usage of GitHub Actions Annotations
- only use annotations for `opoo` and `onoe` if
  `HOMEBREW_GITHUB_ACTIONS` is set. This will make using `brew` less
  noisy in GitHub Actions for third parties. See
  Homebrew/discussions#5602.
- if we've already called `puts_annotation_if_env_set`, then we no
  longer need to print the message to `$stderr`. The message from the
  annotation already show up in the GitHub Actions log, so printing to
  `$stderr` just leads to duplicate messages in the log.

While we're here, let's make sure to forward the `file:` and `line:`
kwargs of `puts_annotation_if_env_set` to the `Annotation` constructor.
2024-09-15 11:31:54 +08:00
BrewTestBot
4430030b0d
brew vendor-gems: commit updates. 2024-09-13 15:03:13 +00:00
dependabot[bot]
c4653cdb02
build(deps-dev): bump rubocop-md in /Library/Homebrew
Bumps [rubocop-md](https://github.com/rubocop/rubocop-md) from 1.2.2 to 1.2.3.
- [Release notes](https://github.com/rubocop/rubocop-md/releases)
- [Changelog](https://github.com/rubocop/rubocop-md/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-md/compare/v1.2.2...v1.2.3)

---
updated-dependencies:
- dependency-name: rubocop-md
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-13 14:59:30 +00:00
Mike McQuaid
51b9200f6e
Merge pull request #18314 from Homebrew/sequoia-runner-for-bottled-formulae
Deploy Sequoia runner, 🔪 Monterey
2024-09-13 08:36:53 +01:00
Carlo Cabrera
51c4421409
Change default Homebrew/core CI runners
We will now build on Ventura (macOS 13) to Sequoia (macOS 15).

Runners for macOS 15-x86_64 will not be allocated by default due to a
lack of appropriate hardware.
2024-09-12 22:06:10 +08:00
Carlo Cabrera
623e1766dd
cmd/shellenv: use long flags for fish
This will make the output more readable. We tend to prefer long flags
elsewhere anyway.
2024-09-12 16:49:23 +08:00
Carlo Cabrera
c5d09b4117
Merge pull request #18304 from WinkelCode/fish-path-order-fix 2024-09-12 16:40:12 +08:00
Carlo Cabrera
a4b433895c
exceptions: skip #fetch_issues is HOMEBREW_NO_BUILD_ERROR_ISSUES is set
This will allow us to set `HOMEBREW_NO_BUILD_ERROR_ISSUES` in our
workflows, which will avoid needlessly burning through our rate limit.
2024-09-12 14:05:30 +08:00
Carlo Cabrera
0fb4d515e5
Merge pull request #18312 from Homebrew/cargo-parallel 2024-09-12 02:28:15 +08:00
Carlo Cabrera
a9591c712f
formula: make cargo respect Homebrew-managed parallelism
`cargo` doesn't follow setting `HOMEBREW_MAKE_JOBS` or
`ENV.deparallelize`. Let's fix that.
2024-09-12 02:16:01 +08:00
Carlo Cabrera
d2c443afce
Merge pull request #18310 from cho-m/m4-env 2024-09-12 02:10:04 +08:00
BrewTestBot
5dd6ad3a1b
Update RBI files for vernier.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-09-11 16:29:58 +00:00
BrewTestBot
72860b6135
brew vendor-gems: commit updates. 2024-09-11 16:29:44 +00:00
dependabot[bot]
041b01f0dd
build(deps-dev): bump vernier from 1.1.2 to 1.2.1 in /Library/Homebrew
Bumps [vernier](https://github.com/jhawthorn/vernier) from 1.1.2 to 1.2.1.
- [Commits](https://github.com/jhawthorn/vernier/compare/v1.1.2...v1.2.1)

---
updated-dependencies:
- dependency-name: vernier
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-11 16:27:12 +00:00
Mike McQuaid
491b9d4fa1
Merge pull request #18309 from Homebrew/linker-flag-parsing
shims/super/cc: fix linker flag parsing
2024-09-11 17:12:56 +01:00
Michael Cho
99d81b4717
ENV/super: replace m4 shim with M4 variable
The problem is the shim can end up getting baked into formula binaries
(e.g. `flex`) or cause odd issues when mixed up with brew `m4`, e.g.
https://github.com/Homebrew/homebrew-core/issues/180040
2024-09-11 11:33:44 -04:00
Carlo Cabrera
f3d1dd165d
shims/super/cc: fix linker flag parsing
Our parsing of linker flags can be easily confused by, e.g.,

    -Wl,-undefined -Wl,dynamic_lookup,-dead_strip_dylibs

The current code that tries to detect these flags will erroneously
conclude that they were not passed.

This change fixes that.
2024-09-11 22:53:04 +08:00
Rylan Polster
6cc232c205
Include formula name in no-URL error 2024-09-11 10:45:28 -04:00