admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
7,857 Commits 15 Branches 471 Tags
Commit Graph

357 Commits

Author SHA1 Message Date
Dominyk Tiller
d25d3b07da audit: flag insecure launchpad 2015-08-10 02:25:59 +01:00
Mike McQuaid
3518cda792 audit: allow assert !.*.include?. 
Came up on Homebrew/homebrew#34573.
 2015-08-09 09:33:33 +01:00
Alexis Hildebrandt
f78a63984b audit: add check for indefinite article 
at the beginning of desc.

Closes Homebrew/homebrew#42404.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-06 18:10:48 +01:00
Xu Cheng
ae0e270727 favor flat_map over map...flatten 2015-08-06 22:33:46 +08:00
Xu Cheng
b121e5fd7b more core file style updated by rubocop 2015-08-06 17:23:56 +08:00
Alexis Hildebrandt
e9180b39f5 audit: simplify command-line spelling check 
Closes Homebrew/homebrew#42403.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-08-05 20:19:40 +01:00
Dominyk Tiller
150a9fe514 audit: flag plaintext mirrorservice 2015-08-05 19:45:24 +01:00
BrewTestBot
13d544e11e Core files style updates. 
Closes Homebrew/homebrew#42354.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-03 13:22:35 +01:00
Baptiste Fontaine
79678cb109 online audit: use GET instead of HEAD 
I also removed the `-L` flag which is already present in
`HOMEBREW_CURL_ARGS`.

Closes Homebrew/homebrew#42352.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-02 11:15:52 +02:00
Xu Cheng
ea21f9bc4d audit: more fix on no-compat mode 2015-07-22 16:41:10 +08:00
Xu Cheng
2648684b3b audit: rename audit_patches to audit_legacy_patches 2015-07-22 16:34:08 +08:00
Xu Cheng
51810ae1ea audit: fix for no-compat mode 2015-07-22 15:27:58 +08:00
Rainer M. Krug
86d04e94e9 audit: recognise head-only and devel-only taps. 
add wildcard into expressions to identify head-only and dev-only taps
to avoid "head-only" and "devel-only" errors when formula is in
*head-only or *devel-only tap

Closes Homebrew/homebrew#41289.
Closes Homebrew/homebrew#41413.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-18 20:50:12 -07:00
Baptiste Fontaine
6303ff7e28 audit: missing spaces added in blocks order report 
Closes Homebrew/homebrew#41783.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-07-18 10:45:47 +02:00
Mike McQuaid
24b0639e27 audit: recommend use of assert_match. 
It produces significantly easier output to debug than doing `assert` and
`.include?` (which just shows if it passed or failed).

Closes Homebrew/homebrew#41662.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-14 11:54:38 -07:00
Dominyk Tiller
b554c8bcca audit: clarify desc calculation 2015-07-14 17:15:51 +01:00
Baptiste Fontaine
3ba3ecba9d audit --online: check homepage reachability 
Closes Homebrew/homebrew#41607.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-07-12 20:32:15 +02:00
Mike McQuaid
4f74e891aa audit: deprecate sha1 always. 
Rather than just when --strict is set. We're asking people to do these
on most PRs now anyway so feels better to let them find this out with
`brew audit`.

Closes Homebrew/homebrew#41523.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-09 17:45:53 +01:00
Mike McQuaid
8e7f15eff4 audit: include date for Ruby 1.8. 2015-07-09 15:28:49 +01:00
Xu Cheng
f68869cc70 audit: better way to handle --online for audit_formula_name 2015-07-09 22:06:53 +08:00
Mike McQuaid
3ac6005931 audit: add --online flag. 
Also add it to the manpage and brew-test-bot.

Closes Homebrew/homebrew#41516.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-09 14:50:55 +01:00
Mike McQuaid
804f1431d4 audit: github repo: verify stable formula is set . 2015-07-08 16:28:51 +01:00
Mike McQuaid
333c3d700f audit: slightly loosen GitHub repo audit. 2015-07-08 15:29:55 +01:00
Mike McQuaid
c0c68b2b3f audit: handle some GitHub repo audit edge cases. 2015-07-08 15:19:36 +01:00
Mike McQuaid
51a1792e7a Audit GitHub repository notability. 
This stuff seems to be taken better when coming from a script rather
than from a human. Feel free to disagree about the specific numbers
chosen here.
 2015-07-08 14:53:48 +01:00
Viktor Szakats
c443fe139d audit: fix/extend ietf.org https rules 
Domains known to be covered by certificates: https://crt.sh/?q=%25ietf.org

Closes Homebrew/homebrew#41244.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-07-02 21:31:10 +01:00
Dominyk Tiller
986a62ebe9 audit: flag re-added tap migrations 
Re 411c217844 (commitcomment-11714539)

Closes Homebrew/homebrew#40806.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-06-30 03:00:32 +01:00
Jack Nagel
22269b7007 Fix audit when tap is nil 
This is the case when a formula is passed as a filename.
 2015-06-23 19:58:37 -04:00
Xu Cheng
b363175401 improve audit_formula_name performance 
Closes Homebrew/homebrew#40939.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-22 21:24:50 +08:00
Xu Cheng
d770a874e4 audit: add benchmark inject code 
Closes Homebrew/homebrew#40847.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-18 20:30:33 +08:00
Xu Cheng
2f44990ea9 Revert "audit: add benchmark inject code" 
This reverts commit fb23d603ded2796299ed7fc2f4ffee22870b7ea6.
 2015-06-18 15:26:11 +08:00
Xu Cheng
7a59a3ee37 audit: add benchmark inject code 2015-06-18 14:46:29 +08:00
Mike McQuaid
1e86730289 Rename requirements named *Dependency. 
Dependency is another similar, related class and it's super confusing
to have some Requirements that are named *Dependency.

Closes Homebrew/homebrew#38891.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-06-16 08:12:01 +01:00
Xu Cheng
4c6da16221 audit: fix for no compat mode 
Closes Homebrew/homebrew#40731.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-15 17:35:04 +08:00
Dominyk Tiller
a047fc08d6 audit: enforce http for gnu ftpmirror 2015-06-14 20:17:08 +01:00
Dominyk Tiller
f63e7a92bb audit: add npm path nudge 2015-06-13 22:25:26 +01:00
Larry Gilbert
69b629b041 Various edits for punctuation, grammar, spelling, etc. 
Closes Homebrew/homebrew#40478.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-06-10 17:44:00 +01:00
Xu Cheng
ea167399a2 audit: fix index method for ruby 1.8 
Per
https://github.com/Homebrew/homebrew/pull/40472#issuecomment-110357915
 2015-06-09 21:34:44 +08:00
Xu Cheng
8604799f1a audit: add rules on field order 
Closes Homebrew/homebrew#40472.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-09 16:03:53 +08:00
Jack Nagel
d3ab5e6034 Revert "audit: add rules for non-ascii character and encoding comment" 
This reverts commit ab8fe812377bc60cc18fe8d7c1ea8ce2f0269294.
 2015-06-08 22:27:28 -04:00
Baptiste Fontaine
d87f9d4359 singular/plural phrasing in audit report 
Closes Homebrew/homebrew#40395.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-06-05 19:32:23 +02:00
Xu Cheng
4cc21fb1f7 audit: audit formulae with the same name 
Closes Homebrew/homebrew#40216.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-06-01 20:08:41 +08:00
Xu Cheng
9bf4bf5fee audit: use Formula#full_name 2015-05-29 17:01:53 +08:00
Viktor Szakats
26d1683039 audit: enforce gnome urls 
Closes Homebrew/homebrew#40172.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-05-29 08:22:37 +01:00
Dominyk Tiller
6db8e1c5a9 audit: simplify ssl/tls audit failure messages 
This cuts the amount of custom code fairly drastically, applying the
same generic syntax across the different SSL/TLS enforced areas.

It also makes the failure message fit onto one terminal line, which
looks cleaner than the multi-line message we currently print
for standard-size Terminals.

Changes something like:

`ftp.gnu.org urls should be https://, not http:// (url is http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz)`

Into:

`Please use https:// for http://ftp.gnu.org/gnu/gawk/gawk-4.1.1.tar.xz`

References: Homebrew/homebrew#39421 Homebrew/homebrew#39306

Closes Homebrew/homebrew#40054.

Signed-off-by: Dominyk Tiller <dominyktiller@gmail.com>
 2015-05-27 11:44:29 +01:00
Xu Cheng
ef3f0f0945 audit: handle TapFormulaAmbiguityError 2015-05-27 13:53:41 +08:00
Nikolaus Wittenstein
39498af1c6 audit looks for and validates 'desc' 2015-05-25 17:23:50 +01:00
Xu Cheng
60f2377853 audit: formula version string should have digit 
Closes Homebrew/homebrew#40025.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-05-24 20:07:44 +08:00
Xu Cheng
78ccd41251 audit: add rules for non-ascii character and encoding comment 
Closes Homebrew/homebrew#40042.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-05-24 20:07:33 +08:00
Xu Cheng
e4ff0a2f2e audit: move audit_java_home inside audit_line 2015-05-24 16:27:54 +08:00