admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
3,355 Commits 15 Branches 471 Tags
Commit Graph

221 Commits

Author SHA1 Message Date
Jack Nagel
d25767b354 doctor: consolidate directory access checks 
Also include a writability check for lib.

Closes Homebrew/homebrew#18571.
 2013-04-12 19:32:02 -05:00
Geoff Petrie
79c745cc76 doctor: suggest brew update in outdated warning 
Closes Homebrew/homebrew#19106.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-04-11 02:12:59 -05:00
Jack Nagel
62a0b3f18d Use #grep where it will suffice 2013-04-05 22:00:36 -05:00
Jack Nagel
ec7dc78ba4 Simplify destructuring this array 2013-03-30 15:16:44 -05:00
Jack Nagel
4a52bf1c31 Use each_key instead of keys.each 2013-03-29 21:59:02 -05:00
Adam Vandenberg
3320b15609 doctor: restore newlines between checks 
Closes Homebrew/homebrew#18060.
 2013-03-29 11:14:46 -07:00
Adam Vandenberg
d9f64a1574 doctor: check for all DYLD env vars 2013-03-26 16:19:55 -07:00
Samuel John
ac68de8a7e doctor: Tweak git-clean suggestion for empty dirs 
git clean -f is not enough. Needs `-d` somtimes to
handle cases when we rename a dir.

Fixes Homebrew/homebrew#18544 and fixes Homebrew/homebrew#14224
 2013-03-18 12:09:15 +01:00
Adam Vandenberg
69c8ed1a1e doctor: add check for coreutils in path 2013-03-13 10:22:09 -07:00
Adam Vandenberg
7b7268c065 doctor: mess with indentation 2013-03-13 09:45:55 -07:00
Misty De Meo
feb836e1ea doctor: skip git origin check without brew repo 
Likely fixes Homebrew/homebrew#18324.
 2013-03-11 10:30:08 -05:00
Misty De Meo
6b96102fad doctor: Update Mono pkg-config warning 2013-02-25 11:17:19 -06:00
Jack Nagel
f037be5148 Don't shadow outer local variables 2013-02-18 12:13:36 -06:00
Mike McQuaid
7766505348 brew-doctor: fix autocrlf warning (again). 
Closes Homebrew/homebrew#17843.
 2013-02-18 10:42:14 +00:00
Adam Vandenberg
37b28741f2 doctor: make brew link more clear 
Closes Homebrew/homebrew#17805.
 2013-02-12 22:30:49 -08:00
Samuel John
e851e88863 brew doctor: Check for CaSe SeNsItIvE fs 
Closes Homebrew/homebrew#16658.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2013-01-31 21:48:28 -08:00
Mike McQuaid
27700390b4 Improve brew doctor autocrlf message. 
Better version of ed357d.

References Homebrew/homebrew#15711.
References Homebrew/homebrew#17361.
References Homebrew/homebrew#17437.
 2013-01-30 21:29:19 -08:00
Jack Nagel
b6631ac23f doctor: core.autocrlf can be empty 
c.f. Homebrew/homebrew#17361.
 2013-01-30 01:26:28 -06:00
Mike McQuaid
92a5c765a9 Improve brew doctor autocrlf check. 
Closes Homebrew/homebrew#15711.
 2013-01-29 17:14:00 -08:00
Misty De Meo
14bb39b898 Don't print git origin check without git repo 2013-01-29 09:48:43 -06:00
Jack Nagel
1ca5b7a204 doctor: fix typo 2013-01-28 23:02:25 -06:00
Sema
667b53ffb0 doctor: fix transposed git command 
Closes Homebrew/homebrew#17338.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-01-27 13:17:19 -06:00
Jack Nagel
fe802f05ef missing: ignore unused optional and recommended deps 2013-01-26 12:14:48 -06:00
Adam Vandenberg
2c6a7bdca8 Check ownership of logs folder 
Closes Homebrew/homebrew#16607.
 2013-01-23 20:12:55 -08:00
Jack Nagel
6b59e610f0 doctor: loosen git origin regexp 
If the repository is set up by `brew update`, the remote URL is
https://github.com/mxcl/homebrew.git, but if it is set up by the install
script, the .git suffix is omitted.
 2013-01-17 21:46:02 -06:00
Simon Sigurdhsson
8000fb807f Doctor check for origin 
Added checks on doctor.rb for:

* Missing git origin
* git origin not pointing at mxcl/homebrew

Tests use `git config --get remote.origin.url`.
Also added printout of origin to --config.rb.

Fixes Homebrew/homebrew#14399.
Closes Homebrew/homebrew#17117.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2013-01-17 17:18:15 -06:00
Misty De Meo
05772f8ccf doctor: use -V for python version 
`python --version` doesn't work in some (very) old versions of
python. While I doubt this is going to come up very often, it's
theoretically possible someone has an old python first in their
path. (python -V works on all versions I'm aware of, including
python3, and comes before --version in the --help anyway.)

Also skips the warning in case the regexp matches nothing, which
probably shouldn't happen. But if it does we shouldn't produce the
wrong warning.
 2013-01-09 17:09:28 -06:00
Jack Nagel
e3068f631a Prune LinkedKegs relative to correct path 
Fixes Homebrew/homebrew#16948.
 2013-01-08 11:03:13 -06:00
Jack Nagel
d2d4813a07 doctor: add helper for printing file listings 2012-12-22 12:48:53 -06:00
Jack Nagel
4e9128aa6c doctor: f.prefix is already a pathname 2012-12-21 19:33:24 -06:00
Jack Nagel
2b47739822 doctor: print offending paths in check_for_gettext 
c.f. Homebrew/homebrew#16688.
 2012-12-21 18:03:24 -06:00
Jack Nagel
847547167a doctor: rename path_folders to paths 2012-12-21 17:16:57 -06:00
Jack Nagel
1780855023 doctor: use a more rubyish conditional 2012-12-21 17:14:01 -06:00
Jack Nagel
73a206a316 doctor: avoid pointless creation of pathname object 2012-12-21 17:12:00 -06:00
Jack Nagel
a64e9e542f doctor: run slowest checks last 2012-12-21 15:15:42 -06:00
Jack Nagel
3dcce70a6a Better reporting for MacPorts/Fink installations 
closes Homebrew/homebrew#15853.
 2012-12-17 17:18:22 -06:00
Jack Nagel
3589465297 doctor: don't check keg-onlies if cellar doesn't exist 2012-12-08 16:41:31 -06:00
Mike McQuaid
ff356b6192 Whitelist 10.8.2 Supplemental Update static libs. 
Fixes Homebrew/homebrew#16215.
 2012-11-26 09:41:05 +00:00
Jack Nagel
6c4c37a01f bash completion for doctor checks 2012-11-13 16:49:43 -06:00
Jack Nagel
6b6e22ffae Don't advise XQuartz upgrades for system X11 
Yeah, yeah. The XQuartz/X11 stuff is confusing.
 2012-11-12 19:48:09 -06:00
Adam Vandenberg
847baa9e14 doctor checks XQuartz version 
Closes Homebrew/homebrew#14182.
 2012-11-11 12:33:50 -08:00
Jack Nagel
1cb59ea5fd Fix curlrc existence check 
Enumerable#one? is not available under Ruby 1.8.6. Further, we really
want #any? here, as setting both HOME and CURL_HOME can trigger a false
negative.

Fixes Homebrew/homebrew#15883.
 2012-11-06 19:02:02 -06:00
Jack Nagel
f8183d9510 Hoist top-level directory list into a constant 2012-11-06 12:32:09 -06:00
Charlie Sharpsteen
c92971f475 doctor: Remove fuse.pc from the whitelist 
Having a third-party `fuse.pc` file will conflict with the `fuse4x` formula.
 2012-11-03 15:44:51 -07:00
Max Howell
f6091b1c85 Specify where to get the CLT package 2012-10-28 10:52:07 -04:00
Stephen Nelson
e7a9f6eb89 Homebrew should not ignore curlrc 
Added doctor check for .curlrc rather than silently ignoring it (#13836).

Closes Homebrew/homebrew#15419.

Signed-off-by: Max Howell <mxcl@me.com>

Removed test in doctor where it actually curl'd a file. It's enough to warn if the curlrc exists. I understand people want to remove the warnings, but the point in the doctor is to help diagnose and not to be some ramification of your UNIX system.
 2012-10-28 10:52:07 -04:00
Adam Vandenberg
babf25af1a doctor: check that Xcode prefix actually exists 
Closes Homebrew/homebrew#14373.
 2012-10-24 11:16:57 -07:00
Adam Vandenberg
d88158b9fe doctor: fix iconv dylib name 2012-10-03 12:41:20 -07:00
Max Howell
82c58bb615 Fix doctor hanging if xcode-select is bad 
Also fix typo in the superenv DEVELOPER_DIR set detection code.
 2012-09-24 08:49:58 -04:00
Misty De Meo
3473bbc010 Make check for stray developer dir more specific 
It looks like there can be harmless stuff leftover in
/Developer/Library, even after Xcode uninstalls older versions. The
existence of the uninstall-developer-folder script should be a better
indicator.

Fixes Homebrew/homebrew#14970.
 2012-09-16 14:07:38 -05:00