Markus Reiter
d24f3c3b99
Merge pull request #6605 from reitermarkus/missing-command-method
...
Fix missing `command` method.
2019-10-15 18:05:22 +02:00
Markus Reiter
40a0b8b10a
Fix missing command
method.
2019-10-15 17:39:15 +02:00
dependabot-preview[bot]
dfb33d6f3f
build: bump rubocop from 0.75.0 to 0.75.1 in /Library/Homebrew
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.75.0 to 0.75.1.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.75.0...v0.75.1 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-15 10:15:05 +00:00
Mike McQuaid
8a93230c15
test/cask: remove disabled functionality tests.
2019-10-15 09:52:33 +01:00
Mike McQuaid
02ded996a4
formulary_spec: remove deprecated tap-pin usage.
2019-10-15 09:13:11 +01:00
Mike McQuaid
1b4fdc17f4
Raise deprecation exceptions in tests
...
Previously tests which hit `odeprecated` would print warnings but not
always raise exceptions or fail. Combine this with the ability to have
`odeprecated` to turn into `odisabled` on certain dates and you have
tests that may fail just on the clock changing (this is bad).
Instead, ensure that tests always raise deprecations as exceptions so
that new deprecations will have their tests handled immediately.
2019-10-15 08:52:42 +01:00
L. E. Segovia
ed7327296a
Cask: only quarantine working symlinks
...
Fixes Homebrew/homebrew-cask#70796
2019-10-14 15:38:41 +00:00
Markus Reiter
f762033a57
Move condition to nested if
statement.
2019-10-14 11:28:30 +02:00
Markus Reiter
cc234d1948
Fix Dmg
detection.
2019-10-14 10:44:52 +02:00
Issy Long
d0c3885f31
Merge pull request #6592 from issyl0/bump-rubocop-target-ruby-version
...
Bump Rubocop's `TargetRubyVersion` to 2.6 and fix all offenses
2019-10-14 09:39:21 +01:00
Mike McQuaid
cbf458ea9c
Lint/ElseAlignment: ignore some bugged autocorrections.
2019-10-14 09:03:02 +01:00
Mike McQuaid
f1702e5139
Merge pull request #6591 from amyspark/fix-depth-upgrade-check
...
upgrade: reject formulae checked in earlier levels
2019-10-14 08:44:10 +01:00
Issy Long
1f6168fe8a
Change regexp.match?(string) to string.match?(regexp) everywhere
...
- Only try to call `.match?` on strings that aren't nil.
2019-10-13 23:22:51 +01:00
Markus Reiter
67d51ef0e1
Fix Dmg
being detected as Tar
.
2019-10-13 17:19:02 +02:00
Issy Long
18e684fad7
Stringify dev-cmd/audit text
variables when used in Regexp matching
...
- To have the audit commands continue to work, and the tests passing
(the previous error was [1]), everywhere we're trying to
`.match?(text)`, instead do `.match?(text.to_s)`.
[1] 5) Homebrew::FormulaAuditor#audit_file __END__ but no DATA
Failure/Error: fa.audit_file
TypeError:
no implicit conversion of Homebrew::FormulaText into String
# ./dev-cmd/audit.rb:267:in `match?'
# ./dev-cmd/audit.rb:267:in `audit_file'
# ./test/dev-cmd/audit_spec.rb:137:in `block (3 levels) in <module:Homebrew>'
2019-10-13 16:04:38 +01:00
Issy Long
fed1bbe029
Disable Metrics/LineLength for long URL lines in patches_spec.rb
...
- The final two `brew style` offenses were for Metrics/LineLength where
parsing the GitHub diff URL as a regex took 119/118 lines.
- This disables the cop for each of those long, problematic lines, and
re-enables them straight afterwards, else they'd apply to the whole file
from the first occurrence onwards, which we probably don't want?
- I wondered about increasing the LineLength limit to 119 or 120, but
it appears to have been set for a justifiable reason in 80d75bc0d8.
2019-10-13 16:04:37 +01:00
Issy Long
3570cb6e77
Auto-fix Style/NegatedUnless offenses
2019-10-13 16:04:36 +01:00
Issy Long
37fee928b5
Auto-fix Style/NegatedIf offenses
2019-10-13 16:04:35 +01:00
Issy Long
b87782ef7d
Auto-fix Style/UnpackFirst offenses
2019-10-13 16:04:34 +01:00
Issy Long
7193229b42
Auto-fix Layout/CommentIndentation offenses
2019-10-13 16:04:33 +01:00
Issy Long
489ba3f462
Auto-fix Layout/ClosingHeredocIndentation offenses
2019-10-13 16:04:32 +01:00
Issy Long
00adbbe98f
Auto-fix Layout/IndentHeredoc offenses
2019-10-13 16:04:31 +01:00
Issy Long
e5e28fbd69
Auto-fix more Layout/IndentationWidth offenses
...
- These didn't appear in the first pass as the other offense fixes caused them.
2019-10-13 16:04:30 +01:00
Issy Long
69d84ebfd9
Auto-fix Lint/ErbNewArguments offenses
2019-10-13 16:04:29 +01:00
Issy Long
245c61017f
Auto-fix Layout/ElseAlignment offenses
2019-10-13 16:04:28 +01:00
Issy Long
341ea60807
Auto-fix Style/RedundantBegin offenses
...
- This also required auto-fixes for Layout/EmptyLinesAroundBlockBody and
Layout/InconsistentIndentation once the auto-fixer had got rid of the
"redundant begin"s.
2019-10-13 16:04:27 +01:00
Issy Long
b78028b9c2
Auto-fix Performance/RegexpMatch offenses
2019-10-13 16:04:26 +01:00
L. E. Segovia
024007f9e2
upgrade: address @MikeMcQuaid's comments
2019-10-12 22:06:08 +00:00
Mike McQuaid
966e7ab363
Merge pull request #6581 from ytqh/remove-unsupported-option-in-xattr
...
remove /usr/bin/xattr unsupported -s option in macOS 10.15
2019-10-12 16:59:09 +01:00
L. E. Segovia
f4707a8041
upgrade: reject formulae checked in earlier levels
2019-10-12 15:53:21 +00:00
Thomas Plaçais
e616a23a0b
Remove uneeded warning message when searching for a cask that was migrated from a formula
2019-10-11 22:44:52 +01:00
ytqh
24ef7fa5c8
remove xattr unsupported option in macOS 10.15
2019-10-11 21:18:53 +08:00
Mike McQuaid
9e56a8625d
Merge pull request #6531 from jpninanjohn/master
...
Show correct message when invalid arguments are passed to brew
2019-10-11 09:30:12 +01:00
Mike McQuaid
0d068341fc
Merge pull request #6467 from EricFromCanada/uses_from_macos-json
...
Expose `uses_from_macos` list in formula API
2019-10-11 09:28:01 +01:00
Mike McQuaid
0e3ab6e6f2
exceptions: tweak build flags error message.
2019-10-11 09:02:41 +01:00
Jacob Middag
c6cb20a768
Fix frozen string bug
2019-10-11 09:34:43 +02:00
Mike McQuaid
a1a0569f75
Merge pull request #6578 from dawidd6/audit-uses-from-macos
...
audit: replace depends_on with uses_from_macos
2019-10-10 19:20:17 +01:00
Dawid Dziurla
86feb5a9de
audit: replace depends_on with uses_from_macos
2019-10-10 17:59:32 +02:00
Mike McQuaid
209d12b89f
vendor-install: remove ARM bottles until built.
2019-10-10 16:17:06 +01:00
Mike McQuaid
2d51b8189b
test: disable some tests on Linux portable ruby.
2019-10-10 16:17:06 +01:00
Mike McQuaid
e3ee64a5fd
Ruby 2.6.3 brew tests fixes
2019-10-10 16:17:06 +01:00
Mike McQuaid
a36f00ae8b
Ruby 2.6 (and remove backports) gems
2019-10-10 16:17:05 +01:00
Mike McQuaid
e9aba2efb6
Require and provide portable Ruby 2.6.3.
2019-10-10 15:53:16 +01:00
Mike McQuaid
a7bfb80786
Revert "Do not run patchelf on portable-ruby [Linux]"
2019-10-10 15:16:30 +01:00
Mike McQuaid
fb87225479
Merge pull request #6573 from MikeMcQuaid/svn-catalina-fix
...
subversion_spec: fix svnadmin calls on Linux.
2019-10-10 11:19:21 +01:00
Mike McQuaid
69c1b4fcf9
subversion_spec: fix svnadmin calls on Linux.
...
Ensure that we only use `xcrun` on Catalina or newer.
2019-10-10 10:45:22 +01:00
dependabot-preview[bot]
7d3b619b84
build: bump mime-types-data in /Library/Homebrew
...
Bumps [mime-types-data](https://github.com/mime-types/mime-types-data ) from 3.2019.0904 to 3.2019.1009.
- [Release notes](https://github.com/mime-types/mime-types-data/releases )
- [Changelog](https://github.com/mime-types/mime-types-data/blob/master/History.md )
- [Commits](https://github.com/mime-types/mime-types-data/compare/v3.2019.0904...v3.2019.1009 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-10 00:36:30 +00:00
Mike McQuaid
1f924db7f3
Merge pull request #6568 from simono/fix-diagnostic-keepfile
...
Fix diagnostic when only keep_file is in sbin.
2019-10-09 20:24:30 +01:00
Simon Olofsson
d372031fdc
Fix diagnostic when only keep_file is in sbin.
...
Brew creates the keep_file itself and then complains about files in sbin.
2019-10-09 19:33:11 +01:00
Shaun Jackman
1c6046c7e3
Do not run patchelf on portable-ruby [Linux]
...
Running patchelf on portable-ruby causes brew tests to segfault.
See https://github.com/Homebrew/brew/pull/6556
2019-10-09 09:21:04 -07:00