admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
20,800 Commits 15 Branches 471 Tags
Commit Graph

20800 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bo Anderson
ae6c58c7bc ENV/super: always set HOMEBREW_SDKROOT for Xcode builds 2020-04-23 11:10:54 +01:00
Mike McQuaid
36a1c5cdc3
Merge pull request #7424 from EricFromCanada/shell-prompt-fix 
sh: fix custom shell prompt for zsh
 2020-04-23 08:35:05 +01:00
EricFromCanada
78b87b7f23 sh: fix custom shell prompt for zsh 2020-04-23 00:38:36 -04:00
Bo Anderson
ef471e9767
Merge pull request #7423 from EricFromCanada/ruby-canonical_segments 
ruby.sh: allow running on older Ruby versions
 2020-04-22 23:21:00 +01:00
Bo Anderson
a5b1b28ba7
Merge pull request #7421 from bayandin/patch-1 
bintray: fix style
 2020-04-22 23:20:30 +01:00
Alexander Bayandin
28def587f0 bintray: fix style 2020-04-22 22:42:26 +01:00
Eric Knibbe
fa1ce146e4 ruby.sh: allow running on older ruby versions 2020-04-22 17:36:00 -04:00
Bo Anderson
fa18b44699
Merge pull request #7422 from MikeMcQuaid/uninstall_gettext 
workflows/tests: link old gettext.
 2020-04-22 22:13:03 +01:00
Mike McQuaid
f9a84075ac
workflows/tests: link old gettext. 
This is failing `brew doctor` on GitHub Actions.
 2020-04-22 21:36:18 +01:00
Mike McQuaid
8e984d621d
Merge pull request #7419 from Bo98/audit 
dev-cmd/audit: fix false openssl@1.1 versioned formula audit
 2020-04-22 08:21:04 +01:00
Bo Anderson
b619e31457 dev-cmd/audit: fix false openssl@1.1 versioned formula audit 2020-04-22 01:00:35 +01:00
Claudia
d026cb91e7
Fix cask loading after adding an artifact type 
This commit fixes an issue where we added a new global artifact
and then updated a cask to make use of that new artifact.
This caused a number of `brew cask` commands to fail for users
who had the cask installed before the artifact was added.

When loading the definition of an installed cask, we configure it
using a snapshot from install time, e. g. `/usr/local/Caskroom/markdownmdimporter/.metadata/config.json`.

The snapshot looks like this:

```
{
  "default": {
    "appdir": "/Applications",
    "prefpanedir": "/Users/claudia/Library/PreferencePanes",
    "qlplugindir": "/Users/claudia/Library/QuickLook",
    "dictionarydir": "/Users/claudia/Library/Dictionaries",
    "fontdir": "/Users/claudia/Library/Fonts",
    "colorpickerdir": "/Users/claudia/Library/ColorPickers",
    "servicedir": "/Users/claudia/Library/Services",
    "input_methoddir": "/Users/claudia/Library/Input Methods",
    "internet_plugindir": "/Users/claudia/Library/Internet Plug-Ins",
    "audio_unit_plugindir": "/Users/claudia/Library/Audio/Plug-Ins/Components",
    "vst_plugindir": "/Users/claudia/Library/Audio/Plug-Ins/VST",
    "vst3_plugindir": "/Users/claudia/Library/Audio/Plug-Ins/VST3",
    "screen_saverdir": "/Users/claudia/Library/Screen Savers"
  },
  "env": {},
  "explicit": {}
}
```

Note that there is no `mdimporterdir` because the cask was installed
before the artifact was added.

The root cause is that the cask loading code still expects the snapshot
to contain directory configuration for all artifact types.
Since the snapshot never learned about the new artifact type, cask
loading would fail.

The fix applied in this commit is to fall back to the global default
whenever the `default` directory map of a configuration snapshot is
incomplete.

See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
 2020-04-21 18:29:14 +02:00
Claudia
374f788a3c
cask/config_spec: add failing test 
We recently added a new global artifact and then updated a cask to
make use of that new artifact. This caused a number of `brew cask`
commands to fail for users who had the cask installed before the
artifact was added.

This commit adds test cases for that failure mode.

See also:
- https://github.com/Homebrew/brew/pull/7286#issuecomment-613376568
- https://discourse.brew.sh/t/cask-definition-is-invalid-invalid-mdimporter-stanza-key-not-found-mdimporterdir
 2020-04-21 18:26:51 +02:00
Mike McQuaid
20f7f266a8
Merge pull request #7415 from bayandin/fix-pushing-bottles 
bintray: fix package creation
 2020-04-21 14:59:09 +01:00
Alexander Bayandin
bd24f5a45e bintray: fix package creation 2020-04-21 14:36:01 +01:00
Mike McQuaid
b91699d1c0
Merge pull request #7414 from MikeMcQuaid/formula_installer_build_from_source 
formula_installer: fix build_from_source? call.
 2020-04-21 13:48:17 +01:00
Mike McQuaid
2cd14d3709
Merge pull request #7412 from Homebrew/dependabot/bundler/docs/html-proofer-3.15.3 
build(deps-dev): bump html-proofer from 3.15.2 to 3.15.3 in /docs
 2020-04-21 13:41:07 +01:00
Mike McQuaid
b3a7ad7ca6
formula_installer: fix build_from_source? call. 
This should check the local instance variable rather than the global
value as it varies for dependencies and requested formulae.
 2020-04-21 13:26:37 +01:00
dependabot-preview[bot]
91e57838c7
build(deps-dev): bump html-proofer from 3.15.2 to 3.15.3 in /docs 
Bumps [html-proofer](https://github.com/gjtorikian/html-proofer) from 3.15.2 to 3.15.3.
- [Release notes](https://github.com/gjtorikian/html-proofer/releases)
- [Commits](https://github.com/gjtorikian/html-proofer/compare/v3.15.2...v3.15.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
 2020-04-21 12:22:06 +00:00
Mike McQuaid
cc6ccc45cd
Merge pull request #7413 from MikeMcQuaid/actions-linuxbrew 
workflows/tests: allow missing system Linuxbrew.
 2020-04-21 13:20:31 +01:00
Mike McQuaid
b8819e98f0
workflows/tests: allow missing system Linuxbrew. 
If it's not there: setup Linuxbrew but reuse the checkout.
 2020-04-21 13:03:40 +01:00
Shaun Jackman
05e66e9d10
Merge pull request #7410 from sjackman/pr-upload 
pr-upload: Fix a bug introduced by PR #7406
 2020-04-20 15:38:41 -07:00
Shaun Jackman
6b547a5c5e pr-upload: Fix a bug introduced by PR #7406 
Fix the error:
Error: No such file or directory @ rb_sysopen - bottle
 2020-04-20 15:16:08 -07:00
Mike McQuaid
d6e7003ef2
Merge pull request #7407 from sjackman/uses_from_macos 
uses_from_macos: Add gzip rsync to the white list
 2020-04-20 20:13:24 +01:00
Mike McQuaid
6d999f95d2
Merge pull request #7406 from sjackman/pr-upload-root-url 
pr-upload: Add argument root-url
 2020-04-20 20:12:59 +01:00
Mike McQuaid
cc74c4a742
Merge pull request #7409 from MikeMcQuaid/brew-pull-args 
pull: fix head_revision definition.
 2020-04-20 20:12:09 +01:00
Mike McQuaid
9457d1af5e
pull: fix head_revision definition. 
Fixes #7405.
 2020-04-20 19:54:38 +01:00
Shaun Jackman
ffb405019d uses_from_macos: Add gzip rsync to the white list 
/usr/bin/gzip and /usr/bin/rsync are provided by macOS.
 2020-04-20 11:52:58 -07:00
Shaun Jackman
ee21fe1d44 Regenerate docs/Manpage.md and manpages/brew.1 2020-04-20 11:49:37 -07:00
Shaun Jackman
29ae567868 pr-upload: Add argument root-url 
The argument root-url is needed for third-party taps.
 2020-04-20 11:47:57 -07:00
Mike McQuaid
cacc8183ce
Merge pull request #7281 from GauthamGoli/argv-cleanup-19 
ARGV: Deprecate ARGV.force_bottle?
 2020-04-20 19:46:30 +01:00
Mike McQuaid
fb0fa419ab
cask/cmd/upgrade_spec: remove more flaky tests. 2020-04-20 16:45:44 +01:00
Gautham G
676ebf7419
ARGV: Deprecate ARGV.force_bottle? 2020-04-20 16:45:43 +01:00
Mike McQuaid
a5b6c5f262
Merge pull request #7382 from dawidd6/whitelist-bin-config 
diagnostic: whitelist /bin and /sbin for *-config files
 2020-04-20 16:38:56 +01:00
Mike McQuaid
c4fed07d34
Merge pull request #7401 from dawidd6/pr-upload 
Add pr-upload command
 2020-04-20 16:33:06 +01:00
Dawid Dziurla
80e118cba3
diagnostic: whitelist /bin and /sbin for *-config files 2020-04-20 16:18:56 +01:00
Dawid Dziurla
3dd5a7465d
add pr-upload command 2020-04-20 13:37:05 +02:00
Mike McQuaid
f074e3a355
Merge pull request #7399 from MikeMcQuaid/uses_from_macos_updates 
rubocops/uses_from_macos: update list.
 2020-04-20 10:56:15 +01:00
Mike McQuaid
9eed1e4e7e
Merge pull request #7400 from MikeMcQuaid/cleanup_max_age_days 
cleanup: all configuring max age days.
 2020-04-20 10:54:58 +01:00
Mike McQuaid
c6d5bdcb82
Merge pull request #7402 from MikeMcQuaid/cli-args-formula-options 
Remove ARGV_WITHOUT_MONKEY_PATCHING
 2020-04-20 10:54:46 +01:00
Mike McQuaid
cddc67b451
rubocops/uses_from_macos: update list. 
Also, provide details on how to update this in future and split it into
two.

Fixes #7396
 2020-04-20 10:36:42 +01:00
Mike McQuaid
701c1811d5
cleanup: all configuring max age days. 
Fixes #7320
 2020-04-20 10:33:15 +01:00
Mike McQuaid
929d8fccc8
Merge pull request #7403 from MikeMcQuaid/pull-cleanup 
pull: cleanup more code.
 2020-04-20 10:32:11 +01:00
Mike McQuaid
af8091a279
Remove ARGV_WITHOUT_MONKEY_PATCHING 
Our usage of `ARGV` will go away soon enough and maintaining state
between `ARGV` and `ARGV_WITHOUT_MONKEY_PATCHING` is futile.

Fixes #7397
 2020-04-20 10:27:14 +01:00
Mike McQuaid
8b84ef5dc8
pull: cleanup more code. 
Remove more unused code.
 2020-04-20 10:09:22 +01:00
Mike McQuaid
dad4249774
Merge pull request #7393 from EricFromCanada/command-fixes 
cmd/dev-cmd: various output fixes
 2020-04-20 09:53:47 +01:00
Mike McQuaid
75c74e4674
cask/cmd/upgrade_spec: remove flaky test. 2020-04-20 09:25:16 +01:00
Mike McQuaid
66eb11d55c
manpages: update. 2020-04-20 08:27:28 +01:00
EricFromCanada
9d6eb41fc5 cmd/dev-cmd: misc. usage and wording fixes 2020-04-19 13:31:54 -04:00
EricFromCanada
b6809f2dda analytics: rearrange help into subcommand format 2020-04-19 11:50:28 -04:00