5541 Commits

Author SHA1 Message Date
Jack Nagel
63629ab13b Formula#system: simplify xcodebuild special case 2014-02-15 17:47:24 -05:00
Jack Nagel
dca786176e Formula#system: remove unnecessary string casts 2014-02-15 17:47:24 -05:00
Mike McQuaid
4bc82456ee bottle: fail if there is no stable version.
Closes Homebrew/homebrew#26742.
2014-02-15 11:28:48 +00:00
Jack Nagel
457d409f80 GitDownloadStrategy: fix typo'd parameter name
This should be "resource", not "resources", though it works anyway
because there is a also "resource" reader method.
2014-02-15 01:43:06 -05:00
Misty De Meo
e225aea902 ARGV.help?: anchor to end of string
Fixes Homebrew/homebrew#26735.
2014-02-14 16:23:38 -08:00
Jack Nagel
7eec2d8b5a GitDownloadStrategy: allow disabling of shallow clone
Closes Homebrew/homebrew#25751.
Closes Homebrew/homebrew#26730.
2014-02-14 16:55:26 -05:00
Jack Nagel
5ce4c2a3f8 VCSDownloadStrategy: use REF_TYPES when extracting ref to use 2014-02-14 15:33:37 -05:00
Jack Nagel
41e3b2cad0 VCSDownloadStrategy: document acceptable ref types 2014-02-14 15:33:37 -05:00
Jack Nagel
a25152b5a1 GitDownloadStrategy: inline simple method 2014-02-14 15:33:37 -05:00
Jack Nagel
df9a8a3365 GitDownloadStrategy: move constant to top of class body 2014-02-14 15:33:37 -05:00
Mike McQuaid
eabe9dc6d0 brew: check for --help and friends in more of ARGV
Let's check for e.g. --help anywhere in the ARGV array rather than just
the first value to avoid brew upgrade --help causing problems.

Closes Homebrew/homebrew#26675.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-02-14 18:32:56 +00:00
Jack Nagel
a7b515e503 Use a more accurate method name and drop unhelpful block 2014-02-13 23:22:43 -05:00
Jack Nagel
fed468c780 Always print top-level issue URL 2014-02-13 23:22:43 -05:00
Jack Nagel
6dec9f6058 Delete comment that isn't relevant to this code anymore 2014-02-13 17:42:37 -05:00
Jack Nagel
f7ef4964a7 Offload more filtering to the search API 2014-02-13 17:39:53 -05:00
Jack Nagel
f5ceae9f94 Allow passing arbitrary qualifiers to issue search 2014-02-13 17:39:53 -05:00
Jack Nagel
0b2c6e87f1 Implement equality for Dependencies collections 2014-02-13 16:31:12 -05:00
Jack Nagel
257a2206a4 Eliminate unnecessary arrays and call to flatten 2014-02-13 15:39:13 -05:00
Jack Nagel
8d5f0d8bb3 Delete unused method 2014-02-12 14:28:26 -05:00
Jack Nagel
345457b33e Pass the string instead of reconstructing it from a regexp 2014-02-12 13:59:18 -05:00
Jack Nagel
0a3794776e Let the API do more work for us 2014-02-12 12:17:32 -05:00
Jack Nagel
33f344bdd4 Drop TODO that nobody has ever worked on 2014-02-12 12:13:02 -05:00
Jack Nagel
ff209c7b9c Drop unnecessary type check, we never pass a Formula instance 2014-02-12 12:10:44 -05:00
Jack Nagel
f66eeec960 Return only open issues in GitHub.issues_for_formula 2014-02-12 12:10:41 -05:00
Mike McQuaid
efb3868697 osmium: add to blacklist.
References Homebrew/homebrew#12652.
2014-02-12 15:17:53 +00:00
Matt Torok
3320f12f76 brew-graph: improve formatting.
This commit adds additional formatting options to the graph. Most noticeable is a top-to-bottom layout (rather than the previous left-to-right), and nicer fonts on everything.

More subtly, the ranking mechanism has been updated so that the "Safe to Remove" cluster is always at the highest rank (fixing a bug where non-leaf nodes could have been placed next to it,) and added better margins and padding. The rank separation was also decreased for a more compact graph.

Under the hood, the GraphViz output code was updated to support attributes with a list of sub-attributes (for example, 'graph [fontsize="11", fontname="Helvetica"]') and to not put quotes around HTML-like labels in clusters.

Closes Homebrew/homebrew#26651.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-02-12 11:40:40 +00:00
Adam Vandenberg
ae69fa25cc Revert "Recognize --head as an alias for --HEAD"
This reverts commit c32ab0a35a2dfa9b593f759ef0ae8b7af077b0b7.

There are other hard-coded uses of HEAD, in build_options for instance.
These all need to be fixed before enabling this.
2014-02-11 21:25:26 -08:00
Chad Catlett
4d3dbba644 Use HOMEBREW_PREFIX/opt to find installs instead of symlinks in bin, lib, sbin.
Closes Homebrew/homebrew#25868.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-02-11 20:27:05 -08:00
Jack Nagel
18f3b9f6d1 ls-taps: search names only 2014-02-11 17:27:12 -05:00
Bo Jeanes
63e56fd4df brew-services: don't hardcode launchctl path
This change allows users to install the `launchctl` wrapper in the
`reattach-to-user-namespace` formula which makes the command work in
Tmux and other non-standard environments.

Closes Homebrew/homebrew#26609.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2014-02-11 19:40:56 +00:00
Mike McQuaid
f42f4e45c1 python_dependency: only set PYTHONPATH for system. 2014-02-10 18:49:26 +00:00
Jack Nagel
b754ad0d0b Update vendored OkJson 2014-02-10 13:17:16 -05:00
Jack Nagel
1eddc73472 Fix ls-taps for v3 API
This doesn't handle paginated results, but it fetches the 100 most
starred results so that's probably good enough for now.

Fixes Homebrew/homebrew#26566.
2014-02-10 11:27:54 -05:00
Misty De Meo
b1c0380b7b Recognize --head as an alias for --HEAD
Homebrew currently recognizes "--head" during the install process, but
rather than actually fetch HEAD it just nags the user to use the
correct option.	Since we recognize the spelling anyway, this just
promotes the lowercase version to an official alias.

Closes Homebrew/homebrew#26555.
2014-02-09 15:44:49 -08:00
Welton Rodrigo
3805df0b44 Include buildpath info into example formula
The example formula had no information about how
to find the current bulding directory. Now it has ;)

Closes Homebrew/homebrew#26554.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
2014-02-09 12:38:02 -08:00
Jack Nagel
15db61f25a X11Dependency: style 2014-02-09 14:23:56 -05:00
Jack Nagel
f16003f58c X11Dependency: return nil instead of raising in #<=>
Returning nil is in the contract of the Comparable module, and a future
version of Ruby will no longer hide this error.
2014-02-09 14:23:56 -05:00
Mike McQuaid
e93792fdef bottle: fix --write messages. 2014-02-09 14:34:50 +00:00
Mike McQuaid
89e07d44f6 bottle: make --write handle both quotes styles. 2014-02-09 14:34:50 +00:00
Jack Nagel
25c4e336f4 Use GitHub wrapper for private tap check 2014-02-08 20:41:11 -05:00
Jack Nagel
3b818a19f9 Pin GitHub module to v3 API 2014-02-08 20:41:11 -05:00
Jack Nagel
e57894e0d8 Switch to v3 search API 2014-02-08 20:41:11 -05:00
Jack Nagel
d01c671d74 Drop unnecessary map + compact in search_tap 2014-02-08 17:53:08 -05:00
Jack Nagel
0b0d171566 Don't let issue search kill install process 2014-02-08 16:04:53 -05:00
Jack Nagel
7d4709d9d6 Prevent repeated warnings when GitHub API rate limit is exceeded 2014-02-08 16:04:53 -05:00
Jack Nagel
ee893fdd88 Preserve original backtrace when raising GitHub::Error 2014-02-08 16:04:53 -05:00
Jack Nagel
2e3871c076 Raise only GitHub::Error from GitHub.open 2014-02-08 16:04:53 -05:00
Jack Nagel
4d6df3e3bc Parse JSON early in GitHub module 2014-02-08 16:04:53 -05:00
Jack Nagel
f7e1244e6d Don't mutate argument in search_tap 2014-02-08 16:04:52 -05:00
Adam Vandenberg
dae221bdb8 Move colormake to headonly
Closes Homebrew/homebrew#25226.
2014-02-06 22:57:01 -08:00