admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
5,541 Commits 15 Branches 471 Tags
Commit Graph

4470 Commits

Author SHA1 Message Date
Jack Nagel
19ca1bb601 Access bottle directly in FormulaInstaller 2014-02-21 00:41:07 -05:00
Josh Tilles
2225ebc44e Adapt to Git 1.9's submodule foreach changes 
Closes Homebrew/homebrew#26871.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-02-21 00:05:42 -05:00
Jack Nagel
ccb216c9c7 Delegate downloader to active_spec instead of storing it in an ivar 2014-02-20 13:45:13 -05:00
Jack Nagel
3aa06a701d Consistently pass path into Formula constructor 2014-02-20 13:31:37 -05:00
Jack Nagel
abbed076f0 Pass path into the Formula constructor 
When the path argument to the Formula constructor is omitted, the
instance's path attribute is created using the Formula.path class
method. However, we have already done this work, so we can just pass it
into the constructor.

This translates to one less call to Pathname#to_s per formula, or about
2600 calls when running `brew readall`.
 2014-02-19 16:53:18 -05:00
Jack Nagel
1f39d6c2d1 Eliminate some Pathname -> String -> Pathname conversions 2014-02-19 16:53:18 -05:00
Jack Nagel
7591b79d7d Push expand_path call down into FromPathLoader 2014-02-19 16:53:18 -05:00
cadrpear
f43bb0c292 Fix building universal binaries on 32-bit CPUs 
[jn: style, update comment]

Closes Homebrew/homebrew#25728.
Fixes Homebrew/homebrew#26834.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-02-19 14:15:03 -05:00
Jack Nagel
a1d2aa0f69 Stop exporting HOMEBREW_VERBOSE to build environment 
This flag no longer affects the output of the compiler wrappers, since
everything is buffered by the build process rather than each individual
tool.

Additionally, this is a user-facing knob that affects ARGV.verbose?, and
the combination of these two issues broke the --quieter feature.
 2014-02-18 21:46:26 -05:00
Jack Nagel
8d4d56c8db Use standard curl progress output in verbose mode 
Closes Homebrew/homebrew#26818.
 2014-02-18 16:03:52 -05:00
Jack Nagel
9b8cff1484 Tweak DownloadError message to include wrapped exception 2014-02-18 15:08:03 -05:00
Jack Nagel
c9784c1857 Collapse begin..end into def..end and use else clause 2014-02-18 15:08:03 -05:00
Drew Rodman
d63ef14794 Add DownloadError to catch a broader range of resource download errors. 
Adding a broader exception class allows for errors raised in Resource.fetch
to be caught in upgrade and prevent the process from being killed when
a download fails. This should resolve issue 18364.

Fixes Homebrew/homebrew#18364.
Closes Homebrew/homebrew#26618.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
 2014-02-18 15:08:03 -05:00
Jack Nagel
ca0eff67fa Inline static exception text to remove a rescue 2014-02-18 13:27:35 -05:00
Jack Nagel
7bdaa7ffe1 search: use a queue to collect errors 
The threading in the tap search code makes handling errors difficult. If
an API-related error is raised in one thread, it is likely to be raised
in each of the rest as well. This results in duplicated error messages,
which is ugly and bad UX.

This patch adds a synchronized queue to collect these exceptions. The
first one added to the queue is re-raised after all operations are
complete.

It's not ideal, but it's minimally invasive and I don't have the energy
or time to do a rewrite.
 2014-02-16 23:19:09 -05:00
Jack Nagel
ea7415237c Add helpful error message for authentication failures 2014-02-16 23:19:09 -05:00
Jack Nagel
3cbb49930c Move error text and helper into error class 2014-02-16 23:19:09 -05:00
Jack Nagel
24cbb4fd2e Add a more useful message when ratelimit is exceeded 2014-02-16 23:11:17 -05:00
Jack Nagel
f7cda3cdb6 Make GitHub::Error a RuntimeError to suppress backtrace 2014-02-16 22:24:33 -05:00
Jack Nagel
6fd0125ad9 Handle GitHub API authentication failures 2014-02-16 22:24:33 -05:00
Jack Nagel
1d5ab3195c Extract error handling from GitHub.open 2014-02-16 22:24:33 -05:00
Mike McQuaid
34930586c3 audit: handle recommended/optional options better. 2014-02-16 22:35:14 +00:00
Mike McQuaid
8157515b2a audit: whitelist pyobject3 use of ARGV. 2014-02-16 22:10:22 +00:00
Mike McQuaid
1fecd418e4 versions: ignore validation errors. 
References Homebrew/homebrew#26748.
 2014-02-16 18:35:33 +00:00
Jack Nagel
63629ab13b Formula#system: simplify xcodebuild special case 2014-02-15 17:47:24 -05:00
Jack Nagel
dca786176e Formula#system: remove unnecessary string casts 2014-02-15 17:47:24 -05:00
Mike McQuaid
4bc82456ee bottle: fail if there is no stable version. 
Closes Homebrew/homebrew#26742.
 2014-02-15 11:28:48 +00:00
Jack Nagel
457d409f80 GitDownloadStrategy: fix typo'd parameter name 
This should be "resource", not "resources", though it works anyway
because there is a also "resource" reader method.
 2014-02-15 01:43:06 -05:00
Misty De Meo
e225aea902 ARGV.help?: anchor to end of string 
Fixes Homebrew/homebrew#26735.
 2014-02-14 16:23:38 -08:00
Jack Nagel
7eec2d8b5a GitDownloadStrategy: allow disabling of shallow clone 
Closes Homebrew/homebrew#25751.
Closes Homebrew/homebrew#26730.
 2014-02-14 16:55:26 -05:00
Jack Nagel
5ce4c2a3f8 VCSDownloadStrategy: use REF_TYPES when extracting ref to use 2014-02-14 15:33:37 -05:00
Jack Nagel
41e3b2cad0 VCSDownloadStrategy: document acceptable ref types 2014-02-14 15:33:37 -05:00
Jack Nagel
a25152b5a1 GitDownloadStrategy: inline simple method 2014-02-14 15:33:37 -05:00
Jack Nagel
df9a8a3365 GitDownloadStrategy: move constant to top of class body 2014-02-14 15:33:37 -05:00
Mike McQuaid
eabe9dc6d0 brew: check for --help and friends in more of ARGV 
Let's check for e.g. --help anywhere in the ARGV array rather than just
the first value to avoid brew upgrade --help causing problems.

Closes Homebrew/homebrew#26675.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2014-02-14 18:32:56 +00:00
Jack Nagel
a7b515e503 Use a more accurate method name and drop unhelpful block 2014-02-13 23:22:43 -05:00
Jack Nagel
fed468c780 Always print top-level issue URL 2014-02-13 23:22:43 -05:00
Jack Nagel
6dec9f6058 Delete comment that isn't relevant to this code anymore 2014-02-13 17:42:37 -05:00
Jack Nagel
f7ef4964a7 Offload more filtering to the search API 2014-02-13 17:39:53 -05:00
Jack Nagel
f5ceae9f94 Allow passing arbitrary qualifiers to issue search 2014-02-13 17:39:53 -05:00
Jack Nagel
0b2c6e87f1 Implement equality for Dependencies collections 2014-02-13 16:31:12 -05:00
Jack Nagel
257a2206a4 Eliminate unnecessary arrays and call to flatten 2014-02-13 15:39:13 -05:00
Jack Nagel
8d5f0d8bb3 Delete unused method 2014-02-12 14:28:26 -05:00
Jack Nagel
345457b33e Pass the string instead of reconstructing it from a regexp 2014-02-12 13:59:18 -05:00
Jack Nagel
0a3794776e Let the API do more work for us 2014-02-12 12:17:32 -05:00
Jack Nagel
33f344bdd4 Drop TODO that nobody has ever worked on 2014-02-12 12:13:02 -05:00
Jack Nagel
ff209c7b9c Drop unnecessary type check, we never pass a Formula instance 2014-02-12 12:10:44 -05:00
Jack Nagel
f66eeec960 Return only open issues in GitHub.issues_for_formula 2014-02-12 12:10:41 -05:00
Mike McQuaid
efb3868697 osmium: add to blacklist. 
References Homebrew/homebrew#12652.
 2014-02-12 15:17:53 +00:00
Adam Vandenberg
ae69fa25cc Revert "Recognize --head as an alias for --HEAD" 
This reverts commit c32ab0a35a2dfa9b593f759ef0ae8b7af077b0b7.

There are other hard-coded uses of HEAD, in build_options for instance.
These all need to be fixed before enabling this.
 2014-02-11 21:25:26 -08:00