When upgrading, if the only package to upgrade is a
pinned package, the output looked like that:
==> Upgrading 0 packages, with result:
==> Not upgrading 1 pinned package:
<<package_name & version>>
The blank line is not beautiful. This commit fixes
the output and replaces with:
==> No packages to upgrade
==> Not upgrading 1 pinned package:
<<package_name & version>>
ClosesHomebrew/homebrew#26157.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Solely because I think `ENV.deparallelize` is *way* clearer than
`ENV.j1`, at least to the uninitiated.
Also, updating the template will reduce the number of `ENV.j1`s that
persist because the Homebrew maintainers want clean histories of
formulae. Ideally, this change should prevent any more cases from being
introduced!
ClosesHomebrew/homebrew#25431.
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
This brings a (small) performance improvement as we yield the files as
they are output by fgrep rather than waiting until fgrep is done to do
any work.
`brew doctor` always complains about uncommitted modifications to
Homebrew when you have status.branch=true in your git config, because
the implicit --branch makes `git status -s` always print branch/tracking
info. The --porcelain mode is similar to -s/--short, but ignores most of
the user's config and should remain stable.
The --untracked-files option ensures we'll see untracked files even for
users with status.showUntrackedFiles=no, which is not suppressed by
--porcelain for some reason.
ClosesHomebrew/homebrew#25230.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
Since a bad xcode-select path can cause many brew commands to freeze,
it's worth warning users and bailing out as early as possible.
The doctor check wasn't good enough, since the doctor could freeze
before the warning about this was ever printed.
