Formula::DATA only worked by accident of implementation; DATA during the
build is actually Object::DATA, so we should mirror that here.
This reverts commit b12444ba6e1ac1d596a70ff4c777d9386d0791ac.
Instances of `IOPatch` created by `patch :DATA` are not affected by re-setting
the `DATA` constant of the `Formula` instance. For these patches, we iterate
through the `patchlist` and use `instance_variable_set` to attach data.
A bit hacky, but `patchlist` has no write accessors so there isn't a clean way
to modify patch contents.
This requires hitting the network, which makes the first invocation
slow. The results are inaccurate as it only pulls down the first page of
results. It is also prone to false-positives.
A better implementation is welcome, but in the years since I wrote this
code I can't think of a single time where I found it useful.
This will allow the reading and checking of formulae that mirror
Homebrew core formulae (e.g. `git` in a tap) and, with the previous exit
code changes, is a reasonable check for "are all the formulae in taps
updated to the latest core DSL".
ClosesHomebrew/homebrew#28328.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
If we want to generate usable patches from inside the unpacked source,
then we should start from the same directory that a normal install
would start from.
This commit adds additional formatting options to the graph. Most noticeable is a top-to-bottom layout (rather than the previous left-to-right), and nicer fonts on everything.
More subtly, the ranking mechanism has been updated so that the "Safe to Remove" cluster is always at the highest rank (fixing a bug where non-leaf nodes could have been placed next to it,) and added better margins and padding. The rank separation was also decreased for a more compact graph.
Under the hood, the GraphViz output code was updated to support attributes with a list of sub-attributes (for example, 'graph [fontsize="11", fontname="Helvetica"]') and to not put quotes around HTML-like labels in clusters.
ClosesHomebrew/homebrew#26651.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This change allows users to install the `launchctl` wrapper in the
`reattach-to-user-namespace` formula which makes the command work in
Tmux and other non-standard environments.
ClosesHomebrew/homebrew#26609.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
This doesn't handle paginated results, but it fetches the 100 most
starred results so that's probably good enough for now.
FixesHomebrew/homebrew#26566.
With this brew-test-bot doesn't skip builds, if a requirement isn't
satisfied but a default_formula is specified.
This default_formula is already in dependencies, because of brew deps.
ClosesHomebrew/homebrew#25398.
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
