19698 Commits

Author SHA1 Message Date
Mike McQuaid
045610ef8d
Merge pull request #7846 from samford/add-version-blank-empty
version: add empty? method
2020-06-29 08:42:36 +01:00
Mike McQuaid
61b4e7c414
Merge pull request #7745 from dtrodrigues/bump-pr-dupes
bump-formula-pr: search for closed dupe PRs
2020-06-29 08:39:30 +01:00
Jonathan Chang
bada8dd759 pr-pull: add review approval trailers on signoff 2020-06-29 12:53:03 +10:00
Jonathan Chang
90309e5f42 github: fetch approved reviews for a pull request 2020-06-29 12:53:03 +10:00
EricFromCanada
68947f2af9 cmd/options: add flag to list a command's options 2020-06-28 12:42:23 -04:00
Sam Ford
15bc09d916
version: add empty? method 2020-06-27 21:03:16 -04:00
Michka Popoff
b4cd99c67c
Merge pull request #7833 from iMichka/resource-empty
software_spec: do not add empty resources
2020-06-27 22:20:55 +02:00
Lionell
5f6917ae7c Merge branch 'master' into license 2020-06-28 02:07:53 +08:00
lionellloh
4d4f6a8fac audit: remove unnecessary nil assignment 2020-06-28 02:07:32 +08:00
Lionell Loh Jian An
759708fae7
Apply suggestions from code review
Code Review Changes

Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-06-28 01:54:41 +08:00
Michka Popoff
36b62c50e0 software_spec: do not add empty resources
Empty resources are allowed to exist under the following form:

resource "filelock" do
  on_linux do
      url "6ee2168387/filelock-3.0.12.tar.gz"
      sha256 "18d82244ee114f543149c66a6e0c14e9c4f8a1044b5cdaadd0f82159d6a6ff59"
  end
end

In this case (or for the on_macos only resource case), just ignore the resource block.

Fixes:
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:148:in `resource_dep'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:99:in `parse_spec'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:53:in `build'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:40:in `block in fetch'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:40:in `fetch'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:40:in `fetch'
/usr/local/Homebrew/Library/Homebrew/dependency_collector.rb:30:in `add'
/usr/local/Homebrew/Library/Homebrew/software_spec.rb:120:in `resource'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2439:in `block in resource'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2438:in `each'
/usr/local/Homebrew/Library/Homebrew/formula.rb:2438:in `resource'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/aws-google-auth.rb:149:in `<class:AwsGoogleAuth>'
/usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/aws-google-auth.rb:1:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:38:in `rescue in load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:35:in `load_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:56:in `load_formula_from_path'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:138:in `load_file'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:128:in `klass'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:124:in `get_formula'
/usr/local/Homebrew/Library/Homebrew/formulary.rb:333:in `factory'
/usr/local/Homebrew/Library/Homebrew/cli/args.rb:87:in `block in formulae'
/usr/local/Homebrew/Library/Homebrew/cli/args.rb:86:in `map'
/usr/local/Homebrew/Library/Homebrew/cli/args.rb:86:in `formulae'
/usr/local/Homebrew/Library/Homebrew/cmd/install.rb:133:in `install'
/usr/local/Homebrew/Library/Homebrew/brew.rb:111:in `<main>'
2020-06-27 19:25:10 +02:00
Dustin Rodrigues
f684a59fa5 bump-formula-pr: search for closed dupe PRs 2020-06-27 12:50:43 -04:00
Mike McQuaid
ba62b988e1
Merge pull request #7840 from Rylan12/remove-iso-8601-hyphen
Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb
2020-06-27 13:15:55 +01:00
Mike McQuaid
1dac6272f7
Merge pull request #7832 from iMichka/backtrace
install: add backtrace on failure
2020-06-27 13:12:12 +01:00
Mike McQuaid
58de51f2ce
Merge pull request #7837 from FTLam11/7392-migrate-audit-rules-to-rubocop
audit: Move patch checks from brew audit to rubocop
2020-06-27 13:11:51 +01:00
Mike McQuaid
21069e3797
Merge pull request #7696 from Rylan12/audit-shell-variables
style: set shell variables in hash
2020-06-27 13:10:35 +01:00
Michka Popoff
6eb80c67a4 install: add backtrace on failure
The error message might be useless alone
2020-06-27 09:59:56 +02:00
Rylan Polster
9c44e39a39 Remove hyphen in ISO 8601 in rubocops/deprecate_spec.rb 2020-06-26 21:32:18 -04:00
Rylan Polster
e82084583a style: set shell variables in hash
When running Utils.popen (or similar popen command), having a line like
"SHELL=bash ..." doesn't work properly. Instead, use:
`Utils.popen({ "SHELL" => "bash" }, "...")`
2020-06-26 16:39:39 -04:00
Rylan Polster
1df0a62532
Merge pull request #7835 from Rylan12/rubocop-deprecation-date
style: enforce ISO 8601 in deprecation date
2020-06-26 16:19:37 -04:00
Frank Lam
ffb1cc8e19
Find patch nodes nested inside blocks 2020-06-27 03:13:50 +08:00
Frank Lam
b2eafdf11d
Remove patch checks from audit 2020-06-27 02:37:57 +08:00
Frank Lam
afb8445380
Add inline patch checks to patches cop 2020-06-27 01:10:52 +08:00
Rylan Polster
9520eabc35 style: enforce ISO-8601 in deprecation date 2020-06-26 11:53:42 -04:00
Mike McQuaid
ac27a98d07
Merge pull request #7836 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-0.1.0
build(deps): bump rubocop-ast from 0.0.3 to 0.1.0 in /Library/Homebrew
2020-06-26 14:59:39 +01:00
William Ma
1044cb91c3 Merge branch 'master' into integrate-uninstall-reinstall 2020-06-26 09:18:19 -04:00
dependabot-preview[bot]
33a86ba247
build(deps): bump rubocop-ast from 0.0.3 to 0.1.0 in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop-hq/rubocop-ast) from 0.0.3 to 0.1.0.
- [Release notes](https://github.com/rubocop-hq/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop-hq/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop-hq/rubocop-ast/compare/v0.0.3...v0.1.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-06-26 05:20:09 +00:00
rmnull
35328ed535
[draft] refactoring keg_relocate to use ELFShim#interpreter instead of .with_interpreter? 2020-06-26 05:34:41 +05:30
Eric Knibbe
db998860f1
Merge pull request #7831 from EricFromCanada/fix-help-output
docs: fixes for help output
2020-06-25 13:08:48 -04:00
Dawid Dziurla
942722ad64
Merge pull request #7830 from vladimyr/crystal
create: add --crystal option
2020-06-25 18:50:26 +02:00
Dario Vladovic
519c339261
create: add --crystal option 2020-06-25 18:23:06 +02:00
Rylan Polster
59f622d4ba
Merge pull request #7823 from Rylan12/rubocop-dstr-string-content
RuboCop string_content keep string interpolation
2020-06-25 12:19:27 -04:00
EricFromCanada
910c85f782 docs: improve commands' help output 2020-06-25 12:01:52 -04:00
EricFromCanada
e62137133e docs: fix comment help output 2020-06-25 11:59:42 -04:00
Frank Lam
644ae115f5
Prepare inline patch specs 2020-06-25 22:29:34 +08:00
Lionell
ff7a80ebf5 Merge branch 'master' into license 2020-06-25 21:51:39 +08:00
William Ma
f03336bb40 uninstall: Clean up cask-appdir after tests 2020-06-25 09:13:02 -04:00
lionellloh
6a05e3663a Remove Homebrew.failed=true 2020-06-25 21:06:29 +08:00
Rylan Polster
cb187f6846 RuboCop string_content keep string interpolation 2020-06-25 09:05:43 -04:00
lionellloh
2cf0ac9ed5 update-spdx-data: use a more specific file path 2020-06-25 20:34:06 +08:00
lionellloh
77a8ff51da single quotes -> double quotes 2020-06-25 19:20:26 +08:00
lionellloh
1b9cbf1bf1 changed method of fetching license data 2020-06-25 19:05:41 +08:00
Mike McQuaid
ac0665daff
Refer to default branch in links with HEAD
Anywhere we can use `blob/master` we can use `blob/HEAD` instead. This
will make life easier if we ever rename our default branch in future
(once/if Git and GitHub provides the necessary tooling to do so).
2020-06-25 11:38:40 +01:00
Lionell
5aa0eb487e rename spec file 2020-06-25 17:51:47 +08:00
Lionell
eb38890f3c change back to open because File.open does not work on URLs 2020-06-25 17:46:28 +08:00
Lionell Loh Jian An
22baff39bc
Apply suggestions from code review
Applying style-related suggestions from code review

Co-authored-by: Dario Vladović <d.vladimyr@gmail.com>
2020-06-25 15:36:55 +08:00
Lionell
57fd1fdc7e Merge branch 'master' into license 2020-06-25 13:42:27 +08:00
Issy Long
1f770270b4
Merge pull request #7820 from vidusheeamoli/add-new-files
Sorbet: update hidden definitions
2020-06-24 23:10:04 +01:00
lionellloh
0304545d0c use File.open instead of Kernel.open 2020-06-25 05:46:33 +08:00
lionellloh
fbd5c32d22 bunch of style fixes 2020-06-25 05:46:18 +08:00