1409 Commits

Author SHA1 Message Date
Eric Knibbe
e63b1f4da5
docs: monospace suggested values 2024-02-04 15:42:26 +01:00
Eric Knibbe
7698cf2098
audit: messaging improvements 2024-02-04 15:10:14 +01:00
Douglas Eichelberger
eb7c3e52a0 Require SystemInclude only where needed 2024-01-31 11:42:01 -08:00
Mike McQuaid
3707c90ce1
Merge pull request #16439 from arianf/fix-non-ghcr
Fixes `openjdk_dep_name_if_applicable` when not using `CurlGitHubPackagesDownloadStrategy`
2024-01-31 11:43:28 +00:00
Douglas Eichelberger
3a27cac7df
Merge pull request #16510 from dduugg/inverse-include-exclude-cop
Vendor remaining Rails cops, remove ActiveSupport
2024-01-30 11:59:10 -08:00
Mike McQuaid
176095a826
utils/bottles: tweak syntax. 2024-01-30 17:15:13 +00:00
Douglas Eichelberger
e00d066d87 Replace Time refinement with Timer Util 2024-01-29 18:50:12 -08:00
Arian Faurtosh
9088cf9be0 Fixes openjdk_dep_name_if_applicable when not using CurlGitHubPackagesDownloadStrategy
When installing a formula, `FormulaInstaller` calls `#pour`, which in turn calls:

6f20c0300a/Library/Homebrew/formula_installer.rb (L1260)

This `tab` is expected to have `#runtime_dependencies`, and it typically will because most packages come from http://ghcr.io

6f20c0300a/Library/Homebrew/utils/bottles.rb (L111)

Any `DownloadStrategy` that does not match `CurlGitHubPackagesDownloadStrategy` will lead here:
6f20c0300a/Library/Homebrew/software_spec.rb (L463)

Causing this branch to be executed for creating the `tab`:
6f20c0300a/Library/Homebrew/utils/bottles.rb (L119)

This causes a slight issue because `openjdk_dep_name_if_applicable` calls `keg.runtime_dependencies` when it's still `nil`.

6f20c0300a/Library/Homebrew/keg_relocate.rb (L134-L140)

And if it's blank, it won't do the regex replacement on `@@HOMEBREW_JAVA@@`, resulting in the following error when running `Kafka`:

```console
$ tail -f /opt/homebrew/var/log/kafka/kafka_output.log
/opt/homebrew/Cellar/kafka/3.6.0/libexec/bin/kafka-run-class.sh: line 346: /opt/homebrew/@@HOMEBREW_JAVA@@/bin/java: No such file or directory
/opt/homebrew/Cellar/kafka/3.6.0/libexec/bin/kafka-run-class.sh: line 346: exec: /opt/homebrew/@@HOMEBREW_JAVA@@/bin/java: cannot execute: No such file or directory
```

As mentioned by: https://github.com/orgs/Homebrew/discussions/2530#discussioncomment-2002374

> Installing Java-dependent formulae from bottle mirrors doesn't work properly at the moment. The issue is that brew needs the manifest in order to correctly replace @@HOMEBREW_JAVA@@ but brew only knows how to fetch manifests from ghcr.io.
> Pull requests to fix this welcome.

This should fix this issue, by getting the `runtime_dependencies` directly from the formula for those cases that it can't get it from https://ghcr.io or tabfile

```ruby
f_runtime_deps = formula.runtime_dependencies(read_from_tab: false)
tab.runtime_dependencies = Tab.runtime_deps_hash(formula, f_runtime_deps)
```
2024-01-29 15:57:55 -08:00
Douglas Eichelberger
2e90749f9f brew vendor-gems: commit updates. 2024-01-26 15:03:59 -08:00
Mike McQuaid
86e1c8aacf
Merge pull request #16463 from dduugg/no-active-support
Remove ActiveSupport from runtime
2024-01-22 19:22:12 +00:00
Douglas Eichelberger
7ae087b24c Update Library/Homebrew/utils/gems.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-01-19 13:36:16 -08:00
Douglas Eichelberger
08e12b2383 Remove ActiveSupport Array access core extensions 2024-01-19 13:34:52 -08:00
Douglas Eichelberger
64d6d6aded Remove canonical_segments check 2024-01-19 12:41:15 -08:00
Issy Long
f682147598
Fix RuboCop Style/RedundantFreeze offenses 2024-01-18 22:20:01 +00:00
Sean Molenaar
119e3d55ec chore: add audit to check if an EOL is known 2024-01-17 11:12:32 +01:00
Mike McQuaid
7e6f5c23a2
Merge pull request #16442 from branchvincent/setuptools
pypi: stop excluding setuptools
2024-01-09 09:00:05 +00:00
Mike McQuaid
8486ff88f1
utils/pypi: readability tweak. 2024-01-09 08:50:08 +00:00
Branch Vincent
ecc60a13e0
pypi: stop excluding setuptools 2024-01-08 19:17:45 -08:00
Douglas Eichelberger
0852e1d7b6 Refactor away String#indent 2024-01-08 13:36:45 -08:00
Douglas Eichelberger
b3522b3bb8 Remove ActiveSupport String filters 2024-01-02 16:56:27 -08:00
Michael Cho
10659a1d61
update-python-resources: show pip install failure when --verbose
Also use `--disable-pip-version-check` to remove pip update notices
2023-12-30 12:16:09 -05:00
Michael Cho
04d8ae20f3
Merge pull request #16367 from cho-m/pypi-use-formula-py
utils/pypi: use python from formula
2023-12-30 10:57:49 -05:00
Douglas Eichelberger
caf8259ae6 Code review changes 2023-12-27 15:29:33 -08:00
Douglas Eichelberger
3abbf4447e Some minor regexp match perf improvements 2023-12-27 13:16:36 -08:00
Michael Cho
326774faee
utils/pypi: use python from formula
Sometimes the Python dependency tree will be impacted by the exact
version of Python being used (most commonly relating to functionality
provided/missing from stdlibs like `importlib-metadata` and `tomllib`)
2023-12-19 20:09:09 -05:00
Issy Long
149b0e4f31
Fix new Style/MutableConstant RuboCop offenses for Ruby 3.1
- A follow-up to de592af20bbff5bcb548d2474f0722e59ff1129a, resetting the previous disabled comments too.
2023-12-16 11:57:06 +00:00
Bo Anderson
89531e9ff3
Update all dependencies 2023-12-15 16:24:46 +00:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop 2023-12-14 05:47:12 +00:00
Douglas Eichelberger
4c96eaf56f
Update gems.rb 2023-12-12 13:39:29 -08:00
Bo Anderson
688d87e839
Remove Ruby 2.6 & macOS system Ruby support code 2023-12-12 03:44:31 +00:00
Bo Anderson
df979295a9
Merge pull request #16294 from Bo98/ruby-3.1-minimum
Require Ruby 3.1
2023-12-11 15:42:29 +00:00
Bo Anderson
03b6a83135
utils/service: assume no service system during generic OS tests 2023-12-07 20:58:01 +00:00
Bo Anderson
987ebe3d6d
Require Ruby 3.1 2023-12-05 02:31:08 +00:00
Bo Anderson
d68e3e563e
Merge pull request #16268 from Bo98/ruby3-for-all
Enable Ruby 3 for all users
2023-11-30 14:27:59 +00:00
Mike McQuaid
14a59d3884
Merge pull request #16257 from Bo98/analytics-version-fix
utils/analytics: don't fail on invalid version
2023-11-30 11:54:18 +00:00
Mike McQuaid
3e39e73287
Merge pull request #16265 from dertuxmalwieder/patch-1
Support the rc shell. Fixes #16264
2023-11-30 11:34:58 +00:00
Cthulhux
1c4c3194e6
got rid of rc_quote
The only "special" case about `rc` quoting is that strings that contain apostrophes need to contain double apostrophes instead. It seems unlikely that this will happen in Homebrew.
2023-11-29 21:40:51 +01:00
Douglas Eichelberger
1bc4e72ab9
Bump VENDOR_VERSION in gems.rb
Per the code comment, it seems I should bump this after ignoring a pair of committed vendored gems in https://github.com/Homebrew/brew/pull/16259 :

https://github.com/Homebrew/brew/pull/16259/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R102
https://github.com/Homebrew/brew/pull/16259/files#diff-bc37d034bad564583790a46f19d807abfe519c5671395fd494d8cce506c42947R109
2023-11-29 10:00:51 -08:00
Bo Anderson
1f483bfe71
utils/analytics: don't fail on invalid version 2023-11-29 15:56:05 +00:00
Bo Anderson
489879ff72
Enable Ruby 3 for all users 2023-11-29 15:30:17 +00:00
Cthulhux
d26a408870
Support the rc shell. Fixes #16264
(In my tests, changes to `shellenv.sh` weren't required, so I didn't bother.)
2023-11-29 02:22:49 +01:00
Mike McQuaid
e93b0fc430
Merge pull request #16224 from Rylan12/remove-os-mac-on-linux
Deprecate `OS::Mac` on Linux
2023-11-23 12:40:22 +00:00
Bo Anderson
7a9f3eb800
utils/ruby.sh: don't _require_ 3.1 in HOMEBREW_RUBY3 mode 2023-11-21 15:03:22 +00:00
Bo Anderson
559336c771
Enable Ruby 3 for HOMEBREW_DEVELOPER 2023-11-20 20:04:18 +00:00
Rylan Polster
529f7b7953
Remove El Capitan system curl workaround 2023-11-16 11:47:48 -05:00
Rylan Polster
8704e79cc0
Separate MacOS references 2023-11-15 18:19:39 -05:00
Ruoyu Zhong
ac7a1bf775
utils/curl: fix Digest::SHA256 typo
Should fix the error seen in Homebrew/homebrew-core#153647 [^1]. This
was introduced in e5d656bcce8 and `Digest::256` seems to be the intended
one.

[^1]: https://github.com/Homebrew/homebrew-core/actions/runs/6805354565/job/18504732312?pr=153647#step:4:36
2023-11-10 23:12:08 +08:00
Mike McQuaid
e9aae0f8b0
utils/gems: improve behaviour (particularly with Ruby 3)
- Use `Tempfile.new` with a mode argument to avoid the default behaviour
  of creating a file with mode 0600 (only user-readable).
- Avoid writing the file if it already exists and the contents are
  unchanged.
2023-11-09 14:57:47 +00:00
Bo Anderson
386fd0548a
Support system Ruby 3 on Linux 2023-11-07 19:27:30 +00:00
Douglas Eichelberger
75179e9239 brew style --fix 2023-11-05 12:18:31 -08:00