26835 Commits

Author SHA1 Message Date
Lukas Oberhuber
60831da3b8 DRY up formula prefix 2022-08-02 09:06:28 -07:00
Lukas Oberhuber
88a69b3de2 Restore previous style 2022-08-02 09:06:28 -07:00
Lukas Oberhuber
d35f2e76a7 Move Metrics/Blocklength disable to rubocop.yml 2022-08-02 09:06:28 -07:00
Carlo Cabrera
7be6b8e6d1
update-report: migrate GCC recursive dependents
When GCC 12 ships (Homebrew/homebrew-core#106755) ships, most (all?)
Linux bottles that depend on GCC will break.

Let's fix that by using the same trick for handling divergent formula
revisions when migrating formulae from linuxbrew-core (#11982). We set
the recorded `version_scheme` to -1, which spoofs the formula being
outdated. When `brew upgrade` installs GCC 12, the broken formulae will
have their bottles reinstalled too.

This works because the reinstallation will also rewrite the existing
RPATHs to point to the new version of GCC instead (#13631). This should
handle most of the breakage.
2022-08-02 23:57:16 +08:00
Lukas Oberhuber
07e299760a
mktemp: use "present?" instead of '!nil?"
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2022-08-02 08:33:40 -07:00
Carlo Cabrera
b2cf1822fa
Fix brew style 2022-08-02 22:53:29 +08:00
Carlo Cabrera
8a169364a8
pr-pull: fix typo
Error: tried to create Proc object without a block
    Do not report this issue until you've run `brew update` and tried again.
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `proc'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:372:in `pr_check_conflicts'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:439:in `block in pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `each'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/dev-cmd/pr-pull.rb:429:in `pr_pull'
    /home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:93:in `<main>'
    Error: Process completed with exit code 1.

https://github.com/Homebrew/homebrew-core/runs/7634004090?check_suite_focus=true#step:10:15
2022-08-02 22:46:30 +08:00
Michka Popoff
3b38695efa
Merge pull request #13512 from iMichka/conflicts
pr-pull: check for conflicts with long running builds
2022-08-02 14:42:08 +02:00
Carlo Cabrera
1c0eac7874
Exclude GCC formulae from RPATH modification for GCC 2022-08-02 19:09:38 +08:00
Carlo Cabrera
532460c098
keg_relocate: fix new GCC lib directory
Also add comment explaining what this line does, along with a TODO
suggesting a replacement once we've shipped the GCC PR.
2022-08-02 13:29:14 +08:00
Carlo Cabrera
53fdb64113
keg_relocate (linux): prepend gcc/lib/current to RPATH when needed
This should help keep bottles that require GCC working when
Homebrew/homebrew-core#106755 is merged.

This only works on freshly-poured bottles. Previously installed bottles
will still break on systems with a host GCC older than GCC 11.
2022-08-02 11:02:47 +08:00
Lukas Oberhuber
676e3d4923 Change name of option on mktemp
From retain_in_sources to retain_in_cache
2022-08-01 18:30:14 -07:00
Lukas Oberhuber
fdf17f06b1 Test for dSYM directory on Mac 2022-08-01 16:30:00 -07:00
Mohammad Zain Abbas
3d66ec1a81
Merge branch 'Homebrew:master' into mohammad 2022-08-02 00:55:07 +02:00
Mohammad Zain Abbas
ac614e29f9 After brew typecheck --fix 2022-08-02 00:54:18 +02:00
Mohammad Zain Abbas
26cdf02506 Fix typecheck issues for livecheckable resources 2022-08-02 00:52:01 +02:00
Mohammad Zain Abbas
3bd747d41b Merge branch 'mohammad' of https://github.com/mohammadzainabbas/brew into mohammad 2022-08-02 00:35:19 +02:00
Mohammad Zain Abbas
609485cdd7 Added a blank line before the output from print_latest_version in the debug output 2022-08-02 00:35:16 +02:00
Mohammad Zain Abbas
87b8c7bb6d
Added double blank line before resources to better separate the debug output
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2022-08-02 03:33:34 +05:00
Mohammad Zain Abbas
9c4b9b7e14 Refactored a bit + brew style --fix 2022-08-02 00:27:53 +02:00
Lukas Oberhuber
5b1724ef33 Fix rubocop warning by ignoring for install_args 2022-08-01 15:27:17 -07:00
Lukas Oberhuber
bee3531090 Improve style 2022-08-01 15:25:34 -07:00
Mohammad Zain Abbas
e718318eaf Fixed issue with info[:meta] for resources 2022-08-01 23:50:18 +02:00
Mohammad Zain Abbas
6daa22bc8e Fixed issue with print_latest_version 2022-08-01 23:34:53 +02:00
Michka Popoff
374c3985d6
pr-pull: check for conflicts with long running builds
This change will prevent us having to run some long running builds
multiple times and to rely on luck to get things merged without conflicts.

The check takes less than 30 secondes on my local setup.
2022-08-01 23:34:06 +02:00
Carlo Cabrera
ce8ef89ec0
Merge pull request #13617 from carlocab/bzr-breezy
download_strategy: replace `bazaar` with `breezy`
2022-08-01 20:03:08 +08:00
Rylan Polster
58be76bc9d
Fix on_{system} handling of generic macOS versions 2022-07-31 20:44:51 -04:00
Lukas Oberhuber
41a5265466 Improve messaging of debug source location 2022-07-31 21:06:33 +01:00
Lukas Oberhuber
93132c6876 Always put source files in the same directory
There's no point in saving old ones because the debug symbols will only
for the newest bulid anyway.

Currently blows away what was there before, which isn't ideal for a dev
workflow. Maybe that should be changed, given a tar file should be a tar
file, so shouldn't change. But there are many different types of files.
2022-07-31 20:54:14 +01:00
Max Eisner
b792a4f645
fix TypeError 2022-07-31 21:48:02 +02:00
Lukas Oberhuber
8b1eb32e99 Sources now retained in Caches/Homebrew/Sources
Full path is ~/Library/Caches/Homebrew/Sources

This creates a brand new directory for each build, but leaves previous.
2022-07-31 20:33:25 +01:00
Max Eisner
b2d94dc897
update arg names in docs and signature 2022-07-31 21:01:42 +02:00
Lukas Oberhuber
4b0d52ef62 debug_symbols passed down to soure dir creator
The flag is now passed down to resource which creates the directory for
unpacking the source.
2022-07-31 19:59:25 +01:00
Mohammad Zain Abbas
b651fe475c Added newer_than_upstream and outdated in resource info 2022-07-31 10:24:55 +02:00
Mohammad Zain Abbas
ce202dc61c Updated livecheck: Refactored for resources' output 2022-07-31 10:17:15 +02:00
Mohammad Zain Abbas
4de6509906 Removed print_latest_resource_version 2022-07-31 10:09:20 +02:00
Mohammad Zain Abbas
4f8f852fbc Refactored print_latest_version for resources as well 2022-07-31 10:08:39 +02:00
Mohammad Zain Abbas
40bbbd601e Refractored resource_version to work for a single resource 2022-07-31 09:49:19 +02:00
Mohammad Zain Abbas
4088c4683e
Indenting resources by two spaces
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2022-07-31 12:39:23 +05:00
Mohammad Zain Abbas
c074e8c020
Aligned output with the existing style seen in #latest_version
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2022-07-31 12:38:40 +05:00
Mohammad Zain Abbas
fe94bfb0f1
Updated livecheck_version
Co-authored-by: Nanda H Krishna <me@nandahkrishna.com>
2022-07-31 12:38:00 +05:00
Mohammad Zain Abbas
5beb7c1772 Simplified check resources' condition for Formulae 2022-07-31 09:35:41 +02:00
Mohammad Zain Abbas
6ec81ac31c No need to show that no resources exists for formulae 2022-07-31 09:33:01 +02:00
Mohammad Zain Abbas
eb2dcf7ea9
Update livecheck command: Casks don't have resource blocks
Co-authored-by: Nanda H Krishna <me@nandahkrishna.com>
2022-07-31 12:29:20 +05:00
Lukas Oberhuber
4eea117e84 ofail if debug-symbols cannot be extracted. 2022-07-30 11:41:05 +01:00
Lukas Oberhuber
15f1ac8775 Integration test for --debug-symbols
But only checks that the command works. Not that `dsymutil` is called
or that `-g` is added to the compile args.

(Not sure how to do either in an integration test.)
2022-07-30 11:23:40 +01:00
Lukas Oberhuber
cd9fe97c55 Improve style 2022-07-30 11:10:26 +01:00
Lukas Oberhuber
e46a61e181 rename & inline dsymutil to prepare_debug_symbols 2022-07-30 11:08:52 +01:00
Mohammad Zain Abbas
a91dbd4a96
Merge branch 'Homebrew:master' into mohammad 2022-07-30 11:49:52 +02:00
Carlo Cabrera
e217fd35c2
Merge pull request #12770 from carlocab/deprecated-dependencies
formula_auditor: audit for deprecated dependencies
2022-07-30 13:23:57 +08:00