16712 Commits

Author SHA1 Message Date
Emre Erhan
cad7f98527
Clean up variable names
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-31 15:17:32 -08:00
emreerhan
a1102f253c Remove checks to variable that is not set anywhere 2020-01-30 15:48:41 -08:00
emreerhan
027cc68534 Add condition to check if ruby version is < 2.7 2020-01-30 15:01:26 -08:00
Mike McQuaid
f8a4dd9fc5
Merge pull request #6968 from MikeMcQuaid/make-check-audit-whitelist
rubocop/lines: add whitelist.
2020-01-29 12:33:53 +00:00
Mike McQuaid
6bc72cf18a
rubocop/lines: add whitelist.
Let's only allow cryto or libraries.
2020-01-29 12:17:21 +00:00
Ryan S. Elliott
733b03ecd0 whitelist asymptote 2020-01-28 10:12:24 -06:00
Shaun Jackman
7f4c7e0afc bottle: Elide root_url only if it is the default
Elide root_url only if it is precisely equal to the default root_url.
Eliding root_url when a prefix matches the default also elides
a custom root_url such as https://linuxbrew.bintray.com/bottles-bio.
2020-01-26 22:04:41 -08:00
Xiao Di Guan
a9b22165fd
doctor: remove DYLD checks 2020-01-26 14:38:32 +11:00
Mike McQuaid
d014d5a982
Merge pull request #6948 from MikeMcQuaid/system_config_boring_git_remote
system_config: ignore HOMEBREW_*_GIT_REMOTE.
2020-01-20 11:54:15 +00:00
Dawid Dziurla
359dc9674c
bump-formula-pr: delete linux sha256 line if required
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-18 15:27:40 +01:00
Mike McQuaid
5f9c98176c
system_config: ignore HOMEBREW_*_GIT_REMOTE.
These aren't interesting enough to show in `brew config` as they
duplicate other data already displayed.
2020-01-18 14:25:38 +00:00
dependabot-preview[bot]
79ed303a30
build: bump unicode-display_width in /Library/Homebrew
Bumps [unicode-display_width](https://github.com/janlelis/unicode-display_width) from 1.6.0 to 1.6.1.
- [Release notes](https://github.com/janlelis/unicode-display_width/releases)
- [Changelog](https://github.com/janlelis/unicode-display_width/blob/master/CHANGELOG.md)
- [Commits](https://github.com/janlelis/unicode-display_width/compare/v1.6.0...v1.6.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-16 19:40:13 +00:00
Mike McQuaid
f59c596e4b
cleanup: fix portable ruby bundler removal logic.
Need to ensure portable rubies are removed last and pass more paramaters to
git clean.
2020-01-16 16:06:22 +00:00
Roger Hu
d27c5fb2cb Catalina upgrades causes Homebrew to break when you run brew cleanup. Catalina has Ruby 2.6 installed, so the portable Ruby version is not needed.
If you have /usr/local/Homebrew/Library/Homebrew/vendor/portable-ruby (for older OS X versions), then the cleanup tool will nuke everything in usr/local/Homebrew/Library/Homebrew/vendor/bundle/ruby. You will need to brew update-reset to get back the old packages.
2020-01-15 23:56:28 -08:00
Jonathan Chang
fc0777b291
Merge pull request #6924 from jonchang/uses_from_macos_audit
audit: add uses_from_macos dependency ordering
2020-01-15 11:37:07 -08:00
Gautham Goli
de9295cc7a
Merge pull request #6939 from Homebrew/argv-cleanup-8
ARGV: Replaces usages of ARGV.force? with Homebrew.args.force?
2020-01-15 21:25:36 +05:30
Gautham Goli
161c3fb6a4 ARGV: Replaces usages of ARGV.force? with Homebrew.args.force? 2020-01-15 21:09:31 +05:30
Mike McQuaid
ea1a3ea6e0
dev-cmd/bottle: run sudo --purge non-interactively.
This should avoid hanging if permissions are not granted.
2020-01-15 10:48:13 +00:00
Mike McQuaid
95e04cbf29
Merge pull request #6932 from Homebrew/dependabot/bundler/Library/Homebrew/parallel_tests-2.30.1
build: bump parallel_tests from 2.30.0 to 2.30.1 in /Library/Homebrew
2020-01-15 07:55:35 +00:00
Issy Long
c65b3f3f13
cmd/gist-logs: Fix bug with parsing of command-line arguments
- A user reported the following error when running `brew gist-logs`,
reproducible with any formula:

```
$ brew gist-logs rustup-init
Error: undefined method `length' for nil:NilClass
Please report this bug:
  https://docs.brew.sh/Troubleshooting
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/cmd/gist-logs.rb:145:in `gist_logs'
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/brew.rb:102:in
```

- From what I can tell, `gist_logs_args.parse` had ended up in the wrong
  method. The `gistify_logs` method already has `formula` (ie the
  formula name) passed into it. But it's the `gist_logs` method that needs
  to do the argument parsing. This was discovered by looking at some other
  recently changed ARGV => Homebrew.args code like cmd/info.
2020-01-14 22:13:19 +00:00
dependabot-preview[bot]
27cdddd5c7
build: bump parallel_tests from 2.30.0 to 2.30.1 in /Library/Homebrew
Bumps [parallel_tests](https://github.com/grosser/parallel_tests) from 2.30.0 to 2.30.1.
- [Release notes](https://github.com/grosser/parallel_tests/releases)
- [Commits](https://github.com/grosser/parallel_tests/compare/v2.30.0...v2.30.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-14 16:44:53 +00:00
Mike McQuaid
36dac3d41f
dev-cmd/bottle: add HOMEBREW_BOTTLE_SUDO_PURGE.
Add environment variable to optionally run `sudo purge` a few times to
potentially work around #6539.
2020-01-14 15:09:13 +00:00
Mike McQuaid
4babdf2a0f
postinstall: use arguments from main command. 2020-01-13 14:57:15 +00:00
Mike McQuaid
a15ce054c8
test: revert renaming test_args method. 2020-01-13 14:56:59 +00:00
Gautham Goli
eadf17881d
Homebrew/test.rb: Reuse test_args method 2020-01-13 14:51:50 +00:00
Mike McQuaid
1640d96855
Merge pull request #6929 from MikeMcQuaid/improve_git_remote
Improve handling of *_GIT_REMOTE env vars
2020-01-13 13:50:35 +00:00
Mike McQuaid
547c0d78fd
Merge pull request #6926 from Homebrew/dependabot/bundler/Library/Homebrew/i18n-1.8.2
build: bump i18n from 1.8.1 to 1.8.2 in /Library/Homebrew
2020-01-13 09:44:42 +00:00
Mike McQuaid
2f39057243
Improve handling of *_GIT_REMOTE env vars
- Output a message whenever a non-default remote is set.
- Ensure that `CoreTap.instance.install` uses the right remote.
2020-01-13 09:43:02 +00:00
Mike McQuaid
a23ae87a11
brew vendor-gems: commit updates. 2020-01-13 09:22:58 +00:00
dependabot-preview[bot]
cdda40304a
build: bump minitest from 5.13.0 to 5.14.0 in /Library/Homebrew
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.13.0 to 5.14.0.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/seattlerb/minitest/compare/v5.13.0...v5.14.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 05:34:06 +00:00
dependabot-preview[bot]
cbd31fbc62
build: bump i18n from 1.8.1 to 1.8.2 in /Library/Homebrew
Bumps [i18n](https://github.com/svenfuchs/i18n) from 1.8.1 to 1.8.2.
- [Release notes](https://github.com/svenfuchs/i18n/releases)
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/svenfuchs/i18n/compare/v1.8.1...v1.8.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-13 01:30:20 +00:00
Jonathan Chang
abf2b83b35 audit: add uses_from_macos dependency ordering 2020-01-12 11:12:27 -08:00
Jonathan Chang
cf66c05d87 audit: avoid build-time checks in core
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-11 09:48:54 -08:00
Jonathan Chang
9634041f82 audit: unnecessary comments from external taps
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-11 09:44:20 -08:00
Jonathan Chang
7239b3099a audit: check for build.with? in core
Co-Authored-By: Mike McQuaid <mike@mikemcquaid.com>
2020-01-11 09:37:10 -08:00
Mike McQuaid
4bdce4701f
Merge pull request #6920 from Homebrew/dependabot/bundler/Library/Homebrew/tins-1.24.0
build: bump tins from 1.23.0 to 1.24.0 in /Library/Homebrew
2020-01-10 12:22:15 +00:00
dependabot-preview[bot]
2bc97f2ae4
build: bump tins from 1.23.0 to 1.24.0 in /Library/Homebrew
Bumps [tins](https://github.com/flori/tins) from 1.23.0 to 1.24.0.
- [Release notes](https://github.com/flori/tins/releases)
- [Commits](https://github.com/flori/tins/compare/v1.23.0...v1.24.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-10 05:25:05 +00:00
Mike McQuaid
8ad50cd4dc
utils/github: refactor and update logic.
- better handle `HOMEBREW_GITHUB_API_USERNAME` and
  `HOMEBREW_GITHUB_API_PASSWORD` from `brew gist-logs`
- only user personal access tokens from the macOS keychain (fixes #6862)
- general refactoring and cleanup around the above
2020-01-09 16:13:44 +00:00
Mike McQuaid
f1de689385
Merge pull request #6914 from MikeMcQuaid/doctor_desired_origin_url
diagnostic: fix suggested origin URL.
2020-01-09 15:40:27 +00:00
Mike McQuaid
d08600c56a
Merge pull request #6912 from Homebrew/dependabot/bundler/Library/Homebrew/i18n-1.8.1
build: bump i18n from 1.7.1 to 1.8.1 in /Library/Homebrew
2020-01-09 15:36:58 +00:00
Mike McQuaid
44f00af10a
brew vendor-gems: commit updates. 2020-01-09 14:21:29 +00:00
Mike McQuaid
70e0b500e9
diagnostic: fix suggested origin URL.
Fixes #6909.
2020-01-09 14:14:44 +00:00
dependabot-preview[bot]
b5c82e59bb
build: bump i18n from 1.7.1 to 1.8.1 in /Library/Homebrew
Bumps [i18n](https://github.com/svenfuchs/i18n) from 1.7.1 to 1.8.1.
- [Release notes](https://github.com/svenfuchs/i18n/releases)
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/svenfuchs/i18n/compare/v1.7.1...v1.8.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-09 10:06:22 +00:00
dependabot-preview[bot]
efa2cb89af
build: bump parser from 2.7.0.1 to 2.7.0.2 in /Library/Homebrew
Bumps [parser](https://github.com/whitequark/parser) from 2.7.0.1 to 2.7.0.2.
- [Release notes](https://github.com/whitequark/parser/releases)
- [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitequark/parser/compare/v2.7.0.1...v2.7.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-09 05:23:48 +00:00
Jonathan Chang
bcb8f4da5f
Merge pull request #6903 from jonchang/audit-core-wording
audit: add "homebrew/core" for relevant checks
2020-01-08 15:53:45 -05:00
Jonathan Chang
779304df68 audit: add "homebrew/core" for relevant checks 2020-01-08 15:38:48 -05:00
Mike McQuaid
4efc1276b3
dev-cmd/audit: make git audit only --new-formula only.
Useful in e.g. https://github.com/Homebrew/homebrew-core/pull/46550 to
avoid repeatedly triggering a failing audit.
2020-01-08 12:12:26 +00:00
Mike McQuaid
dd573a9615
brew vendor-gems: commit updates. 2020-01-08 11:04:28 +00:00
dependabot-preview[bot]
0ea16042d4
build: bump i18n from 1.7.0 to 1.7.1 in /Library/Homebrew
Bumps [i18n](https://github.com/svenfuchs/i18n) from 1.7.0 to 1.7.1.
- [Release notes](https://github.com/svenfuchs/i18n/releases)
- [Changelog](https://github.com/ruby-i18n/i18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/svenfuchs/i18n/compare/v1.7.0...v1.7.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2020-01-08 11:02:35 +00:00
Mike McQuaid
45409618df
cmd/upgrade: fix pinned dependent handling.
Ensure they aren't upgraded or reinstalled even if they are outdated.

Fixes #6898.
2020-01-07 19:38:50 +00:00