4584 Commits

Author SHA1 Message Date
Seeker
6d1de3a72b
Merge pull request #7986 from SeekingMeaning/bump-cask-pr
dev-cmd: add bump-cask-pr command
2020-09-08 09:40:55 -07:00
Mike McQuaid
8118aee85d
Merge pull request #8651 from Homebrew/imgbot
[ImgBot] Optimize images
2020-09-08 17:14:00 +01:00
Markus Reiter
66555af904
Merge pull request #8639 from reitermarkus/rspec-github-actions
Add RSpec formatter for Github Actions.
2020-09-08 17:50:30 +02:00
Seeker
0a4fbf7f6a dev-cmd: add bump-cask-pr 2020-09-08 08:26:05 -07:00
ImgBotApp
1a7b3e87ee
[ImgBot] Optimize images
*Total -- 61.65kb -> 43.73kb (29.07%)

/docs/assets/img/docs/managing-pull-requests.drawio.svg -- 61.61kb -> 43.69kb (29.08%)
/Library/Homebrew/test/support/fixtures/test.gif -- 0.04kb -> 0.03kb (18.6%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-09-08 14:34:34 +00:00
Seeker
15af7189eb utils: add tar
Includes `validate_file` method to be used by `bump-formula-pr`
2020-09-08 07:08:07 -07:00
Markus Reiter
4d8dcb1d81 Add RSpec formatter for Github Actions. 2020-09-07 23:50:44 +02:00
Rylan Polster
7bd2f511c4
Merge pull request #8620 from nwhetsell/fix-license-exception-url
Remove trailing slash from SPDX license exception URL
2020-09-05 13:00:52 -04:00
Nathan Whetsell
89ef97a51b Remove trailing slash from SPDX license exception URL 2020-09-05 10:37:14 -04:00
Markus Reiter
36a8a823a1 Use curl workarounds for both curl and curl_output. 2020-09-05 10:42:35 +02:00
Markus Reiter
f1bf6c03c3 Add tests for implications. 2020-09-04 05:29:56 +02:00
Markus Reiter
e5b56e485f Move cask audit implications into Audit. 2020-09-04 04:47:31 +02:00
Dustin Rodrigues
5ce013b0d0
Merge pull request #8576 from dtrodrigues/revision-audit
audit: compare current version to last committed version when seeing if revision should be reset
2020-09-03 10:32:42 -04:00
Dustin Rodrigues
76ec69e3c3 audit: compare current version to last committed version when seeing if revision should be removed 2020-09-03 10:02:28 -04:00
Mike McQuaid
2e5272d04c Deprecate/disable code for Homebrew 2.5.0.
Do the usual "disable deprecations" and "uncomment pending deprecations"
dance and delete/deprecate/disable relevant/related code.
2020-09-03 10:34:22 +01:00
Maxim Belkin
a6d29894d9 cleanup: fix and reuse portable ruby logic.
Align the logic in `cleanup_portable_ruby` with that in `ruby.sh`.

Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2020-09-03 09:43:41 +01:00
Mike McQuaid
8604cdb15a
Merge pull request #8541 from claui/fix-patch-stdout
Return standard output in `popen_write`
2020-09-02 17:48:12 +01:00
Mike McQuaid
64eaa80c47
Merge pull request #8522 from rmNULL/elf-fixtures
spec:  Pathname#rpath, Pathname#interpreter and Pathname#patch!
2020-09-02 17:21:47 +01:00
Markus Reiter
4d1fa19a18 Add test for GitHub::Actions::Annotation. 2020-09-02 16:44:16 +02:00
Markus Reiter
ebd4ce467c Output GitHub Actions annotations for brew style. 2020-09-02 16:44:16 +02:00
rmnull
7863cc6f80
remove {rust,cpp,go}.elf fixutres. 2020-09-02 18:58:36 +05:30
rmnull
f5ca649e1d
new elf fixtures, and basic tests for Pathname#rpath(=), and Pathname#interpreter(=). 2020-09-02 18:58:36 +05:30
Mike McQuaid
5e5dabcadd
Merge pull request #8431 from SeekingMeaning/formula/installed_prefix
formula: rename `installed_prefix` and `opt_or_installed_prefix_keg`
2020-09-01 19:22:50 +01:00
Markus Reiter
b9f3589ab7 Test casks are already tested covered brew style. 2020-09-01 19:26:46 +02:00
Seeker
f366280e18 formula: add any_installed_version 2020-09-01 09:45:54 -07:00
Seeker
5def0701ba formula: rename opt_or_installed_prefix_keg to any_installed_keg 2020-09-01 09:39:20 -07:00
Markus Reiter
b4d14c193f Use Homebrew::Style for brew cask style. 2020-09-01 18:34:26 +02:00
Seeker
5acdcd26d0 formula: rename installed_prefix to latest_installed_prefix 2020-09-01 09:32:32 -07:00
Mike McQuaid
8b97c27c21 brew style manual fixes 2020-09-01 14:26:45 +01:00
Markus Reiter
6994556d19 Don't allow platform in cask descriptions. 2020-09-01 13:18:59 +02:00
Markus Reiter
3038ff8726 Improve detection of descriptions starting with cask/formula name. 2020-09-01 02:53:25 +02:00
Rylan Polster
4d0a1ff775 deprecate!, disable!: allow symbols for reason 2020-08-31 10:11:08 -04:00
Rylan Polster
842335d47b style: check disable! dates and reasons 2020-08-31 10:11:08 -04:00
Rylan Polster
6162799d63 style: check deprecate! reason 2020-08-31 10:11:08 -04:00
nandahkrishna
e5fe57c1fe
Migrate livecheck to Homebrew/brew
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2020-08-31 17:08:28 +05:30
nandahkrishna
8151016531
livecheck: remove test for livecheck_formulae 2020-08-31 16:37:37 +05:30
Mike McQuaid
854a139a79
Merge pull request #8533 from Rylan12/deprecate-date-issue
style: fix deprecation date check
2020-08-31 08:16:57 +01:00
Mike McQuaid
30e177f563
Merge pull request #8254 from nandahkrishna/migrate-livecheck-module
livecheck migration: create Homebrew::Livecheck
2020-08-31 08:09:58 +01:00
Claudia
772032f18a
Add failing tests for popen_write
When using `popen_write`, the expectation is to return the
standard output of the child process.

This expectation is evident in how `safe_popen_write` is written:

```
  def self.safe_popen_write(*args, **options, &block)
    output = popen_write(*args, **options, &block)
    return output if $CHILD_STATUS.success?

    raise ErrorDuringExecution.new(args, status: $CHILD_STATUS, output: [[:stdout, output]])
  end
```

However, no code has been written to actually *obtain* that output
from the child process. The side effects of that are described in
issue #8244. [1]

[1]: https://github.com/Homebrew/brew/issues/8244

The newly-added tests reveal that `popen_write` only returns the
number 4 instead of the expected standard output.

For example, given a file `foo` with the content `Foo\n`, one test
calls `popen_write` with `cat foo -` and an input of `Bar`.
The expected output would be `Foo\nBar\n` but the actual output is
the number 4 (which is what Ruby’s `IO#write` method returns).
2020-08-30 22:29:46 +02:00
Markus Reiter
0129247391 Refuse to install Git if HOMEBREW_TEST_GENERIC_OS is set. 2020-08-29 21:45:51 +02:00
Markus Reiter
bb1be7ef9d Call clear_available_cache before and after Git specs. 2020-08-29 21:42:24 +02:00
Rylan Polster
b1c374b729 style: fix deprecation date check 2020-08-29 10:57:07 -04:00
Nanda H Krishna
3cab6042d8
livecheck: update URL in test
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
2020-08-29 03:23:10 +05:30
nandahkrishna
062156365b
livecheck: modified test 2020-08-29 02:18:18 +05:30
nandahkrishna
2550af57df
livecheck: changes made and improved test 2020-08-29 00:32:34 +05:30
Seeker
4377a08b6e version: allow implicitly converting tokens to strings 2020-08-28 10:25:52 -07:00
nandahkrishna
4e0cc48b65
livecheck: changes made and tests added 2020-08-27 22:46:06 +05:30
nandahkrishna
c9f0642d45
livecheck migration: create Homebrew::Livecheck
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2020-08-27 21:26:58 +05:30
Mike McQuaid
ff8d30df74
Merge pull request #8255 from nandahkrishna/migrate-livecheck-strategy
livecheck migration: add strategies
2020-08-27 16:12:38 +01:00
nandahkrishna
f520301180
livecheck migration: add strategies
Co-authored-by: Sam Ford <1584702+samford@users.noreply.github.com>
Co-authored-by: Thierry Moisan <thierry.moisan@gmail.com>
Co-authored-by: Dawid Dziurla <dawidd0811@gmail.com>
Co-authored-by: Maxim Belkin <maxim.belkin@gmail.com>
Co-authored-by: Issy Long <me@issyl0.co.uk>
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
Co-authored-by: Seeker <meaningseeking@protonmail.com>
2020-08-27 20:00:30 +05:30