Jack Nagel
d79a7c0fcf
Always use exec_editor to exec the editor
2015-01-05 15:27:07 -05:00
Jack Nagel
04f600bb50
Emit warning when no editor is set
...
Closes Homebrew/homebrew#34647 .
2015-01-05 15:23:35 -05:00
Mike McQuaid
dc16371e19
utils: install_gem_setup_path! now checks PATH.
...
Check the executable is present to give a better error message if it isn't.
Closes Homebrew/homebrew#35541 .
2015-01-05 19:14:55 +00:00
Mike McQuaid
6fe0c3a83b
rubocop.yml: tweak rules to match existing format.
...
Don't want to enforce more than we need to.
2015-01-05 19:01:39 +00:00
Jack Nagel
e0286c5aae
Avoid shell quoting issues when extracting xz and lz archives
2015-01-05 10:46:14 -05:00
Jack Nagel
120bd43f87
Buffer 16K at a time
2015-01-05 10:45:05 -05:00
Mike McQuaid
3821c190f9
style: explicitly point to config file.
...
Closes Homebrew/homebrew#35556 .
2015-01-05 08:01:20 +00:00
Mike McQuaid
980cad0717
audit (strict): only run brew style
with Ruby 2.
2015-01-05 07:52:47 +00:00
Dominyk Tiller
e871a91958
install: fail on devel where devel doesn't exist
...
Just equalises a little how we treat HEAD and devel. The former already
fails if there isn’t a head defined, It seemed logical that devel
should fail in the same way.
Closes Homebrew/homebrew#35554 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-05 00:04:23 -05:00
Jack Nagel
f937e5f920
Forward arguments in IRB formula helpers
2015-01-04 21:37:27 -05:00
Jack Nagel
eec4feccaa
Include selected spec in Formula#inspect
2015-01-04 21:36:22 -05:00
Jack Nagel
8535c037ac
Remove unused assignment
2015-01-04 15:37:33 -05:00
Jack Nagel
50514678d1
Make active_spec protected
2015-01-04 15:33:25 -05:00
Jack Nagel
bda3b4d91e
Decouple LocalBottleDownloadStrategy from CurlDownloadStrategy
2015-01-04 15:33:25 -05:00
Jack Nagel
799d2571e3
Extract non-curl parts of CurlDownloadStrategy into a base class
2015-01-04 15:33:25 -05:00
Jack Nagel
683e209b10
Remove unused argument
2015-01-04 14:29:00 -05:00
Jack Nagel
991f540855
Doc most DSL methods as write-only
...
The public readers for these attributes are on the instance, not the
class.
2015-01-04 14:25:59 -05:00
Jack Nagel
85dfece168
Fix markup
2015-01-04 14:25:59 -05:00
Jack Nagel
6eb0b3505b
Top-level DSL methods only manipulate the stable spec
2015-01-04 14:25:59 -05:00
Jack Nagel
4398660cdd
Checkout outdatedness in brew upgrade <formula>
...
Fixes Homebrew/homebrew#35523 .
2015-01-04 14:03:56 -05:00
Mike McQuaid
c294ce22a7
audit: also run brew style
on --strict
.
...
Closes Homebrew/homebrew#35465 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-04 11:05:34 +00:00
Mike McQuaid
e0cacd3008
style: run Rubocop on formulae (new command)
2015-01-04 11:05:34 +00:00
Mike McQuaid
1cd0a47067
tests.rb: use Homebrew.failed to send exit code.
2015-01-04 11:05:34 +00:00
Mike McQuaid
bd334c55a0
brew.rb: return exit code from internal commands.
2015-01-04 11:05:34 +00:00
Viktor Szakats
fc2818b7a5
Use more https in urls and updated some lost links
...
Closes Homebrew/homebrew#35531 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-04 02:13:16 -05:00
Jack Nagel
9db8580414
Explicitly pass formulae to outdated_brews
2015-01-04 00:41:24 -05:00
Jack Nagel
318c103802
Remove unnecessary encoding comments
...
These files do not contain any non-ASCII characters.
2015-01-03 23:44:26 -05:00
Viktor Szakats
b81097cdee
Use more https links and some link updates along the way
...
Closes Homebrew/homebrew#35529 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-03 23:03:08 -05:00
Jack Nagel
a52143c63c
Remove readline and zlib hacks
2015-01-03 22:39:07 -05:00
Jack Nagel
a2a24b3a0d
Load formulae into private namespace
2015-01-03 22:39:07 -05:00
Xu Cheng
8ab4b9ae55
fixtures add test.ico
...
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-03 22:37:59 -05:00
Baptiste Fontaine
fe0c57cd0f
brew irb --help replaced with --examples
...
The --help flag is intercepted by brew.rb and prints the global usage
string. `irb` is never called when `brew irb --help` is executed.
Closes Homebrew/homebrew#35466 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-03 21:31:26 -05:00
Jack Nagel
43aa00227a
Get rid of mixed operator styles
2015-01-03 17:54:07 -05:00
Xu Cheng
fae84e5031
replace fixture png to 8x8 in size and rgb scale color
...
Closes Homebrew/homebrew#35456 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-03 20:50:01 +00:00
Dominyk Tiller
d071e2a5f4
Maintainer-Guidelines: basic touch-up
...
* Moved the `pip` homepage to something that points more directly at
`pip`.
* Adds a note on `test do`. All the maintainers and the bot check the
existence of such things these days, but I guess if anyone stumbles
across the document it’s useful to say.
* GiX is formally dead, and has two blessed forks.
* Typo on contributor.
Closes Homebrew/homebrew#35467 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 17:13:23 +00:00
Mike McQuaid
39fb39288f
utils: always set PATH in install_gem_setup_path.
2015-01-02 14:13:32 +00:00
Mike McQuaid
167dac74b7
utils: tweak install_gem_setup_path to not warn.
...
If the `Gem.user_dir/bin` is not already in the PATH it'll complain
unnecessarily (as we add it to the PATH ourselves) so just add it to the
PATH before running the install.
2015-01-02 13:37:06 +00:00
Mike McQuaid
9e8103cf38
Add Homebrew.install_gem_setup_path! function.
...
This uses the logic from tests.rb in man.rb too so that this can be
shared in a few places.
2015-01-02 12:42:02 +00:00
Baptiste Fontaine
81986ee7a7
audit: system check fixed for multiple arguments
...
Closes Homebrew/homebrew#35459 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 10:36:36 +00:00
Mike McQuaid
1e96c6fec4
formula_versions: ignore another exception.
2015-01-02 10:34:36 +00:00
Shaun Jackman
c01e6b81d3
test-bot: do not --cleanup outside CI.
...
Closes Homebrew/homebrew#35424 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-02 09:50:28 +00:00
Mike McQuaid
e87b377add
pull: fix tap URL regex for devel/head-only.
2015-01-02 09:24:25 +00:00
Dominyk Tiller
30ed74165e
LICENSE: bump to 2015
...
It's that most glorious time of the year: When everyone on Github
bumps their license dates to cover yet another year ahead.
Closes Homebrew/homebrew#35433 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-01 23:55:12 -05:00
Baptiste Fontaine
8fcfa08c43
ID3 tags stripped from MP3 test fixture
...
Closes Homebrew/homebrew#35427 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-01 21:34:12 +00:00
Jack Nagel
26a2e4c4d3
Avoid formula lookup when we know it will fail
...
Formulary.loader_for cannot raise exceptions, as canonical_name must
work for nonexistent formulae. However, we can skip the constant lookup
and a redundant file existence check by returning a loader that raises
immediately in #get_formula.
2015-01-01 13:21:29 -05:00
Jack Nagel
34fc227f92
Get rid of StandardLoader class
2015-01-01 13:21:29 -05:00
Baptiste Fontaine
b7ca3e33d6
minimal MP3 test file added
...
Closes Homebrew/homebrew#35417 .
Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-01 15:02:08 +00:00
Jack Nagel
648c47e85d
Re-raise NameError when it doesn't match our constant
2014-12-31 17:28:21 -05:00
Jack Nagel
5bf92cd7ca
Check file existence instead of rescuing LoadError
2014-12-31 17:28:21 -05:00
Jack Nagel
2cb160dc46
Stop rescuing NameError
...
This clause originated in 4a36c56ac7b36904712aa472b9bd50ef1b0c80d3,
attempting to catch NameErrors raised by const_defined? calls earlier in
the method body. Those const_defined? calls have since been moved out of
the body of the begin block.
Stop rescuing NameError here, which will make true programming errors in
formulae easier to debug.
2014-12-31 17:28:21 -05:00