13212 Commits

Author SHA1 Message Date
Mike McQuaid
8ed1425ed7 tests: don't output seed multiple times.
This clutters up the output. Instead, hide it with a RSpec formatter and
generate and output it ourselves.
2017-12-15 09:14:44 +00:00
Mike McQuaid
8410950d14 java_requirement: use popen_read :err option. 2017-12-14 16:44:25 +00:00
Mike McQuaid
cdeb0b1f23 bump-formula-pr: use popen_read :err option. 2017-12-14 16:44:25 +00:00
Mike McQuaid
7a8f61c28c gist-logs: use full path to brew.
This fixes the command with environment filtering enabled.
2017-12-14 16:44:25 +00:00
Mike McQuaid
c912d268f1
Merge pull request #3577 from MikeMcQuaid/python_requirement_tweaks
python_requirement: various tweaks/fixes.
2017-12-14 10:10:06 +00:00
Mike McQuaid
f4e647cbc6 python_requirement: various tweaks/fixes.
- simplify the code by avoiding some unnecessary variables and rename
  functions
- make more stuff private so implementation details don't leak
- make Python 2 binary `python2.7` to handle cases like those in
  https://github.com/Homebrew/homebrew-core/issues/21500
- only set `PYTHONPATH` for system Python; Homebrew's Python doesn't
  need it.
2017-12-14 09:21:26 +00:00
Mike McQuaid
b085da91c3 postinstall: add HOMEBREW_PREFIX/{,s}bin to PATH.
This avoids the need for workarounds such as:
https://github.com/Homebrew/homebrew-core/pull/21688
2017-12-14 09:20:07 +00:00
Mike McQuaid
9a0981e0eb
Merge pull request #3566 from sjackman/path
Do not specify absolute paths to utilities
2017-12-13 08:56:31 +00:00
Mike McQuaid
4b849dacd2
Merge pull request #3573 from DomT4/python_dead_code
python: remove package_available? logic
2017-12-13 08:50:05 +00:00
Dominyk Tiller
5a018f8650
python: remove package_available? logic
It was added in https://github.com/Homebrew/legacy-homebrew/pull/37345 for
a use case discussed in https://github.com/Homebrew/legacy-homebrew/pull/37340
that never seems to have actually emerged. I can find no reference of it
ever having been used, despite it existing for 2+ years here.
2017-12-13 06:16:02 +00:00
Dominyk Tiller
d6ebdf1e62
python: handle env filtering on pth check
Since ENV filtering became the default this has been chucking
erroneous warnings from both `brew doctor` and things like `brew install pygobject`
about needing to run:
```
echo 'import site; site.addsitedir("/usr/local/lib/python2.7/site-packages")' >> /Users/xyz/Library/Python/2.7/lib/python/site-packages/homebrew.pth
```
even though I had Homebrew's `python` installed.
2017-12-13 06:09:37 +00:00
Shaun Jackman
ce85e3b3b5 Remove with_system_path
The method with_system_path is no longer needed,
since environment filtering uses a default PATH.
2017-12-12 09:27:06 -08:00
Shaun Jackman
a4033c7196 Do not specify absolute paths to utilities
Specifying an absolute path to utilities is no longer needed,
since environment filtering uses a default PATH.
2017-12-12 09:25:16 -08:00
commitay
8a63356aed Partially revert "Add audit check for URL schema" 2017-12-12 08:22:23 +10:00
Markus Reiter
3c988c0403 Fix messed up parenthesis. 2017-12-11 23:01:37 +01:00
Mike McQuaid
f42d8acde3
Merge pull request #3559 from MikeMcQuaid/git-describe-1.4.0
brew.sh: latest HOMEBREW_VERSION is 1.4.0
2017-12-11 17:14:42 +00:00
Mike McQuaid
67a6c51606 brew.sh: latest HOMEBREW_VERSION is 1.4.0 2017-12-11 16:43:11 +00:00
Mike McQuaid
5f471ee289 doctor: tell people not to file issues.
This stuff doesn't matter.
2017-12-11 15:27:18 +00:00
Mike McQuaid
236e884511
Merge pull request #3553 from MikeMcQuaid/bump-formula-pr-messages
bump-formula-pr: improve error messages.
2017-12-11 09:44:43 +00:00
Dominyk Tiller
55d9750056
caveats: fix fish caveats under env filtering 2017-12-11 09:16:39 +00:00
Mike McQuaid
1babfb679d bump-formula-pr: improve error messages.
- Be clearer about how URLs/tags/revisions/versions are specified in
  error messages.
- Give a better error message if `hub` isn't configured.
2017-12-11 09:02:41 +00:00
Mike McQuaid
7411da36e5
Merge pull request #3551 from laurent22/master
Mentions how hub needs to be configured
2017-12-11 09:01:59 +00:00
Dominyk Tiller
d70a406fe7
caveats: fix PKG_CONFIG_PATH nudge under env filtering 2017-12-11 06:26:56 +00:00
Mike McQuaid
837ea74f44
Merge pull request #3543 from MikeMcQuaid/remove-env-unsets
Remove some unset/checked environment checks
2017-12-10 17:46:29 +00:00
Mike McQuaid
7466b23d8a
Merge pull request #3529 from MikeMcQuaid/env-filtering-default
Default environment filtering to on for all users.
2017-12-10 17:46:19 +00:00
Mike McQuaid
b41eb9d306
Merge pull request #3510 from MikeMcQuaid/remove-bottle-hooks
hooks/bottles: remove bottle hooks.
2017-12-10 17:46:10 +00:00
Mike McQuaid
46775f556f
Merge pull request #3542 from MikeMcQuaid/xcode-9.2
Xcode 9.2
2017-12-10 17:45:51 +00:00
Laurent Cozic
fd8262ef7d
Mentions how hub needs to be configured
This is to address issue #3531
2017-12-10 11:08:15 +00:00
Mike McQuaid
3c6b1daf2b Revert "formula_installer: tweak dependent requirements."
This reverts commit cc752e97f6dcfb3e58c9e753262926672edeb571.

Fixes #1585.

I will open a new issue for the actual underlying bug here (that
requirements aren't being handled correctly based on the stable/devel
spec used at installation time).
2017-12-09 14:23:34 +00:00
ilovezfs
e57da601d7
Merge pull request #3548 from sjackman/x11
X11Requirement: Inherit from generic class [macOS]
2017-12-08 13:35:17 -08:00
Mike McQuaid
69ab17fc35
Merge pull request #3547 from MikeMcQuaid/force-vendor-ruby-clarify
brew.1: clarify Homebrew's Ruby isn't 2.0 now.
2017-12-08 21:01:45 +00:00
Mike McQuaid
e72fde418b
Merge pull request #3546 from MikeMcQuaid/formula_assertions_ruby_23
formula_assertions: remove Ruby 2.0 compatibility.
2017-12-08 21:01:32 +00:00
Shaun Jackman
020c1adebd X11Requirement: Inherit from generic class [macOS]
Fix the warning: already initialized constant X11Requirement
2017-12-08 10:38:58 -08:00
Mike McQuaid
4eeeb5eac4 brew.1: clarify Homebrew's Ruby isn't 2.0 now.
Make this generic; it doesn't matter what version this is and this will
future proof it.
2017-12-08 16:49:33 +00:00
Mike McQuaid
4fa16c9428 formula_assertions: remove Ruby 2.0 compatibility.
We only support Ruby 2.3, now.
2017-12-08 16:45:41 +00:00
Mike McQuaid
301bb1d5dd .simplecov: filter more filters/folders.
This is stuff that can never be exercised by our test suite but is
exercised by `brew test-bot` so remove it from the coverage checks.
2017-12-08 16:44:33 +00:00
Mike McQuaid
6b9ca5dbf5 Remove some unset/checked environment checks
These will be redundant once environment filtering is on by default
in #3529.
2017-12-08 16:33:33 +00:00
Mike McQuaid
5055c31a86
Merge pull request #3483 from sjackman/x11
Implement X11Requirement for Linux
2017-12-08 15:47:37 +00:00
Mike McQuaid
1eca333084
Merge pull request #3530 from sjackman/glibc
config: Print host glibc version [Linux]
2017-12-08 15:46:36 +00:00
Mike McQuaid
c34cea3391
Merge pull request #3520 from amyspark/upgrade-ignore-dependencies
Accept new build flags when upgrading
2017-12-08 15:17:40 +00:00
Mike McQuaid
1aee4e1e1c Xcode 9.2
Update all the necessary versions but also cleanup some related
indentation and point the `Xcode.md` document to the code rather than
duplicating it there (which means it sometimes ends up outdated).
2017-12-08 14:59:15 +00:00
Shaun Jackman
0575d7b610 config: Print host glibc version [Linux] 2017-12-07 10:37:19 -08:00
Mike McQuaid
f52d69abea
Merge pull request #3539 from MikeMcQuaid/nil_req_dep
formula_installer: handle nil req_dependency.
2017-12-07 17:16:18 +00:00
Shaun Jackman
804393efc4 Implement X11Requirement for Linux
Move the XQuartz implementation to extend/os/mac/requirements.
2017-12-07 08:45:29 -08:00
Mike McQuaid
360d7bc6f4
Merge pull request #3537 from MikeMcQuaid/avoid-irrelevant-build-deps
formula_installer: avoid irrelevant build deps.
2017-12-07 16:19:23 +00:00
Mike McQuaid
4ca9831da6 formula_installer: handle nil req_dependency.
Closes #3538.
2017-12-07 16:17:55 +00:00
Markus Reiter
34b03dea52
Merge pull request #3532 from reitermarkus/to_s
Add missing `to_s`.
2017-12-07 17:08:19 +01:00
Mike McQuaid
b9cf7b2bbc formula_installer: avoid irrelevant build deps.
If dependents are already installed ensure their build dependencies (and
requirements) don't end up in the dependency/requirement tree.

Fixes #3033.
2017-12-07 14:56:12 +00:00
Mike McQuaid
0245b2cfea formula_installer: fix default formula prune.
Only prune it if it's not already installed.

Fixes bug with https://github.com/Homebrew/brew/pull/3479
Closes https://github.com/Homebrew/brew/pull/3535.
2017-12-07 08:55:36 +00:00
Mike McQuaid
1d344cf2f5 Document HOMEBREW_FORCE_BREWED_CURL
Should have been in #3482.
2017-12-06 12:56:15 +00:00