2238 Commits

Author SHA1 Message Date
constXife
4f5643a676 Fix undefined variable ruby_version 2017-06-06 13:45:09 +07:00
JCount
d5838c7e80 pull_spec: use stable, non-fork PR for patch expectation 2017-06-04 15:41:50 -04:00
Markus Reiter
3064b5b3c3 Add test for brew style. 2017-06-04 10:11:59 +02:00
Markus Reiter
0b66796540 Merge pull request #2712 from 13k/hbc-dsl-appcast-fix
Fix curl invocation in Hbc::DSL::Appcast
2017-06-03 07:57:06 +02:00
Markus Reiter
2d6ae61314 Re-revert "Fix operator spacing." 2017-06-02 19:22:05 +02:00
Mike McQuaid
ce80485aa4 Merge pull request #2664 from GauthamGoli/audit_caveats_rubocop
audit: Port audit_caveats method to rubocop and add tests
2017-06-02 15:48:22 +01:00
adrian
de78999def don't try to find the full path of the editor in 'brew edit'
fixes #2709
2017-06-01 17:45:07 -07:00
Markus Reiter
8ce8cea6f0 Try moving back to Library/Homebrew/test. 2017-06-01 17:30:19 +02:00
JCount
88964adf19 Move .codecov.yml to root.
also, unignore it.
2017-06-01 10:52:03 -04:00
ilovezfs
197392b56d Revert "Fix operator spacing." 2017-06-01 04:06:40 -07:00
Kiyoshi '13k' Murata
c4b010b6d7 Fix curl invocation in Hbc::DSL::Appcast.
Fixes #2592
2017-06-01 06:02:50 -03:00
Markus Reiter
d34ba7395b Fix operator spacing. 2017-05-31 19:53:41 +02:00
Gautham Goli
cf848a14d2 audit: Port audit_caveats method to rubocop and add tests 2017-05-31 22:59:48 +05:30
Mike McQuaid
90c971625e Merge pull request #2704 from MikeMcQuaid/jenkins-brew-sh
Update jenkins.brew.sh links.
2017-05-30 20:28:50 +01:00
Mike McQuaid
9032574038 Update jenkins.brew.sh links.
These previously, incorrectly pointed to bot.brew.sh.

Fixes #2703.
2017-05-30 19:14:40 +01:00
Gautham Goli
51f2338dd5 audit: Port audit_text method to rubocop and add tests 2017-05-30 15:28:05 +05:30
Mike McQuaid
28cd0d3856 Fix Linux build
Remove `testbottest` formula (this should have lived in the `brew
test-bot` repository from the outset) and make various other changes to
fix the Linux build here.
2017-05-30 09:51:06 +01:00
Mike McQuaid
7a38bab333 Fixup all RuboCop warnings. 2017-05-29 18:43:18 +01:00
Mike McQuaid
4356016b4a Use parallel RuboCop
This requires updating to Rubocop 0.49.0 which will require some fixes
to rules, in Homebrew/brew and Homebrew/homebrew-core but opening this
for now so I remember.
2017-05-29 18:42:02 +01:00
Markus Reiter
3165fd2519 Merge pull request #2663 from reitermarkus/lockfile
Convert `FormulaLock` to more generic `LockFile`.
2017-05-29 19:27:58 +02:00
Mike McQuaid
c2cb2c7868 Merge pull request #2682 from MikeMcQuaid/improve-installed-messaging
Improve some `brew install` messaging.
2017-05-29 09:15:15 +01:00
Mike McQuaid
da39db01a2 Merge pull request #2687 from issyl0/fix_formula_description_regex
Match the "formula name in description" on word boundaries
2017-05-29 08:06:27 +01:00
Isabell Long
279a4df6c3 Match the "formula name in description" on word boundaries
- The regexp for the "check if formula name is used in formula's
  description" cop matches every instance of the formula name if it
  exists, whether it's in a word or not.
- For example, the formula `mon` has the description "Monitor
  hosts/services/whatever and alert about problems". This makes
  `brew audit --strict` complain because it matches "Monitor",
  which isn't the formula name! The formula `pass` has the description
  "Password manager".  Again, the strict audit matches "Password",
  which isn't an issue.
- Instead, this change matches on a word boundary, so it will match
  `mon:`, or `mon `, but not "Monitor", or, for example, "harmony".
- I've changed the tests to account for this change.
2017-05-29 00:26:47 +01:00
Mike McQuaid
945cfc7cb7 diagnostic: move some more macOS doctor checks.
Move some `brew doctor` checks that are pretty macOS specific so they
are only run on macOS.
2017-05-27 13:34:59 +01:00
Mike McQuaid
ef59a751f4 Improve some brew install messaging.
Improve the messaging around `brew install` when there's a possible user
action such as an `upgrade` or `link` and don't tell people to
`install --force` when it's unnecessary.

While I did this, tweak the output and function usage in a couple of
related places.

Some example output before this change:
```
Warning: openssl is a keg-only and another version is linked to opt.
Use `brew install --force` if you want to install this version
Warning: mysql@5.6 is a keg-only and another version is linked to opt.
Use `brew install --force` if you want to install this version
Warning: analog-6.0_1 already installed
Warning: bash-completion@2-2.5 already installed, it's just not linked.
```

Some example output after this change:
```
Error: openssl 1.0.2k is already installed
To upgrade to 1.0.2l, run `brew upgrade openssl`
Warning: mysql@5.6 5.6.36_1 is already installed
Warning: analog 6.0_1 is already installed
Warning: bash-completion@2 2.5 is already installed, it's just not linked.
You can use `brew link bash-completion@2` to link this version.
```
2017-05-27 10:15:37 +01:00
Markus Reiter
060af0a26a Rename FormulaLock to LockFile. 2017-05-25 06:18:52 +02:00
Markus Reiter
0bb2773b17 Deprecate --caskroom flag. 2017-05-24 23:54:36 +02:00
Markus Reiter
b91d0254bb Add test for --binaries default value. 2017-05-24 20:34:20 +02:00
Markus Reiter
02a1e2781f Fix tests for CLI::Options DSL. 2017-05-22 02:51:17 +02:00
Markus Reiter
98f91fb883 Refactor CLI::Style. 2017-05-22 02:51:16 +02:00
Markus Reiter
66e9a060de Refactor CLI::Home. 2017-05-22 02:51:16 +02:00
Markus Reiter
276adc9e8b Refactor CLI::Edit. 2017-05-22 02:51:16 +02:00
Markus Reiter
8248345a9a Refactor CLI::Create. 2017-05-22 02:51:16 +02:00
Markus Reiter
b7347dcc44 Refactor CLI::Cleanup. 2017-05-22 02:51:16 +02:00
Markus Reiter
1714c73b49 Refactor CLI::Audit. 2017-05-22 02:51:16 +02:00
Markus Reiter
a44d4ce88b Remove Cask’s CLI#debug?. 2017-05-22 02:51:16 +02:00
Markus Reiter
9e821863d0 Pass along CLI::Binaries. 2017-05-22 02:51:16 +02:00
Markus Reiter
e1098b0e6d Merge pull request #2638 from reitermarkus/matchers
Use scoped RSpec matchers.
2017-05-19 23:24:35 +02:00
Markus Reiter
3139383fe6 Merge pull request #2623 from rednoah/master
Support GPG (signed data) container in Homebrew Cask
2017-05-19 20:48:35 +02:00
Markus Reiter
f0dc1d96c5 Merge pull request #2537 from reitermarkus/pathname-to_str
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
Markus Reiter
3cdf8f938a Use scoped RSpec matchers. 2017-05-15 17:23:40 +02:00
Mike McQuaid
ea8be174f6 Merge pull request #2631 from GauthamGoli/audit_homepage_rubocop
audit: Port audit_homepage method to rubocop and add tests
2017-05-15 10:02:47 +01:00
Mike McQuaid
9889b42ec4 Merge pull request #2628 from GauthamGoli/formula_desc_cop_fix
audit: Detect multiline and interpolated strings in formula desc cop
2017-05-15 10:01:38 +01:00
Gautham Goli
91efcb045e Port audit_homepage method to rubocop and add tests 2017-05-14 22:05:46 +05:30
Mike McQuaid
13efa8656e Merge pull request #2620 from MikeMcQuaid/more-env-filtering-tweaks
More environment filtering tweaks
2017-05-14 15:08:47 +01:00
Gautham Goli
80572939b4 Update string_content method to support multiline strings, add test for same 2017-05-13 18:48:40 +05:30
Mike McQuaid
8205e61e64 More environment filtering tweaks
- only document HOMEBREW_* variables in the manpage (although still
  read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
2017-05-13 11:42:01 +01:00
Gautham Goli
d04f295de3 Add autocorrect method for ComponentsOrder rubocop and tests 2017-05-13 03:09:55 +05:30
Reinhard Pointner
5c59b3352f Support GPG (signed data) container in Homebrew Cask (test case) 2017-05-11 16:27:45 +08:00
mansimarkaur
45754a1888 diagnostic_spec.rb: check_access_lock_dir test
Added assertion to check `HOMEBREW_LOCK_DIR.stat.mode` changes after `HOMEBREW_LOCK_DIR.chmod 0555`
2017-05-10 03:02:55 +05:30