Jack Nagel
dbb527f352
The argument to MacOS.locate is always a string
2014-04-21 22:47:15 -05:00
Jack Nagel
7573855756
Only check Xcode prefix when non-nil
2014-04-21 18:52:12 -05:00
Jack Nagel
24e27465e0
Remove comments that no longer reflect any adjacent code
2014-04-21 18:51:43 -05:00
Jack Nagel
749c877f03
Add another comment
2014-04-19 21:47:42 -05:00
Jack Nagel
bac25a77bf
Elaborate on why we should remove this code
2014-04-19 21:40:44 -05:00
Jack Nagel
8d6c1358a2
Update comment
2014-04-15 14:26:12 -05:00
Jack Nagel
538dea98ad
Start cleaning up Xcode.version
2014-04-15 14:20:18 -05:00
Jack Nagel
20c150fb8c
Xcode.bad_xcode_select_path? is used only once, so inline it
2014-04-15 11:28:52 -05:00
Jack Nagel
b78a4b7372
Don't call xcrun twice
2014-04-15 11:26:04 -05:00
Jack Nagel
2f052a2f65
Remove another unnecessary check
2014-04-15 11:26:03 -05:00
Jack Nagel
490cb34885
Remove unnecessary xcode-select check
...
This is handled here:
67fbb313da/Library/brew.rb (L34-46)
2014-04-15 11:21:27 -05:00
Jack Nagel
fcda7a1086
Document some unanswered questions in the Xcode module
2014-04-15 10:08:59 -05:00
Jack Nagel
2d8d7184f6
Remove dead constant
2014-04-15 09:49:01 -05:00
Clemens Gruber
dbe06bbbfc
Add Xcode 5.1.1 (=Golden master build) clang version
...
Closes Homebrew/homebrew#28173 .
Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2014-04-05 09:41:30 -05:00
Misty De Meo
89692b34a8
Xcode.prefix: remove osx-gcc-installer hack
...
This hack is starting to outlive its usefulness, and produces false
positives.
Fixes Homebrew/homebrew#28147 .
2014-04-04 15:26:41 -07:00
Jack Nagel
c13311ca09
Cache MacOS.version comparison results
...
MacOS.version#<=> is called many, many times during formula loading with
the same half dozen or so arguments. A typical call to this method
involves:
* a hash lookup to convert a symbol argument to a string
* creation of a throw-away Version object wrapping the argument
* the actual version comparison, which is not cheap
This makes it a prime candidate to be memoized.
2014-04-02 20:29:20 -05:00
Jack Nagel
55b0ee787a
Remove dead code
2014-04-01 22:54:15 -05:00
Jack Nagel
4830bdb5b7
The argument to pkgutil_info is always a string
2014-04-01 20:49:11 -05:00
Jack Nagel
0d3121f781
Batch up mdfind calls when possible
2014-04-01 20:47:26 -05:00
Jack Nagel
97ca3baedc
Avoid calling xcodebuild twice
2014-04-01 18:51:34 -05:00
Misty De Meo
3943a77832
CLT.installed?: base result on version detection
...
CLT.installed? previously returned false if the user had outdated dev
tools installed after a 10.9 upgrade, which was confusing to users.
2014-03-26 10:35:30 -07:00
Mike McQuaid
3b0eef09e9
Remove unnecessary swearing.
2014-03-22 10:14:20 +00:00
Jack Nagel
cca7d1a96f
Update latest CLT version check
2014-03-10 15:39:16 -05:00
Jack Nagel
5bd5e05541
Recognize Xcode 5.1 and CLT 5.1
...
Closes Homebrew/homebrew#27389 .
Fixes Homebrew/homebrew#27390 .
2014-03-10 15:26:36 -05:00
Adam Vandenberg
3b24d9f0be
latest xcode is 5.0.2
...
Closes Homebrew/homebrew#26943 .
2014-02-23 13:15:53 -08:00
Mike McQuaid
2a2c9402b9
mac: note that we only track stable Xcode versions.
2014-01-22 17:48:47 -08:00
Misty De Meo
d7a6161751
Recommit ENV changes
2014-01-04 01:20:56 -08:00
Mike McQuaid
e3bb6f6e0b
Revert "default_cc: locate already returns Pathnames"
...
This reverts commit 8ec6123d439e8f4d3586bbca6a426b726bd5e9dd.
2014-01-04 09:14:27 +00:00
Mike McQuaid
4866fd670f
Revert "default_compiler: recognize gcc-4.0"
...
This reverts commit bedcbb806bb8a991a1317b4ccde8d16b6974cc46.
2014-01-04 09:14:26 +00:00
Misty De Meo
ce97caed34
default_compiler: recognize gcc-4.0
2014-01-03 18:25:09 -08:00
Misty De Meo
a6c838b08a
default_cc: locate already returns Pathnames
2014-01-03 18:24:54 -08:00
Misty De Meo
d1d6451a6a
CLT.version: check 10.9 CLT first
...
10.9 users might have older CLT receipts sitting around, which could
result in bad pkgutil results. For example, before changing this, my
`brew --config` was printing '1.0' (the 10.7 version) instead of
'5.0.1.0.1.1382131676', the actual CLT I had installed.
2013-12-14 16:21:00 -08:00
Mike McQuaid
d7c13f84b6
Update string references to mxcl/homebrew.
2013-12-14 18:18:35 +00:00
Mike McQuaid
4c2e7b1659
Update docs, comment mxcl/homebrew refs.
2013-12-14 18:18:35 +00:00
Jack Nagel
36d3a2dfa8
Homebrew CVS is required for Xcode 5+
2013-12-04 01:19:17 -06:00
Jack Nagel
06bf1c0f02
Implement MacOS.dev_tools_prefix a different way
...
Avoid producing a dev_tools_path of "//usr/bin".
Fixes Homebrew/homebrew#24751 .
Closes Homebrew/homebrew#24754 .
2013-11-28 19:27:33 -06:00
Mike McQuaid
48e4fbc8d9
Mac: add dev_tools_prefix method.
...
Basically dev_tools_path without the `/usr/bin`.
2013-11-27 08:53:02 +00:00
Jack Nagel
6f7dcb08e8
Add Hardware::CPU.aes? and Hardware::CPU.avx2?
2013-11-26 20:23:19 -06:00
Jack Nagel
cb18b9e77e
Add Hardware::CPU.intel? and Hardware::CPU.ppc?
2013-11-26 20:23:19 -06:00
Jack Nagel
48e8be2454
Remove caching from MacOS.preferred_arch
...
The really expensive computation is now cached at its source, and this
only caches true anyway.
2013-11-26 20:23:19 -06:00
Jack Nagel
cb350fa9eb
Simplify Hardware::CPU.is_64_bit?
2013-11-26 20:23:19 -06:00
Jack Nagel
f172413a26
Cache calls to sysctl_bool at the source
2013-11-26 20:23:19 -06:00
Misty De Meo
426f5c0666
Fix MacOS::CLT.installed? for 10.9+
...
This continues to use mavericks_dev_tools? instead of trying to read
from pkgutil because pkgutil is really slow.
Fixes Homebrew/homebrew#24123 .
2013-11-22 20:47:57 -08:00
Jack Nagel
8b7ddc1fed
XQuartz 2.7.5 released
...
Closes Homebrew/homebrew#24173 .
2013-11-12 10:12:41 -06:00
Mike McQuaid
90c696ea67
xcode: fix nil outdated comparison.
2013-11-08 09:54:25 +00:00
Jack Nagel
5863a72625
Make sure 10.9 users upgrade XQuartz
2013-11-06 09:48:18 -06:00
Jack Nagel
f580e9271b
Revert "Make sure 10.9 users upgrade XQuartz"
...
This causes CI builds on 10.9 to fail; will repush once it is updated.
This reverts commit 70c5ce09d995426aefdbfd4aba0b06efe100a433.
2013-11-05 22:53:22 -06:00
Jack Nagel
82d6e2cf8a
Make sure 10.9 users upgrade XQuartz
2013-11-05 22:34:20 -06:00
Jack Nagel
466cc33bf3
Add pkgutil version for XQuartz 2.7.5_rc4
2013-11-05 22:32:42 -06:00
Jack Nagel
a82276b2cb
Add Xcode 5.0.2 to compiler map
...
Fixes Homebrew/homebrew#24018 .
2013-11-05 22:19:33 -06:00