574 Commits

Author SHA1 Message Date
Jack Nagel
25164350d6 Revert "Roll ignore_deps change back temporarily"
This reverts commit 067f4d474cb158debb8ad7d19d664fb2540cb09f.
2014-03-13 19:10:41 -05:00
Jack Nagel
4cb3d121a4 Roll ignore_deps change back temporarily 2014-03-13 17:40:22 -05:00
Jack Nagel
16fde6fbdb Rewrite postfix conditional 2014-03-13 15:59:54 -05:00
Jack Nagel
3b68723fa8 Make FormulaInstaller setup more readable 2014-03-13 15:59:54 -05:00
Jack Nagel
ce5e2aa65c Make debug an installer mode 2014-03-13 15:59:54 -05:00
Jack Nagel
4d02849d43 Make verbose an installer mode 2014-03-13 15:59:54 -05:00
Jack Nagel
908d2ba792 Make interactive an installer mode 2014-03-13 15:59:53 -05:00
Jack Nagel
05836649fe Add predicate methods for inspecting the installer mode 2014-03-13 15:59:53 -05:00
Jack Nagel
d1e6f04651 Remove unnecessary check for pour_bottle?
@start_time will be nil if we're pouring a bottle, so we don't need to
also check pour_bottle?.
2014-03-13 15:59:53 -05:00
Jack Nagel
7c62275e13 Whitelist arguments that are passed to build process 2014-03-13 15:59:53 -05:00
Jack Nagel
60caf14ce2 Don't set installer options to their default
ignore_deps and show_header default to false.
2014-03-13 15:59:53 -05:00
Jack Nagel
a96c1a2afc Make force_bottle an explicit installer mode 2014-03-10 14:56:02 -05:00
Jack Nagel
7b6fa8b7bb Inline install_bottle? logic into the installer 2014-03-10 14:56:02 -05:00
Jack Nagel
2182ce4d16 Remove some obsoleted hacks from the installer 2014-03-10 14:56:02 -05:00
Jack Nagel
42e60f7c59 Make build_bottle an explicit installer mode 2014-03-10 14:56:01 -05:00
Jack Nagel
f01c8a0218 Pass build_from_source value to dependency installer 2014-03-08 23:42:14 -06:00
Jack Nagel
3a4bd12d48 Add stubs for build_from_source and build_bottle installer modes 2014-03-08 22:28:50 -06:00
Jack Nagel
ce93c75f11 Remove "--fresh" option from installer
Turns out that this doesn't really work at all. `brew install` _never_
reuses options in the first place, and using this option with `brew
upgrade` results in some nasty corner cases in passing options to
dependencies.
2014-03-08 19:08:47 -06:00
Jack Nagel
cf41bb1ebb Don't remove --only-dependencies since it is meaningless
When only_deps is true, this method is never called.
2014-03-08 19:08:47 -06:00
Jack Nagel
a465950874 Sanitize ARGV options that are reflected in the installer mode 2014-03-08 18:50:00 -06:00
Jack Nagel
1ab5943fb2 Let commands decide what mode the installer should use 2014-03-04 14:06:25 -06:00
Jack Nagel
4c0db19538 Extract installer setup to prelude method 2014-03-04 14:06:25 -06:00
Jack Nagel
e8727a4eee Show full name when a installing a tap dependency 2014-03-04 12:29:42 -06:00
Jack Nagel
de254f6cd6 Stop mutating build options in upgrade 2014-03-02 14:02:18 -06:00
Jack Nagel
0eefded983 Remove unnecessary parameter from inherited_options_for 2014-03-02 14:02:17 -06:00
Jack Nagel
c534b1907d Revert "Let commands decide what mode the installer should use"
I'd still like to make this change, but at least for now the initializer
requires ignore_deps to be set correctly.

This reverts commit 881a8855b944fa9bd7dfd598bb9197f79f7a13f0.
2014-03-02 09:01:50 -06:00
Jack Nagel
ffbe5bf22c Let commands decide what mode the installer should use 2014-03-02 00:21:13 -06:00
Jack Nagel
ea85812c58 Reduce the number of ways options can be passed to the installer 2014-03-02 00:03:08 -06:00
Jack Nagel
a12d3918d4 Remove unnecessary memoization from FormulaInstaller#build_argv 2014-03-01 23:55:21 -06:00
Jack Nagel
40369dbbcd Only propagate universal option if the formula defines it 2014-03-01 18:55:32 -06:00
Jack Nagel
b168361ed0 Automatically install taps for cross-tap dependencies
Closes Homebrew/homebrew#27099.
2014-02-28 16:09:36 -06:00
Jack Nagel
7e76f02824 Don't verify deps when ignoring them 2014-02-28 15:57:55 -06:00
Jack Nagel
369f9b3251 FormulaInstaller: verify dependencies map to formulae before locking 2014-02-28 11:16:55 -06:00
Jack Nagel
793d6de6c3 Pass expansion-time build options to install_dependency 2014-02-27 14:22:43 -06:00
Jack Nagel
97dd879159 Clean up FormulaInstaller#install_dependency 2014-02-27 14:22:42 -06:00
Jack Nagel
e9b687070a Remove requested? dependency magic 2014-02-27 14:22:42 -06:00
Adam Vandenberg
1f86923ec2 ignore skip_clean :all 2014-02-23 15:53:26 -08:00
Adam Vandenberg
9559e162b2 Cleaner: do work in clean instead of constructor 2014-02-23 15:53:25 -08:00
Jack Nagel
19ca1bb601 Access bottle directly in FormulaInstaller 2014-02-21 00:41:07 -05:00
Mike McQuaid
8108ccc374 formula_installer: print bottle failure exception. 2014-02-02 21:29:06 +00:00
Misty De Meo
d885d98164 C++ stdlibs: issue warning, don't fail the build 2014-02-02 11:04:30 -08:00
Misty De Meo
edf474cb63 C++ stdlib check: don't check executables for deps
This avoids some possible false positives, as happens with, e.g., qt4.
2014-02-02 11:04:30 -08:00
Jack Nagel
76a45df325 Note when --only-dependencies is a no-op 2013-12-19 16:43:46 -06:00
Steven Peters
b524943226 install: add --only-dependencies option
The traditional approach to installing the dependencies of a formula is
the following:

  brew install `brew deps formula`

This approach ignores any options that are specified in the parent
formula. This pull request adds a --only-dependencies option to brew
install that installs the dependencies of a formula with optional flags,
but returns before installing the parent formula.

Closes Homebrew/homebrew#25272.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2013-12-19 16:43:42 -06:00
Jack Nagel
bc3ebd8343 Build install summary in a separate method and print all at once
This prevents interleaved output, e.g. when running with Ruby warnings
turned on.
2013-12-12 15:42:35 -06:00
Jack Nagel
b174012b17 Initialize ivars to silence warnings 2013-12-12 15:42:35 -06:00
Jack Nagel
f579d90458 Expand requirements of default deps added by other requirements
Dependencies built from requirements with a default formula may
themselves have requirements, and these requirements may have default
formulae, which may have more requirements, etc., so we have to keep
expanding until this isn't the case.

Fixes Homebrew/homebrew#25025.
Fixes Homebrew/homebrew#25037.
2013-12-09 14:36:10 -06:00
Jack Nagel
08055e1776 Ensure option names are consistent for default formula requirements 2013-12-09 14:36:10 -06:00
Jack Nagel
901902b53b Compute recursive deps for default_formula deps 2013-12-09 14:36:10 -06:00
Jack Nagel
293bde278a Rename filter_deps to expand_dependencies 2013-12-09 14:36:10 -06:00