Mike McQuaid
6b9ca5dbf5
Remove some unset/checked environment checks
...
These will be redundant once environment filtering is on by default
in #3529 .
2017-12-08 16:33:33 +00:00
Louis Bergelson
2abf2a6a79
whitelisting additional SentinelOne dylib pattern
...
it seems like SentinelOne is now using dylibs that include a number, possibly randomized in some way
this causes brew doctor to give a warning, but it should probably be ignored like the previous versions of the sentinel dylib
updating diagnostic.rb to include a new pattern to ignore dylibs of the form sentinel-*.dylib
2017-11-28 17:34:16 -05:00
Mike McQuaid
9ebf338804
diagnostic: fix paths usage.
...
- Don't allow taking an argument. This doesn't work and never has as it
caches the result regardless of the argument.
- Don't rely on the PATH to check for external commands.
2017-11-17 17:41:58 +00:00
Markus Reiter
526299913f
Remove usless comments.
2017-10-24 19:39:40 +02:00
Dominyk Tiller
212367ee7e
diagnostic: handle APFS returning hash order
2017-10-20 22:44:11 +01:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Mike McQuaid
3a606abaa1
Merge pull request #3229 from BenMusch/check-for-master-no-refactor
...
doctor: Check for branch of core tap (take 2)
2017-10-18 10:59:59 +01:00
Dominyk Tiller
16ea29a641
diagnostic: pass explicit sort to handle APFS
2017-10-14 06:35:25 +01:00
Markus Reiter
175ca909ee
Clean up code style and remove .rubocop_todo.yml.
2017-10-08 16:10:37 +02:00
Mike McQuaid
a8ca47d294
diagnostic: remove unnecessary blank line.
2017-10-01 19:07:10 +01:00
Mike McQuaid
7974ce24b6
Fix regex style
2017-09-28 20:10:06 +01:00
Ben Muschol
2d6bd04007
Merge branch 'master' into check-for-master-no-refactor
2017-09-27 16:36:10 -04:00
Ben Muschol
fe5c885da0
Implement changes
2017-09-27 16:32:13 -04:00
Mike McQuaid
01e9ec9a9f
Rubocop: automatic rule fixes.
2017-09-24 21:23:59 +01:00
ilovezfs
204f370491
Revert "Add check for HEAD ref in diagnostics"
2017-09-18 14:49:10 -04:00
ilovezfs
8b91018c70
Revert "diagnostic: don't check CI core branch."
...
This reverts commit cb5b14307ca4640e1ba68cfd28e7fef34a3b771b.
2017-09-18 14:49:10 -04:00
ilovezfs
6fab5b0976
Revert "diagnostic: also don't check Jenkins core branch."
...
This reverts commit db41f9d1182ff8c4c3b42b458e38d5c58b496ffb.
2017-09-18 14:49:10 -04:00
ilovezfs
78a742c1ff
Revert "Add check for HEAD ref in diagnostics"
2017-08-26 10:15:35 -07:00
ilovezfs
784a85f885
Revert "diagnostic: don't check CI core branch."
...
This reverts commit cb5b14307ca4640e1ba68cfd28e7fef34a3b771b.
2017-08-26 10:14:23 -07:00
ilovezfs
b1e0998f58
Revert "diagnostic: also don't check Jenkins core branch."
...
This reverts commit db41f9d1182ff8c4c3b42b458e38d5c58b496ffb.
2017-08-26 10:13:43 -07:00
Mike McQuaid
db41f9d118
diagnostic: also don't check Jenkins core branch.
2017-08-26 14:50:55 +01:00
Mike McQuaid
cb5b14307c
diagnostic: don't check CI core branch.
2017-08-26 14:44:26 +01:00
Ben Muschol
7b31dd6062
Prefer if over unless, simplify messaging
2017-08-26 08:25:08 -04:00
Ben Muschol
b351c3f3ff
Fix method name
2017-08-25 21:04:23 -04:00
Ben Muschol
abe47b79c8
Add check for HEAD ref in diagnostics
2017-08-25 20:25:58 -04:00
Mike McQuaid
bd06a7926c
diagnostic: use ENV[]
2017-07-20 20:02:34 +01:00
Justin Baugh
0a9de6b8a6
Update source check to match style
2017-07-20 14:44:20 -04:00
Justin Baugh
e077bfe655
Address rubocop issues
2017-07-20 11:57:43 -04:00
Justin Baugh
7504d830cb
Add warning to doctor if HOMEBREW_BUILD_FROM_SOURCE is set.
2017-07-20 11:08:53 -04:00
Wang Boyu
89d2cc00da
diagnostic: Update whitelisted dylib used by Symantec (again)
2017-06-22 16:00:54 +08:00
Wang Boyu
803c5c3afe
diagnostic: Update whitelisted dylib used by Symantec
2017-06-22 10:02:35 +08:00
Mike McQuaid
370eeed2e4
diagnostic: quiet some CI whining.
...
We want to be able to symlink Homebrew/test-bot to Homebrew/core on
Linux for CI speed.
2017-06-17 14:01:42 +01:00
Baptiste Fontaine
569180dfe5
diagnostic: Fix suggested git remote commands
2017-06-14 17:26:35 +02:00
Mike McQuaid
7a0aff1080
Autocorrect Rubocop Style/PerlBackrefs.
2017-06-10 20:23:20 +03:00
Markus Reiter
2d6ae61314
Re-revert "Fix operator spacing."
2017-06-02 19:22:05 +02:00
ilovezfs
197392b56d
Revert "Fix operator spacing."
2017-06-01 04:06:40 -07:00
Markus Reiter
d34ba7395b
Fix operator spacing.
2017-05-31 19:53:41 +02:00
Mike McQuaid
945cfc7cb7
diagnostic: move some more macOS doctor checks.
...
Move some `brew doctor` checks that are pretty macOS specific so they
are only run on macOS.
2017-05-27 13:34:59 +01:00
Markus Reiter
f0dc1d96c5
Merge pull request #2537 from reitermarkus/pathname-to_str
...
Remove `to_s` from some `Pathname`s.
2017-05-18 09:39:07 +02:00
Mike McQuaid
8205e61e64
More environment filtering tweaks
...
- only document HOMEBREW_* variables in the manpage (although still
read from all the original environment variables).
- resort manpage environment variables in alphabetical order
- check the original path for trailing slashes
2017-05-13 11:42:01 +01:00
Markus Reiter
5828eefd01
Remove to_s from some Pathnames.
2017-05-08 13:37:28 +02:00
Markus Reiter
24f48ae7d9
Use PATH#select.
2017-04-30 21:11:28 +02:00
Markus Reiter
22f624b373
Make PATH enumerable.
2017-04-30 21:11:28 +02:00
Markus Reiter
f8ad9d7efd
Use PATH where possible.
2017-04-30 21:11:27 +02:00
Mike McQuaid
11acadaa50
Merge pull request #2524 from MikeMcQuaid/more-env-filtering-fixes
...
Hide sensitive tokens from install/test/post.
2017-04-23 09:45:47 +01:00
Mike McQuaid
d02b4f321d
Hide sensitive tokens from install/test/post.
...
Hide these tokens to avoid malicious subprocesses e.g. sending them
over the network. Also, support using these tokens with environment
filtering and clear `HOMEBREW_PATH` from subprocesses to stop them
sniffing it. Finally, use `HOMEBREW_PATH` to detect Homebrew’s user’s
PATH for e.g. `brew doctor` etc.
2017-04-22 16:31:19 +01:00
Mike McQuaid
ba3c46d24f
More deprecations.
...
Deprecate more methods. Internal APIs have been verified to be unused
elsewhere and removed. External APIs have had deprecation methods added.
Existing deprecations have been either upgraded to produce warnings or
no longer deprecated and the reasoning documented.
2017-04-22 16:28:07 +01:00
Mike McQuaid
b757c927af
diagnostic: also accept trailing / on git urls.
2017-03-28 19:44:30 +01:00
Mike McQuaid
46a91428f7
Merge pull request #2413 from JCount/increase-minimum-git-version
...
diagnostic: increase minimum git version to 1.8.5
2017-03-28 19:35:15 +01:00
JCount
08523d393f
diagnostic: increase minimum git version to 1.8.5
...
older versions do not support the 'git -C <path>' option
2017-03-28 12:05:06 -04:00
