38881 Commits

Author SHA1 Message Date
Mike McQuaid
678bfecc5a
Merge pull request #16721 from cho-m/prune-non-direct-test-deps
test: prune test deps of dependencies
2024-02-22 12:30:15 +00:00
Mike McQuaid
b8243d0e9e
Merge pull request #16717 from jesboat/fix-chmod-message2
[brew audit] fix "Incorrect file permissions" message
2024-02-22 08:51:52 +00:00
Mike McQuaid
89fd6964f9
Merge pull request #16715 from reitermarkus/tap-ensure-installed
Clean up `Tap#ensure_installed!` usage.
2024-02-22 08:47:48 +00:00
Mike McQuaid
689b76cbad
Merge pull request #16714 from reitermarkus/tap-cask-files
Support `Tap#cask_files` when using API.
2024-02-22 08:47:18 +00:00
Mike McQuaid
318256c0b4
Merge pull request #16713 from reitermarkus/tap-formula-files
Support `Tap#formula_files` when using API.
2024-02-22 08:46:37 +00:00
Michael Cho
fed4e78e23
test: prune test deps of dependencies 2024-02-21 15:03:46 -05:00
Issy Long
6a9c9c00a0
Merge pull request #16718 from issyl0/pyyaml-resource-needs-specific-deps-too
rubocop: The `pyyaml` resource requires `depends_on "libyaml"`
2024-02-21 08:10:59 +00:00
Markus Reiter
9f5e1f2870
Clean up Tap#ensure_installed! usage. 2024-02-21 03:21:02 +01:00
Markus Reiter
8b977ced6f
Merge pull request #16719 from Homebrew/sponsors-maintainers-man-completions
Update manpage and completions.
2024-02-21 03:18:42 +01:00
Douglas Eichelberger
13d7f802fa
Merge pull request #16707 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2024-02-20 17:00:22 -08:00
BrewTestBot
2adc91643a
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2024-02-21 00:19:02 +00:00
BrewTestBot
808d5dec7e
Update manpage and completions.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2024-02-21 00:06:23 +00:00
Issy Long
ff21ef0955
It helps if you actually require the new cop to run it on real code 2024-02-20 23:49:25 +00:00
Issy Long
3bfe7e5aa1
Handle nil resource args for some reason
- Ran this against `signal-cli` and despite it having a valid-looking resource block, it failed on `undefined method 'str_content' for nil:NilClass`.
2024-02-20 23:48:58 +00:00
Issy Long
5c7be57531
Appease Sorbet 2024-02-20 23:36:52 +00:00
Douglas Eichelberger
fb192ed46d Exclude parlour.rbi from rubocop 2024-02-20 15:31:25 -08:00
Issy Long
a895496982
rubocop: The pyyaml resource requires depends_on "libyaml" 2024-02-20 23:22:15 +00:00
Jade Elizabeth Sailor
94aeabfc8a [brew audit] fix "Incorrect file permissions" message
When the file isn't world-readable, `brew audit` prints a failure
message including a suggestion to `chmod +r` the file. Unfortunately,
this isn't quite right: with both macOS and coreutils, leaving out the
"who" in a chmod only affects bits which would be set in the umask. So,
if the umask doesn't allow world-readable (which might be why the file
wasn't world-readable in the first place), the suggested chmod command
does nothing.

Change to print `chmod a+r` instead; that does have the intended effect.

No other `chmod` suggestions in this file have the same problem.
2024-02-20 16:26:21 -05:00
Markus Reiter
771193c80a
Ensure readall runs without API. 2024-02-20 20:44:14 +01:00
Markus Reiter
2d41fe8feb
Support Tap#formula_files when using API. 2024-02-20 20:44:13 +01:00
Markus Reiter
7f5a67917a
Ensure CoreCaskTap is included in diagnostics. 2024-02-20 20:44:02 +01:00
Markus Reiter
4cf0f79368
Support Tap#cask_files when using API. 2024-02-20 20:44:02 +01:00
Markus Reiter
28ad3f7fec
Merge pull request #16712 from reitermarkus/caskloader-tap-paths
Remove `CaskLoader::tap_paths`.
2024-02-20 20:41:01 +01:00
Markus Reiter
670eb3d02d
Remove CaskLoader::tap_paths. 2024-02-20 18:25:11 +01:00
Mike McQuaid
14ba271533
Merge pull request #16705 from issyl0/lxml-resource-needs-uses-from-macos
rubocop: Formulae with the "lxml" resource have required dependencies
2024-02-20 12:54:19 +00:00
Issy Long
ff23de4766
Formatting and cope with more modern RSpec config changes
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2024-02-20 12:17:27 +00:00
Mike McQuaid
aa58637201
Merge pull request #16640 from dduugg/finalize-sigs
Finalize methods that do not support overrides
2024-02-20 08:44:36 +00:00
BrewTestBot
4272a6108b
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2024-02-20 00:18:54 +00:00
Ruoyu Zhong
7abeca1970
Merge pull request #16706 from Homebrew/sponsors-maintainers-man-completions
Update manpage and completions.
2024-02-20 08:17:26 +08:00
BrewTestBot
cece7e8ea3
Update manpage and completions.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2024-02-20 00:06:06 +00:00
Issy Long
33c33b5338
rubocop: Formulae with the "lxml" resource have required dependencies
- We're moving from `depends_on "python-lxml"` to `resource "lxml" ...` as part
  of the new Python vendoring plan.
- For `resource "lxml"` to work, `uses_from_macos "libxml2"` and
  `uses_from_macos "libxslt"` are needed in the formulae.
- This new RuboCop rule enforces that a formula including the "lxml" resource
  also include those dependencies.
2024-02-19 22:50:55 +00:00
Douglas Eichelberger
e7e4ecc405 Change return type 2024-02-19 13:29:49 -08:00
Douglas Eichelberger
b5d07dd7d6 Finalize methods that do not support overrides 2024-02-19 13:23:45 -08:00
Bo Anderson
c35546167d
Merge pull request #16703 from Bo98/codespaces-fix
devcontainer: fix creation error
2024-02-19 18:51:17 +00:00
Bo Anderson
34d7a12f6b
devcontainer: fix creation error 2024-02-19 18:41:24 +00:00
Douglas Eichelberger
ab62a717b9
Merge pull request #16407 from dduugg/default-prefixes
Remove redirection for default prefixes
2024-02-19 09:48:26 -08:00
Mike McQuaid
aa925598ee
Merge pull request #16699 from dduugg/modern-rspec
Modernize RSpec configuration
2024-02-19 16:56:53 +00:00
Douglas Eichelberger
c2e48ec79c Extract find_files to helper 2024-02-19 08:28:12 -08:00
Douglas Eichelberger
d97645977f Fix rebase test failure 2024-02-19 08:27:59 -08:00
Mike McQuaid
e258bab0f9
Merge pull request #16701 from Homebrew/remove-deparallelize-creator
formula_creator: remove `ENV.deparallelize` suggestion
2024-02-19 16:25:22 +00:00
Patrick Linnane
95449b4dc3
formula_creator: remove ENV.deparallelize suggestion
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-02-19 08:14:44 -08:00
Mike McQuaid
d33efcda9c
Merge pull request #16556 from PauloPhagula/patch-1
fix: use recommended way of updating Fish shell $PATH
2024-02-19 14:44:49 +00:00
Mike McQuaid
52d73a1ec3
Merge pull request #16668 from colindean/patch-4
Common-Issues: Documents resolving dual installations from Migration Assistant copies
2024-02-19 14:36:27 +00:00
Mike McQuaid
b083b1a85b
Merge pull request #16673 from dduugg/fix-rubocop-filters
Fix rubocop .rbi exclusion
2024-02-19 14:07:30 +00:00
Mike McQuaid
412852bd5f
Apply suggestions from code review
Co-authored-by: Markus Reiter <me@reitermark.us>
2024-02-19 14:05:12 +00:00
Mike McQuaid
e5f0795e20
Update Library/.rubocop.yml
Co-authored-by: Markus Reiter <me@reitermark.us>
2024-02-19 13:57:54 +00:00
Douglas Eichelberger
d7ebf97467
Turn on disable_monkey_patching 2024-02-19 13:57:28 +00:00
Douglas Eichelberger
ab8f5702ac
git grep -l '^shared_examples' | xargs gsed -i 's|^shared_examples|RSpec.shared_examples|g' 2024-02-19 13:57:28 +00:00
Douglas Eichelberger
26eda5a303
git grep -l '^describe' | xargs gsed -i 's|^describe|RSpec.describe|g' 2024-02-19 13:57:27 +00:00
Douglas Eichelberger
2255b9d43d
Enable verify_partial_doubles 2024-02-19 13:57:27 +00:00