38881 Commits

Author SHA1 Message Date
apainintheneck
2da1c93df7 tap: memoize Tap.reverse_tap_migrations_renames
This should be a relatively small hash but it gets recalculated
every time we call Cask#oldnames or Formula#oldnames which ends
up being a lot if you run certain commands with --eval-all.

For example, when running the following, it took 10% of the total
runtime.

```
brew deps --casks --eval-all
```
2024-03-01 20:14:42 -08:00
apainintheneck
99d5200db3 tap: fix performance regression in *_files_by_name
We essentially stopped caching these accidentally and they get
called every time we try to load a cask or formula from the API.
It gets really, really, really slow.

I ran `brew deps --casks --eval-all` before and after the changes.

I let it run for 3 minutes before killing it. No output had been
printed to the screen.

It finished printing all output (pages and pages of it) in less
than a minute.

---

This should match the caching behavior we had before the
recent changes in these two PRs.

- https://github.com/Homebrew/brew/pull/16777
- https://github.com/Homebrew/brew/pull/16775
2024-03-01 19:30:53 -08:00
Patrick Linnane
0a3549b7f2
Merge pull request #16789 from Homebrew/update-formulae-docs 2024-03-01 16:28:29 -08:00
Patrick Linnane
7fd9d09be0
Update docs/Acceptable-Formulae.md
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2024-03-01 15:36:25 -08:00
Michael Cho
408c8e806f
utils/pypi: ignore test resources when counting matches
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-03-01 16:26:34 -05:00
Patrick Linnane
e98808e566
docs: update language on commit messages & notability
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-03-01 11:05:08 -08:00
Patrick Linnane
6e7e56fdec
Merge pull request #16787 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-1.31.1 2024-03-01 10:40:37 -08:00
BrewTestBot
21fd99b88b
Update RBI files for rubocop-ast.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-03-01 18:26:55 +00:00
BrewTestBot
1fd536d8ef
brew vendor-gems: commit updates. 2024-03-01 18:26:39 +00:00
dependabot[bot]
56f5f1f7f3
build(deps-dev): bump rubocop-ast in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast) from 1.31.0 to 1.31.1.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.31.0...v1.31.1)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-01 18:24:46 +00:00
Douglas Eichelberger
b1b2c60816
Merge pull request #16786 from Homebrew/dependabot/bundler/Library/Homebrew/yard-0.9.36
build(deps-dev): bump yard from 0.9.35 to 0.9.36 in /Library/Homebrew
2024-03-01 10:18:43 -08:00
Douglas Eichelberger
fae9ab8d1e Resolve vale violations 2024-03-01 10:00:42 -08:00
BrewTestBot
abbccdc86f
Update RBI files for yard.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-03-01 17:19:00 +00:00
BrewTestBot
01ca89cbd9
brew vendor-gems: commit updates. 2024-03-01 17:18:43 +00:00
dependabot[bot]
36d6a211c5
build(deps-dev): bump yard from 0.9.35 to 0.9.36 in /Library/Homebrew
Bumps [yard](https://github.com/lsegal/yard) from 0.9.35 to 0.9.36.
- [Release notes](https://github.com/lsegal/yard/releases)
- [Changelog](https://github.com/lsegal/yard/blob/main/CHANGELOG.md)
- [Commits](https://github.com/lsegal/yard/compare/v0.9.35...v0.9.36)

---
updated-dependencies:
- dependency-name: yard
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-03-01 17:16:48 +00:00
Ruoyu Zhong
38b671d8bb
Merge pull request #16750 from iMichka/autobump
bump-formula|cask-pr: do not allow to bump autobumped packages
2024-03-02 00:33:06 +08:00
Mike McQuaid
387332ab68
Merge pull request #16782 from reitermarkus/tap-sig-5
Rename `Tap#reverse_cask_renames` to `Tap#cask_reverse_renames`.
2024-03-01 15:41:39 +00:00
Mike McQuaid
6c6c418dff
Merge pull request #16785 from reitermarkus/tap-sig-remote
Actually return `super` in `CoreTap#remote`.
2024-03-01 13:46:39 +00:00
Mike McQuaid
56b3982e7a
Merge pull request #16784 from reitermarkus/tap-sig-7
Add signature for `Tap#config`.
2024-03-01 13:46:20 +00:00
Mike McQuaid
9421d50f9d
Merge pull request #16783 from reitermarkus/tap-sig-6
Clear cache for `Tap#formula_reverse_renames`.
2024-03-01 13:45:59 +00:00
Markus Reiter
567ea44c99
Actually return super in CoreTap#remote. 2024-03-01 13:22:03 +01:00
Markus Reiter
0966d2cd8f
Add signature for Tap#config. 2024-03-01 13:16:56 +01:00
Markus Reiter
01133769ba
Clear cache for Tap#formula_reverse_renames. 2024-03-01 12:58:05 +01:00
Markus Reiter
c3c5437c4f
Rename Tap#reverse_cask_renames to Tap#cask_reverse_renames. 2024-03-01 12:57:37 +01:00
Michka Popoff
f96290eb39
bump-formula|cask-pr: do not allow to bump autobumped packages
Avoids:
- Bumping stuff by mistake that will get autobumped anyway
- Abusing the system to get "free" commits
2024-03-01 09:15:43 +00:00
Mike McQuaid
f1eea64523
Merge pull request #16779 from reitermarkus/fix-load-from-path
Fix loading casks/formulae from relative paths.
2024-03-01 08:47:41 +00:00
Mike McQuaid
0e1c1e3435
Merge pull request #16777 from reitermarkus/tap-sig-3
Simplify `Tap#formula_files_by_name`.
2024-03-01 08:41:33 +00:00
Mike McQuaid
98f6ab2bbc
Merge pull request #16775 from reitermarkus/tap-sig-2
Simplify `Tap#cask_files_by_name`.
2024-03-01 08:40:44 +00:00
Kevin
99baaf350d
Merge pull request #16781 from Homebrew/remove-ability-to-skip-dupe-pr-check-in-autobump
Remove ability to skip the duplicate PR check in autobump
2024-02-29 21:14:59 -08:00
Kevin
4ea6a8ccbb Remove ability to skip the duplicate PR check in autobump
This simply removes the environment variable check. The code was disabled in core around two weeks ago in https://github.com/Homebrew/homebrew-core/pull/163023. We need this PR to land first as explained in https://github.com/Homebrew/actions/pull/506#issuecomment-1972489707 to unblock other PRs.
2024-02-29 20:47:28 -08:00
Markus Reiter
3da0f8c4a6
Fix loading casks/formulae from relative paths. 2024-03-01 04:05:15 +01:00
Markus Reiter
2a78eba1ad
Simplify Tap#formula_files_by_name. 2024-02-29 22:48:50 +01:00
Markus Reiter
755c8aecad
Simplify Tap#cask_files_by_name. 2024-02-29 22:47:43 +01:00
Michael Cho
977ac20b2b
Merge pull request #16731 from cho-m/setuptools
docs: update info on setuptools for Python 3.12
2024-02-29 14:17:02 -05:00
Michael Cho
79bbad9b38
utils/pypi: default to formula version when using package_name
Signed-off-by: Michael Cho <michael@michaelcho.dev>
2024-02-29 13:48:43 -05:00
Issy Long
7e5f308668
Merge pull request #16769 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-1.61.0 2024-02-29 17:58:23 +00:00
Patrick Linnane
faf399716f
Fix Style/RedundantLineContinuation offenses
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-02-29 09:26:51 -08:00
Mike McQuaid
afcf059100
Merge pull request #16770 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-ast-1.31.0
build(deps-dev): bump rubocop-ast from 1.30.0 to 1.31.0 in /Library/Homebrew
2024-02-29 17:26:16 +00:00
BrewTestBot
da61a89ca1
Update RBI files for rubocop-ast.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-02-29 17:15:33 +00:00
BrewTestBot
cfb974e122
brew vendor-gems: commit updates. 2024-02-29 17:15:18 +00:00
dependabot[bot]
3fc1325161
build(deps-dev): bump rubocop-ast in /Library/Homebrew
Bumps [rubocop-ast](https://github.com/rubocop/rubocop-ast) from 1.30.0 to 1.31.0.
- [Release notes](https://github.com/rubocop/rubocop-ast/releases)
- [Changelog](https://github.com/rubocop/rubocop-ast/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-ast/compare/v1.30.0...v1.31.0)

---
updated-dependencies:
- dependency-name: rubocop-ast
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-29 17:13:46 +00:00
BrewTestBot
fcfd8cfde6
Update RBI files for rubocop.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-02-29 17:13:24 +00:00
BrewTestBot
477c58ab60
brew vendor-gems: commit updates. 2024-02-29 17:12:42 +00:00
dependabot[bot]
e7414bc20b
build(deps-dev): bump rubocop from 1.60.2 to 1.61.0 in /Library/Homebrew
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.60.2 to 1.61.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop/compare/v1.60.2...v1.61.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-02-29 17:10:39 +00:00
Mike McQuaid
2aa8040265
Merge pull request #16768 from Homebrew/parse-source-checksum-correctly-in-json-v3
internal json v3: parse ruby source checksum correctly
2024-02-29 10:45:28 +00:00
Mike McQuaid
136c50a52a
Merge pull request #16753 from cho-m/pypi-only-resources
utils/pypi: allow only updating `extra_packages`
2024-02-29 10:42:42 +00:00
Mike McQuaid
0604b5e9a8
Merge pull request #16767 from cho-m/bump-sync-msg-all-latest
dev-cmd/bump: hide version syncing when empty list
2024-02-29 10:42:06 +00:00
Mike McQuaid
8a846fb1c2
Merge pull request #16766 from reitermarkus/tap-installed
Only show installed taps in `brew tap` output.
2024-02-29 10:35:19 +00:00
apainintheneck
cd5b93a2f2 internal json v3: parse ruby source checksum correctly
Currently we are including this in the API but not actually
parsing and loading it correctly from the JSON. I think this
was an oversight when addressing feedback and refactoring
the JSON shape. Not a big deal, of course, because I'm the
only person using it right now.

I found this out while testing installs using the API and I got
this error while running `brew reinstall tree`.

```
Warning: Cannot verify integrity of '60fc4212023d3fef00e6de4b9f3f0d63402cf3eca00778d09f4f2d3481b524a1--tree.rb'.
No checksum was provided.
```
2024-02-28 21:34:31 -08:00
Kevin
154a21706a
Merge pull request #16638 from apainintheneck/load-internal-json-v3
Load internal json v3
2024-02-28 19:46:14 -08:00