31087 Commits

Author SHA1 Message Date
Bo Anderson
61a73014d3 os/mac/xcode: support Xcode 15.1 2023-12-23 00:55:50 +00:00
Bo Anderson
04ad24efe8 os/mac/xcode: add fast path for Xcode version detection 2023-12-23 00:49:36 +00:00
apainintheneck
857ab132a2 cmd/config: limit tap info output
We really only need to see info that is surprising or out of the norm.
For that reason, we can skip showing the tap remote and the tap branch
if they are what we expect them to be.
2023-12-22 10:39:29 -08:00
Mike McQuaid
0b804d4ab0
Merge pull request #16384 from apainintheneck/fix-cask-all
Fix Cask::Cask.all bug
2023-12-22 08:52:01 +00:00
apainintheneck
536b37c766 cmd/config: Add core cask tap to output
This information is occasionally useful when debugging so we should
include it by default to make our lives easier.
2023-12-21 22:54:38 -08:00
apainintheneck
b79778229c Resolve Cask::Cask.all todo
Now it takes the :eval_all parameter that means we can remove
ARGV handling inside Cask::Cask.all.
2023-12-21 21:55:16 -08:00
apainintheneck
5a674c232f Fix Cask::Cask.all bug
We were only loading casks from files with this command which,
of course, didn't work for casks that can only be loaded from
the API (when the core cask tap is not tapped). This changes
things to align more with what we do for formulae.
2023-12-21 21:39:58 -08:00
Issy Long
fb124f92ed
Ignore non-zap trash methods 2023-12-22 00:41:56 +00:00
Issy Long
b9f13fc35d
Better detection and replacement of non-alphabetized arrays
- Use `sort_by` to sort the array, rather than comparing each element
  to the next.
- This doesn't error with complaints about clobbering at all when run on
  `homebrew/cask`, hurray. And it also handles interpolations correctly,
  rather than ignoring them.

Co-authored-by: Bevan Kay <email@bevankay.me>
2023-12-22 00:26:38 +00:00
Issy Long
f34accfcde
Make the test expect_offense calls consistent with other tests 2023-12-22 00:20:02 +00:00
Issy Long
f4754baa00
Ignore zap trash stanzas with interpolation
- Interpolating the version into a path is a common pattern, but the interpolations
  trip up the alphabetization autocorrect quite spectacularly, so let's
  ignore them (for now?).
2023-12-22 00:19:03 +00:00
Michael Cho
53accccfb2
formula_cellar_checks: detect cpuid in static libs 2023-12-21 12:08:18 -05:00
Mike McQuaid
f093c27a17
Merge pull request #16376 from MikeMcQuaid/cask_on_system_conditionals_fix
rubocops/cask/on_system_conditionals: allow blocks.
2023-12-21 10:12:00 +00:00
Mike McQuaid
82edf71cf6
Merge pull request #16368 from Kentzo/prefer_sudo_as_root
sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER.
2023-12-21 10:08:25 +00:00
Mike McQuaid
a21b2dc833
rubocops/cask/on_system_conditionals: allow blocks.
Without this, there's an infinite loop on `brew style --fix` if you have
a `if Hardware::CPU.arm?` in a `postflight` block where it will change
back and forward between `if` and `on_os` syntax forever.
2023-12-21 10:00:46 +00:00
Ilya Kulakov
5f7db2b732
Fix syntax errors.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-12-21 01:16:09 -08:00
Issy Long
73b3ace77c
Apparently N is alphabetically before c; downcase the comparison 2023-12-21 01:25:18 +00:00
BrewTestBot
f614442d89
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-12-21 00:25:44 +00:00
Mike McQuaid
228b1d62ed
cask/artifact/abstract_uninstall: handle signal failures.
If the process is running as another user: this will always fail.
2023-12-20 19:43:46 +00:00
Ilya Kulakov
4783c5b9fe Fix syntax errors. 2023-12-20 10:05:43 -08:00
Ilya Kulakov
9b672b0e45 sudo: sudo_as_root should apply on top of HOMEBREW_SUDO_THROUGH_SUDO_USER
System commands run with sudo_as_root must be run as  regardless of who is running sudo.
2023-12-20 09:39:10 -08:00
Ilya Kulakov
f71189ae4d Revert "sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER."
This reverts commit 907da26e335b84c29b159d082fdc6ee23fcfba69.
2023-12-20 09:36:46 -08:00
Mike McQuaid
dde0411e02
Merge pull request #16369 from cho-m/std_configure_args-prefix
formula: allow changing `std_configure_args` prefix
2023-12-20 16:12:36 +00:00
Michael Cho
3e428f7676
formula_auditor: split out checksum check 2023-12-20 10:22:26 -05:00
Michael Cho
2b58d9d9a1
formula: allow changing std_configure_args prefix 2023-12-20 10:08:27 -05:00
Mike McQuaid
4d93a50ad6
Merge pull request #16364 from cho-m/pybuild-rubocopy
rubocops/lines: consistency with single non-runtime Python
2023-12-20 11:57:17 +00:00
Ilya Kulakov
907da26e33 sudo: Prioritize sudo_as_root over HOMEBREW_SUDO_THROUGH_SUDO_USER. 2023-12-19 22:39:44 -08:00
Rylan Polster
f61ef4be2f
Merge pull request #16351 from Rylan12/rubocop-for-cask-discontinued
Create rubocop requiring `deprecate!` over `discontinued` for casks
2023-12-19 21:00:58 -05:00
Rylan Polster
841a0623c6
Don't have a comment saying to remove this cop 2023-12-19 20:47:20 -05:00
Michael Cho
326774faee
utils/pypi: use python from formula
Sometimes the Python dependency tree will be impacted by the exact
version of Python being used (most commonly relating to functionality
provided/missing from stdlibs like `importlib-metadata` and `tomllib`)
2023-12-19 20:09:09 -05:00
Issy Long
8cf58e36e6
Add a new RuboCop for alphabetizing zap trash array elements
- Part of issue 16323.
- Previously this was being done manually by Cask maintainers.
- While we're here, enforce that the `zap trash` path is not in `[]` if
  it only contains a single element.
- This is buggy on actual Casks, hence the draft PR.
2023-12-19 23:42:08 +00:00
Michael Cho
61b512c72c
rubocops/lines: consistency with single non-runtime Python 2023-12-19 15:20:45 -05:00
Mike McQuaid
23ce2d5bf8
Merge pull request #16362 from Homebrew/dependabot/bundler/Library/Homebrew/tapioca-0.11.14
build(deps-dev): bump tapioca from 0.11.13 to 0.11.14 in /Library/Homebrew
2023-12-19 18:05:34 +00:00
BrewTestBot
2343f500c1
Update RBI files for rdiscount.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-19 17:51:21 +00:00
BrewTestBot
d41dfb328c
Update RBI files for tapioca.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-19 17:50:12 +00:00
BrewTestBot
c96e162172
brew vendor-gems: commit updates. 2023-12-19 17:45:51 +00:00
BrewTestBot
4fb44306fd
brew vendor-gems: commit updates. 2023-12-19 17:44:22 +00:00
dependabot[bot]
91b9f6c83d
build(deps-dev): bump rdiscount in /Library/Homebrew
Bumps [rdiscount](https://github.com/davidfstr/rdiscount) from 2.2.7.1 to 2.2.7.2.
- [Changelog](https://github.com/davidfstr/rdiscount/blob/master/CHANGELOG.md)
- [Commits](https://github.com/davidfstr/rdiscount/compare/2.2.7.1...2.2.7.2)

---
updated-dependencies:
- dependency-name: rdiscount
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-19 17:41:24 +00:00
dependabot[bot]
c8e89eee2e
build(deps-dev): bump tapioca in /Library/Homebrew
Bumps [tapioca](https://github.com/Shopify/tapioca) from 0.11.13 to 0.11.14.
- [Release notes](https://github.com/Shopify/tapioca/releases)
- [Commits](https://github.com/Shopify/tapioca/compare/v0.11.13...v0.11.14)

---
updated-dependencies:
- dependency-name: tapioca
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-19 17:41:15 +00:00
Mike McQuaid
38c5e52a6d
Merge pull request #16358 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-performance-1.20.0
build(deps-dev): bump rubocop-performance from 1.19.1 to 1.20.0 in /Library/Homebrew
2023-12-19 12:01:48 +00:00
Akihiro Suda
009318dcaf
cleaner: remove *.tbd
For https://github.com/Homebrew/brew/pull/16355#issuecomment-1860642797

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
2023-12-19 19:05:28 +09:00
Patrick Linnane
9dee80cb2d
various: fix style errors 2023-12-18 09:34:01 -08:00
BrewTestBot
f04d777c85
Update RBI files for rubocop-performance.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-18 17:09:12 +00:00
BrewTestBot
5c01bc34d3
brew vendor-gems: commit updates. 2023-12-18 17:03:04 +00:00
dependabot[bot]
311b268340
build(deps-dev): bump rubocop-performance in /Library/Homebrew
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-performance/compare/v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-18 16:59:59 +00:00
BrewTestBot
5636457248
Update RBI files for rubocop-rails.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-18 16:33:14 +00:00
BrewTestBot
7b9b49d11f
brew vendor-gems: commit updates. 2023-12-18 16:29:36 +00:00
dependabot[bot]
aa09726d00
build(deps-dev): bump rubocop-rails in /Library/Homebrew
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.22.2 to 2.23.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.22.2...v2.23.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-18 16:26:45 +00:00
Bo Anderson
b72421e258
Merge pull request #16352 from Rylan12/fix-cask-discontinued-api-generation
Re-add some `discontinued?` checks for casks
2023-12-18 01:42:21 +00:00
Rylan Polster
fe74f5925a
Merge pull request #16353 from Homebrew/sorbet-files-update
sorbet: Update RBI files.
2023-12-17 20:38:03 -05:00