38785 Commits

Author SHA1 Message Date
BrewTestBot
1359ebc025
sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow.
2023-12-18 00:27:17 +00:00
Eric Knibbe
eb5f7fb32b
Merge pull request #16314 from EricFromCanada/bump-skipped-deprecated-disabled 2023-12-17 19:20:54 -05:00
Rylan Polster
25b753fe51
Re-add some discontinued? checks for casks 2023-12-17 19:07:37 -05:00
Eric Knibbe
4259e2ad96
cmd/bump: indicate deprecated or skipped formulae/casks 2023-12-17 16:50:02 -05:00
Rylan Polster
8d8cd23414
Add rubocop to enforce deprecate! over discontinued 2023-12-17 16:49:53 -05:00
Rylan Polster
254fcf7c1f
Update livecheck test fixtures to use deprecate! and disable! 2023-12-17 16:31:04 -05:00
Rylan Polster
4793677123
Merge pull request #16292 from Rylan12/cask-deprecate-disable
Add `deprecate!` and `disable!` to casks
2023-12-17 15:03:39 -05:00
Mike McQuaid
3431996146
Merge pull request #16350 from Homebrew/sponsors-maintainers-man-completions
Update manpage and completions.
2023-12-17 15:59:48 +00:00
Mike McQuaid
fb7f1a2c4d
Merge pull request #16349 from unshare/homepage-ua
Work around recent Akamai/Microsoft issues
2023-12-17 15:58:01 +00:00
BrewTestBot
4470edd1f2
Update manpage and completions.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2023-12-17 15:35:39 +00:00
Mike McQuaid
4776c191da
Merge pull request #16345 from razvanazamfirei/update-cask-documentation
create: modify cask template
2023-12-17 15:34:44 +00:00
Mike McQuaid
7dfbaec9d4
docs/Acceptable-Casks: capitalise Apple Silicon. 2023-12-17 15:22:44 +00:00
Issy Long
7e328d8f0a
Merge pull request #16346 from issyl0/dont-forget-about-rubocop-comments
Fix new `Style/MutableConstant` RuboCop offenses for Ruby 3.1
2023-12-17 10:58:33 +00:00
Rylan Polster
c21b8bd68a
Fix deprecation message
Co-authored-by: Bo Anderson <mail@boanderson.me>
2023-12-16 23:10:20 -05:00
Rylan Polster
6431822e7b
Apply feedback 2023-12-16 20:18:35 -05:00
Rylan Polster
472dd95b16
Fix cask loading from the API
Co-authored-by: Kevin <apainintheneck@gmail.com>
2023-12-16 20:08:26 -05:00
Rylan Polster
c5f33aaf99
Load nil reasons from API correctly 2023-12-16 20:01:47 -05:00
Rylan Polster
40d3ab6a5d
Add tests and fix brew typecheck 2023-12-16 20:01:47 -05:00
Rylan Polster
7eb3f1a314
Replace discontinued? with deprecated? 2023-12-16 20:01:47 -05:00
Rylan Polster
53c1e6ecdb
Add deprecate! and disable! to cask stanza order 2023-12-16 20:01:47 -05:00
Rylan Polster
641a80475e
Update cask logic to handle deprecations and disables 2023-12-16 20:01:47 -05:00
Rylan Polster
036723a668
Add deprecate! and disable! methods to the Cask DSL 2023-12-16 20:01:46 -05:00
Valentin Kulesh
06155ff6e0
Work around recent Akamai/Microsoft issues
At the moment, Microsoft Office and related casks fail audit due to
failure to fetch a product homepage from the main Microsoft site
(https://www.microsoft.com/) served by Akamai CDN.
The failure is severe and weird: no status code is received as the
connection is reset.
The analysis revealed the issue is linked to `User-Agent` and
`Accept-Language` headers parsing. Homebrew uses involved user agent
strings and has language hardcoded as `en`.
The simplest workaround is to use a simple user agent string when checking
homepage availability if the cask is in an audit exceptions list.

Merging this would fix Microsoft Office updates (including
https://github.com/Homebrew/homebrew-cask/pull/162671)
2023-12-16 22:20:17 +03:00
Bo Anderson
a60c58c798
Merge pull request #16347 from jeroen/upload-artifact
Fix "an artifact with this name already exists on the workflow run"
2023-12-16 13:50:34 +00:00
Jeroen Ooms
29cf01d442 Fix workflow for duplicate names 2023-12-16 14:36:12 +01:00
Issy Long
149b0e4f31
Fix new Style/MutableConstant RuboCop offenses for Ruby 3.1
- A follow-up to de592af20bbff5bcb548d2474f0722e59ff1129a, resetting the previous disabled comments too.
2023-12-16 11:57:06 +00:00
Mike McQuaid
29d1be9e9a
Merge pull request #16335 from samford/separate-stable-version-audit
FormulaAuditor: Separate stable version audit
2023-12-15 22:43:38 +00:00
Sam Ford
4a4f8cb2d2
FormulaAuditor: Add #committed_version_info method
The `#audit_stable_version` check was previously part of
`#audit_revision_and_version_scheme` and duplicates some of the
logic to identify previous version information. To avoid the
duplication, this extracts the logic into a `#committed_version_info`
method that can be called in both audits. The method stores the
information in instance variables, so we don't repeat the collection
process if it has already run.
2023-12-15 17:29:32 -05:00
Sam Ford
ccbde5952d
FormulaAuditor: Separate stable version audit
The "stable version should not decrease" formula audit currently
prevents us from being able to create bottles when downgrading a
formula version. We previously worked around this by bumping
`version_scheme` but this wasn't an intended use case and we now
avoid using it for this purpose.

We can handle simple formula downgrades by reverting changes in a
syntax-only PR but that isn't sufficient when we need new bottles
(i.e., if additional changes have been made to the formula in the
interim time). In the latter case, the only available solution may be
to revert all changes made after the previous version using a
syntax-only PR and then create another PR to reintroduce the other
changes and create new bottles.

To avoid the aforementioned approach, this splits the stable version
audit into a separate method, so we can use `brew audit
--except=stable_version` to selectively skip it.
2023-12-15 17:27:01 -05:00
Razvan Azamfirei
cbe2c1d5c5
docs: update documentation 2023-12-15 15:49:05 -05:00
Razvan Azamfirei
ae1c058f9b
create: modify cask template 2023-12-15 15:34:43 -05:00
Bo Anderson
af7f12b1bd
Merge pull request #16344 from Homebrew/dependabot/bundler/Library/Homebrew/ruby-prof-1.6.3
build(deps-dev): bump ruby-prof from 1.4.3 to 1.6.3 in /Library/Homebrew
2023-12-15 19:36:52 +00:00
Bo Anderson
93865bf53e
Gemfile: remove ruby-prof bound 2023-12-15 19:24:05 +00:00
BrewTestBot
f555f1ec21
Update RBI files for ruby-prof.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2023-12-15 19:00:10 +00:00
BrewTestBot
d3d46a57e6
brew vendor-gems: commit updates. 2023-12-15 18:54:36 +00:00
dependabot[bot]
a94fcd4923
build(deps-dev): bump ruby-prof from 1.4.3 to 1.6.3 in /Library/Homebrew
Bumps [ruby-prof](https://github.com/ruby-prof/ruby-prof) from 1.4.3 to 1.6.3.
- [Changelog](https://github.com/ruby-prof/ruby-prof/blob/master/CHANGES)
- [Commits](https://github.com/ruby-prof/ruby-prof/compare/1.4.3...1.6.3)

---
updated-dependencies:
- dependency-name: ruby-prof
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-15 18:51:14 +00:00
Bo Anderson
2157fb06a8
Merge pull request #16338 from Bo98/update-everything
Update all dependencies
2023-12-15 18:07:27 +00:00
Bo Anderson
89531e9ff3
Update all dependencies 2023-12-15 16:24:46 +00:00
Mike McQuaid
dc3daf77a5
Merge pull request #16341 from issyl0/rubocop-ruby-3.1
rubocop: Set TargetRubyVersion to 3.1 & disable all cops that fail
2023-12-15 08:32:06 +00:00
Issy Long
de592af20b
rubocop: Set TargetRubyVersion to 3.1 & disable all cops that fail
- As discussed in
  https://github.com/Homebrew/brew/pull/16337#issuecomment-1855668516,
  then we won't have the chicken/egg problem of fixing cops for syntax
  that's unsupported on Ruby 2.6 _before_ we set the TargetRubyVersion
  to 3.1, but if we set it too early then all the taps will fail.
2023-12-14 23:19:43 +00:00
Bo Anderson
e269d273e1
Merge pull request #16339 from Homebrew/dependabot/github_actions/actions/download-artifact-4
build(deps): bump actions/download-artifact from 3 to 4
2023-12-14 18:49:06 +00:00
dependabot[bot]
7af13623fb
build(deps): bump actions/upload-artifact from 3 to 4
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](https://github.com/actions/upload-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-14 18:34:44 +00:00
dependabot[bot]
95a68a1d04
build(deps): bump actions/download-artifact from 3 to 4
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](https://github.com/actions/download-artifact/compare/v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-14 18:30:39 +00:00
Mike McQuaid
a04d8a3e12
Merge pull request #16336 from Bo98/style-fixes-dec2023
Fix style violations under newer RuboCop
2023-12-14 09:24:03 +00:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop 2023-12-14 05:47:12 +00:00
Mike McQuaid
2e9d7fbcf8
Merge pull request #16332 from Homebrew/dependabot/github_actions/github/codeql-action-3
build(deps): bump github/codeql-action from 2 to 3
2023-12-13 19:12:32 +00:00
dependabot[bot]
18f63869be
build(deps): bump github/codeql-action from 2 to 3
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2 to 3.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/v2...v3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-12-13 18:23:57 +00:00
Mike McQuaid
2e3f110c83
Merge pull request #16331 from MikeMcQuaid/untap_tap
cmd/untap: be more careful about formula tap.
2023-12-13 15:41:10 +00:00
Mike McQuaid
fbd3d4e48a
cmd/untap: be more careful about formula tap.
`Formula#any_version_installed?` doesn't consider taps so we need to
manually check the tabs from the kegs instead.

See https://github.com/Homebrew/brew/pull/16330#issuecomment-1854007492
onwards for relevant discussion.
2023-12-13 15:24:37 +00:00
Mike McQuaid
bd378a7b25
Merge pull request #16330 from MikeMcQuaid/untap_exceptions
cmd/untap: fix untapping syntax failure.
2023-12-13 14:09:44 +00:00