945 Commits

Author SHA1 Message Date
Bo Anderson
a06d136d2c
Move Sorbet gems into an optional group 2021-06-11 08:10:30 +01:00
Mike McQuaid
c4d69dd2e9
Revert "fix(vendor-gems): redirect bundler stdout to stderr" 2021-06-07 14:51:07 +01:00
Gibson Fahnestock
07d571bebc
fix(vendor-gems): redirect bundler stdout to stderr
When running brew commands and interpreting the output, e.g. running
`brew livecheck --json`, it's necessary to stop other programs Homebrew
happens to execute from writing logging output to stdout. Most programs
don't do this, but `bundle install` does seem to.

To reproduce the issue you can run:

```shell
git -C "$(brew --prefix)" clean -ffdx Library/Homebrew/vendor
stdout=$(HOMEBREW_FORCE_VENDOR_RUBY=1 brew livecheck --newer-only --json --cask $(brew --repo homebrew/cask)/Casks/grid.rb)
echo "^^^ was stderr, >>> is stdout: $stdout"
```

If you run it without this change it will print a bunch of output like
this to the stdout before printing out the livecheck JSON output:

```text
Using bundler 1.17.3
Fetching byebug 11.1.3
Fetching coderay 1.1.3
Installing byebug 11.1.3 with native extensions
Installing coderay 1.1.3
Fetching colorize 0.8.1
Installing colorize 0.8.1

[
  # Contents of the JSON block.
]
```

With this change the stdout from `bundle install` will be redirected to
brew's stderr, meaning only the JSON goes to stdout, and the rest goes
to stderr.
2021-06-03 11:18:23 +01:00
Mike McQuaid
aa937b9024
Merge pull request #11474 from cho-m/fix-tar-validation
utils/tar: fix validation for tar without directory or extensions
2021-06-02 14:06:17 +01:00
hyuraku
90c02f7b5a change https://api.github.com to API_URL 2021-06-02 21:13:53 +09:00
Michael Cho
9e29c6eac2
utils/tar: fix validation for tar without directory or extensions 2021-06-01 12:53:25 -07:00
Rylan Polster
9f5afcbf63
Merge pull request #11381 from cnnrmnn/fix-range-requests
Fix range requests with `curl`
2021-05-15 16:40:20 -04:00
Nanda H Krishna
389f289770
utils/pypi: use opt_bin for pipgrip 2021-05-15 23:14:34 +05:30
Connor Mann
a079ba9bb3 Add parentheses for clarity 2021-05-14 15:28:56 -04:00
Connor Mann
2a9540b3ab
Check for key explicitly with key?
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-05-14 15:16:37 -04:00
Connor Mann
b546960da9 Revert "Update Library/Homebrew/utils/curl.rb"
This reverts commit ecaaafba203578498fbc0a48493adea1790839f2.
2021-05-14 15:14:56 -04:00
Connor Mann
f7fe111430
Use blank? instead of checking for nil 2021-05-14 11:53:49 -04:00
Connor Mann
2500b8daba
Update Library/Homebrew/utils/curl.rb
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-05-14 11:47:38 -04:00
Connor Mann
ecaaafba20
Update Library/Homebrew/utils/curl.rb
Co-authored-by: Rylan Polster <rslpolster@gmail.com>
2021-05-14 11:16:35 -04:00
Connor Mann
b79aeab8b2
Update Library/Homebrew/utils/curl.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-05-14 09:55:45 -04:00
Connor Mann
85702dfe53
Update Library/Homebrew/utils/curl.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2021-05-14 09:55:40 -04:00
cnnrmnn
b406e0b35a Update call sites 2021-05-14 09:53:29 -04:00
cnnrmnn
86bce7bf1d Stop unnecessarily dumping headers 2021-05-14 09:50:57 -04:00
cnnrmnn
a156621297 Simplify header parsing 2021-05-14 09:44:05 -04:00
cnnrmnn
16e7072543 Fix argument order 2021-05-13 12:53:57 -04:00
cnnrmnn
7637fd5366 Only use continue-at with partial requests 2021-05-13 12:28:34 -04:00
cnnrmnn
df0915e33f Check partial request support with Accept-Ranges 2021-05-13 12:11:34 -04:00
cnnrmnn
b9b917756c Add header parsing 2021-05-13 11:42:28 -04:00
cnnrmnn
aa989bd55a Change inititial partial request to HEAD request 2021-05-13 11:39:59 -04:00
Mike McQuaid
b914411ac8
Delete Bintray code
Remove all code related to Bintray. It no longer works so there's no
point keeping it around.

Some of this could arguably be deprecated/disabled first/instead but:
I'm not sure I see the sense in keeping stuff around that's known to be
broken.
2021-05-12 13:37:18 +01:00
Bo Anderson
92cf904719
Merge pull request #11362 from Bo98/json-tab-write
formula_installer: write tab when pouring local --only-json-tab bottles
2021-05-11 22:10:18 +01:00
Bo Anderson
33e1255f65
formula_installer: write tab when pouring local --only-json-tab bottles 2021-05-11 14:28:12 +01:00
David Xia
7920006020
fix: use recommended way of updating Fish shell $PATH
fixes https://github.com/Homebrew/brew/issues/8965

See Fish docs https://fishshell.com/docs/current/tutorial.html#path.

> A faster way is to use the `fish_add_path function`... The advantage is that
> you don't have to go mucking around in files: just run this once at the
> command line, and it will affect the current session and all future instances
> too.
>
> Or you can modify `$fish_user_paths` yourself, but you should be careful not
> to append to it unconditionally in config.fish, or it will grow longer and
> longer.
2021-05-08 21:19:19 -07:00
Bo Anderson
d15cb8a83d
utils/ruby.sh: fix Ruby path searching 2021-05-05 22:59:24 +01:00
Mike McQuaid
5d67709cb6
Merge pull request #11214 from hyuraku/utils_repair_style
Utils repair style
2021-04-23 14:17:22 +01:00
Mike McQuaid
d81b898117
utils/curl: tweak style. 2021-04-22 13:57:28 +01:00
Kenneth Chew
af594739dc
audit: specify which URL has a content problem in problem message 2021-04-22 13:52:18 +01:00
hyuraku
2b6afea8ed utils/ruby.sh: repair style 2021-04-21 22:19:35 +09:00
hyuraku
d3b07d078f utils/analytics.sh: repair style 2021-04-21 21:12:27 +09:00
hyuraku
05260f4565 utils/lock.sh: repair style 2021-04-21 20:51:50 +09:00
Dawid Dziurla
4a183cf109
Merge pull request #11158 from dawidd6/bump-fork-org
bump-formula-pr: add --fork-org flag
2021-04-17 14:18:39 +02:00
Dawid Dziurla
63be66408e
bump-formula-pr: add --fork-org flag 2021-04-17 09:53:15 +02:00
Mike McQuaid
b57fe84f81
Use long/readable tar flags.
Also, use `--no-same-permissions` instead of `-o` (which does nothing
without `-p` being passed and run as `root`) for the more explicit
description of the behaviour we want.
2021-04-16 14:05:06 +01:00
Mike McQuaid
96cd1c058e
utils/bottles: tweak/improve some of the API. 2021-04-16 14:05:05 +01:00
Bo Anderson
635e58e9aa
software_spec: fix bottle domain fallback handling 2021-04-15 19:24:25 +01:00
Mike McQuaid
75592cbebc
Better handle brew bottle --only-json-tab bottles
- test them in `brew test-bot` (before we do so in homebrew/core)
- don't fail if we cannot find the tab/install receipt in a bottle
- cache listing the files in a bottle so we don't do it more times than
  necessary
- fix resolution of version and formula names from a bottle if we're
  getting them from a bottle without a tab/install receipt

This will need to be in a tagged release before we can ship tab-less
bottles to users.
2021-04-13 14:26:31 +01:00
Mike McQuaid
6f071a06f8
Use JSON.pretty_generate
It's dramatically more human readable for very little difference in
space.
2021-04-09 15:44:37 +01:00
Mike McQuaid
1d34f7f2fa
Merge pull request #11077 from MikeMcQuaid/any_bottles
Support `all: SHA256` bottles.
2021-04-09 10:18:19 +01:00
Mike McQuaid
0cb1645d25
bottles: support :all tag.
This allows the creation of bottles which will be used by any macOS
version, architecture or OS (i.e. macOS or Linux).

Add `TODO` stubs for where the bottle generation logic should be
implemented.
2021-04-09 09:50:16 +01:00
Mike McQuaid
6b5213286c
Rename "exact" tag match to "no_older_versions"
This is more specific about the behaviour we want to have in future.
2021-04-09 09:36:18 +01:00
Mike McQuaid
d73351251c
Deprecate, disable, delete code for next major/minor version.
Do the usual dance for bumping our major/minor version.
2021-04-09 09:30:36 +01:00
Bo Anderson
20d86c0185
Refactor some tag handling into a Utils::Bottles::Tag class 2021-04-08 17:23:57 +01:00
Rylan Polster
95a5c58eee
Merge pull request #10847 from jonchang/github-pat-update
github/api: update personal access token format.
2021-04-05 19:43:43 -04:00
Rylan Polster
229e035a3d
Update PAT regex 2021-04-05 19:23:18 -04:00
Markus Reiter
cdcd216237
Revert "Revert "Merge pull request #10898 from reitermarkus/audit-timeout""
This reverts commit 0b8a9bc1a14d8513ab57423fe028d72a52b38b3d.
2021-04-03 20:10:33 +02:00