32085 Commits

Author SHA1 Message Date
Rylan Polster
842b4ac3d3
Improve VS Code debugger support 2024-08-15 11:47:31 -04:00
Douglas Eichelberger
70b072a7d0 Suppress sorbet type errors when using `undef' 2024-08-15 08:03:45 -07:00
Rylan Polster
dd8334bf83
Merge pull request #18050 from Homebrew/rdbg 2024-08-15 10:28:54 -04:00
Rylan Polster
0b5130937f
Update debugger to fail without portable ruby 2024-08-15 10:14:52 -04:00
Carlo Cabrera
c42860cd3c
Merge pull request #18045 from Homebrew/linux-formula_installer-strict 2024-08-15 17:47:19 +08:00
Carlo Cabrera
9adf40bea2
Merge pull request #18046 from Homebrew/linux-keg-strict 2024-08-15 17:09:27 +08:00
Mike McQuaid
0c90fd9f08
Merge pull request #18054 from reitermarkus/disable-message 2024-08-15 09:52:01 +01:00
Rylan Polster
3b63a7eff4
Add brew debugger command 2024-08-14 22:56:26 -04:00
apainintheneck
f6a6979711 Verify more constants are not loaded at startup
Loading different constants can be tricky with all the requires in
Homebrew so we want to strengthen the existing checks to make
sure that things are not getting required when there is a performance
penalty. This expands the existing check to include more constants
beyond `Formula` that we don't expect to be defined and that pull
in a lot of other dependencies.
2024-08-14 19:08:31 -07:00
Markus Reiter
3342d5f99b
Fix message when disablement is in the past. 2024-08-14 21:31:01 +02:00
Mike McQuaid
02d414d79b
Merge pull request #18008 from Homebrew/deprecate-old-style-cmds 2024-08-14 07:45:13 +01:00
Douglas Eichelberger
5ca1f2579f Annotate AbstractCommand public API 2024-08-13 13:49:42 -07:00
Douglas Eichelberger
becb84fc65
Update Library/Homebrew/cli/parser.rb
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2024-08-13 13:03:48 -07:00
Patrick Linnane
9b33210241
Update io.rb
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-08-13 13:30:49 -06:00
Patrick Linnane
699d918d95
extend/os/linux/keg: use typed: strict
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-08-13 13:09:43 -06:00
Patrick Linnane
7e58233aaf
extend/os/linux/formula_installer: use typed: strict
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-08-13 12:56:01 -06:00
Patrick Linnane
ddd28e52e7
extend/io: use typed: strict
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-08-13 12:42:06 -06:00
Patrick Linnane
79d887afa2
Merge pull request #18042 from Homebrew/download-typed-strict 2024-08-13 12:36:59 -06:00
Patrick Linnane
31df4cff73
download: use typed: strict
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-08-13 12:23:33 -06:00
Patrick Linnane
89d1731f4c
formula_name_cask_token_auditor: use typed: strict
Signed-off-by: Patrick Linnane <patrick@linnane.io>
2024-08-13 12:04:31 -06:00
Bo Anderson
467666c8b3
unpack_strategy/dmg: fix UID handling 2024-08-13 17:50:34 +01:00
BrewTestBot
8bf6a01719
brew vendor-gems: commit updates. 2024-08-13 15:55:18 +00:00
dependabot[bot]
6bb898a4ce
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.11518 to 0.5.11519.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-13 15:53:43 +00:00
Rui Chen
1270eb37b1
formula_auditor: fix eol check
Co-authored-by: Ruoyu Zhong <zhongruoyu@outlook.com>
2024-08-13 16:36:38 +08:00
Mike McQuaid
aad48a01db
Merge pull request #18026 from Homebrew/vscode_tweaks 2024-08-13 08:13:19 +01:00
Bevan Kay
dcce0584bd
Revert "Make Cask::Artifact::Installer typesafe" 2024-08-13 08:24:20 +10:00
Douglas Eichelberger
32107f2cb3
Merge pull request #18020 from Homebrew/installer-safety
Make Cask::Artifact::Installer typesafe
2024-08-12 13:35:21 -07:00
William Woodruff
09c12d817e
Revert "attestation: specialize error when gh is old" 2024-08-12 15:53:17 -04:00
William Woodruff
aafa81b3d9
Merge pull request #17926 from Homebrew/ww/gh-too-old 2024-08-12 15:28:36 -04:00
William Woodruff
be8ee6ea22
fixup attestation_spec
Signed-off-by: William Woodruff <william@yossarian.net>
2024-08-12 15:10:18 -04:00
William Woodruff
30acccf4b3
attestation: disable if gh is too old
Signed-off-by: William Woodruff <william@yossarian.net>
2024-08-12 14:54:55 -04:00
Issy Long
807093f276
dev-cmd/typecheck: Support typechecking in taps
```shell
$ brew typecheck homebrew/bundle
No sorbet/ directory found. Maybe you want to run 'srb init'?

A type checker for Ruby

Usage:
  srb                                 Same as "srb t"
  srb (init | initialize)             Initializes the `sorbet` directory
  srb rbi [options]                   Manage the `sorbet` directory
  srb (t | tc | typecheck) [options]  Typechecks the code

Options:
  -h, --help     View help for this subcommand.
  --version      Show version.

For full help:
  https://sorbet.org
Check https://docs.brew.sh/Typechecking for more information on how to resolve these errors.
```
2024-08-12 18:14:22 +01:00
Mike McQuaid
46bf4d7948
Improve VSCode configuration
- Update outdated and add new recommended extensions
- Exclude some vendored code from search results by default
- Add more VSCode editor settings that are consistent with our linting
- Provide configuration for coverage visualization in VSCode but disable
  it by default
- Add SimpleCov coverage for `eval` and ensure that we always default to
  line coverage in case upstream defaults ever change
2024-08-12 17:36:14 +01:00
BrewTestBot
b25b897604
brew vendor-gems: commit updates. 2024-08-12 16:24:17 +00:00
dependabot[bot]
5c5fa8dbce
build(deps-dev): bump rexml from 3.3.4 to 3.3.5 in /Library/Homebrew
Bumps [rexml](https://github.com/ruby/rexml) from 3.3.4 to 3.3.5.
- [Release notes](https://github.com/ruby/rexml/releases)
- [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md)
- [Commits](https://github.com/ruby/rexml/compare/v3.3.4...v3.3.5)

---
updated-dependencies:
- dependency-name: rexml
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-08-12 16:22:51 +00:00
Issy Long
45978435e7
rubocop: Use Sorbet/StrictSigil as it's better than comments
- Previously I thought that comments were fine to discourage people from
  wasting their time trying to bump things that used `undef` that Sorbet
  didn't support. But RuboCop is better at this since it'll complain if
  the comments are unnecessary.

- Suggested in https://github.com/Homebrew/brew/pull/18018#issuecomment-2283369501.

- I've gone for a mixture of `rubocop:disable` for the files that can't
  be `typed: strict` (use of undef, required before everything else, etc)
  and `rubocop:todo` for everything else that should be tried to make
  strictly typed. There's no functional difference between the two as
  `rubocop:todo` is `rubocop:disable` with a different name.

- And I entirely disabled the cop for the docs/ directory since
  `typed: strict` isn't going to gain us anything for some Markdown
  linting config files.

- This means that now it's easier to track what needs to be done rather
  than relying on checklists of files in our big Sorbet issue:

```shell
$ git grep 'typed: true # rubocop:todo Sorbet/StrictSigil' | wc -l
    268
```

- And this is confirmed working for new files:

```shell
$ git status
On branch use-rubocop-for-sorbet-strict-sigils
Untracked files:
  (use "git add <file>..." to include in what will be committed)
        Library/Homebrew/bad.rb
        Library/Homebrew/good.rb

nothing added to commit but untracked files present (use "git add" to track)

$ brew style
Offenses:

bad.rb:1:1: C: Sorbet/StrictSigil: Sorbet sigil should be at least strict got true.
^^^^^^^^^^^^^

1340 files inspected, 1 offense detected
```
2024-08-12 15:24:27 +01:00
Mike McQuaid
c8732c6a94
Merge pull request #18001 from smsearcy/fix-fish-shellenv 2024-08-12 14:23:05 +01:00
Mike McQuaid
6105728c31
Merge pull request #18004 from Homebrew/more-srb-strict 2024-08-12 14:22:00 +01:00
Mike McQuaid
6b3cac7b89
Merge pull request #18019 from Homebrew/safe-try-new 2024-08-12 14:21:44 +01:00
Mike McQuaid
fd14deaebd
Merge pull request #18011 from Homebrew/more-srb-strict-cmd 2024-08-12 14:21:18 +01:00
Mike McQuaid
e3f8081f0a
Merge pull request #18010 from apainintheneck/refactor-method-to-remove-extra-tap-requires 2024-08-12 14:21:04 +01:00
Mike McQuaid
fa53e7b1e5
Merge pull request #18022 from bevanjkay/update-report 2024-08-12 08:56:14 +01:00
Mike McQuaid
457a408c4b
Merge pull request #18009 from reitermarkus/token-auditor 2024-08-12 08:52:15 +01:00
Mike McQuaid
f021b7f12e
Merge pull request #17999 from ntkme/curlrc-analytics 2024-08-12 08:42:38 +01:00
Issy Long
7047edcbdb
Too much find and replace
Co-authored-by: Bo Anderson <mail@boanderson.me>
2024-08-12 08:29:20 +01:00
Bevan Kay
0a9883a8dc
cmd/update-report: don't output cask updates on linux 2024-08-12 17:12:19 +10:00
Bevan Kay
7e04c96c29
cask/dsl/caveats: fix rosetta caveat printing 2024-08-12 16:52:05 +10:00
Douglas Eichelberger
c799f5f818 Allow Cask refs 2024-08-11 18:01:04 -07:00
Douglas Eichelberger
a41f15ede7 Make FromContentLoader.try_new typesafe 2024-08-11 17:10:55 -07:00
Douglas Eichelberger
52b25d71f5 Make Cask::Artifact::Installer typesafe 2024-08-11 16:56:20 -07:00