admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
16,117 Commits 15 Branches 471 Tags
Commit Graph

844 Commits

Author SHA1 Message Date
Markus Reiter
63c5bd96a0
Merge pull request #4486 from reitermarkus/container-refactoring 
Assimilate `Container`s with `UnpackStrategy`.
 2018-07-17 00:03:28 +02:00
Markus Reiter
e5865e7e7f Assimilate Containers with UnpackStrategy. 2018-07-16 23:50:45 +02:00
Markus Reiter
d069cc2ebc Move error to the right place. 2018-07-16 23:36:15 +02:00
Markus Reiter
82482f4787 Add support for self-extracting .exe archives. 2018-07-16 09:54:37 +02:00
Markus Reiter
c9c5d8e008 Change Container::me? to Container::can_extract?. 2018-07-16 09:16:50 +02:00
Markus Reiter
f92e3086ac
Merge pull request #4474 from reitermarkus/refactor-containers 
Refactor containers and automatically determine dependencies.
 2018-07-16 08:40:38 +02:00
commitay
eb1271304f cask upgrade: add message about auto_updates and :latest 2018-07-15 11:13:04 +10:00
commitay
6d1f99fa5f cask info: display auto_updates 2018-07-15 11:13:04 +10:00
Markus Reiter
b7e849799f
Merge pull request #4469 from reitermarkus/systemcommand-path 
Don’t expand `executable` path in `SystemCommand`.
 2018-07-14 22:45:43 +02:00
Markus Reiter
fdc250cac4 Refactor containers and automatically determine dependencies. 2018-07-14 22:32:26 +02:00
Markus Reiter
a9e109e31a Don’t expand executable path in SystemCommand. 2018-07-14 02:33:42 +02:00
commitay
ba929cd9e1 cask audit: check for latest with auto_updates 2018-07-12 19:22:47 +10:00
Mike McQuaid
459e2bfa48
Merge pull request #4455 from reitermarkus/heredocs 
Use more descriptive heredoc names.
 2018-07-12 09:30:35 +01:00
Markus Reiter
7762ce32aa Use more descriptive heredoc names. 2018-07-11 18:15:30 +02:00
Markus Reiter
20ec595cb2 Fix Installer not supporting plain executables. 2018-07-11 16:56:37 +02:00
Markus Reiter
44400db00a Don't let install_phase fail. 2018-07-11 16:46:33 +02:00
Markus Reiter
37f3a603ce Use env utility instead of with_env. 2018-07-11 16:46:33 +02:00
Markus Reiter
ae38c5d6d1 Fix SystemCommand PATH. 2018-07-11 15:58:38 +02:00
Markus Reiter
4e49e8de0d Fix SystemCommand :path. 2018-07-11 15:58:38 +02:00
Markus Reiter
c51189ae0e
Merge pull request #4363 from reitermarkus/external-cask-commands 
Simplify and fix external `brew cask` command detection.
 2018-07-11 11:26:40 +02:00
Markus Reiter
98bb073b46
Merge pull request #4265 from claui/fix-pkg-environment 
Fix PKG installer environment
 2018-07-11 08:25:19 +02:00
Markus Reiter
4ddb1123d7
Merge pull request #4426 from reitermarkus/refactor-system-command-plist 
Simplify `Hbc::SystemCommand::Result#plist`.
 2018-07-09 18:30:32 +02:00
Markus Reiter
fcf8cb24fd Remove unused incremental_hash method. 2018-07-06 23:14:34 +02:00
Markus Reiter
e7f950750e Simplify and fix external brew cask command detection. 2018-07-06 22:04:26 +02:00
Claudia
3dbb735f3c
Fix PKG installer environment 
This commit solves an issue where the environment handed to
`/usr/sbin/installer` is not the same as the environment used by the
graphical PKG installer.

This is evident in some post-install scripts, e. g. the
`component-10.pkg/Scripts/postinstall` script in the `dymo-label`
cask. The code says:

```
USER_ID=`id -u ${USER}`

launchctl bootstrap gui/$USER_ID /Library/LaunchAgents/com.dymo.dls.webservice.plist
```

The graphical installer will export e. g. `USER=alice`, and
everything works as intended.

However, `brew cask install` does not override `sudo`’s default,
which is `USER=ROOT`. This violates the assumptions in the script.

This commit fixes the issue by configuring `sudo` to override the
following environment variables with the proper user name:

- `LOGNAME`
- `USER`
- `USERNAME`
 2018-07-06 09:38:00 +02:00
Markus Reiter
e07eddc391 Simplify Hbc::SystemCommand::Result#plist. 2018-07-05 10:54:35 +02:00
commitay
44a78a12a9
Merge pull request #4344 from commitay/cask-audit-all-appcasts 
cask audit: check for devmate and hockeyapp appcasts
 2018-07-04 11:13:40 +10:00
Mike McQuaid
61a8c4d1fb
Merge pull request #4300 from apjanke/new-rubocop-version 
Upgrade to Rubocop 0.57.2
 2018-07-01 09:08:16 +01:00
Andrew Janke
e0a8a79921 Style fixes for Rubocop 0.57.1 2018-06-30 19:40:14 -04:00
Markus Reiter
20b990a19f Remove Cask#qualified_token. 2018-06-30 06:03:51 +02:00
Markus Reiter
df3d017739 Fix Cask#full_name. 2018-06-30 06:01:01 +02:00
commitay
b12498159b cask audit: check for devmate and hockeyapp appcasts 2018-06-28 23:17:05 +10:00
Markus Reiter
6a44c529e5 Readd functionality to list all casks. 2018-06-23 01:54:07 +02:00
commitay
41e27928c4
Merge pull request #4232 from commitay/cask-caveats 
cask fetch and upgrade: print caveats
 2018-06-21 11:51:29 +10:00
Markus Reiter
25542d7398
Merge pull request #4316 from reitermarkus/merge-search 
Merge `brew cask search` into `brew search`.
 2018-06-18 21:31:33 +02:00
Markus Reiter
c814199a79
Merge pull request #4320 from lucafavatella/brew-cask-doctor 
Fix `brew cask doctor` for non-standard installation location
 2018-06-18 16:30:23 +02:00
Markus Reiter
8c620d8b97 Redirect brew cask search to brew search. 2018-06-18 16:23:35 +02:00
Markus Reiter
da193d2f7e Merge brew cask search into brew search. 2018-06-18 16:23:35 +02:00
Vítor Galvão
9831e67452
Merge pull request #4346 from commitay/version-minor_patch 
cask dsl versions: add minor_patch
 2018-06-16 13:18:21 +01:00
commitay
c5bbf28dd6 cask dsl versions: add minor_patch 2018-06-15 22:40:33 +10:00
Luca Favatella
ece34dbe26 cask doctor: fix for non-standard installation location in ~ 
Symptom (relevant portions):
```
$ brew cask doctor
==> Homebrew-Cask Version
Homebrew-Cask 1.6.7-56-g9ebcef7
Homebrew/homebrew-cask (git revision fc24e; last commit 2018-06-09)
==> macOS
10.13.5
==> SIP
Enabled
...
==> Homebrew-Cask Install Location
<NONE>
==> Homebrew-Cask Staging Location
~/homebrew/Caskroom
...
==> Environment Variables
HOMEBREW_CASK_OPTS="--appdir=~/Applications"
LC_ALL="en_US.UTF-8"
PATH="/usr/bin:/bin:/usr/sbin:/sbin:~/homebrew/Library/Homebrew/shims/scm"
SHELL="/bin/bash"
Cask's Doctor Checkup: failed
 - The staging path ~/homebrew/Caskroom does not exist.
Error: There are some problems with your setup.
```

Analysis:

* The source code is
  [this](9ebcef785e/Library/Homebrew/cask/lib/hbc/cli/doctor.rb (L63-L66)).

* The issue is reproducible in `brew irb`:

```
$ ls -dl ~/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ ( cd ~ && pwd; )
/Users/luca
$ ls -dl /Users/luca/homebrew/Caskroom
drwxrwxr-x  10 luca  admin  340  9 Jun 16:22 /Users/luca/homebrew/Caskroom
$ brew irb
==> Interactive Homebrew Shell
Example commands available with: brew irb --examples
irb(main):001:0> Pathname.new("~/homebrew/Caskroom").exist?
=> false
irb(main):002:0> Pathname.new("/Users/luca/homebrew/Caskroom").exist?
=> true
```
 2018-06-14 23:58:03 +01:00
Luca Favatella
cac30f6186 cask doctor: delete unused render_* methods 2018-06-14 23:56:35 +01:00
Markus Reiter
b45996dada Don’t use ohai for SystemCommand output. 2018-06-14 22:45:20 +02:00
commitay
7a48e04d07 internal_audit_modified_casks: remove appcast 2018-06-11 13:15:32 +10:00
commitay
c3ac638b9f appcast: remove calculate_checkpoint 2018-06-11 13:15:32 +10:00
commitay
0980de4cb0 _appcast_checkpoint: remove 2018-06-11 13:15:30 +10:00
commitay
c68526ac09 audit: remove appcast checkpoints 2018-06-11 13:14:00 +10:00
Markus Reiter
1d27c5f79a Don't create Caskroom.path for tests. 2018-06-09 11:32:49 +02:00
Markus Reiter
767ebe6ab6 Fail brew cask upgrade early if Cask is not installed. 2018-06-09 11:27:44 +02:00
Markus Reiter
488149242b Remove Hbc.init. 2018-06-09 11:18:40 +02:00