32163 Commits

Author SHA1 Message Date
William Woodruff
38e47ea996
Merge pull request #17896 from Homebrew/ww/pypi-normalize 2024-07-29 10:38:14 -04:00
William Woodruff
de582fbdbf
resource_auditor: make typechecker happy
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-29 10:27:42 -04:00
William Woodruff
921fa5b6ed
resource_auditor: normalize PyPI names to kebab case before auditing
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-29 10:18:17 -04:00
Mike McQuaid
96cbc7bd6e
dev-cmd/release: add missing require. 2024-07-29 09:25:51 +01:00
Issy Long
9e98bbf59a
Revert "dev-cmd/contributions: Show only the CSV output for --csv" 2024-07-28 19:28:19 +01:00
Issy Long
df6b06c57e
Merge pull request #17888 from Homebrew/bin-pathname-audit-bugs
rubocops/text: Allow all "#{bin}/foo" interpolated strings with spaces
2024-07-28 17:44:59 +01:00
Patrick Linnane
6509dc1f29
Merge pull request #17883 from bevanjkay/unpack-strategy-types 2024-07-28 09:30:24 -07:00
Issy Long
f0084e611a
rubocops/text: Allow all "#{bin}/foo" interpolated strings with spaces
- This was complaining about `shell_output("#{bin}/abricate-get_db --help 2>&1")` which it shouldn't have.
2024-07-28 17:18:35 +01:00
Issy Long
c880dd4350
dev-cmd/contributions: Show only the CSV output for --csv
- This was noisy when using `--csv` as it would print the text output
  and then the CSV output.
2024-07-28 16:17:07 +01:00
Sam Ford
a196898ad3
unpack_strategy/cab: align method order
This simply moves the `Cab#dependencies` method above
`#extract_to_dir`, to align it with the other strategies.
2024-07-28 10:17:23 -04:00
Sam Ford
6918160fd9
UnpackStrategy: Make #dependencies non-nilable
`T.nilable` was removed from the `P7Zip#dependencies` type signature
in a previous commit, as `UnpackStrategy#dependencies` doesn't allow
for a nilable return type. This updates the type signature for the
other `#dependencies` methods to also remove `T.nilable`, as they
would produce a runtime error otherwise.
2024-07-28 10:15:02 -04:00
Bevan Kay
0a658a3290
unpack_strategy/p7zip: update types 2024-07-28 22:31:38 +10:00
Bevan Kay
98ec6a9722
unpack_strategy: update types 2024-07-28 22:31:38 +10:00
Issy Long
0af1ce866c
utils/github/api: Fix uninitialized constant Etc
- I saw this in:

```
Error: uninitialized constant GitHub::API::Etc
Warning: Removed Sorbet lines from backtrace!
Rerun with `--verbose` to see the original backtrace
/opt/homebrew/Library/Homebrew/utils/github/api.rb:140:in `uid_home'
/opt/homebrew/Library/Homebrew/utils/github/api.rb:154:in `block in github_cli_token'
/opt/homebrew/Library/Homebrew/utils/uid.rb:8:in `drop_euid'
/opt/homebrew/Library/Homebrew/utils/github/api.rb:150:in `github_cli_token'
/opt/homebrew/Library/Homebrew/utils/github/api.rb:194:in `credentials'
/opt/homebrew/Library/Homebrew/utils/github/api.rb:251:in `open_rest'
/opt/homebrew/Library/Homebrew/utils/github/api.rb:334:in `open_graphql'
/opt/homebrew/Library/Homebrew/utils/github.rb:414:in `members_by_team'
/opt/homebrew/Library/Homebrew/dev-cmd/contributions.rb:71:in `run'
/opt/homebrew/Library/Homebrew/brew.rb:95:in `<main>'
```
2024-07-27 23:45:16 +01:00
Mike McQuaid
7abc6f4349
cask/installer: improve *_FORBIDDEN_* env handling.
- Improve the error message when a cask or formula is forbidden by an
  environment variable (fixes #17880)
- Move the `forbidden_tap_check` and `forbidden_cask_and_formula_check`
  methods to the top of the `install` method, so that they are checked
  before the main cask is downloaded.
2024-07-27 16:13:51 +01:00
Mike McQuaid
04621bab95
Merge pull request #17879 from Homebrew/kernel_require_utils 2024-07-26 20:02:00 +01:00
William Woodruff
0b2a74dcd9
Merge pull request #17878 from Homebrew/ww/mirrored-bottle-attestations 2024-07-26 14:48:54 -04:00
Mike McQuaid
42438f45ae
extend/kernel: add missing utils require.
Don't require this globally to avoid slowing down boot.
2024-07-26 19:48:51 +01:00
William Woodruff
6e2975d026
attestation: handle mirrored bottles correctly
Signed-off-by: William Woodruff <william@yossarian.net>
2024-07-26 14:26:45 -04:00
Mike McQuaid
a901a9c389
sbom: ensure Homebrew versions are more consistent.
Avoid making bottles non-reproducible by ensuring that the Homebrew
version doesn't include the full commit hash but just a `-dev` suffix.

This is similar to the approach we use for analytics.
2024-07-26 17:37:05 +01:00
Patrick Linnane
d79fa417b8
Merge pull request #17872 from Homebrew/dependabot/bundler/Library/Homebrew/rubocop-sorbet-0.8.5 2024-07-26 08:38:27 -07:00
Patrick Linnane
b4d2fafafb
Merge pull request #17870 from Homebrew/dependabot/bundler/Library/Homebrew/docile-1.4.1 2024-07-26 08:38:23 -07:00
BrewTestBot
d117a286b5
Update RBI files for docile.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-07-26 15:26:31 +00:00
BrewTestBot
e852990eda
brew vendor-gems: commit updates. 2024-07-26 15:26:19 +00:00
BrewTestBot
7476c6c6b3
Update RBI files for rubocop-sorbet.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-07-26 15:25:41 +00:00
BrewTestBot
ed9cf4eec1
Update RBI files for sorbet.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-07-26 15:25:32 +00:00
BrewTestBot
ce7b44fb8a
brew vendor-gems: commit updates. 2024-07-26 15:25:31 +00:00
BrewTestBot
c1b2ef4df6
brew vendor-gems: commit updates. 2024-07-26 15:25:21 +00:00
dependabot[bot]
ce9f5e43c1
build(deps-dev): bump sorbet in /Library/Homebrew
Bumps [sorbet](https://github.com/sorbet/sorbet) from 0.5.11493 to 0.5.11495.
- [Release notes](https://github.com/sorbet/sorbet/releases)
- [Commits](https://github.com/sorbet/sorbet/commits)

---
updated-dependencies:
- dependency-name: sorbet
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-26 15:16:21 +00:00
dependabot[bot]
123ca51cac
build(deps-dev): bump rubocop-sorbet in /Library/Homebrew
Bumps [rubocop-sorbet](https://github.com/shopify/rubocop-sorbet) from 0.8.4 to 0.8.5.
- [Release notes](https://github.com/shopify/rubocop-sorbet/releases)
- [Commits](https://github.com/shopify/rubocop-sorbet/compare/v0.8.4...v0.8.5)

---
updated-dependencies:
- dependency-name: rubocop-sorbet
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-26 15:15:48 +00:00
dependabot[bot]
d111d82dd9
build(deps-dev): bump docile from 1.4.0 to 1.4.1 in /Library/Homebrew
Bumps [docile](https://github.com/ms-ati/docile) from 1.4.0 to 1.4.1.
- [Changelog](https://github.com/ms-ati/docile/blob/main/HISTORY.md)
- [Commits](https://github.com/ms-ati/docile/compare/v1.4.0...v1.4.1)

---
updated-dependencies:
- dependency-name: docile
  dependency-type: indirect
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-26 15:15:19 +00:00
Branch Vincent
5304b70c92
rubocops/lines: remove existing npm audit 2024-07-26 05:41:57 -07:00
Branch Vincent
88aed13958
rubocops/lines: rustup-init -> rustup 2024-07-25 19:26:59 -07:00
Branch Vincent
0c0b95fae5
formula: remove std_npm_args from system's pretty_args 2024-07-25 17:11:12 -07:00
Sam Ford
0a2e9661b6
Strategy#from_url: remove unused param
The `url_provided` parameter of the `Strategy#from_url` method was
originally introduced in #9529 but I removed it in a later commit in
that PR in favor of a different approach. Unfortunately, I forgot to
remove the `url_provided` parameter, as it was no longer needed after
that change. This removes the parameter and updates `#from_url` calls
accordingly.
2024-07-25 13:41:40 -04:00
Sam Ford
34fbf09841
Merge pull request #17842 from sazriel26/livecheck-for-head-only
[livecheck] Help to check head only formulae
2024-07-25 13:40:08 -04:00
Sam Ford
3dc89609ee
Merge pull request #17861 from samford/livecheck/remove-unused-requires
livecheck: remove unused `require` calls
2024-07-25 13:37:20 -04:00
Sam Ford
0de85120cb
Git: remove unused open3 require
I refactored the `Git` strategy to use `SystemCommand` instead of
`Open3#capture3` in #13387 but I forgot to remove `require "open3"`
at the time. `Git` doesn't use `open3` now, so this removes the
unused `require`.
2024-07-25 12:43:16 -04:00
Sam Ford
fcaeacd0da
livecheck: remove unused URI require
`URI#parse` was originally added in #9074 and replaced with
`Addressable::URI#parse` in #13306 but `require "uri"` wasn't removed
at the time. livecheck doesn't use `URI` now, so this removes the
unused `require`.
2024-07-25 12:41:34 -04:00
BrewTestBot
2cb80fdd47
Update RBI files for spoom.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml) workflow.
2024-07-25 16:33:27 +00:00
BrewTestBot
4673128b21
brew vendor-gems: commit updates. 2024-07-25 16:33:11 +00:00
dependabot[bot]
da12015237
build(deps-dev): bump spoom from 1.3.3 to 1.4.0 in /Library/Homebrew
Bumps [spoom](https://github.com/Shopify/spoom) from 1.3.3 to 1.4.0.
- [Release notes](https://github.com/Shopify/spoom/releases)
- [Commits](https://github.com/Shopify/spoom/compare/v1.3.3...v1.4.0)

---
updated-dependencies:
- dependency-name: spoom
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-07-25 16:23:54 +00:00
Mike McQuaid
506feed220
Merge pull request #17855 from Homebrew/missing_formula_requires 2024-07-25 15:43:10 +01:00
Sam Ford
f23d0ce373
livecheck: convert head-only strings to Versions
`brew livecheck` currently gives a Sorbet type error when run on a
HEAD-only formula: `Parameter 'version': Expected type Version, got
type String with value "c06c10d"`. This happens because the `current`
and `latest` values are strings but `LivecheckVersion#create` expects
a `Version` object.

This addresses the issue by creating a `Version` object from the
related commit strings. This ensures that the type of these variables
is more uniform, which makes them easier to reason about.
2024-07-25 10:23:39 -04:00
Sharon Azriel
31f4570cc2
[livecheck] Help to check head only formulae 2024-07-25 10:22:05 -04:00
Mike McQuaid
266ed1426b
Merge pull request #17857 from samford/contributions-reorder-requires 2024-07-25 15:21:03 +01:00
Issy Long
928bf87f59
Merge pull request #17856 from Homebrew/not-all-bin-interpolation-is-bad 2024-07-25 15:09:38 +01:00
Sam Ford
a6e61fd664
contributions, github: reorder requires
Per feedback to https://github.com/Homebrew/brew/pull/17806, this
moves some `require` statements in `dev-cmd/contributions.rb` and
`Utils::GitHub` into the methods that need them.
2024-07-25 10:02:18 -04:00
Mike McQuaid
0f0e2c7bd9
Merge pull request #17854 from Homebrew/version_unsafe 2024-07-25 13:51:08 +01:00
Issy Long
38bb463aad
Interpolated shell_output("#{bin}/foo -v"), for example, is fine
- This would be weird to change because it's a string not a pathname passed to `shell_output`.
- I had misunderstood https://github.com/Homebrew/brew/pull/17826#discussion_r1690806375.
2024-07-25 13:28:00 +01:00