hyuraku
ec0d492c09
move cask/cmd/reinstall to cask/reinstall
2023-04-10 22:07:06 +09:00
Issy Long
8319c8f9b9
Make audit_casks return [path, { errors:, warnings:}] for CI
...
- This was failing but only in CI because the annotations require
"errors" and "warnings" hash elements. Since formulae have this
despite formulae not having warnings (probably for compatibility with
casks), I decided to reinstate `errors` and `warnings` hash for Casks
_right at the end_ and we can clean this up another time (famous last
words).
2023-04-07 14:31:12 +01:00
Issy Long
d636d2de37
Apply suggestions from review comments
...
- Rename `strictish` to `strict_only` in `add_error` method.
- Return just `errors`, a Set, not `{ errors: errors }`, a Hash,
from `Auditor.audit`.
2023-04-06 00:10:28 +01:00
Issy Long
2b8127d518
Turn cask warnings into errors when --strict is passed (or implied)
...
- Ignore them and don't show them otherwise.
- Part three of issue 15074:
> As a result, I propose that all current cask audit warnings are never
> displayed as warnings but the underlying audit checks turned into
> errors displayed only with --strict (or one of the other relevant
> flags).
2023-04-01 01:56:46 +01:00
Issy Long
a4e8f9e22b
audit: Make --display-failures-only the default for Casks
...
- Cask warnings are really noisy and numerous. Let's only show them if
the user passes `--strict` or something implying `--strict`, like
`--new-cask`.
- Additionally remove `display_passes` since we would like silence if
nothing is wrong with the cask, the same as with formula audits.
2023-04-01 01:56:45 +01:00
Markus Reiter
bdd6523ce8
Deprecate appcast.
2023-03-30 03:29:06 +02:00
Mike McQuaid
253dca568c
Revert "move cask/cmd/reinstall"
2023-03-23 17:06:42 +00:00
hyuraku
31e49d96af
move cask/cmd/reinstall to cask/reinstall
2023-03-23 22:50:03 +09:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability
2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize
2023-03-19 23:35:47 -04:00
Mike McQuaid
c31ae1ce6a
Merge pull request #14948 from hyuraku/remove-cask/cmd/fetch
...
remove `cask/cmd/fetch`
2023-03-19 17:21:22 -04:00
hyuraku
da6f48dbd0
Merge branch 'master' into move-cask/cmd/uninstall
2023-03-12 11:49:06 +09:00
hyuraku
413e8ac81e
remove cask/cmd/fetch
2023-03-11 22:12:33 +09:00
hyuraku
db328b59f2
move cask/cmd/uninstall to cask/uninstall
2023-03-09 22:33:29 +09:00
hyuraku
19f83ef67f
move cask/cmd/upgrade to cask/upgrade
2023-03-09 20:40:20 +09:00
hyuraku
7c1bd961c6
remove cask/cmd/zap and cask/cmd/zap_spec
2023-03-06 22:27:53 +09:00
hyuraku
e39232313f
move cask/cmd/list to cask/list
2023-03-02 21:53:15 +09:00
Mike McQuaid
9296db0c41
Merge pull request #14839 from hyuraku/move-cask/cmd/info-to-cask/info
...
Move `cask/cmd/info` to `cask/info`
2023-03-01 12:25:26 +00:00
apainintheneck
64ef2f1899
cask/cmd/upgrade: fix missing versions variable
...
This reference to the versions variable is unnecessary.
2023-02-28 22:58:00 -08:00
hyuraku
efdef5f26c
move cask/cmd/info to cask/info
2023-03-01 00:00:54 +09:00
Douglas Eichelberger
2073e70696
brew style --fix
2023-02-27 21:43:10 -08:00
Douglas Eichelberger
f9f73f3ef6
Tidy up
2023-02-27 21:42:47 -08:00
Douglas Eichelberger
1ab278f74c
Fix style/type violations
2023-02-27 20:34:07 -08:00
Douglas Eichelberger
0eccc0e987
git grep -l Utils::Inflection | xargs gsed -i 's|Utils::Inflection|Utils|g'
2023-02-27 20:18:27 -08:00
Douglas Eichelberger
2400c6daed
brew style --fix
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
37015b6b08
Change to pluralize, port more call sites
2023-02-27 20:17:33 -08:00
Douglas Eichelberger
0438a3a538
Draft implementation to replace ActiveSupport inflections
2023-02-27 20:17:33 -08:00
Issy Long
44b0050b94
cmd/(outdated,upgrade): Document -g as a shorter --greedy for Casks
...
- Fixes https://github.com/Homebrew/brew/issues/ 14682.
2023-02-18 18:47:49 +00:00
apainintheneck
6914c310c7
extend/os: remove cask install code
...
This code is unnecessary since `--formula` is passed
by default to the install command on Linux making it
impossible to reach `Cask::Cmd::Install.install_casks`
since it is surrounded by `if casks.any?; end`.
2023-02-09 17:35:02 -08:00
Mike McQuaid
342d40e88d
Merge pull request #14510 from reitermarkus/audit-only-except
...
Pass `only` and `except` to cask audits.
2023-02-08 09:05:00 +01:00
Markus Reiter
b821a00bc5
Pass only and except to cask audits.
2023-02-08 08:38:32 +01:00
hyuraku
8daca925f1
remove #TODO
2023-02-07 22:56:04 +09:00
hyuraku
c066e940c4
apply extend/os to Cask::cmd::install#install_casks
2023-02-07 22:54:06 +09:00
Rylan Polster
dde44ed37c
Clarify cause of the bug in messaging
...
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
2023-02-05 16:10:22 +01:00
Rylan Polster
0fd1be9a8e
Add error message with instructions for the missing cask file
2023-02-05 15:35:11 +01:00
apainintheneck
47b3f6fe6e
Stop including/extending search.rb
...
- Instead use class methods.
- This is better than use it as a mixin
when only a small number of methods are
used in each class or module.
- It also allows us to conditionally
require it in `brew install`.
- Removed unused search require in descriptions.rb.
2022-12-17 11:08:13 -08:00
apainintheneck
c477b9aab3
Cleanup after adding os specific rubocop
...
- Change name of rubocop warning
- Disable linting on remaining offending lines
- Add todos to move lines with disabled linting
checks to extend/os in the future
2022-11-29 23:13:50 -08:00
Daniel Bayley
b9ee9b868d
Fix install <cask> --dry-run
2022-11-11 17:33:11 +00:00
Ian Gregory
a0f915169c
Remove --adopt switch from reinstall and upgrade
2022-10-25 19:07:21 -04:00
Ian Gregory
a715dec49d
Add --adopt switch
...
Allows `brew install` & co. to adopt existing cask artifacts that are
identical to those being installed.
Discussion: #14006
2022-10-21 23:28:51 -04:00
Bo Anderson
eac32f0b20
Additional fixes for Ruby 3 compatibility
2022-10-18 01:54:59 +01:00
Bo Anderson
9b99594753
Preliminary compatibility fixes for Ruby 3
2022-10-11 02:53:27 +01:00
hyuraku
374dd3dea2
repair if syntax and remove useless line
2022-08-27 22:29:07 +09:00
hyuraku
b61ae59421
repair syntax
2022-08-19 21:43:57 +09:00
hyuraku
1bfcf314ac
repair style
2022-08-18 00:16:11 +09:00
hyuraku
8a7f445d1f
repair how to show casks to be installed
2022-08-17 22:14:05 +09:00
hyuraku
93ebe42a72
add dry-run option to cask#install
2022-08-16 21:00:45 +09:00
Sean Molenaar
cc61a759ed
Merge pull request #13627 from SMillerDev/feature/cask/signing_check
...
cask: add audit for incorrect signing
2022-08-16 10:51:59 +02:00
fn ⌃ ⌥
a208ea9c92
info: highlight package name
2022-08-15 07:47:52 -07:00
Sean Molenaar
e90371f8ab
cask: add audit for incorrect signing
2022-08-11 09:11:29 +02:00
