14001 Commits

Author SHA1 Message Date
JCount
ae1986ac91 Merge pull request #3018 from Homebrew/revert-2848-refactoring
Revert "Refactor SVN and cURL download strategies."
2017-08-07 17:33:12 -04:00
ilovezfs
986887b413 Revert "Refactor SVN and cURL download strategies." 2017-08-07 14:31:56 -07:00
Markus Reiter
6ef49d8b86 Merge pull request #2848 from reitermarkus/refactoring
Refactor SVN and cURL download strategies.
2017-08-07 22:13:10 +02:00
Markus Reiter
dc5a2c1764 Simplify CurlDownloadStrategy. 2017-08-07 21:31:17 +02:00
Markus Reiter
fb59e79689 Simplify SubversionDownloadStrategy. 2017-08-07 21:31:17 +02:00
Mike McQuaid
69799d97b1 formula_cellar_checks: remove stray backtick. 1.3.1 2017-08-07 11:48:45 +01:00
Mike McQuaid
1be06bfd14 Merge pull request #3016 from MikeMcQuaid/no-sandbox-message
sandbox: stop printing message.
2017-08-07 11:45:36 +01:00
Mike McQuaid
0950d1f195 Merge pull request #3017 from MikeMcQuaid/reinstall_broken_bottles
formula_cellar_checks: reinstall broken bottles.
2017-08-07 11:45:15 +01:00
Mike McQuaid
5327b304a6 Merge pull request #2998 from andrewyatz/bugfix/pkgconfiglibdir
Bugfix/pkgconfiglibdir
2017-08-07 11:44:58 +01:00
Gautham Goli
a3219ca09c Add node pattern methods to handle dependency audits in a better way 2017-08-07 16:02:50 +05:30
Mike McQuaid
e2070780f1 formula_cellar_checks: reinstall broken bottles.
If we pour from a bottle and then immediately know it’s broken then
we should tell users how to resolve their issue and where to file a
issue to.

Inspired by https://github.com/Homebrew/homebrew-core/issues/16477.
2017-08-07 11:21:55 +01:00
Andrew Yates
9b5a3b80bf Incorrect - added
I added an extra un-wanted - into the pkgconfig path. Now removed
2017-08-07 11:20:56 +01:00
Mike McQuaid
12c454822a sandbox: stop printing message.
We’re always using the sandbox where possible now so this is just
noise for the vast majority of our users.
2017-08-07 11:16:36 +01:00
Mike McQuaid
8e89b9d9d0 Merge pull request #3003 from MikeMcQuaid/better-no-resource-version
software_spec: improve no resource version error.
2017-08-07 10:34:12 +01:00
Mike McQuaid
8217385627 software_spec: improve no resource version error.
This should make it clearer to us that they needed to `brew update`.

Fixes https://github.com/Homebrew/homebrew-core/issues/16075
Fixes https://github.com/Homebrew/brew/issues/2944
2017-08-07 10:12:52 +01:00
Mike McQuaid
6a31e02ab2 Merge pull request #3005 from MikeMcQuaid/cleanup-aliases
keg: cleanup aliases correctly.
2017-08-07 09:50:56 +01:00
Markus Reiter
f57a172cd2 Merge pull request #3013 from reitermarkus/fix-pkg-uninstallation
Fix `Pkg#uninstall` not calling `MacOS.undeletable?` for all files.
2017-08-06 14:00:53 +02:00
Markus Reiter
ffc47388bd Fix Pkg#uninstall not calling MacOS.undeletable? for all files. 2017-08-06 13:19:30 +02:00
Mike McQuaid
c2cbfc1526 Merge pull request #3010 from rwhogg/remove-homebrew-x11-reference
formula: Remove reference to homebrew/x11
2017-08-06 09:55:56 +01:00
Markus Reiter
cf6a568f98 Merge pull request #3009 from reitermarkus/fix-cask-url-ext
Fix parsing extension from URL.
2017-08-05 23:16:44 +02:00
Gautham Goli
781da49df8 audit: Add tests for audit rules ported from line_problems method to rubocops 2017-08-06 02:28:58 +05:30
Gautham Goli
7614d2cc8b audit: Port FileUtils, inreplace audit rules in audit_lines to rubocop 2017-08-06 02:28:58 +05:30
Gautham Goli
affd9055c2 audit: Port classname and template comments audit rules from line_problems method to rubocop 2017-08-06 02:28:58 +05:30
Markus Reiter
bd25c2e219 Fix parsing extension from URL. 2017-08-05 22:05:04 +02:00
Bob W. Hogg
06ecad2950 formula: Remove reference to homebrew/x11
That tap is now defunct.

Signed-off-by: Bob W. Hogg <rwhogg@linux.com>
2017-08-05 12:54:39 -07:00
Markus Reiter
7a17a166ec Merge pull request #3006 from reitermarkus/unfocus
Delete `:focus`.
2017-08-05 21:05:08 +02:00
Mike McQuaid
e862bcbc32 keg: cleanup aliases correctly.
This was missed when I was focused on cleaning up versioned aliases.

Fixes #2992.
2017-08-05 18:03:04 +01:00
Mike McQuaid
441bd37fd0 Merge pull request #3004 from MikeMcQuaid/travis-only-master
travis.yml: only build the master branch.
2017-08-05 18:02:06 +01:00
Mike McQuaid
eaea27c960 formula_installer: restore build_bottle defaults. 2017-08-05 17:51:47 +01:00
Mike McQuaid
8405158d8d Merge pull request #2976 from GauthamGoli/audit_external_patches_rubocop
audit: Port patches audit code to a rubocop and add tests
2017-08-05 17:39:40 +01:00
Gautham Goli
66ffdb5b06 Refactor legacy_patches_cop to merge external patch audit rules in a single cop and add tests 2017-08-05 21:51:24 +05:30
Gautham Goli
43cec10000 audit: Port patches audit code to a rubocop 2017-08-05 21:51:24 +05:30
Mike McQuaid
df0abe08b2 travis.yml: only build the master branch.
This avoid two weird things:

- scary messages when building tags fails
- two builds being run instead of one when people create a PR and a
  branch on the Homebrew/brew repo (rather than their fork).
2017-08-05 17:09:32 +01:00
Markus Reiter
f5af3fe0cd Delete :focus. 2017-08-05 18:09:09 +02:00
Markus Reiter
c26c9204fa Merge pull request #2965 from reitermarkus/cask-tap
Detect `Tap` in `CaskLoader`.
2017-08-05 16:54:26 +02:00
Markus Reiter
f89e09b785 Add spec for conflicts_with cask. 2017-08-05 16:21:14 +02:00
Markus Reiter
67327c75b5 Implement conflicts_with :cask. 2017-08-05 16:19:50 +02:00
Mike McQuaid
ae0b7cb824 Merge pull request #2991 from javian/additionalphpignores
audit: add additional php header ignore patterns
2017-08-05 15:16:05 +01:00
Markus Reiter
42cfb6d238 Merge pull request #2999 from mistydemeo/tap_each_enum
Tap.each: return an enumerable when no block given
2017-08-04 16:14:06 +02:00
Markus Reiter
77fb123139 Merge pull request #3000 from reitermarkus/remove-checkurl
Remove `brew cask _checkurl`.
2017-08-04 16:13:23 +02:00
Markus Reiter
12d4226bfc Remove _checkurl. 2017-08-04 15:39:32 +02:00
Misty De Meo
1c3ece12b9 Tap.each: return an enumerable when no block given 2017-08-03 17:23:16 -07:00
Andrew Yates
365c55573b Moving /usr/lib/pkg-config to be first
Ensuring old functionality still happens and /usr/lib/pkg-config is the first location found in macOS.
2017-08-03 17:22:18 +01:00
ilovezfs
1cae6dd677 Merge pull request #2997 from ilovezfs/non-libraries
formula_cellar_checks: check_non_libraries only for new formulae
2017-08-03 05:48:15 -07:00
ilovezfs
ee6b0e7c9b formula_cellar_checks: check_non_libraries only for new formulae
This check is overly opinionated and leads to audit failures no one
cares to fix, so let's only run it for new formulae.
2017-08-03 05:21:36 -07:00
Andrew Yates
19cfcc34ef Adding in "/usr/lib/pkg-config"
Moving "/usr/lib/pkg-config" into the pkg-path path
2017-08-03 10:46:12 +01:00
Andrew Yates
980db9d3fb Remove errant pkg-config libdir
We found an issue in Linuxbrew/homebrew-core#3366 where the addition of "/usr/lib/pkg-config" causes compilation issues if system pkg-config files are in that directory on Linux. Removing the line from here and adding it into the mac superenv.
2017-08-03 10:44:56 +01:00
Jan Viljanen
85da376233 audit: add additional php header ignore patterns 2017-08-03 06:13:15 +02:00
JCount
2ad03b8eb3 Merge pull request #2990 from JCount/formula_desc_cop-x86
formula_desc_cop: add 'x86' to VALID_LOWERCASE_WORDS
2017-08-01 13:43:18 -04:00
JCount
68878d73ef formula_desc_cop: add 'x86' to VALID_LOWERCASE_WORDS 2017-08-01 11:36:44 -04:00