14001 Commits

Author SHA1 Message Date
ilovezfs
d4f8e2fa18 Merge pull request #1571 from MikeMcQuaid/admin-doctor
Revert "Fix early exit condition for check_for_member_of_admin_group"
2016-11-25 17:35:28 +00:00
Mike McQuaid
771ae5c528 Revert "Merge pull request #1562 from woodruffw/check-admin-group"
This reverts commit 7f13b37b903564e2a64cea982d6b84d1aa6b800b, reversing
changes made to 62e0ecdaafbc6779205908c7ab191c884473afd6.
2016-11-25 16:44:33 +00:00
Mike McQuaid
64cb52ef3e Revert "Merge pull request #1567 from cesarandreu/fix-diagnostic-conditonal"
This reverts commit 89c3348923c3450d8d32f1252abd53209b39c288, reversing
changes made to 7f13b37b903564e2a64cea982d6b84d1aa6b800b.
2016-11-25 16:44:30 +00:00
Mike McQuaid
89c3348923 Merge pull request #1567 from cesarandreu/fix-diagnostic-conditonal
Fix early exit condition for check_for_member_of_admin_group
2016-11-25 13:17:26 +00:00
Cesar Andreu
3b53418a2b Fix early exit condition for check_for_member_of_admin_group 2016-11-25 02:30:50 -08:00
Mike McQuaid
7f13b37b90 Merge pull request #1562 from woodruffw/check-admin-group
diagnostic: check if the user is a member of the admin group.
2016-11-25 08:11:03 +00:00
Mike McQuaid
62e0ecdaaf Merge pull request #1559 from MikeMcQuaid/unsupported-better-exceptions
exceptions: better handle unsupported macOS versions.
2016-11-24 21:15:39 +00:00
William Woodruff
bb0e683bc4
diagnostic: check if the user is a member of the admin group.
Non-administrative users are unable to run `brew linkapps` (and possibly other
commands) under normal circumstances.
2016-11-24 12:26:50 -05:00
Josh Hagins
949a3b62e7 Merge pull request #1547 from umireon/cask-uninstall-symlink
cask: Delete package dir if it is symlink on the uninstall
2016-11-24 12:16:42 -05:00
Mike McQuaid
f8aa057b07 Merge pull request #1561 from tsekityam/patch-2
Fix broken link
2016-11-24 11:41:43 +00:00
Tse Kit Yam
2279751103 Fix broken link 2016-11-24 18:26:01 +08:00
Mike McQuaid
3c77faeb14 exceptions: better handle unsupported macOS versions.
Don’t fail on `OS::ISSUES_URL` being missing (which happens on
unsupported macOS versions) and instead tell people to not file issues.
2016-11-24 08:54:38 +00:00
Mike McQuaid
17bad9ac59 Merge pull request #1374 from sjackman/bottle-checksums
Do not remove unknown bottle tags
2016-11-23 19:10:37 +00:00
Shaun Jackman
8a3481ee1d Do not remove unknown bottle tags 2016-11-23 10:36:09 -08:00
Mike McQuaid
3bcf80f651 README: fix Patreon badge spacing. 2016-11-23 13:23:45 +00:00
Mike McQuaid
0271e76f08 README: add Patreon badge. 2016-11-23 13:23:28 +00:00
Mike McQuaid
641b0b53f7 Merge pull request #1549 from umireon/osxfuse-paths-with-requirement
osxfuse_requirement: add library and include paths
2016-11-23 11:45:32 +00:00
Mike McQuaid
f73b4eafcf Merge pull request #1551 from MikeMcQuaid/audit-deprecation-option-new-formulae
audit: allow deprecated options on new @ formulae.
2016-11-23 11:28:02 +00:00
Mike McQuaid
1980af52de audit: allow deprecated options on new @ formulae.
As these may be migrations from another tap where we want to migrate
options across correctly.
2016-11-23 11:03:10 +00:00
Kaito Udagawa
00b18c3587 osxfuse_requirement: add library and include paths
In the installation whose prefix is other than /usr/local,
osxfuse library and include path must explicitly be specified during build.
Although brew's pkg-config is configured to prepend appropriates paths,
the prepended paths (/usr/local) supercede the original HOMEBREW_PREFIX.
This behavior will cause the linker to select libraries outside brew's tree.

By adding /usr/local to HOMEBREW_LIBRARY_PATHS, superenv ensures that appears
only after the HOMEBREW_PREFIX, and thus fixes this problem.

HOMEBREW_INCLUDE_PATHS is also configured like keg-only Formulae.
2016-11-22 23:52:26 +09:00
Mike McQuaid
c3f959d6af Merge pull request #1542 from woodruffw/deprecate-utils-json
compat: deprecate Utils::JSON in favor of corelib JSON.
2016-11-21 18:45:20 +00:00
Kaito Udagawa
63e7fb5cae cask: Delete package dir if it is symlink on the uninstall
When a Formula is converted into a Cask (e.g. osxfuse),
a symlink remains at the place of package dir.
This change ensure to remove such leftovers.
2016-11-22 03:10:42 +09:00
Markus Reiter
c7267b123d Merge pull request #1502 from reitermarkus/load-metadata-cask-file
Load cask file in `.metadata` directory directly.
2016-11-21 10:43:15 +01:00
Markus Reiter
cc7541cbc4 Merge pull request #1535 from umireon/cask-pkg-choice
Cask: Add the choices option to pkg stanza
2016-11-21 10:25:30 +01:00
Mike McQuaid
6b2242822b Merge pull request #1546 from MikeMcQuaid/llvm-clang-fixes
LLVM Clang fixes
2016-11-21 09:18:22 +00:00
Mike McQuaid
b9d0d7719a cc: don't filter -fopenmp for non-llvm_clang.
We can filter it just for Clang and let it be used by anything else.
2016-11-21 08:50:01 +00:00
Mike McQuaid
28a00e9d6c development_tools: return llvm_clang Version class.
This was implemented before the rest of the file was refactored.
2016-11-21 08:49:29 +00:00
Mike McQuaid
a3f03e2066 development_tools: use begin/end
A more widely used style than relying on `if`/`else` returns.
2016-11-21 08:49:04 +00:00
Mike McQuaid
c1688be780 version/null: add inspect method.
This makes it easier to identify null versions when inspecting them.
2016-11-21 08:48:26 +00:00
Mike McQuaid
1710973792 Merge pull request #1540 from woodruffw/audit-check-blacklist
audit: check formula name against blacklisted names.
2016-11-21 07:52:05 +00:00
William Woodruff
d07b9ed7f2
Replace Utils::JSON with corelib JSON calls. 2016-11-20 20:06:25 -05:00
William Woodruff
54d18cee17
compat: deprecate Utils::JSON in favor of corelib JSON. 2016-11-20 15:02:47 -05:00
Kaito Udagawa
df635c8259 cask: compact the code 2016-11-21 04:13:29 +09:00
Mike McQuaid
947b850035 Merge pull request #1130 from aw1621107/allow-brew-llvm-for-openmp
Prefer brewed Clang over gcc-6 for needs :openmp
2016-11-20 12:38:28 +00:00
Mike McQuaid
a16bfa57e8 Merge pull request #1537 from umireon/nonfatal-requirement-message-once
install: suppress redundunt warnings with `depends_on` requirement
2016-11-20 11:59:57 +00:00
Kaito Udagawa
bcc9002214 install: print nothing if @requirement_messages is a String or nil 2016-11-20 19:49:58 +09:00
William Woodruff
4a9601ab82
audit: check formula name against blacklisted names. 2016-11-20 00:40:54 -05:00
Kaito Udagawa
0c22cc45e6 cask: Call Tempfile#close(true) with the choices file to ensure it deleted 2016-11-20 14:23:55 +09:00
Markus Reiter
7fbab8be9c Merge pull request #1538 from reitermarkus/remove-kexts
Remove kernel extensions specified in `uninstall :kext`.
2016-11-20 00:33:53 +01:00
Kaito Udagawa
2807202103 cask: use Tempfile and some style fixes 2016-11-19 14:52:38 +09:00
Markus Reiter
1834457272 Remove kernel extensions specified in uninstall :kext. 2016-11-19 01:53:26 +01:00
Markus Reiter
bd9755fd78 Load cask file in .metadata directory directly. 2016-11-18 23:02:58 +01:00
Kaito Udagawa
f4a3bc100b cask: add the choices option to pkg stanza
installer command accepts -applyChoiceChangesXML option to change
customize options on the GUI installer from the commandline.
(`man installer` for more detailed information)

The introduced option `choice` enables the choice changes to be supplied
via pkg stanza without tricks in preflight code.
2016-11-19 04:41:21 +09:00
Kaito Udagawa
61c8fff0ee install: suppress redundunt warnings with depends_on requirement
When a formula depends on any requirements, they evaluated at most three times:
before locking, before installing dependent, before building formula.
When a non-fatal requirement is specified and thus evaluated three times,
mostly the same warning message is also emitted three times.

This change restricts printing the warning messages only when a bottle is
successfully installed or before building.
Since this timing is after the final dependency computation for each cases,
the warnings will be most useful to check what is not yet satisfied.
2016-11-19 04:14:26 +09:00
Mike McQuaid
7853406fb4 Merge pull request #1515 from alyssais/formula_cache
Fix flaky tests.
2016-11-18 15:37:49 +00:00
Mike McQuaid
c3022ad2d5 Merge pull request #1536 from MikeMcQuaid/testbottest-tarballs
testbottest: don't use TEST_FIXTURE_DIR.
2016-11-18 14:37:04 +00:00
Mike McQuaid
e8d5040141 testbottest: don't use TEST_FIXTURE_DIR.
This isn't defined for formulae.
2016-11-18 14:08:40 +00:00
Alex Wang
3e4544025d Prefer brewed Clang over gcc-6 for needs :openmp
Clang has fully implemented OpenMP support as of LLVM 3.7, so if OpenMP
is required by a formula gcc is no longer the only choice of compiler.

Clang should be preferred over gcc because using gcc meant linking
against libstdc++, which is ABI incompatible with libc++. This may be
unnoticeable for some users, but it causes other builds to fail, e.g.
pstoedit when imagemagick was built with OpenMP. pstoedit is required
for the octave formula, so for some users this could be a significant
problem.
2016-11-18 08:54:09 -05:00
Mike McQuaid
5e073f1f40 Merge pull request #1528 from MikeMcQuaid/audit-devel-revision
audit: don't check devel version_scheme/revision.
2016-11-18 13:53:22 +00:00
Mike McQuaid
0e2218807a Merge pull request #1529 from MikeMcQuaid/uninstall-ignore-deprecations
uninstall: ignore deprecations when uninstalling.
2016-11-18 13:06:42 +00:00