Markus Reiter
16f4130dd8
Add internal command to calculate appcast checkpoint.
2017-01-23 09:33:12 +01:00
Mike McQuaid
3be56aee71
Merge pull request #1895 from xu-cheng/bottle
...
bottle: fix regex
2017-01-23 07:51:23 +00:00
Trevor Powell
4ce6616f2e
Fix "Failed to eject" errors with DMGs
...
Use "diskutil unmount force" to unmount DMGs.
2017-01-22 22:52:11 -06:00
Vítor Galvão
70a5ebafc4
cask - internal_stanza: arguments to args
2017-01-23 01:13:58 +00:00
Alyssa Ross
19e61355b3
tests: remove with_git_env method
...
A common git environment is now used in all tests, so this is no longer
required.
2017-01-22 20:54:37 +00:00
Alyssa Ross
b53ce62ffb
tests: use more recent git committer date
...
This will allow the `brew bundle` test to use the default git
environment.
2017-01-22 20:45:15 +00:00
Alyssa Ross
9c3d01c682
tests: remove unnecessary comment
...
See https://github.com/Homebrew/brew/pull/1890#discussion_r97229473 .
2017-01-22 19:59:13 +00:00
Markus Reiter
cbc9e5dd3b
tests: re-use with_environment in using_git_env
...
Proposed by @reitermarkus in
https://github.com/Homebrew/brew/pull/1890#discussion_r97210285 .
I made one slight adjustment of preserving the previous date string in
case anything was relying on it.
2017-01-22 19:53:58 +00:00
Alyssa Ross
1e1de8c111
tests: remove remainder of ARGV stubs
...
I was waiting for confirmation that there wasn't a good reason for these
to be stubbed before I removed them.
2017-01-22 19:53:58 +00:00
Alyssa Ross
a736c7e317
tests: set verbose in ENV instead of stubbing ARGV
2017-01-22 19:53:58 +00:00
Alyssa Ross
0c1d665568
tests: set developer in ENV rather than stubbing
2017-01-22 19:53:58 +00:00
Alyssa Ross
116ed3ec80
tests: automatically restore ENV in teardown
2017-01-22 19:53:58 +00:00
Alyssa Ross
6e0f1366b0
tests: extract a common using_git_env method
2017-01-22 19:52:34 +00:00
Alyssa Ross
6f305ad3dc
Merge pull request #1892 from alyssais/global_teardown_fs
...
tests: clean up file system for all tests
2017-01-22 19:47:38 +00:00
Xu Cheng
22f294af90
bottle: fix regex
...
Noted that this is intended for the revision of this formula instead of
rebuild of a bottle.
2017-01-22 19:50:14 +08:00
Alyssa Ross
6861451f87
tests: remove more per-test file system cleanup
...
These locations are now all automatically cleaned up after every test.
2017-01-22 11:15:18 +00:00
Alyssa Ross
1aee7c6945
tests: remove explicit tmpdir deletions
...
These are no longer necessary.
2017-01-22 11:15:18 +00:00
Alyssa Ross
d7b8420aaa
tests: clean up file system for all tests
...
(No longer just integration tests.)
2017-01-22 11:15:18 +00:00
Alyssa Ross
7c27bfd37a
Merge pull request #1891 from alyssais/global_teardown_argv
...
tests: reset ARGV in teardown
2017-01-22 11:06:07 +00:00
Alyssa Ross
d86342a251
tests: reset ARGV in teardown
2017-01-21 15:08:20 +00:00
Alyssa Ross
c9d7bab6ca
Merge pull request #1889 from alyssais/clear_tab_cache_in_teardown
...
tests: clear tab cache in global teardown
2017-01-21 14:55:12 +00:00
Alyssa Ross
2d550b5008
tests: clear tab cache in global teardown
2017-01-21 14:24:19 +00:00
Alyssa Ross
ab9d8df792
Merge pull request #1888 from alyssais/tests_enforce_lifecycle
...
tests: enforce `super` in lifecycle hooks
2017-01-21 13:24:54 +00:00
Alyssa Ross
70a381a00f
tests: enforce super
in lifecycle hooks
...
This will allow us to have global setup and teardown for tests.
For example, we can automatically clear caches after each test, to avoid
annoying intermittent failures like #1879 and #1886 .
2017-01-21 11:34:52 +00:00
ilovezfs
cebe137499
audit: exempt wine's deps from the universal deprecation
...
This can be reverted when wine's dependencies are all vendored.
2017-01-20 07:18:51 -08:00
Alyssa Ross
d7c463ad2c
Merge pull request #1878 from alyssais/keg_cleanup
...
Simplify Keg class
2017-01-19 19:24:24 +00:00
Alyssa Ross
245944d359
keg: use Forwardable to methods delegated to #path
2017-01-19 17:06:38 +00:00
Alyssa Ross
34e13fc527
keg: don't conditionally switch alias target
...
This seems to be a remnant of Ruby 1.8.
2017-01-19 17:06:38 +00:00
Mike McQuaid
0810039868
Merge pull request #1879 from alyssais/formulary_cache_clear
...
tests: add a missing Tab cache clear
2017-01-19 17:04:10 +00:00
Alyssa Ross
366ee0b267
tests: revert modification to ARGV at end of test
...
Similar to 6fc1747e0550545b4fe80f5a1854d16dd2b08afe. I hadn't seen any
test failures caused by this, but I noticed it in the process of
trackign that down and it's an accident waiting to happen.
2017-01-19 13:21:39 +00:00
Alyssa Ross
6fc1747e05
tests: add a missing Tab cache clear
...
This was responsible for the sporadic failures I encountered in #1878 .
2017-01-19 13:16:08 +00:00
Gautham Goli
0b3d9031e2
Add --fix option to brew audit command
2017-01-18 22:35:37 +05:30
Mike McQuaid
f0249643d4
formula_installer: use attr_accessor for installed_*
2017-01-18 16:10:28 +00:00
Mike McQuaid
5424db1263
upgrade: temporarily comment out for fix.
2017-01-18 15:25:17 +00:00
Mike McQuaid
aa926a1bdf
Merge pull request #1813 from MikeMcQuaid/installed_as_dependency
...
tab: store installed_as_dependency, installed_on_request.
2017-01-18 14:56:48 +00:00
Mike McQuaid
89d8864b6b
upgrade: tab installed_{as_dependency,on_request}
2017-01-18 11:23:22 +00:00
Mike McQuaid
ee43c09f7a
install: set installed_{as_dependency,on_request}.
2017-01-18 11:23:21 +00:00
Mike McQuaid
16293c0a68
formula_installer: use installed_* variables.
...
Also, report formulae installed on request. This is useful in
differentiating between those formulae that are popular because they
are widely requested and those that are popular because they are widely
depended on.
2017-01-18 11:23:21 +00:00
Mike McQuaid
44f1c9752a
formula: installed_{as_dependency,on_request} hash
...
Which, in turn, provides them for `brew info --json=v1` so other tools
such as e.g. `brew bundle` can make use of this information.
2017-01-18 11:23:21 +00:00
Mike McQuaid
b99fb56275
tab: store installed_{as_dependency,on_request}.
...
These are used to determine whether or not a formula’s install was
specifically requested by a user and/or pulled in as a dependency.
2017-01-18 11:23:21 +00:00
Gautham Goli
483c40fb03
Add custom cop to refactor revision to rebuild in bottle block
2017-01-18 15:54:47 +05:30
Mike McQuaid
22e8ddc743
Merge pull request #1872 from MikeMcQuaid/improve_integration_test_failure_output
...
integration_command_test_case: improve fail output
2017-01-18 10:22:33 +00:00
Mike McQuaid
4d2201b8be
integration_command_test_case: improve fail output
...
Instead of `puts`ing when the failure occurs save it until the error
message and print a prose description of what the failure was and the
output from the command. This makes the output from failing tests
significantly easier to read.
2017-01-18 08:36:36 +00:00
Mike McQuaid
9f183be358
Merge pull request #1868 from zmwangx/bottle-add-improve-regexp
...
bottle: add: improve regexp to recognize comments
2017-01-18 08:02:45 +00:00
Mike McQuaid
950e27927b
Merge pull request #1869 from MikeMcQuaid/versioned_formula_conflicts_fix
...
audit: only warn on versioned conflicts_with.
2017-01-17 21:12:37 +00:00
Mike McQuaid
ffa5ebde53
Merge pull request #1863 from alyssais/uses_ignore_untapped
...
uses: properly handle untapped formulae in recursive dependency expansion (again!)
2017-01-17 19:58:52 +00:00
Mike McQuaid
1497dfaced
Merge pull request #1862 from alyssais/uses_include_optional
...
uses: fix recursive requirement resolution
2017-01-17 19:58:30 +00:00
Zhiming Wang
f0e5ebce06
rubocop_todo: bump max module length to 400
2017-01-17 14:55:00 -05:00
Mike McQuaid
4f0505f759
audit: only warn on versioned conflicts_with.
...
Rather than all versioned formulae regardless. Oops.
2017-01-17 19:09:41 +00:00
Zhiming Wang
42486c1181
bottle: add: improve regexp to recognize comments
...
This would have eliminated the need for Homebrew/homebrew-core#9000 , for
instance.
2017-01-17 10:26:01 -05:00