admin/brew
1
0
Fork 0
Code Issues Packages Projects Releases 6 Wiki Activity
20,317 Commits 15 Branches 471 Tags
Commit Graph

78 Commits

Author SHA1 Message Date
Mike McQuaid
40432d86f9
cmd/uninstall: handle unparsed arguments. 
If `Homebrew.args` hasn't yet been populated then `named` will return
`nil`. Instead, ensure it is an array before we try to `join` it.

This is pretty much only a test-time problem but has been causing flaky
builds.
 2020-03-11 11:21:28 +00:00
Mike McQuaid
a7fe0ed847
cmd: use more and cleanup new args APIs. 2020-03-05 09:40:15 +00:00
EricFromCanada
2f7c3afeb8 cmd: improve wording of messages, spacing 2019-12-15 00:04:45 -05:00
Zach Auten
fd429d0d75 Moved kegs from ARGV to args.rb 2019-11-09 11:56:47 -05:00
EricFromCanada
6520785307 manpages: grammar fixes 2019-08-20 08:26:26 -04:00
Mike McQuaid
c4f72312ce
Fixup brew style failures. 2019-04-30 09:19:18 +01:00
Mike McQuaid
36dbad3922
Add frozen_string_literal to all files. 2019-04-20 13:27:36 +09:00
Mike McQuaid
e40b171127
Rename cli_parser to cli/parser. 2019-04-17 22:16:50 +09:00
Mike McQuaid
6cb7a00f2d
cmd: remove --help headers and tweak docs. 2019-01-30 21:39:28 +00:00
Gautham Goli
f82a202995
uninstall: Use CLI::Parser to parse args 2018-12-10 23:49:19 +05:30
Markus Reiter
16618d0fc7 Use ActiveSupport’s #pluralize and #to_sentence. 2018-10-07 23:10:56 +02:00
Markus Reiter
e9b9ea49a1 Update to RuboCop 0.59.1. 2018-09-17 03:45:59 +02:00
Mike McQuaid
3a2e6b82fd Make pinning more robust 
Don’t autoremove pins on uninstall or upgrade and note this in the
manpage.
 2018-02-05 10:59:11 +00:00
Markus Reiter
9bee9ca575 Use “squiggly” heredocs. 2017-10-18 14:39:09 +02:00
Markus Reiter
d700a5ba18 Use Formatter::pluralize where possible. 2017-05-29 17:50:13 +02:00
Mike McQuaid
566d3cb58b Document all short flags. 2017-04-02 10:14:58 +01:00
Alyssa Ross
49310667b4 Revert "uninstall: remove nil requireds/dependents" 
This reverts commit d7e72899e6f24dca5e02a734d5a4e64e39fc680e.
 2016-12-31 12:23:53 +00:00
Alyssa Ross
bbf53ad4ab uninstall: don't comma-seperate kegs in example 
The example command given in the dependency errors/warnings previously
comma-seperated the kegs, which was incorrect syntax. This fixes that.
 2016-12-30 17:45:37 +00:00
Alyssa Ross
ea3a41e213 uninstall: better example in dependency warning 
Previously, this only included a subset of all the kegs the user was
trying to uninstall. With this change, all named formulae/kegs will be
included in the example command.
 2016-12-30 17:44:18 +00:00
Mike McQuaid
39a0fec95d uninstall: ignore deprecations when uninstalling. 
Handle `MethodDeprecatedError` because we want people to be able to
uninstall regardless of the content of their formula.
 2016-11-18 09:34:58 +00:00
Mike McQuaid
d7e72899e6 uninstall: remove nil requireds/dependents 
These shouldn’t get here in the first place so this is a bit of a hack
pending a better fix.
 2016-11-15 14:34:49 +00:00
Alyssa Ross
ca3562645c uninstall: style fixes 
Works around Rubycop not liking method names that start with `is_`
by changing convention from singular to plural.

I think it's better that way anyway.
 2016-11-14 13:39:17 +00:00
Alyssa Ross
c77040b346 uninstall: clean up warnings 2016-11-14 13:09:40 +00:00
Alyssa Ross
3c310b2e3d Warn developers when uninstalling a dependency 
Suggested in #1084.

Made the existing warning output entirely to STDERR, because
previously the first line went to STDERR and subsequent ones went
to STDOUT.
 2016-11-14 12:13:34 +00:00
Mike McQuaid
4538d80db1 uninstall: don't need kegs to exist for --force. 
Otherwise there's an error which is a regression on previous
functionality. This mirrors `rm -f` which doesn't fail if a file doesn't
exist.
 2016-11-11 13:15:49 +00:00
Alyssa Ross
481a097643 uninstall: document --ignore-dependencies 2016-10-25 23:59:55 +01:00
Alyssa Ross
3702e561d6 uninstall: test should_check_for_dependents? 2016-10-25 23:53:10 +01:00
Alyssa Ross
5a3d6c4c8f uninstall, keg: update style 2016-10-25 23:48:34 +01:00
Alyssa Ross
d0ad097082 uninstall: remove duplicated method 
This was moved to Keg, but looks like I forgot to get rid of it here.
 2016-10-25 23:48:00 +01:00
Alyssa Ross
a4dc835ba0 uninstall: call Formula#missing_dependencies directly 2016-10-25 22:36:13 +01:00
Alyssa Ross
99a7fb8cb4 uninstall: don't use unless || 2016-10-25 22:34:35 +01:00
Alyssa Ross
ef13f8eaca uninstall: only <=1 Diagnostic.missing_deps call 2016-10-25 22:34:35 +01:00
Alyssa Ross
ed0fffd931 uninstall: style fixes 2016-10-25 22:34:35 +01:00
Alyssa Ross
7792acda52 uninstall: allow dependent checks to be by-passed 
Dependent can be bypassed with `--ignore-dependencies`.
This is now the default for `HOMEBREW_DEVELOPER`s.
 2016-10-25 22:34:35 +01:00
Alyssa Ross
ecb1075390 uninstall: check for dependents even with --force 2016-10-25 22:34:34 +01:00
Alyssa Ross
b42f76939c uninstall: reorganise code 
With the way uninstall is set up at the moment, it's pretty difficult to
add functionality to both the --force and normal variants.

Extracting the racks and kegs to be uninstalled before uninstalling them
should make this easier.
 2016-10-25 22:34:34 +01:00
Alyssa Ross
888c44b238 uninstall: fix dependent order bug 2016-10-25 22:34:34 +01:00
Alyssa Ross
08f3aecf6b uninstall: consistent spelling of "dependent" 
@ilovezfs pointed out that Homebrew generally uses "dependent", rather than
"dependant".
 2016-10-25 22:34:34 +01:00
Alyssa Ross
e41c4e5029 uninstall: better message when dependents remain 
Suggested by @MikeMcQuaid
 2016-10-25 22:34:34 +01:00
Alyssa Ross
6f0aabe707 uninstall: refuse when dependants still installed 
Closes #934.
 2016-10-25 22:34:34 +01:00
Markus Reiter
0ab750bf24 Use module_function for commands. 2016-10-02 00:24:47 +02:00
Joseph Frazier
66ca9e79fc uninstall: improve pronoun for multiple version message 
When exactly two versions of a package were installed, the uninstall
message should not read "Remove them all with...", since only one
version remains.

"Remove all versions with..." is flexible enough to avoid being
interpreted as grammatically incorrect, and it still accurately
describes the general behavior of `brew uninstall --force`.
 2016-09-21 11:37:23 -04:00
Mike McQuaid
56fc1c725a cmd/uninstall: fix Rubocop warnings. 2016-09-11 17:59:00 +01:00
Max Nordlund
fa1fd70a37 Add all the top level comments 2016-04-10 22:59:25 +02:00
Xu Cheng
2130cb8c86 uninstall: fix indent 2015-10-17 03:59:28 +08:00
Xu Cheng
dee4c76e62 uninstall: fix when Cellar doesn't exist 2015-10-17 03:57:40 +08:00
Xu Cheng
4740d7fad4 uninstall: simplify logic 
Also reduce unnecessary disk operations

Closes Homebrew/homebrew#43024.

Signed-off-by: Xu Cheng <xucheng@me.com>
 2015-08-18 15:58:07 +08:00
Baptiste Fontaine
f690b54621 Suggest 'brew uninstall' everywhere for consistency 
Mixing 'brew remove' with 'brew uninstall' can confuse users.

Closes Homebrew/homebrew#43026.

Signed-off-by: Baptiste Fontaine <batifon@yahoo.fr>
 2015-08-17 20:36:02 +02:00
Vlad Shablinsky
d3037f7044 update opt for renamed formula 
After the formula gets renamed oldname opt is created and
it points to the linked keg. However if we then upgrade newname
oldname opt still points to the same keg it pointed before upgrade.
The commit fixes this behaviour thus that oldname opt links at the
same keg opt point.
 2015-08-17 01:53:58 +08:00
Vlad Shablinsky
3a764cb549 uninstall: fix --force 
Closes Homebrew/homebrew#42814.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
 2015-08-11 18:13:13 +01:00