35333 Commits

Author SHA1 Message Date
Mike McQuaid
bd8341d422
Merge pull request #15020 from dtrodrigues/pluralize-includecount
Add include_count parameter to pluralize util
2023-03-20 13:53:31 +00:00
Mike McQuaid
1e4abe2cc9
Merge pull request #15018 from dduugg/rm-hash-refinement
Use ActiveSupport Hash#assert_valid_keys instead of refinement
2023-03-20 13:48:47 +00:00
Mike McQuaid
eb6a443aff
Merge pull request #15019 from dduugg/enable-types
Remove misleading upstream.rbi, enable types in on_system
2023-03-20 13:47:37 +00:00
Dustin Rodrigues
b776fb32de
change includecount to include_count for readability 2023-03-20 07:23:17 -04:00
Dustin Rodrigues
e5fba88035
use includecount argument in pluralize 2023-03-19 23:35:47 -04:00
Dustin Rodrigues
b68c955946
utils: add includecount argument to pluralize util 2023-03-19 23:35:40 -04:00
Douglas Eichelberger
92b99b3132 Remove misleading upstream.rbi, enable types in on_system 2023-03-19 19:41:46 -07:00
Douglas Eichelberger
4dcd5ac47f Remove HashValidator 2023-03-19 17:37:58 -07:00
Douglas Eichelberger
516c61057b Use ActiveSupport Hash#assert_valid_keys instend of refinement 2023-03-19 17:37:58 -07:00
Mike McQuaid
98a2923463
Merge pull request #15016 from Homebrew/sponsors-maintainers-man-completions
Update manpage and completions.
4.0.7
2023-03-19 18:53:06 -04:00
Mike McQuaid
94eafdb3fe
Merge pull request #15015 from dtrodrigues/contributions-plural
dev-cmd/contributions: appropriately pluralize contribution statement
2023-03-19 18:52:44 -04:00
Dustin Rodrigues
afae58b430
dev-cmd/contributions: fix typecheck errors 2023-03-19 17:34:35 -04:00
BrewTestBot
df21c36c16
Update manpage and completions.
Autogenerated by the [sponsors-maintainers-man-completions](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/sponsors-maintainers-man-completions.yml) workflow.
2023-03-19 21:33:22 +00:00
Mike McQuaid
203c93196b
Merge pull request #15011 from carlocab/pr-pull-no-cherry-pick
pr-pull: add `--no-cherry-pick` flag
2023-03-19 17:32:31 -04:00
Mike McQuaid
c5fa3d221c
Merge pull request #15009 from apainintheneck/remove-old-prefix-placeholder
cask: remove old prefix placeholder
2023-03-19 17:29:00 -04:00
Mike McQuaid
96eb047121
Merge pull request #15008 from dduugg/enable-types
Enable types in Library/Homebrew/cask, etc.
2023-03-19 17:22:18 -04:00
Mike McQuaid
c31ae1ce6a
Merge pull request #14948 from hyuraku/remove-cask/cmd/fetch
remove `cask/cmd/fetch`
2023-03-19 17:21:22 -04:00
Dustin Rodrigues
834740f04c
dev-cmd/contributions: refactor to shorten line length 2023-03-19 17:12:11 -04:00
Issy Long
b979646c42
Merge pull request #15000 from issyl0/fix-extra-blank-line-in-caveats
caveats: Remove extra blank line between `keg_only` and other caveats
2023-03-19 20:57:15 +00:00
Dustin Rodrigues
a562d6deee
dev-cmd/contributions: appropriately pluralize contribution statement 2023-03-19 16:55:33 -04:00
Carlo Cabrera
e7f15ae0ee
Merge pull request #14974 from ywwry66/install_info_from_path 2023-03-20 04:31:46 +08:00
Issy Long
f10b88ca85
caveats: Add a new line if there isn't one from previous conditions 2023-03-19 18:38:09 +00:00
Carlo Cabrera
e5b9e97b92
Use git merge-base to determine original_commit 2023-03-20 00:55:20 +08:00
Carlo Cabrera
c669f1d625
pr-pull: add --no-cherry-pick flag
Needed for Homebrew/homebrew-core#125556. Without this, `pr-pull`
attempts to cherry-pick commits from the PR branch onto the PR branch,
and then gets upset that nothing happened.

See https://github.com/Homebrew/homebrew-core/actions/runs/4461335852/jobs/7835095294#step:10:40
2023-03-19 23:44:44 +08:00
Nanda H Krishna
8f6276ed5f
Merge pull request #14695 from DestroyerXyz/master
CI: use actions/cache@v3
2023-03-19 10:14:12 -04:00
hyuraku
4271d41e51 remove new specs 2023-03-19 22:31:00 +09:00
Shreyans Jain
cef132f8ca
fix: save-state and set-output deprecated
Signed-off-by: Shreyans Jain <shreyansthebest2007@gmail.com>
2023-03-19 17:37:21 +05:30
hyuraku
dfee012f77 change cask spec to formula one 2023-03-19 19:14:46 +09:00
apainintheneck
c831a1e5cb CI: Change order of tap-syntax step
Now the steps that say they run on all taps are
after the one where we set up all taps.
2023-03-19 00:43:00 -07:00
apainintheneck
d42e9b40d5 formulary: add test for loading service blocks from API 2023-03-19 00:09:16 -07:00
apainintheneck
501730df5d Add service serialization specs 2023-03-19 00:09:16 -07:00
apainintheneck
db8d488db4 service: add info to API json and load from api
As a part of serializing the hash, certain path
placeholders are used for the HOMEBREW_PREFIX and $HOME
directories. Beyond that certain elements need to be
turned back into strings like cron and sockets and symbols
need to be preserved as well.

The run command accepts either an arg or kwargs so it
has to be treated specially here.
2023-03-19 00:09:10 -07:00
Mike McQuaid
26914e2469
Merge pull request #15006 from dduugg/brew-types
Enable typing in Library/Homebrew/brew.rb
2023-03-19 00:33:42 -04:00
apainintheneck
3aae28aa0d cask: remove old prefix placeholder
This was just a temporary workaround while we
waited for the API to regenerate the JSON content.
2023-03-18 16:42:44 -07:00
Douglas Eichelberger
aea54a9ceb Generate RBI for StackProf 2023-03-18 16:29:12 -07:00
Douglas Eichelberger
6415ae6739 Add stackprof to Gemfile 2023-03-18 16:23:08 -07:00
Douglas Eichelberger
4f2ff3819b Clean up rbi files 2023-03-18 16:03:25 -07:00
Douglas Eichelberger
abfe29040b Enable types in Library/Homebrew/cask 2023-03-18 16:03:10 -07:00
Ruiyang Wu
4ac228cc41 Use install-info from texinfo if not available in /usr/bin
`install-info` is not shipped with macOS Ventura and some Linux
distros. This commit uses `install-info` from `texinfo` formula if it
is not available in `/usr/bin`.

See: https://github.com/Homebrew/discussions/discussions/4306
2023-03-18 18:24:03 -04:00
Nanda H Krishna
e89492fc38
Merge pull request #15005 from nandahkrishna/actions-error-remove
utils/github/actions: remove `Error` class
2023-03-18 16:58:49 -04:00
Douglas Eichelberger
2969cdb5c1 Enable types in brew.rb 2023-03-18 13:55:19 -07:00
Douglas Eichelberger
6dc20d253a Add stackprof@0.2.23.rbi 2023-03-18 13:46:13 -07:00
Nanda H Krishna
30845593cc
utils/github/actions: remove Error class 2023-03-18 16:38:08 -04:00
Nanda H Krishna
27bb6ff1dd
Merge pull request #15002 from nandahkrishna/actions-multiline-envfile
utils/github/actions: add `format_multiline_string` method
2023-03-18 15:31:12 -04:00
Rylan Polster
5550aa215e
Merge pull request #15001 from issyl0/cask-tests-fix-for-ventura
test/cask: Fix "System Settings" caveats for (non-)Ventura OSes
2023-03-18 11:32:48 -04:00
Issy Long
13fe1bb4b4
formula_auditor: Better keg_only reason message
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2023-03-18 15:27:35 +00:00
Issy Long
865e99c611
test/cask: Rename 'expected_json_ventura' since it's >= Ventura
- Let's actually show in the fixtures JSON filename what's changed
  between the two.
2023-03-18 15:16:23 +00:00
Nanda H Krishna
b792a5fd20
utils/github/actions: add format_multiline_string method 2023-03-18 10:49:16 -04:00
Issy Long
bda88ce96e
formula_auditor: Having HOMEBREW_PREFIX in keg_only reasons is bad
- Fixes issue 14996.
- The API JSON is generated with a `/usr/local` Homebrew prefix, but
  frequently now users have `/opt/homebrew` as their prefix. Since
  formulae `keg_only` reasons are generated by the API, this can lead
  to the confusing messaging that follows:

```
socket_vmnet is keg-only, which means it was not symlinked into /opt/homebrew,
because /usr/local/bin is often writable by a non-admin user.
```

- With this change, that formula as it is now will fail `brew audit`,
  prompting to remove the prefix reference.

```
❯ HOMEBREW_NO_INSTALL_FROM_API=1 brew audit --strict socket_vmnet
socket_vmnet:
  * `keg_only` reason should not include `HOMEBREW_PREFIX` as it provides confusing output.
Error: 1 problem in 1 formula detected
```
2023-03-18 14:46:13 +00:00
Issy Long
6b4b923b44
test/cask: Fix "System Settings" caveats for (non-)Ventura OSes
- "System Preferences" was updated to be "System Settings" in macOS
  Ventura. This naming was updated in our caveats generator in PR 14997.
- This test was failing for me locally (on Ventura) because it was
  hardcoded to expect `System Preferences => Security & Privacy`, but
  getting `System Settings => Privacy & Security`.
- This is not the most important thing in the world, we can probably
  live with the failing test, but I thought I'd try to fix it anyway.
2023-03-18 13:19:20 +00:00