Max Eisner
a56feff5d0
adapt to executable and subcmd being mandatory
2022-09-06 14:42:00 +02:00
Max Eisner
60db35096f
simplify and comment dangling comma handling
2022-09-06 14:42:00 +02:00
Max Eisner
ab09d15703
remove newlines left behind after correction
2022-09-06 14:42:00 +02:00
Max Eisner
de7ef64f61
use #inspect instead of wrapping symbols
2022-09-06 14:41:59 +02:00
Max Eisner
a002463362
#delete_suffix instead of #sub
2022-09-06 14:41:59 +02:00
Max Eisner
1b15d03634
remove always-true condition
2022-09-06 14:41:59 +02:00
Max Eisner
8398dfbae0
fix condition array substraction
2022-09-06 14:41:59 +02:00
Max Eisner
06518ec613
add RuboCop to combine multiple calls
2022-09-06 14:41:59 +02:00
Max Eisner
e4b67e84dd
fix shell parameter type
2022-09-06 14:41:59 +02:00
Max Eisner
d963a1ae2f
style
2022-09-06 14:41:59 +02:00
Max Eisner
2329844f50
refactor: naming
2022-09-06 14:41:58 +02:00
Max Eisner
50ae38a372
add :arg shell_parameter
2022-09-06 14:41:58 +02:00
Max Eisner
b901e5873d
do not use parantheses if no args given to method
2022-09-06 14:41:58 +02:00
Max Eisner
0509eebda4
fix: don't write binary param if base_name == binary/base_name
2022-09-06 14:41:58 +02:00
Max Eisner
fd98c3df58
add preliminary RuboCop for generate_completions DSL
2022-09-06 14:41:57 +02:00
Rylan Polster
1c54e915b6
Update cask rubocops to use on_arch blocks and sha256 arm:, intel:
2022-08-25 00:49:28 -04:00
Rylan Polster
3f00893201
Include on_{system} blocks as stanzas in rubocop
2022-08-23 14:09:29 -04:00
Rylan Polster
af99dfba00
Refactor on_system rubocops for use in casks
2022-08-14 17:31:07 -04:00
Rylan Polster
dd2b1ce7e9
Merge pull request #13681 from Rylan12/cask-variables-rubocop
...
Add and adjust cask rubocops to handle variables
2022-08-11 20:05:08 -04:00
Rylan Polster
ec132ff851
Add and adjust cask rubocops to handle variables
2022-08-10 17:45:43 -04:00
Rylan Polster
39071d5816
Remove arch from cask stanza ordering temporarily
2022-08-10 15:37:28 -04:00
Mike McQuaid
6b697470fd
brew style --fix
...
For https://github.com/Homebrew/brew/pull/13671
2022-08-10 14:19:33 +01:00
Rylan Polster
dd72f1ac95
Add arch cask DSL
2022-08-05 17:12:55 -04:00
fn ⌃ ⌥
d5f949e60b
Check dependency order in on_system methods
2022-08-03 06:33:30 -07:00
Rylan Polster
2c3926ae1e
Check nesting for blocks with one child
2022-07-24 23:37:36 +02:00
Rylan Polster
a4327521d5
Add on_system to and reorder component order cop
2022-07-24 23:37:35 +02:00
Rylan Polster
d5d6456b24
Add checks for on_system method
2022-07-24 23:01:56 +02:00
Rylan Polster
7b24ed3b4d
Update OnSystem cop to check other on_{system} methods
2022-07-24 23:01:56 +02:00
fn ⌃ ⌥
49867da232
rubocops: allow uses_from_macos "less"
2022-07-12 13:31:51 -07:00
danielnachun
ed1324c9ca
add pax to allowlist
2022-07-05 09:57:10 -07:00
Rylan Polster
9b49561066
Update components_order cop to check other on_{system} methods
2022-07-01 10:52:41 -04:00
Mike McQuaid
22d6af1258
Manual brew style fixes.
2022-06-30 08:56:21 +01:00
Mike McQuaid
2d5eab2e1c
brew style --fix
2022-06-30 08:56:21 +01:00
danielbayley
7d145f5798
Fix Rubocop trailing / bug
2022-04-27 18:42:11 +01:00
Bo Anderson
1c73e25627
uses_from_macos: allow libxcrypt
2022-04-27 15:08:43 +01:00
Issy Long
f8d9a5c2db
rubocops/urls: In regexps, only allow valid hostname characters
...
> This regular expression has an unrestricted wildcard '.*' which may cause 'googlecode\.com/files' to be matched anywhere in the URL, outside the hostname.
2022-04-15 16:45:41 +01:00
Issy Long
aa36b343ca
rubocops/urls: Escape .s in hostnames in regexps
2022-04-15 16:45:25 +01:00
Issy Long
ffe0c18b2a
rubocops/homepage: Escape .s in hostnames in regexps
2022-04-15 15:46:36 +01:00
Bo Anderson
212a9efaf5
rubocops/uses_from_macos: allow keg only berkeley-db
2022-03-30 14:24:10 +01:00
Mike McQuaid
03f7b254e9
rubocops: fix OnOs block checks.
...
This wasn't correctly flagging the use of `on_os` in `test do` as
invalid.
2022-03-29 19:15:03 +01:00
Carlo Cabrera
f05e57f414
Merge pull request #12823 from carlocab/setuptools-audit
...
rubocops/text: remove `setuptools` audit
2022-02-01 16:57:57 +08:00
Mike McQuaid
1486a1ed2a
Merge pull request #12822 from rickmark/master
...
Fix for GitHub url ends with ‘.git’ check
2022-02-01 08:37:57 +00:00
Carlo Cabrera
bc67c05528
rubocops/text: remove setuptools audit
...
This currently no longer applies, because we might sometimes need an
older `setuptools` than the one shipped with a Python formula.
This is needed for Homebrew/homebrew-core#93964 .
2022-02-01 15:26:50 +08:00
Rick Mark
dd7a33649f
Update homepage.rb
2022-02-01 00:03:48 -07:00
Roland Crosby
d8df9c2ee9
Allow cargo build --lib
...
When building Rust packages that provide libraries but no executable
binaries, `cargo install` doesn't do anything; you need to use `cargo
build` and install any libraries manually. See e.g.
rust-lang/cargo#8294 .
Unfortunately, Homebrew's Rubocop "use cargo install *std_cargo_args"
rule, as currently written, blocks all invocations of `cargo build`.
This commit changes that rule to exclude invocations of `cargo build`
that use the `--lib` argument (`--lib` specifies to Cargo that a
package's library targets should be built). This will enable library
packages to be built while retaining the "use cargo install
*std_cargo_args" message for the more common case when a Rust package
provides executable binaries.
2022-01-31 21:11:22 -05:00
Bevan Kay
8c82ec964f
Update Library/Homebrew/rubocops/cask/url_legacy_comma_separators.rb
...
Co-authored-by: Issy Long <issyl0@github.com>
2022-01-12 10:40:22 +11:00
Bevan Kay
d371547d5a
fix tests
2022-01-12 10:39:38 +11:00
Bevan Kay
7e24930e4e
Update Library/Homebrew/rubocops/cask/url_legacy_comma_separators.rb
...
Co-authored-by: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
2022-01-11 01:22:22 +11:00
Bevan Kay
22d68fb99b
fix style offences
2022-01-10 21:34:51 +11:00
Bevan Kay
cc2b99c8cf
Add check for url :block
2022-01-10 21:27:20 +11:00
