1466 Commits

Author SHA1 Message Date
Rylan Polster
036723a668
Add deprecate! and disable! methods to the Cask DSL 2023-12-16 20:01:46 -05:00
Bo Anderson
5692c8ecbf
Fix style violations under newer RuboCop 2023-12-14 05:47:12 +00:00
Mike McQuaid
beb9799265
cmd/untap: fix untapping syntax failure.
If an installed cask is invalid on attempting an untap: it will
prevent untapping that cask.

Fix this in two ways: one more specific to `untap` and one more
generally to other commands too:
- specific: only read the actual formulae/casks from the tap we're
  untapping instead of all of those that are installed
- general: rescue more exceptions in `Cask::Caskroom.casks` (like we
  already do for `Formula.installed`
2023-12-13 13:54:37 +00:00
Bo Anderson
b42256d286
Deprecate, disable & delete code for Homebrew 4.2.0 2023-12-07 23:42:13 +00:00
Bo Anderson
fe011ca0f9
Partially support pour_bottle? in API 2023-12-07 18:05:41 +00:00
Bo Anderson
27730f68c5
formula: fix specified_path for aliases without core tap 2023-12-01 17:00:15 +00:00
Mike McQuaid
1b8207bf47
Merge pull request #16250 from branchvincent/pip-cache
formula: add `PIP_CACHE_DIR` to build env
2023-11-23 12:54:01 +00:00
Mike McQuaid
1e2cdc6eac
formula: tweak cache ordering. 2023-11-23 12:38:51 +00:00
Branch Vincent
e58ed46195
formula: add PIP_CACHE_DIR to build env 2023-11-22 13:53:05 -08:00
Rylan Polster
8704e79cc0
Separate MacOS references 2023-11-15 18:19:39 -05:00
Mike McQuaid
ff404fe5ab
Merge pull request #16184 from dduugg/rm-try
Remove use of ActiveSupport try
2023-11-06 13:11:01 +00:00
Douglas Eichelberger
00ba09d73d Remove use of ActiveSupport try 2023-11-05 09:28:19 -08:00
Douglas Eichelberger
0191af7899 resolve typecheck errors 2023-11-05 08:55:58 -08:00
Eric Knibbe
03e743a75e
api: add using: attribute to head & stable URLs 2023-10-11 14:14:18 -04:00
Mike McQuaid
6b01bc1773
Merge pull request #16007 from Bo98/better-readall
Improve performance of `brew readall`
2023-09-28 14:44:21 +01:00
Bo Anderson
0c08a3cccb
Improve performance of Formula#to_hash 2023-09-28 14:07:25 +01:00
Bo Anderson
e4623cc8f4
Improve performance of brew readall 2023-09-28 14:05:09 +01:00
apainintheneck
5760ae4fb2 cmd/readall: Cleanup todos
- keep running the command against all os/arch combinations
  as the default
- remove todos and deprecations related to changing the behavior
- create constants for os/arch combinations
2023-09-19 21:33:13 -07:00
apainintheneck
7e05a9b574 cmd/audit: improve performance of versioned formula names
There is a check for other versioned formula with the same name
in the file audit. This just memoizes all of the versioned
formulae in a tap during the first call and then uses that much
shorter list everytime it checks for things.
2023-09-16 09:18:13 -07:00
Bo Anderson
be2834ace8
formula: add global caching for declared_runtime_dependencies 2023-09-15 03:08:27 +01:00
Sam Ford
578c935bcf
Formula, BuildError: Update type signatures
We're seeing type errors when building formulae that use something
like `xcodebuild ..., "-arch", Hardware::CPU.arch`, since `CPU.arch`
is a symbol. We've been addressing these issues by calling `#to_s` on
the value but there was some talk about simply expanding the type
signatures to accommodate anything that will be cast to a `String`.

There's maybe still an argument to be made for doing string conversion
in formulae but expanding the type signatures will resolve a number of
existing type errors if we simply want to rely on implicit type
casting.

Past that, this also updates the type signature for `BuildError` to
align with the `#system` signature changes, as we receive a type error
otherwise.
2023-09-13 19:16:04 -04:00
Eric Knibbe
931f762598
docs+rubydoc: various grammar/wording fixes 2023-09-11 02:26:37 -04:00
Eric Knibbe
bd659ce4d0
formula: fixes for rubydoc output
in particular, #generate_completions_from_executable
2023-09-09 14:54:45 -04:00
hyuraku
08c4e6848e remove useless require 2023-09-08 22:52:33 +09:00
hyuraku
adc2a2fea1 remove ARGV from Formula#all 2023-09-02 19:35:22 +09:00
Branch Vincent
f8ab19d187
formula: drop old pip feature flag 2023-08-26 12:48:16 +01:00
Mike McQuaid
d313e8b027
Merge pull request #15824 from dduugg/inreplace-static
Make inreplace a purely static method v2
2023-08-08 12:32:10 +01:00
Douglas Eichelberger
5d5c22e104 Replace integration test with unit test 2023-08-07 18:32:08 -07:00
Douglas Eichelberger
2b29c498fa s/blk/block 2023-08-07 17:26:46 -07:00
Branch Vincent
61d23fef53
formula: use pip's --no-compile 2023-08-05 16:39:29 -07:00
Douglas Eichelberger
864f31e52a Forward block argument 2023-08-04 16:20:56 -07:00
Douglas Eichelberger
efd02b956d Revert "Revert "Make inreplace a purely static method""
This reverts commit 8656caa67ce2dd9ec6484969b183c1fd7805451e.
2023-08-04 16:20:38 -07:00
Alexander Bayandin
8656caa67c
Revert "Make inreplace a purely static method" 2023-08-03 16:16:19 +01:00
Douglas Eichelberger
da33049c69 Resolve Style/OptionalBooleanParameter violation 2023-08-02 14:47:06 -07:00
Douglas Eichelberger
2ad87f87d5 Make inreplace a purely static method 2023-08-02 09:44:18 -07:00
Douglas Eichelberger
8d8dac0de4 Narrow member type of inreplace paths enumerable 2023-08-01 09:22:48 -07:00
Douglas Eichelberger
da8a062cfc Widen paths type in Formula#inreplace 2023-07-31 11:31:35 -07:00
Branch Vincent
768a8085a7
formula: suppress std args for cabal, meson, pip 2023-07-31 08:53:34 -07:00
Branch Vincent
8b016141cd
formula: fix std_cargo_args type error 2023-07-25 20:41:16 -07:00
Douglas Eichelberger
a4ca2b9e0b remove unnecessary casts 2023-07-24 22:08:52 -07:00
Douglas Eichelberger
b5c145cfa9 Add init sig as well 2023-07-24 14:12:47 -07:00
Douglas Eichelberger
08e46c18cd Add type to Formula attrs 2023-07-24 14:12:36 -07:00
Douglas Eichelberger
a46430a390 Fix type error when running 'brew doctor' 2023-07-24 07:00:26 -07:00
Mike McQuaid
3b3300546b
Merge pull request #15741 from dduugg/stict-type-string_inreplace_extension 2023-07-24 08:40:46 +01:00
Douglas Eichelberger
6d53c52d2c Add sigs to Formula boolean methods 2023-07-23 21:05:02 -07:00
Branch Vincent
b7775fa007
formula: fix std_pip_args with empty prefix 2023-07-23 20:35:44 -07:00
Douglas Eichelberger
09885cad3a Add sigs to Formula pathname methods 2023-07-23 18:42:06 -07:00
Carlo Cabrera
a1bf42cc89
formula: fix inreplace typechecking error
Fixes

        TypeError: Parameter 'before': Expected type T.nilable(T.any(Regexp, String)), got type Pathname with value #<Pathname:/opt/homebrew/Cellar/php/8.2.8/lib/php>
      Caller: /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/php.rb:207
      Definition: /opt/homebrew/Library/Homebrew/formula.rb:2483

https://github.com/Homebrew/homebrew-core/actions/runs/5635089949/job/15265751616?pr=137335#step:3:1732
2023-07-23 15:23:45 +08:00
Carlo Cabrera
d0b0fa5421
formula: fix typechecking error in std_cmake_args
`install_libdir` is sometimes passed a `Pathname`.
2023-07-23 01:52:58 +08:00
Douglas Eichelberger
f55c2a4e8e Fix type error 2023-07-21 20:09:00 -07:00