14976 Commits

Author SHA1 Message Date
Markus Reiter
b7ea9e1830 Allow access to lock directory inside tests. 2018-10-17 14:23:02 +02:00
Markus Reiter
178db5dca5
Merge pull request #5104 from reitermarkus/create-cache
Ensure cache directory for `CacheStoreDatabase` exists.
2018-10-16 23:54:46 +02:00
Markus Reiter
dbf5d5b222
Merge pull request #5118 from reitermarkus/brew-cask-style
Run `rubocop` in temporary directory to skip reading parent config.
2018-10-16 22:00:37 +02:00
Markus Reiter
8aab6dc03d Run rubocop in temporary directory to skip reading parent config. 2018-10-16 14:55:00 +02:00
Markus Reiter
afb75a67b1 Ensure cache directory for CacheStoreDatabase exists. 2018-10-16 11:16:17 +02:00
Mike McQuaid
1621eb0b9d
description_cache_store: handle empty database.
Don't perform an incremental update from a report or list of formulae if
the cache is currently empty.

Also, remove some accidentally remaining debugging output.
2018-10-15 22:51:43 -07:00
Mike McQuaid
4def45f499
utils/github_spec: use author that exists. 2018-10-15 14:15:08 -07:00
Mike McQuaid
056dd588b2
utils/github: add ValidationFailedError.
These have specific errors returned so would be more useful to output.
2018-10-15 12:03:16 -07:00
Markus Reiter
473155e12c
Merge pull request #5103 from reitermarkus/incomplete-downloads
Fix cleanup of incomplete downloads.
2018-10-15 15:19:56 +02:00
Mike McQuaid
9bcb1d5b01
Merge pull request #5100 from MikeMcQuaid/or-later-default
bottles: make `or_later` the default.
2018-10-14 20:25:34 -07:00
Mike McQuaid
1cf020a823
Merge pull request #5102 from MikeMcQuaid/analytics-build-error-options
analytics: fix display of build error options.
2018-10-14 12:33:53 -07:00
Mike McQuaid
f04b0b3130
Merge pull request #5107 from MikeMcQuaid/homebrew-core-line-length
Shorten tap line length
2018-10-14 11:43:19 -07:00
Mike McQuaid
960207295b
rubocop.yml: reduce linelength. 2018-10-13 18:45:39 -07:00
Mike McQuaid
a2074f01a2
Merge pull request #4922 from MikeMcQuaid/azure-coverage
Generate Cobertura coverage data for Azure Pipelines
2018-10-14 02:19:06 +01:00
Mike McQuaid
100e85dda1
Generate Cobertura coverage data for Azure Pipelines
These can be used and displayed directly in the Azure Pipelines GUI.

It may not end up replacing CodeCov but it's easy enough so: why not.
2018-10-13 17:55:04 -07:00
Mike McQuaid
9a144fe0bd
Merge pull request #5095 from EricFromCanada/cli-parser-help
cli_parser: improve help text formatting
2018-10-14 00:27:38 +01:00
Markus Reiter
1f24c6600c Fix cleanup of incomplete downloads. 2018-10-14 00:15:16 +02:00
Mike McQuaid
c2d23838d0
analytics: fix display of build error options.
Currently these are all like `wget #<Options:0x0000000101171658>`.
2018-10-13 15:09:03 -07:00
Markus Reiter
9b84b2404a
Merge pull request #5087 from amyspark/xattr-fail
Cask: fix quarantine check when xattr is broken
2018-10-13 23:52:41 +02:00
Markus Reiter
6d41f4fa7c
Merge pull request #5061 from amyspark/quarantine-symlinks
Cask: set write permissions on symlinks
2018-10-13 23:49:13 +02:00
Markus Reiter
2cb0050a99
Merge pull request #5099 from alecclarke/fix-style-in-uninstall_zap_shared_examples
Use the `all` matcher to check the existence of each path.
2018-10-13 23:27:43 +02:00
Mike McQuaid
8dd59548ed
bottles: make or_later the default.
When Mojave was in beta we made it so that High Sierra bottles would
automatically be used on Mojave. Let's make this the default in general:
older bottles will be used on newer versions of macOS when a newer
bottle is not available.

This should make it easier for taps to bottle single versions of bottles
which will work more widely and to give us breathing room whenever a new
version of macOS is released.

Currently this only applies to the `wine` formula which will have the
`or_later` removed in a Homebrew/homebrew-core PR.

Question: should we use an `odeprecated` for the use of `or_later`?
2018-10-13 12:39:21 -07:00
Mike McQuaid
65b44f2f57
Merge pull request #5098 from Homebrew/dependabot/bundler/Library/Homebrew/test/mustache-1.1.0
Bump mustache from 1.0.5 to 1.1.0 in /Library/Homebrew/test
2018-10-13 19:54:52 +01:00
Mike McQuaid
5118fe2503
Merge pull request #5096 from MikeMcQuaid/descriptions-cache
Use cache_store for descriptions
2018-10-13 19:54:25 +01:00
Mike McQuaid
fe6b78a3f3
Use cache_store for descriptions
This makes use of both the existing interfaces and could use the
existing cache file but we'll create a new one and cleanup the old one
to avoid issues and use a more consistent name.
2018-10-13 08:22:52 -07:00
Alec Clarke
3a8e87134b Use the all matcher to check the existence of each path.
This change allows us to remove the `RSpec/IteratedExpectation` rule from `.rubocop_todo.yml` as we no longer iterate over each path to check existence.

Note: We this PR didn't change the subsequent test checking for the negative expectations as this isn't part of the rule (see: https://github.com/rubocop-hq/rubocop-rspec/issues/278).
2018-10-13 07:23:57 -07:00
dependabot[bot]
e19a0fe719
Bump mustache from 1.0.5 to 1.1.0 in /Library/Homebrew/test
Bumps [mustache](https://github.com/mustache/mustache) from 1.0.5 to 1.1.0.
- [Release notes](https://github.com/mustache/mustache/releases)
- [Changelog](https://github.com/mustache/mustache/blob/master/HISTORY.md)
- [Commits](https://github.com/mustache/mustache/compare/v1.0.5...v1.1.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-13 14:17:44 +00:00
L. E. Segovia
1707caf968
Cask: fix quarantine check when xattr is broken 2018-10-13 01:27:36 +00:00
EricFromCanada
6b8724431f cli_parser: improve help text formatting
- reduce desc_line_length so `brew help` output fits in 80 columns
- support special formatting across line breaks
- support emphasis using asterisks
- add missing depends_on: tests
2018-10-12 13:38:14 -04:00
Mike McQuaid
662641557e
Merge pull request #5085 from alyssais/bump_formula_pr-no_fork
bump-formula-pr: gracefully handle unforkable repositories
2018-10-12 11:05:08 +01:00
Mike McQuaid
778e0dbdb1
Merge pull request #5043 from javian/rubocopadjustment
rubocop: only use config if style is testing specified file(s)
2018-10-12 11:02:28 +01:00
commitay
c2bf97bdee audit: use core_tap instead of official_tap 2018-10-12 09:12:12 +10:00
Alyssa Ross
864475e14f
bump-formula-pr: use GitHub error message info
This saves an API call, and is more accurate, because the repo API
doesn't actually say whether forking is enabled, but this error message
does.

To do this, the original GitHub error message had to be accessible on
the GitHub exceptions.
2018-10-11 16:39:29 +01:00
Alyssa Ross
23984273f3
bump-formula-pr: always use base if unforkable 2018-10-11 16:34:40 +01:00
Alyssa Ross
f4a82236b7
bump-formula-pr: add --no-fork
GitHub seems to be discouraging forking private repositories[0]:

> By default, new organizations are configured to disallow the forking
> of private repositories.

bump-formula-pr tries to create its pull requests from a fork, so it
can't be used for private taps set up in this way.

I've added a --no-fork option that will create PRs in the tap repo
itself, rather than in a fork, to accommodate this use case.

[0]: https://help.github.com/articles/allowing-people-to-fork-private-repositories-in-your-organization/
2018-10-11 13:23:56 +01:00
Mike McQuaid
17154abf46
Merge pull request #5076 from aimileus/search-perf
Remove redundant check in formula_files and cask_files
2018-10-10 17:26:01 +01:00
Emiel Wiedijk
0fcdc9ba07
Create method ruby_file?
Both formula_files and cask_files need to check whether a file is
a Ruby file. Also, use this method in formula_file? and cask_file?
2018-10-10 17:31:09 +02:00
Mike McQuaid
448096168b
Update manpages
- dev-cmd/man: sort the `cmd_path`s (for APFS)
- update manpages based on latest content
2018-10-10 14:41:50 +01:00
Mike McQuaid
b1b0b08361
Merge pull request #5078 from Homebrew/dependabot/bundler/Library/Homebrew/test/rspec-expectations-3.8.2
Bump rspec-expectations from 3.8.1 to 3.8.2 in /Library/Homebrew/test
2018-10-10 12:45:05 +01:00
Dominique Orban
ea0ef6bf81 audit: permit openblas for non-official taps
macOS provides Accelerate but not OpenBLAS
2018-10-09 14:57:30 -07:00
dependabot[bot]
b666aa407f
Bump rspec-expectations from 3.8.1 to 3.8.2 in /Library/Homebrew/test
Bumps [rspec-expectations](https://github.com/rspec/rspec-expectations) from 3.8.1 to 3.8.2.
- [Release notes](https://github.com/rspec/rspec-expectations/releases)
- [Changelog](https://github.com/rspec/rspec-expectations/blob/master/Changelog.md)
- [Commits](https://github.com/rspec/rspec-expectations/compare/v3.8.1...v3.8.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-09 20:49:19 +00:00
Jan Viljanen
ce530fd0f5 move rspec pattern 2018-10-09 22:10:25 +02:00
Emiel Wiedijk
6ac30826d0
Remove redundant check in formula_files and cask_files
Formula_files consists of every non-recursive child of formula_dir,
for which formula_file? evaluates to true. formula_file? checks if the file
is a child of formula_dir, which it is by definition. It turns out that by
removing the check, the time used for 'brew search' decreased from 800 ms to
700 ms, noticably faster during tab completion. The same happens with
cask_files and cask_file?
2018-10-09 21:07:40 +02:00
Mike McQuaid
cf1c951e2f
Merge pull request #5063 from Homebrew/dependabot/bundler/Library/Homebrew/test/codecov-0.1.13
Bump codecov from 0.1.11 to 0.1.13 in /Library/Homebrew/test
2018-10-09 10:32:23 +01:00
commitay
5024efa506
Merge pull request #5059 from commitay/remove-checkpoint
remove appcast checkpoint audit
2018-10-09 15:21:24 +10:00
commitay
cd1cf8927e
Merge pull request #5060 from commitay/openssl-versioned-whitelist
audit: remove `openssl@1.1` from unstable spec whitelist
2018-10-09 15:12:38 +10:00
Shaun Jackman
7b13f4a402
Merge pull request #5067 from sjackman/audit-head
audit: Permit HEAD for non-official taps
2018-10-08 21:29:30 -07:00
L. E. Segovia
2c9b599c0a
Cask: simplify chmod +w passes 2018-10-08 18:23:21 +00:00
Jan Viljanen
aa6912425e rubocop: move rspec include to root config file
To avoid confusion and bugs in rubocop robucop-spec should be required
from the root config.
2018-10-08 20:08:38 +02:00
Jan Viljanen
bca922fd5b rubocop: only use config if style is testing specified file(s) 2018-10-08 20:08:37 +02:00