Mike McQuaid
b7c55422b5
cmd/update-report: avoid unnecessary EOS.
...
Co-authored-by: Douglas Eichelberger <dduugg@users.noreply.github.com>
2023-03-28 08:49:05 +01:00
Mike McQuaid
9de0b619f3
More update tweaks
...
- Make copying to `*_names.before.txt` the responsibility of `update.sh`
(unless the file doesn't exist at all). This provides the added
benefit of allowing the inspection of the before/after state after
running a `brew update` rather than both files always being identical
at this point.
- State `No changes to formulae or casks.` on macOS.
- Rename and flip `updated_formula_report` to `auto_update`; this naming
was confusing every time.
- Only display the `You can upgrade with...` messaging if we're not
auto-updating as sometimes it will be displayed before the commands it
references (e.g. `upgrade`, `outdated` or an `install` that proceeds
to upgrade these formulae).
Fixes https://github.com/Homebrew/brew/issues/15065
2023-03-27 17:24:32 +01:00
Mike McQuaid
cf6614b50e
Merge pull request #15061 from reitermarkus/keyboard-layout
...
Add `keyboard_layout` stanza.
4.0.10
2023-03-27 14:54:46 +01:00
Mike McQuaid
47c7f006c8
Merge pull request #15064 from bevanjkay/allow-arch-in-flight
...
cask/dsl: pass #{arch} to flight blocks
2023-03-27 14:54:05 +01:00
Bevan Kay
68584ac7a7
dsl: pass #{arch} to flight blocks
2023-03-27 11:28:59 +11:00
Markus Reiter
140d444462
Merge pull request #15056 from reitermarkus/fetch-arch
...
Allow fetching for different arch.
2023-03-26 17:28:38 +02:00
Markus Reiter
c38f0c3aae
Fix typecheck.
2023-03-26 09:26:36 +02:00
Markus Reiter
471ce0b880
Use keyboard_layout stanza in livecheck.
2023-03-26 08:14:24 +02:00
Markus Reiter
3da305fa80
Add keyboard_layout stanza.
2023-03-26 08:14:24 +02:00
Issy Long
d43ba7c306
Merge pull request #15013 from issyl0/rubocops-cask-no-overrides
2023-03-25 13:44:19 +00:00
Markus Reiter
5e52d415a9
Allow fetching for different arch.
2023-03-25 11:56:09 +01:00
Nanda H Krishna
c271a9ae75
Merge pull request #15054 from Homebrew/dependabot/bundler/Library/Homebrew/rspec-sorbet-1.9.2
...
build(deps): bump rspec-sorbet from 1.9.1 to 1.9.2 in /Library/Homebrew
2023-03-24 15:35:23 -04:00
Nanda H Krishna
4ee55f790b
Merge pull request #15055 from Homebrew/dependabot/bundler/Library/Homebrew/connection_pool-2.4.0
...
build(deps): bump connection_pool from 2.3.0 to 2.4.0 in /Library/Homebrew
2023-03-24 15:33:58 -04:00
BrewTestBot
70b55ffbb5
Update RBI files for connection_pool.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-03-24 19:18:25 +00:00
BrewTestBot
5bd839c132
Update RBI files for rspec-sorbet.
...
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gems.yml ) workflow.
2023-03-24 19:16:45 +00:00
BrewTestBot
0c583a0b7d
brew vendor-gems: commit updates.
2023-03-24 19:12:37 +00:00
BrewTestBot
95bd2c002b
brew vendor-gems: commit updates.
2023-03-24 19:11:17 +00:00
dependabot[bot]
1ed5f828e4
build(deps): bump connection_pool in /Library/Homebrew
...
Bumps [connection_pool](https://github.com/mperham/connection_pool ) from 2.3.0 to 2.4.0.
- [Release notes](https://github.com/mperham/connection_pool/releases )
- [Changelog](https://github.com/mperham/connection_pool/blob/main/Changes.md )
- [Commits](https://github.com/mperham/connection_pool/compare/v2.3.0...v2.4.0 )
---
updated-dependencies:
- dependency-name: connection_pool
dependency-type: indirect
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-03-24 19:08:48 +00:00
dependabot[bot]
f5909de3bd
build(deps): bump rspec-sorbet from 1.9.1 to 1.9.2 in /Library/Homebrew
...
Bumps [rspec-sorbet](https://github.com/samuelgiles/rspec-sorbet ) from 1.9.1 to 1.9.2.
- [Release notes](https://github.com/samuelgiles/rspec-sorbet/releases )
- [Changelog](https://github.com/samuelgiles/rspec-sorbet/blob/master/CHANGELOG.md )
- [Commits](https://github.com/samuelgiles/rspec-sorbet/commits/v1.9.2 )
---
updated-dependencies:
- dependency-name: rspec-sorbet
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-03-24 19:07:41 +00:00
Mike McQuaid
d80f7ac48e
Merge pull request #15052 from MikeMcQuaid/formulary_service
...
formulary: require service.
2023-03-24 10:42:17 +00:00
Mike McQuaid
a0eb5ebec7
formulary: require service.
...
This is used in this file.
2023-03-24 09:23:09 +00:00
Mike McQuaid
9a491a2bd3
Merge pull request #15050 from Homebrew/no_more_ubuntu_16
...
docker: stop building Ubuntu 16.04 image.
2023-03-24 09:13:17 +00:00
Mike McQuaid
6a77ef2170
docker: stop building Ubuntu 16.04 image.
...
This is too slow to be building every time and we're long past the
deprecation date.
Fixes https://github.com/Homebrew/brew/issues/14661
2023-03-24 08:57:48 +00:00
Mike McQuaid
fad8deda56
Merge pull request #15046 from issyl0/rubocop-method-parameter-pr
...
rubocop: Remove the final `Naming/MethodParameterName` exceptions: `pr`
2023-03-24 08:51:49 +00:00
Mike McQuaid
7b4de4ad1f
Merge pull request #15035 from hartwork/dockerfile-fix-build
...
Dockerfile: Fix the build, package gh exists in Ubuntu >=22 only
2023-03-24 08:44:31 +00:00
Sebastian Pipping
bd16355a07
docker.yml: Run for pull requests also, for debuggability
2023-03-24 05:43:04 +01:00
Sebastian Pipping
05319c86dc
Dockerfile: Install gpg (GnuPG 2.x) for Ubuntu 18 and 20 also
2023-03-24 05:42:33 +01:00
Kevin
86c518e2d7
Merge pull request #15007 from apainintheneck/add-service-block-to-formula-api
...
Add service block to formula api
2023-03-23 17:30:04 -07:00
Issy Long
61dc026fcc
rubocop: Remove the final Naming/MethodParameterName exceptions: pr
...
- Core RuboCop didn't want this shortening upstreamed, but that's OK!
2023-03-24 00:29:42 +00:00
Sebastian Pipping
51f171e506
Dockerfile: Fix the build, package gh exists in Ubuntu >=22 only
2023-03-23 20:38:08 +01:00
Issy Long
e4156909d4
Only take overrideable stanzas into account
...
- This skips over stanza names that are not overrideable in `on_*`
blocks, with the positive side effect that `on_*` blocks themselves
aren't in the list so we can get rid of another conditional.
- Stanzas overrideable in blocks are defined in `Cask::DSL` by each of
the methods calling `set_unique_stanza`.
2023-03-23 18:59:29 +00:00
Mike McQuaid
78feddce94
Merge pull request #15044 from Homebrew/revert-15040-move_cask/cmd/reinstall
...
Revert "move `cask/cmd/reinstall`"
2023-03-23 17:26:21 +00:00
Mike McQuaid
253dca568c
Revert "move cask/cmd/reinstall"
2023-03-23 17:06:42 +00:00
Mike McQuaid
8f9caa3427
Merge pull request #15040 from hyuraku/move_cask/cmd/reinstall
...
move `cask/cmd/reinstall`
2023-03-23 16:31:01 +00:00
hyuraku
6a5ed3497e
repair the options
2023-03-24 00:42:10 +09:00
Mike McQuaid
c31da2b3c9
Merge pull request #15042 from MikeMcQuaid/skip_post_install
...
Add `brew install --skip-post-install`
2023-03-23 15:37:06 +00:00
Mike McQuaid
95a8c3f638
Add brew install --skip-post-install
...
Will be needed by `brew test-bot`.
2023-03-23 15:22:27 +00:00
hyuraku
ca3520e379
repair Cask#Reinstall::reinstall_casks
2023-03-23 23:39:58 +09:00
Issy Long
d4d413db62
String interpolations in regexps should also be allowed
...
- This came up in Cask `simply-fortran`:
```
Scanning /opt/homebrew/Library/Taps/homebrew/homebrew-cask/Casks/simply-fortran.rb
send_node: s(:send, nil, :arch), send_node.parent: s(:begin,
s(:send, nil, :arch)), send_node.parent.parent: (regexp
(str "href=.*?simplyfortran[._-]v?(\\d+(?:\\.\\d+)+)")
(begin
(send nil :arch))
(str "\\.dmg")
(regopt :i))
Casks/simply-fortran.rb:2:3: C: Cask/NoOverrides: Do not use a top-level arch stanza as the default. Add it to an on_{system} block instead.
Use :or_older or :or_newer to specify a range of macOS versions.
arch arm: "-arm64", intel: "-x86_64"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1 file inspected, 1 offense detected
```
2023-03-23 13:55:00 +00:00
hyuraku
75c867e296
move cask/cmd/reinstall_spec to cask/reinstall_spec
2023-03-23 22:50:28 +09:00
hyuraku
31e49d96af
move cask/cmd/reinstall to cask/reinstall
2023-03-23 22:50:03 +09:00
Issy Long
c1de3dfb90
Fix string interpolation detection again to be even broader
...
- My approach wasn't quite good enough. Replace it with what RuboCop
itself does to detect all forms of string interpolation.
2023-03-23 13:17:09 +00:00
Mike McQuaid
ea92f56da4
Merge pull request #15039 from Homebrew/improve-ci-jobs
...
Improve some CI jobs
2023-03-23 10:03:37 +00:00
Mike McQuaid
7a22d919ad
Merge pull request #15038 from MikeMcQuaid/update-report-fix-ordering
...
cmd/update-report: fix ordering.
2023-03-23 09:46:56 +00:00
Mike McQuaid
510c4dce76
Improve some CI jobs
...
- make the CodeCov CI job informational. We don't want red PRs just
because the coverage varies slightly. We still get comments inline
saying where code coverage is met; this is more useful during review
than a single number and failing status
- make the Triage CI job do less: instead of enforcing a time period for
review window, make it only exist to self-approve PRs for merge and
require a maintainer otherwise to review
2023-03-23 09:20:09 +00:00
Mike McQuaid
e75b983686
cmd/update-report: fix ordering.
...
New formulae/casks were shown as removed and vice versa.
Fixes #15036
2023-03-23 08:48:48 +00:00
apainintheneck
6ccf21c2c9
Merge branch 'master' into add-service-block-to-formula-api
2023-03-22 20:06:32 -07:00
apainintheneck
801ee5e474
Address feedback
...
- style nits
- better comments for tests that are not idempotent
- moved appdir placeholder constant to global.rb
2023-03-22 19:43:49 -07:00
Issy Long
0889593e2a
Another failing test for a real Cask, version.csv.first interpolated
2023-03-23 00:02:17 +00:00
Issy Long
e66226aefc
Fix skipping of livecheck block contents in on_* blocks
...
- This passes the previously failing test for `on_*` blocks with
`livecheck` blocks with multiple stanzas inside them (eg `url` and
`strategy`) that weren't being correctly skipped because we weren't
detecting high enough up the ancestry.
2023-03-22 23:17:32 +00:00