Mike McQuaid
b70b5429d0
Deprecate default_formula Requirement DSL
...
This has been a nightmare in terms of the complexity to our dependency
system and the whack-a-mole required on bugs. If a Requirement resolves
to a Formula it should just use `depends_on "formula"` instead. This
matches the effective behaviour all users of bottles (the vast majority
of users and installs) and what we're doing in Homebrew/homebrew-core.
2018-01-14 13:27:43 +00:00
Mike McQuaid
d54e670a64
requirements: move more to compat.
2017-12-30 20:56:55 +00:00
Mike McQuaid
b9cf7b2bbc
formula_installer: avoid irrelevant build deps.
...
If dependents are already installed ensure their build dependencies (and
requirements) don't end up in the dependency/requirement tree.
Fixes #3033 .
2017-12-07 14:56:12 +00:00
Markus Reiter
9bee9ca575
Use “squiggly” heredocs.
2017-10-18 14:39:09 +02:00
Markus Reiter
175ca909ee
Clean up code style and remove .rubocop_todo.yml.
2017-10-08 16:10:37 +02:00
Markus Reiter
f5af3fe0cd
Delete :focus.
2017-08-05 18:09:09 +02:00
Mike McQuaid
e755505c70
Merge pull request #2969 from MikeMcQuaid/default-formula-bottles
...
formula_installer: use default_formula for bottles
2017-07-30 18:41:10 +01:00
Mike McQuaid
a83baba8b5
formula_installer: use default_formula for bottles
...
This was the original, intended functionality before this was broken
in fe117bf79b244c42b7e4049d353c3c003eae4880.
Fixes https://github.com/Homebrew/homebrew-core/issues/13680 .
2017-07-30 16:56:24 +01:00
Markus Reiter
2ad3a87045
Silence all specs by default.
2017-07-29 20:25:37 +02:00
Markus Reiter
3cdf8f938a
Use scoped RSpec matchers.
2017-05-15 17:23:40 +02:00
Mike McQuaid
51ca9025a5
formula_installer_spec: add default formula test.
...
Test the situation where a requirement is satisfied by a non-formula
but the `default_formula` is also installed.
2017-03-29 09:34:52 +01:00
Mike McQuaid
0cc9d93885
formula_installer: tweak req formula additions.
...
Rather than just checking if a requirement's dependency is installed or
not check if the requirement was actually satisfied by a particular
formula rather than e.g. just having a `default_formula` defined.
2017-03-25 10:59:54 +00:00
Markus Reiter
8b60412c99
Convert FormulaInstaller test to spec.
2017-02-27 13:45:06 +01:00
