7196 Commits

Author SHA1 Message Date
Jack Nagel
6d791acf22 Support older git without "submodule sync --recursive"
Fixes Homebrew/homebrew#36774.
2015-02-13 22:16:57 -05:00
Xu Cheng
56f7208f8e info: show correct file origin for formula from path or url
Closes Homebrew/homebrew#36733.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-13 11:33:51 +00:00
Mike McQuaid
e34d9a7b37 outdated: handle HEAD, URL and path installation.
Handles edge cases missed in Homebrew/homebrew#36699.

Closes Homebrew/homebrew#36741.

Closes Homebrew/homebrew#36760.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-13 10:58:43 +00:00
Mike McQuaid
0caa1912d9 Move "path or URL" tap string to global constant. 2015-02-13 10:58:43 +00:00
Jack Nagel
7004d3de0d Extract logging from the command class 2015-02-12 20:20:10 -05:00
Jack Nagel
384c444be8 Drop unnecessary call to compact 2015-02-12 20:09:31 -05:00
Jack Nagel
28b926686b Get the basename and dirname once 2015-02-12 19:13:03 -05:00
Mike McQuaid
988ec8de98 outdated: handle fully qualified tapped formulae.
Previously if I did `brew install boxen/brews/imagemagick` and then `brew
upgrade boxen/brews/imagemagick` and the version of `imagemagick` in
`boxen/brews` was older than the version in `Homebrew/homebrew` then it would
install the correct version from the `boxen/brews` tap and then try to
immediately upgrade it to the version from `Homebrew/homebrew`. I'd argue
fairly strongly that this behaviour is pretty unintuitive; when you fully
specify a formula from a tap then it should be prioritised by `brew upgrade`
and `brew outdated.

This commit makes `brew upgrade boxen/brews/imagemagick` only upgrade the
version of `imagemagick` if the version in the `boxen/brews` tap is newer.
Similarly `brew outdated imagemagick` and `brew outdated
boxen/brews/imagemagick` will show different results if the newer version
differs between `boxen/brews` and `Homebrew/homebrew`.

Closes Homebrew/homebrew#36699.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 14:22:48 +00:00
Mike McQuaid
2320c0a6c1 pull: copy new subject when bumping. 2015-02-11 14:22:19 +00:00
Xu Cheng
4d17d4c8db gist-logs: show the formula origin for non core-formula
Closes Homebrew/homebrew#36730.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 11:04:37 +00:00
Xu Cheng
f640cbac9e brew uses: parse ARGV properly
`ARGV.flag?` = `ARGV.include?` + `ARGV.switch?`

Closes Homebrew/homebrew#36727.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-11 11:02:46 +00:00
Xu Cheng
105eaf3382 test-bot: only test the runtime dependencies.
Also add support to `brew uses` to ignore build or optional dependencies.

Closes Homebrew/homebrew#36154.
Closes Homebrew/homebrew#36656.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-09 14:12:19 +00:00
Dominyk Tiller
8e12390fc8 Update Example Formula documentation.
I feel like we’re probably fighting a losing battle here, but here’s a
bundle more updates to the example formula to cover some ground not
already covered.

Closes Homebrew/homebrew#36644.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-09 12:40:10 +00:00
Jack Nagel
4b91017894 Make compiler shim robust against missing environment variables
Fixes Homebrew/homebrew#36217.
2015-02-08 20:04:07 -05:00
Jack Nagel
d4e24dce0a Get rid of cccfg? method 2015-02-08 20:04:06 -05:00
Jack Nagel
fd031f256a Add predicate methods for compiler shim configuration 2015-02-08 20:04:06 -05:00
Jack Nagel
60452a526f Quote entire path passed to checkout-index 2015-02-08 19:53:38 -05:00
Jack Nagel
5c758f7852 Revert "download_strategy: escape spaces in git submodule path."
This is causing submodules to be checked out into a path with a literal
"$path" component:

$ find . | grep "\$path$"
./$path
./Carthage/Checkouts/Commandant/$path
./Carthage/Checkouts/Commandant/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/PrettyColors/$path
./Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveCocoa/$path
./Carthage/Checkouts/ReactiveCocoa/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveTask/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/Quick/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/ReactiveCocoa/$path
./Carthage/Checkouts/ReactiveTask/Carthage/Checkouts/ReactiveCocoa/Carthage.checkout/Quick/$path

This reverts commit 3a5f099297e9ab3b799af5f7a65edd8d64bc7bae.
2015-02-08 19:44:39 -05:00
Xu Cheng
e547438ff4 cmd/info: prevent duplicate dependency display.
Before:

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔, xz ✔, xz ✔, xz ✔, xz ✔, xz ✔

    $ brew info --json=v1 llvm
    ... "dependencies":["xz","xz","xz","xz","xz","xz"], ...

After

    $ brew info llvm
    ==> Dependencies
    Build: xz ✔

    $ brew info --json=v1 llvm
    ... "dependencies":["xz"], ...

Closes Homebrew/homebrew#36653.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 15:53:30 +00:00
Kashif Rasul
003d650e88 download_strategy: escape spaces in git submodule path.
for issue Homebrew/homebrew#36646

Closes Homebrew/homebrew#36649.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 14:14:34 +00:00
Dominyk Tiller
2abd3298f9 audit: catch more examples from example_formula
See
https://github.com/Homebrew/homebrew/pull/36629#discussion_r24293912
amongst other recent examples. The example formula isn’t as strongly
policed as the ` brew create ` default, this tries to do something
about that.

Closes Homebrew/homebrew#36639.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 12:24:17 +00:00
David Christenson
fb246b0f4e Minimize test JPEG and PNG
Losslessly compress with jpegoptim and optipng.

Closes Homebrew/homebrew#36606.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-08 12:23:39 +00:00
David Christenson
46aa40c067 Add test PDF and SVG. 2015-02-08 12:23:31 +00:00
Xu Cheng
f8791da2ec formula: sort installed version in to_hash
https://github.com/Homebrew/homebrew-brewdler/pull/43#discussion_r24248760

Closes Homebrew/homebrew#36611.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-07 20:43:03 +00:00
Jack Nagel
357d0f2796 Use start_with? to simplify path sanity check 2015-02-07 13:54:33 -05:00
Jack Nagel
f438af9915 Don't prune cellar paths when cellar is in /opt
Fixes Homebrew/homebrew#35382.
2015-02-07 13:54:33 -05:00
Jack Nagel
9f3d88158b Save and restore build attribute
This probably doesn't matter in practice, but I don't want to take any
chances.
2015-02-07 11:02:35 -05:00
Jack Nagel
cd522b1719 Always respect build options when invoking post_install
Fixes Homebrew/homebrew#36335.
2015-02-07 11:02:35 -05:00
Jack Nagel
4851b1e7a8 Use a local instead of an instance variable 2015-02-07 11:02:35 -05:00
Mike McQuaid
5e62d7503e formula_cellar_checks: tweak postgresql on 10.8.
It shadows system headers sometimes (probably just Server.app?) but we don't
really care.
2015-02-06 08:30:42 +00:00
Roberto Nibali
39ead112f3 brew.rb: fix help regex.
Don't match `help` at the end of every string because `brew installhelp`
shouldn't really be running help.

Closes Homebrew/homebrew#36559.
Closes Homebrew/homebrew#36576.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-06 08:19:35 +00:00
Mike McQuaid
8e34b4c322 How-To-Open-a-Homebrew-Pull-Request: bottle update 2015-02-05 11:55:13 +00:00
Tim D. Smith
e40d302dee audit_installed: give better Python advice
Update advice about easy-install.pth files.

Closes Homebrew/homebrew#36547.
2015-02-04 23:35:42 -08:00
Tim D. Smith
c3691ca950 Suggest homebrew-pypi-poet instead of mkpydeps 2015-02-04 18:18:29 -08:00
Mike McQuaid
e8d8c3a486 test-bot: don't try and bottle unstable formulae.
e.g. devel-only or head-only formulae.
2015-02-04 14:20:21 +00:00
Xu Cheng
2787eaa853 pyenv-pip-rehash: boneyarded
Since pyenv v20141211, it bundles built-in pip-rehash feature.

Closes Homebrew/homebrew#36524.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-04 11:18:36 +00:00
Jack Nagel
2bf409d888 brew list foo should always error when foo is not installed
Fixes Homebrew/homebrew#36484.
2015-02-03 20:26:57 -05:00
Christian Moritz
79bde9c13b GitDownloadStrategy: support submodule changes
This commits adds support for updating a formula with changed git
submodules with GitDownloadStrategy when the cloned repository is still
in the cache. This is done by running git submodule sync --recursive
before updating the submodules, so that git can reload the submodule
config from the updated .gitmodules file.

Fixes Homebrew/homebrew#36395.
Closes Homebrew/homebrew#36466.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-02-03 20:00:34 -05:00
Mike McQuaid
f2a9b9cbd2 test-bot: optional requirements are satisfied. 2015-02-03 16:46:36 +00:00
Jack Nagel
291e900abc AprRequirement should not generate a build-time dependency
We want the apr requirement to act as a build-time requirement in case
it is satisfied (that is, the CLT is installed), as the resulting
binaries will link to the system libapr which is always present.

When it is *not* satisfied by the CLT, and we need to install the
formula, we have to treat it as a runtime dependency since the resulting
binaries will link to it.

Fixes Homebrew/homebrew#36301.
Fixes Homebrew/homebrew#36438.
Closes Homebrew/homebrew#36443.
2015-02-02 00:39:04 -05:00
Jack Nagel
208bc0516b AprRequirement should not short-circuit if apr is installed
If apr is installed, we still want to grab it during dependency
resolution in case we need to pass options to the generated dependency.

In other words, it doesn't make sense for the satisfiable condition to
include the default formula, as the default formula is the fallback for
when the requirement is *not* satisfied.
2015-02-02 00:39:04 -05:00
Jack Nagel
d362f5a2fb Remove message that is never displayed
Requirements with default formulae cannot fail the build.
2015-02-02 00:39:04 -05:00
Jack Nagel
12e4602a3b AprRequirement's default formula should be apr-util
This matches the recommendation in the message.
2015-02-02 00:39:04 -05:00
chdiza
5e854164a7 untap: Handle multiple arguments
Closes Homebrew/homebrew#36436.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-01 20:12:13 +01:00
Dominyk Tiller
8a707ebb2b ngircd: system openssl fix
Fix for linking into the system OpenSSL, strict audit fixes, and the
plist.

Closes Homebrew/homebrew#36386.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-02-01 17:31:05 +01:00
Baptiste Fontaine
40447c239d JavaDependency: ignore trailing + in the version 2015-02-01 09:31:01 +01:00
Jack Nagel
e298f09ab6 Move mysqlreport to the boneyard
The project was deprecated in favor of percona-toolkit:
http://blog.codenode.com/2015/01/hack-mysql-has-been-retired.html

Closes Homebrew/homebrew#36342.
2015-01-31 23:58:04 -05:00
Jack Nagel
649579072c Move cdf to the boneyard
Closes Homebrew/homebrew#36009.
2015-01-31 23:54:37 -05:00
Dominyk Tiller
5fcf40fffd sitecopy: boneyarding
Sitecopy currently compiles against the insecure system OpenSSL, and
won’t compile against our OpenSSL because it wants SSLv2 at runtime
(Ouch) and it won’t compile against GnuTLS because GnuTLS have
considerably changed the structure of their build since the last update
of sitecopy (2008).

Closes Homebrew/homebrew#36389.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
2015-01-31 18:27:57 -05:00
Baptiste Fontaine
a9c4091de7 Fix more version misdetections for URLs with archs
Closes Homebrew/homebrew#36368.

Signed-off-by: Mike McQuaid <mike@mikemcquaid.com>
2015-01-30 08:55:49 +00:00